* [PATCH] HID: add USB_HID dependancy on some USB HID drivers
@ 2021-12-02 11:48 Greg Kroah-Hartman
2021-12-02 16:47 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-02 11:48 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: linux-input, Greg Kroah-Hartman, kernel test robot
Some HID drivers are only for USB drivers, yet did not depend on
CONFIG_USB_HID. This was hidden by the fact that the USB functions were
stubbed out in the past, but now that drivers are checking for USB
devices properly, build errors can occur with some random
configurations.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/hid/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 9f5435b55949..828c2995ec34 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -214,7 +214,7 @@ config HID_CHICONY
config HID_CORSAIR
tristate "Corsair devices"
- depends on HID && USB && LEDS_CLASS
+ depends on USB_HID && LEDS_CLASS
help
Support for Corsair devices that are not fully compliant with the
HID standard.
@@ -560,7 +560,7 @@ config HID_LENOVO
config HID_LOGITECH
tristate "Logitech devices"
- depends on HID
+ depends on USB_HID
depends on LEDS_CLASS
default !EXPERT
help
@@ -951,7 +951,7 @@ config HID_SAITEK
config HID_SAMSUNG
tristate "Samsung InfraRed remote control or keyboards"
- depends on HID
+ depends on USB_HID
help
Support for Samsung InfraRed remote control or keyboards.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: add USB_HID dependancy on some USB HID drivers
2021-12-02 11:48 [PATCH] HID: add USB_HID dependancy on some USB HID drivers Greg Kroah-Hartman
@ 2021-12-02 16:47 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2021-12-02 16:47 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Kosina, open list:HID CORE LAYER, kernel test robot
On Thu, Dec 2, 2021 at 12:48 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> Some HID drivers are only for USB drivers, yet did not depend on
> CONFIG_USB_HID. This was hidden by the fact that the USB functions were
> stubbed out in the past, but now that drivers are checking for USB
> devices properly, build errors can occur with some random
> configurations.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
Now applied to hid.git branch for-5.16/upstream-fixes
Cheers,
Benjamin
> drivers/hid/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 9f5435b55949..828c2995ec34 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,7 @@ config HID_CHICONY
>
> config HID_CORSAIR
> tristate "Corsair devices"
> - depends on HID && USB && LEDS_CLASS
> + depends on USB_HID && LEDS_CLASS
> help
> Support for Corsair devices that are not fully compliant with the
> HID standard.
> @@ -560,7 +560,7 @@ config HID_LENOVO
>
> config HID_LOGITECH
> tristate "Logitech devices"
> - depends on HID
> + depends on USB_HID
> depends on LEDS_CLASS
> default !EXPERT
> help
> @@ -951,7 +951,7 @@ config HID_SAITEK
>
> config HID_SAMSUNG
> tristate "Samsung InfraRed remote control or keyboards"
> - depends on HID
> + depends on USB_HID
> help
> Support for Samsung InfraRed remote control or keyboards.
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-02 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 11:48 [PATCH] HID: add USB_HID dependancy on some USB HID drivers Greg Kroah-Hartman
2021-12-02 16:47 ` Benjamin Tissoires
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.