From: Suman Tripathi <stripathi@apm.com> To: Tejun Heo <htejun@gmail.com> Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>, "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Mark Langsdorf <mlangsdo@redhat.com>, Jon Masters <jcm@redhat.com>, patches <patches@apm.com>, Suman Tripathi <svtripathi@gmail.com> Subject: Re: [PATCH v2 1/3] ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci. Date: Mon, 1 Feb 2016 11:45:00 -0800 [thread overview] Message-ID: <CAOHikRBbTafF68qF9n+HNo4p6bwAShZtObw8sPDe45QmG0Xxiw@mail.gmail.com> (raw) In-Reply-To: <20160131113249.GW32380@htj.duckdns.org> On Sun, Jan 31, 2016 at 3:32 AM, Tejun Heo <htejun@gmail.com> wrote: > On Wed, Jan 27, 2016 at 03:19:55PM +0530, Suman Tripathi wrote: >> This patch removes the AHCI_HFLAG_EDGE_IRQ support from libahci. >> The upcoming patches will have the flexibility to override >> irq handlers in the LLD's. Controller's implementing a EDGE trigger >> latch can implement their own interrupt handler inside the driver. >> >> Signed-off-by: Suman Tripathi <stripathi@apm.com> > > Shouldn't this patch come after the irq override is in place? > > 1. introduce irq override. > > 2. remove AHCI_HFLAG_EDGE_IRQ by moving the edge triggered handler to > ahci_xgene. > > 3. Update xgene irq handler to address the erratum. Thought of remove the AHCI_HFLAG_EDGE entirely first because we don't require it . Then implement the irq override capability. > > Thanks. > > -- > tejun -- Thanks, with regards, Suman Tripathi
WARNING: multiple messages have this Message-ID (diff)
From: stripathi@apm.com (Suman Tripathi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/3] ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci. Date: Mon, 1 Feb 2016 11:45:00 -0800 [thread overview] Message-ID: <CAOHikRBbTafF68qF9n+HNo4p6bwAShZtObw8sPDe45QmG0Xxiw@mail.gmail.com> (raw) In-Reply-To: <20160131113249.GW32380@htj.duckdns.org> On Sun, Jan 31, 2016 at 3:32 AM, Tejun Heo <htejun@gmail.com> wrote: > On Wed, Jan 27, 2016 at 03:19:55PM +0530, Suman Tripathi wrote: >> This patch removes the AHCI_HFLAG_EDGE_IRQ support from libahci. >> The upcoming patches will have the flexibility to override >> irq handlers in the LLD's. Controller's implementing a EDGE trigger >> latch can implement their own interrupt handler inside the driver. >> >> Signed-off-by: Suman Tripathi <stripathi@apm.com> > > Shouldn't this patch come after the irq override is in place? > > 1. introduce irq override. > > 2. remove AHCI_HFLAG_EDGE_IRQ by moving the edge triggered handler to > ahci_xgene. > > 3. Update xgene irq handler to address the erratum. Thought of remove the AHCI_HFLAG_EDGE entirely first because we don't require it . Then implement the irq override capability. > > Thanks. > > -- > tejun -- Thanks, with regards, Suman Tripathi
next prev parent reply other threads:[~2016-02-01 19:45 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-27 9:49 [PATCH v2 0/3] ata: Fixes related to edge trigger latch for ahci_xgene driver Suman Tripathi 2016-01-27 9:49 ` Suman Tripathi [not found] ` <1453888197-11368-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org> 2016-01-27 9:49 ` [PATCH v2 1/3] ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci Suman Tripathi 2016-01-27 9:49 ` Suman Tripathi 2016-01-31 11:32 ` Tejun Heo 2016-01-31 11:32 ` Tejun Heo 2016-02-01 19:45 ` Suman Tripathi [this message] 2016-02-01 19:45 ` Suman Tripathi 2016-01-27 9:49 ` [PATCH v2 2/3] libahci: Implement the capability to override the generic ahci interrupt handler Suman Tripathi 2016-01-27 9:49 ` Suman Tripathi [not found] ` <1453888197-11368-3-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org> 2016-01-31 11:35 ` Tejun Heo 2016-01-31 11:35 ` Tejun Heo 2016-02-01 19:43 ` Suman Tripathi 2016-02-01 19:43 ` Suman Tripathi 2016-01-27 9:49 ` [PATCH v2 3/3] ahci_xgene: Implement the workaround to fix the missing of edge interrupt for HOST_IRQ_STAT Suman Tripathi 2016-01-27 9:49 ` Suman Tripathi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOHikRBbTafF68qF9n+HNo4p6bwAShZtObw8sPDe45QmG0Xxiw@mail.gmail.com \ --to=stripathi@apm.com \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=htejun@gmail.com \ --cc=jcm@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=mlangsdo@redhat.com \ --cc=olof@lixom.net \ --cc=patches@apm.com \ --cc=svtripathi@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.