From: Suman Tripathi <stripathi@apm.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Mark Langsdorf <mlangsdo@redhat.com>,
Jon Masters <jcm@redhat.com>, patches <patches@apm.com>,
Suman Tripathi <svtripathi@gmail.com>
Subject: Re: [PATCH v2 2/3] libahci: Implement the capability to override the generic ahci interrupt handler.
Date: Mon, 1 Feb 2016 11:43:56 -0800 [thread overview]
Message-ID: <CAOHikRBmZ2Nk5knH7_4X+ieTYN9ubWrEwhTNAvQzq5cxWmLDJA@mail.gmail.com> (raw)
In-Reply-To: <20160131113540.GX32380@htj.duckdns.org>
On Sun, Jan 31, 2016 at 3:35 AM, Tejun Heo <htejun@gmail.com> wrote:
> On Wed, Jan 27, 2016 at 03:19:56PM +0530, Suman Tripathi wrote:
>> @@ -2466,13 +2467,19 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht)
>> {
>> struct ahci_host_priv *hpriv = host->private_data;
>> int irq = hpriv->irq;
>> + irqreturn_t (*ahci_irq_handler)(int irq, void *dev_instance);
>> int rc;
>>
>> if (hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX))
>> rc = ahci_host_activate_multi_irqs(host, sht);
>
> You need to add { } to the if body too. Please read CodingStyle.
>
>> - else
>> - rc = ata_host_activate(host, irq, ahci_single_level_irq_intr,
>> + else {
>> + ahci_irq_handler = hpriv->ahci_irq_intr ? hpriv->ahci_irq_intr :
>> + ahci_single_level_irq_intr;
>> +
>> + rc = ata_host_activate(host, irq, ahci_irq_handler,
>> IRQF_SHARED, sht);
>> + }
>
> Can you please make this handled the same way as ->start_engine?
> Also, maybe print out a warning message if a driver specifies both
> AHCI_HFLAG_MULTI_MSI[X] and the irq handler override?
Ok Sure
>
> Thanks.
>
> --
> tejun
--
Thanks,
with regards,
Suman Tripathi
WARNING: multiple messages have this Message-ID (diff)
From: stripathi@apm.com (Suman Tripathi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] libahci: Implement the capability to override the generic ahci interrupt handler.
Date: Mon, 1 Feb 2016 11:43:56 -0800 [thread overview]
Message-ID: <CAOHikRBmZ2Nk5knH7_4X+ieTYN9ubWrEwhTNAvQzq5cxWmLDJA@mail.gmail.com> (raw)
In-Reply-To: <20160131113540.GX32380@htj.duckdns.org>
On Sun, Jan 31, 2016 at 3:35 AM, Tejun Heo <htejun@gmail.com> wrote:
> On Wed, Jan 27, 2016 at 03:19:56PM +0530, Suman Tripathi wrote:
>> @@ -2466,13 +2467,19 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht)
>> {
>> struct ahci_host_priv *hpriv = host->private_data;
>> int irq = hpriv->irq;
>> + irqreturn_t (*ahci_irq_handler)(int irq, void *dev_instance);
>> int rc;
>>
>> if (hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX))
>> rc = ahci_host_activate_multi_irqs(host, sht);
>
> You need to add { } to the if body too. Please read CodingStyle.
>
>> - else
>> - rc = ata_host_activate(host, irq, ahci_single_level_irq_intr,
>> + else {
>> + ahci_irq_handler = hpriv->ahci_irq_intr ? hpriv->ahci_irq_intr :
>> + ahci_single_level_irq_intr;
>> +
>> + rc = ata_host_activate(host, irq, ahci_irq_handler,
>> IRQF_SHARED, sht);
>> + }
>
> Can you please make this handled the same way as ->start_engine?
> Also, maybe print out a warning message if a driver specifies both
> AHCI_HFLAG_MULTI_MSI[X] and the irq handler override?
Ok Sure
>
> Thanks.
>
> --
> tejun
--
Thanks,
with regards,
Suman Tripathi
next prev parent reply other threads:[~2016-02-01 19:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 9:49 [PATCH v2 0/3] ata: Fixes related to edge trigger latch for ahci_xgene driver Suman Tripathi
2016-01-27 9:49 ` Suman Tripathi
[not found] ` <1453888197-11368-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2016-01-27 9:49 ` [PATCH v2 1/3] ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci Suman Tripathi
2016-01-27 9:49 ` Suman Tripathi
2016-01-31 11:32 ` Tejun Heo
2016-01-31 11:32 ` Tejun Heo
2016-02-01 19:45 ` Suman Tripathi
2016-02-01 19:45 ` Suman Tripathi
2016-01-27 9:49 ` [PATCH v2 2/3] libahci: Implement the capability to override the generic ahci interrupt handler Suman Tripathi
2016-01-27 9:49 ` Suman Tripathi
[not found] ` <1453888197-11368-3-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2016-01-31 11:35 ` Tejun Heo
2016-01-31 11:35 ` Tejun Heo
2016-02-01 19:43 ` Suman Tripathi [this message]
2016-02-01 19:43 ` Suman Tripathi
2016-01-27 9:49 ` [PATCH v2 3/3] ahci_xgene: Implement the workaround to fix the missing of edge interrupt for HOST_IRQ_STAT Suman Tripathi
2016-01-27 9:49 ` Suman Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOHikRBmZ2Nk5knH7_4X+ieTYN9ubWrEwhTNAvQzq5cxWmLDJA@mail.gmail.com \
--to=stripathi@apm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=htejun@gmail.com \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=svtripathi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.