[PATCH] staging: speakup: Remove unused variable.

[PATCH] staging: speakup: Remove unused variable.

[Bhagyashri Dighole]

Remove unused variable which is used to store return value,
Detected by Coccinelle semantic patch ret.cocci.

Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
---
 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index ee240d3..a748eb8 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
-- 
2.7.4

Re: [PATCH] staging: speakup: Remove unused variable.

[Greg Kroah-Hartman]

On Wed, Mar 13, 2019 at 11:53:15PM +0530, Bhagyashri Dighole wrote:
> Remove unused variable which is used to store return value,
> Detected by Coccinelle semantic patch ret.cocci.
> 
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
>  drivers/staging/speakup/i18n.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d3..a748eb8 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>  	input++;		/* Advance over %. */
>  	input = skip_flags(input);
>  	input = skip_width(input);
> -	input = skip_conversion(input);
> -	return input;
> +	return skip_conversion(input);

This same patch just got rejected a few days ago :(

Please see the mailing list for the details.

greg k-h

Re: [Outreachy kernel] [PATCH] staging: speakup: Remove unused variable.

[Julia Lawall]

On Wed, 13 Mar 2019, Bhagyashri Dighole wrote:

> Remove unused variable which is used to store return value,
> Detected by Coccinelle semantic patch ret.cocci.
>
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
>  drivers/staging/speakup/i18n.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d3..a748eb8 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>  	input++;		/* Advance over %. */
>  	input = skip_flags(input);
>  	input = skip_width(input);
> -	input = skip_conversion(input);
> -	return input;
> +	return skip_conversion(input);

The maintainer already said that he preferred this one left as is, because
he liked the input = input = input = pattern.

julia

>  }
>
>  /*
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1552501395-12308-1-git-send-email-digholebhagyashri%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] staging: speakup: Remove unused variable.

[Bhagyashri Dighole]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Thu, Mar 14, 2019 at 1:01 AM Greg Kroah-Hartman <
gregkh@linuxfoundation.org> wrote:

> On Wed, Mar 13, 2019 at 11:53:15PM +0530, Bhagyashri Dighole wrote:
> > Remove unused variable which is used to store return value,
> > Detected by Coccinelle semantic patch ret.cocci.
> >
> > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> > ---
> >  drivers/staging/speakup/i18n.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/i18n.c
> b/drivers/staging/speakup/i18n.c
> > index ee240d3..a748eb8 100644
> > --- a/drivers/staging/speakup/i18n.c
> > +++ b/drivers/staging/speakup/i18n.c
> > @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
> >       input++;                /* Advance over %. */
> >       input = skip_flags(input);
> >       input = skip_width(input);
> > -     input = skip_conversion(input);
> > -     return input;
> > +     return skip_conversion(input);
>
> This same patch just got rejected a few days ago :(
>
> Please see the mailing list for the details.
>

I will check the mailing list.

>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1767 bytes --]

Re: [Outreachy kernel] [PATCH] staging: speakup: Remove unused variable.

[Bhagyashri Dighole]

[-- Attachment #1: Type: text/plain, Size: 2263 bytes --]

On Thu, Mar 14, 2019 at 1:02 AM Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Wed, 13 Mar 2019, Bhagyashri Dighole wrote:
>
> > Remove unused variable which is used to store return value,
> > Detected by Coccinelle semantic patch ret.cocci.
> >
> > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> > ---
> >  drivers/staging/speakup/i18n.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/i18n.c
> b/drivers/staging/speakup/i18n.c
> > index ee240d3..a748eb8 100644
> > --- a/drivers/staging/speakup/i18n.c
> > +++ b/drivers/staging/speakup/i18n.c
> > @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
> >       input++;                /* Advance over %. */
> >       input = skip_flags(input);
> >       input = skip_width(input);
> > -     input = skip_conversion(input);
> > -     return input;
> > +     return skip_conversion(input);
>
> The maintainer already said that he preferred this one left as is, because
> he liked the input = input = input = pattern.
>

Yes, I will consider this scenario for next time :).

Thanks


> julia
>
> >  }
> >
> >  /*
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1552501395-12308-1-git-send-email-digholebhagyashri%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903132031440.2515%40hadrien
> .
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 3904 bytes --]