All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] fsl_esdhc driver is broken with DM
Date: Sun, 1 Oct 2017 16:13:57 -0300	[thread overview]
Message-ID: <CAOMZO5AykPdQpDWkP44DUzODM77JaXGSNUshU38PAMEqrdNvzA@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5AViRo=ThXbP_AGz33q6bf7XuERn2gqEY-uqfkgq2jffQ@mail.gmail.com>

On Sun, Oct 1, 2017 at 12:50 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Tom,
>
> On Sun, Oct 1, 2017 at 11:49 AM, Tom Rini <trini@konsulko.com> wrote:
>
>>> Same regression is observed with mx7dsabresd board as well.
>>
>> It's likely to be all i.MX :(
>
> Only the i.MX configs with CONFIG_DM_MMC=y.

mx6slevk_spl_defconfig does not have CONFIG_DM_MMC selected and it is
also broken since 2017.05 due to this commit:

commit 001cdbbb32ef1f62f5913f2913eab49e3270ee7b
Author: Peng Fan <peng.fan@nxp.com>
Date:   Sat Mar 4 10:45:44 2017 +0800

    imx: mx6slevk: enable more DM drivers

    Enable more DM drivers. The imx I2C/MMC DM drivers needs DM_GPIO
    enabled. So needs to enable them together.

    DM FEC and SPI are not enabled, but they use gpio in board code.
    So use gpio_request first to request the gpio, because DM_GPIO
    is enabled.

    Signed-off-by: Peng Fan <peng.fan@nxp.com>
    Cc: Stefano Babic <sbabic@denx.de>

I managed to fix it and will submit a fix for it.

mx6slevk_defconfig which has CONFIG_DM_MMC=y is still broken though
and not sure how to fix it.

  parent reply	other threads:[~2017-10-01 19:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-30 15:35 [U-Boot] fsl_esdhc driver is broken with DM Fabio Estevam
2017-10-01 14:29 ` Fabio Estevam
2017-10-01 14:49   ` Tom Rini
2017-10-01 15:50     ` Fabio Estevam
2017-10-01 17:46       ` Łukasz Majewski
2017-10-01 19:13       ` Fabio Estevam [this message]
2017-10-02 10:23       ` Jagan Teki
2017-10-02 11:06         ` Fabio Estevam
2017-10-09 18:05           ` Jagan Teki
2017-10-10 11:48             ` Fabio Estevam
2017-10-11 10:17               ` Jagan Teki
2017-10-11 15:49                 ` Fabio Estevam
2017-10-11 16:06                   ` Jagan Teki
2017-10-11 16:09                     ` Fabio Estevam
2017-10-11 16:29                       ` Jagan Teki
2017-10-11 18:41                       ` Tom Rini
2017-10-13  8:16                         ` Lukasz Majewski
2017-10-13 13:33                           ` Fabio Estevam
2017-10-16 20:51                             ` Jagan Teki
2017-10-16 21:52                               ` Fabio Estevam
2017-10-19 21:52                                 ` Adam Ford
2017-10-19 22:44                                   ` Fabio Estevam
2017-10-20  2:18                                     ` Adam Ford
2017-10-20 11:41                                       ` Fabio Estevam
2017-10-24 22:38                               ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AykPdQpDWkP44DUzODM77JaXGSNUshU38PAMEqrdNvzA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.