All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] fsl_esdhc driver is broken with DM
Date: Sat, 30 Sep 2017 12:35:22 -0300	[thread overview]
Message-ID: <CAOMZO5Bntayji=Ufa-RaZnYPG+xP=81VntjvgxhSZp73nOmVGA@mail.gmail.com> (raw)

Hi,

I noticed that  fsl_esdhc is broken on 2017.09 for mx6slevk, when
CONFIG_DM_MMC is selected:

U-Boot 2017.09 (Sep 30 2017 - 12:31:17 -0300)

CPU:   Freescale i.MX6SL rev1.0 792 MHz (running at 396 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 35C
Reset cause: WDOG
Model: Freescale i.MX6 SoloLite EVK Board
Board: MX6SLEVK
DRAM:  1 GiB
PMIC: PFUZE100! DEV_ID=0x10 REV_ID=0x11
MMC:
MMC Device 1 not found
*** Warning - No MMC card found, using default environment

In:    serial
Out:   serial
Err:   serial
Net:   FEC
Hit any key to stop autoboot:  0
=> mmc info
No MMC device available
=>

2017.07 works fine.

I ran a bisect which pointed to:

commit d6eb25e9878617f9a1d7f06ec21c9b981bb0a4e5
Author: Simon Glass <sjg@chromium.org>
Date:   Sat Jul 29 11:35:22 2017 -0600

    dm: mmc: fsl_esdhc: Drop mmc_init() call from fsl_esdhc_init()

    We want to use fsl_esdhc_init() with driver model. Move the mmc_init() out
    of this function so that we can use it for our common init.

    Signed-off-by: Simon Glass <sjg@chromium.org>

If I remove CONFIG_DM_MMC:

--- a/configs/mx6slevk_defconfig
+++ b/configs/mx6slevk_defconfig
@@ -31,7 +31,6 @@ CONFIG_DM=y
 # CONFIG_BLK is not set
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_DM_MMC=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHYLIB=y

Then the mmc can be used normally.

Any ideas on how to fix this properly so that fsl_esdhc can work with DM?

Thanks

             reply	other threads:[~2017-09-30 15:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-30 15:35 Fabio Estevam [this message]
2017-10-01 14:29 ` [U-Boot] fsl_esdhc driver is broken with DM Fabio Estevam
2017-10-01 14:49   ` Tom Rini
2017-10-01 15:50     ` Fabio Estevam
2017-10-01 17:46       ` Łukasz Majewski
2017-10-01 19:13       ` Fabio Estevam
2017-10-02 10:23       ` Jagan Teki
2017-10-02 11:06         ` Fabio Estevam
2017-10-09 18:05           ` Jagan Teki
2017-10-10 11:48             ` Fabio Estevam
2017-10-11 10:17               ` Jagan Teki
2017-10-11 15:49                 ` Fabio Estevam
2017-10-11 16:06                   ` Jagan Teki
2017-10-11 16:09                     ` Fabio Estevam
2017-10-11 16:29                       ` Jagan Teki
2017-10-11 18:41                       ` Tom Rini
2017-10-13  8:16                         ` Lukasz Majewski
2017-10-13 13:33                           ` Fabio Estevam
2017-10-16 20:51                             ` Jagan Teki
2017-10-16 21:52                               ` Fabio Estevam
2017-10-19 21:52                                 ` Adam Ford
2017-10-19 22:44                                   ` Fabio Estevam
2017-10-20  2:18                                     ` Adam Ford
2017-10-20 11:41                                       ` Fabio Estevam
2017-10-24 22:38                               ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5Bntayji=Ufa-RaZnYPG+xP=81VntjvgxhSZp73nOmVGA@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.