From: Fabio Estevam <festevam@gmail.com>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Catalin Marinas <catalin.marinas@arm.com>,
will@kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Fugang Duan <fugang.duan@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
mripard@kernel.org, Olof Johansson <olof@lixom.net>,
Arnd Bergmann <arnd@arndb.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dinh Nguyen <dinguyen@kernel.org>,
marcin.juszkiewicz@linaro.org, Stefan Agner <stefan@agner.ch>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
yuehaibing@huawei.com, Thomas Gleixner <tglx@linutronix.de>,
ronald@innovation.ch, Marco Felsch <m.felsch@pengutronix.de>,
Ping Bai <ping.bai@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-input@vger.kernel.org, NXP Linux Team <Linux-imx@nxp.com>
Subject: Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Date: Mon, 2 Sep 2019 23:38:54 -0300 [thread overview]
Message-ID: <CAOMZO5CHmvrbVG_h8hOb7hMjXasV_QwtNoXpEw9kqY=4Jj5HAg@mail.gmail.com> (raw)
In-Reply-To: <1567519424-32271-2-git-send-email-Anson.Huang@nxp.com>
Hi Anson,
On Mon, Sep 2, 2019 at 11:05 PM Anson Huang <Anson.Huang@nxp.com> wrote:
> + ret = input_register_device(input);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to register input device\n");
> + return ret;
> + }
> +
> + pdata->input = input;
> + platform_set_drvdata(pdev, pdata);
> +
> + ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, SC_IRQ_BUTTON, true);
> + if (ret) {
> + dev_warn(&pdev->dev, "enable scu group irq failed\n");
> + return ret;
Better do a 'goto input_unregister' here instead and call
input_unregister_device().
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Catalin Marinas <catalin.marinas@arm.com>,
will@kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Fugang Duan <fugang.duan@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
mripard@kernel.org, Olof Johansson <olof@lixom.net>,
Arnd Bergmann <arnd@arndb.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dinh Nguyen <dinguyen@kernel.org>,
marcin.juszkiewicz@linaro.org, Stefan Agner <stefan@agn>
Subject: Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Date: Mon, 2 Sep 2019 23:38:54 -0300 [thread overview]
Message-ID: <CAOMZO5CHmvrbVG_h8hOb7hMjXasV_QwtNoXpEw9kqY=4Jj5HAg@mail.gmail.com> (raw)
In-Reply-To: <1567519424-32271-2-git-send-email-Anson.Huang@nxp.com>
Hi Anson,
On Mon, Sep 2, 2019 at 11:05 PM Anson Huang <Anson.Huang@nxp.com> wrote:
> + ret = input_register_device(input);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to register input device\n");
> + return ret;
> + }
> +
> + pdata->input = input;
> + platform_set_drvdata(pdev, pdata);
> +
> + ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, SC_IRQ_BUTTON, true);
> + if (ret) {
> + dev_warn(&pdev->dev, "enable scu group irq failed\n");
> + return ret;
Better do a 'goto input_unregister' here instead and call
input_unregister_device().
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>, Ping Bai <ping.bai@nxp.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Peng Fan <peng.fan@nxp.com>, Stefan Agner <stefan@agner.ch>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
will@kernel.org, yuehaibing@huawei.com,
marcin.juszkiewicz@linaro.org,
Jagan Teki <jagan@amarulasolutions.com>,
linux-input@vger.kernel.org, ronald@innovation.ch,
NXP Linux Team <Linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
mripard@kernel.org, Marco Felsch <m.felsch@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fugang Duan <fugang.duan@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Date: Mon, 2 Sep 2019 23:38:54 -0300 [thread overview]
Message-ID: <CAOMZO5CHmvrbVG_h8hOb7hMjXasV_QwtNoXpEw9kqY=4Jj5HAg@mail.gmail.com> (raw)
In-Reply-To: <1567519424-32271-2-git-send-email-Anson.Huang@nxp.com>
Hi Anson,
On Mon, Sep 2, 2019 at 11:05 PM Anson Huang <Anson.Huang@nxp.com> wrote:
> + ret = input_register_device(input);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to register input device\n");
> + return ret;
> + }
> +
> + pdata->input = input;
> + platform_set_drvdata(pdev, pdata);
> +
> + ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, SC_IRQ_BUTTON, true);
> + if (ret) {
> + dev_warn(&pdev->dev, "enable scu group irq failed\n");
> + return ret;
Better do a 'goto input_unregister' here instead and call
input_unregister_device().
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-03 2:39 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 14:03 [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:37 ` Anson Huang
2019-09-03 6:37 ` Anson Huang
2019-09-03 6:37 ` Anson Huang
2019-09-03 6:47 ` Oleksij Rempel
2019-09-03 6:47 ` Oleksij Rempel
2019-09-03 6:47 ` Oleksij Rempel
2019-09-03 6:55 ` Anson Huang
2019-09-03 6:55 ` Anson Huang
2019-09-03 6:55 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 2:38 ` Fabio Estevam [this message]
2019-09-03 2:38 ` Fabio Estevam
2019-09-03 2:38 ` Fabio Estevam
2019-09-03 3:11 ` Anson Huang
2019-09-03 3:11 ` Anson Huang
2019-09-03 3:11 ` Anson Huang
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:48 ` Anson Huang
2019-09-03 6:48 ` Anson Huang
2019-09-03 6:48 ` Anson Huang
2019-09-03 7:28 ` Oleksij Rempel
2019-09-03 7:28 ` Oleksij Rempel
2019-09-03 7:28 ` Oleksij Rempel
2019-09-03 7:35 ` Anson Huang
2019-09-03 7:35 ` Anson Huang
2019-09-03 7:35 ` Anson Huang
2019-09-03 7:43 ` Oleksij Rempel
2019-09-03 7:43 ` Oleksij Rempel
2019-09-03 7:43 ` Oleksij Rempel
2019-09-22 16:14 ` Pavel Machek
2019-09-22 16:14 ` Pavel Machek
2019-09-22 16:14 ` Pavel Machek
2019-09-03 14:03 ` [PATCH V2 3/5] arm64: dts: imx8qxp: Add scu power key node Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 4/5] arm64: dts: imx8qxp-mek: Enable scu power key Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 5/5] arm64: defconfig: Enable CONFIG_KEYBOARD_IMX_SC_PWRKEY as module Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-22 16:13 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Pavel Machek
2019-09-22 16:13 ` Pavel Machek
2019-09-22 16:13 ` Pavel Machek
2019-09-23 2:31 ` Anson Huang
2019-09-23 2:31 ` Anson Huang
2019-09-23 2:31 ` Anson Huang
2019-09-22 16:14 ` Pavel Machek
2019-09-22 16:14 ` Pavel Machek
2019-09-22 16:14 ` Pavel Machek
2019-09-23 2:34 ` Anson Huang
2019-09-23 2:34 ` Anson Huang
2019-09-23 2:34 ` Anson Huang
2019-10-06 0:32 ` Shawn Guo
2019-10-06 0:32 ` Shawn Guo
2019-10-06 0:32 ` Shawn Guo
2019-10-07 1:29 ` Anson Huang
2019-10-07 1:29 ` Anson Huang
2019-10-07 1:29 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CHmvrbVG_h8hOb7hMjXasV_QwtNoXpEw9kqY=4Jj5HAg@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=olof@lixom.net \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=ronald@innovation.ch \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.