From: Fabio Estevam <festevam@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Pierre-Hugues Husson <phh@phh.me>,
Archit Taneja <architt@codeaurora.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
linux-rockchip@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate
Date: Wed, 26 Jan 2022 17:32:55 -0300 [thread overview]
Message-ID: <CAOMZO5CesC_mZDHhF93_1u6rMrmtc-pMaB8X28CX-npY_5BaDA@mail.gmail.com> (raw)
In-Reply-To: <20220126202427.3047814-1-pgwipeout@gmail.com>
On Wed, Jan 26, 2022 at 5:25 PM Peter Geis <pgwipeout@gmail.com> wrote:
> +
> + ret = clk_set_rate(hdmi->cec_clk, HDMI_CEC_CLK_RATE);
> + if (ret)
> + dev_warn(hdmi->dev, "Cannot set HDMI cec clock rate: %d\n", ret);
You are setting the cec clock rate after it has been enabled, which
can be glitchy.
Better to set the rate prior to enabling the clock.
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Pierre-Hugues Husson <phh@phh.me>,
Archit Taneja <architt@codeaurora.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
linux-rockchip@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate
Date: Wed, 26 Jan 2022 17:32:55 -0300 [thread overview]
Message-ID: <CAOMZO5CesC_mZDHhF93_1u6rMrmtc-pMaB8X28CX-npY_5BaDA@mail.gmail.com> (raw)
In-Reply-To: <20220126202427.3047814-1-pgwipeout@gmail.com>
On Wed, Jan 26, 2022 at 5:25 PM Peter Geis <pgwipeout@gmail.com> wrote:
> +
> + ret = clk_set_rate(hdmi->cec_clk, HDMI_CEC_CLK_RATE);
> + if (ret)
> + dev_warn(hdmi->dev, "Cannot set HDMI cec clock rate: %d\n", ret);
You are setting the cec clock rate after it has been enabled, which
can be glitchy.
Better to set the rate prior to enabling the clock.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>,
Archit Taneja <architt@codeaurora.org>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Robert Foss <robert.foss@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-rockchip@lists.infradead.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Pierre-Hugues Husson <phh@phh.me>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate
Date: Wed, 26 Jan 2022 17:32:55 -0300 [thread overview]
Message-ID: <CAOMZO5CesC_mZDHhF93_1u6rMrmtc-pMaB8X28CX-npY_5BaDA@mail.gmail.com> (raw)
In-Reply-To: <20220126202427.3047814-1-pgwipeout@gmail.com>
On Wed, Jan 26, 2022 at 5:25 PM Peter Geis <pgwipeout@gmail.com> wrote:
> +
> + ret = clk_set_rate(hdmi->cec_clk, HDMI_CEC_CLK_RATE);
> + if (ret)
> + dev_warn(hdmi->dev, "Cannot set HDMI cec clock rate: %d\n", ret);
You are setting the cec clock rate after it has been enabled, which
can be glitchy.
Better to set the rate prior to enabling the clock.
next prev parent reply other threads:[~2022-01-26 20:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 20:24 [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate Peter Geis
2022-01-26 20:24 ` Peter Geis
2022-01-26 20:24 ` Peter Geis
2022-01-26 20:32 ` Fabio Estevam [this message]
2022-01-26 20:32 ` Fabio Estevam
2022-01-26 20:32 ` Fabio Estevam
2022-01-27 9:33 ` Sascha Hauer
2022-01-27 9:33 ` Sascha Hauer
2022-01-27 9:33 ` Sascha Hauer
2022-01-28 19:03 ` Peter Geis
2022-01-28 19:03 ` Peter Geis
2022-01-28 19:03 ` Peter Geis
2022-03-13 10:12 ` Piotr Oniszczuk
2022-03-13 10:12 ` Piotr Oniszczuk
2022-03-13 10:12 ` Piotr Oniszczuk
2022-03-13 12:56 ` Peter Geis
2022-03-13 12:56 ` Peter Geis
2022-03-13 12:56 ` Peter Geis
2022-03-13 16:14 ` Piotr Oniszczuk
2022-03-13 16:14 ` Piotr Oniszczuk
2022-03-13 16:14 ` Piotr Oniszczuk
2022-03-14 11:31 ` Robin Murphy
2022-03-14 11:31 ` Robin Murphy
2022-03-14 11:31 ` Robin Murphy
2022-03-14 16:34 ` Robin Murphy
2022-03-14 16:34 ` Robin Murphy
2022-03-14 16:34 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5CesC_mZDHhF93_1u6rMrmtc-pMaB8X28CX-npY_5BaDA@mail.gmail.com \
--to=festevam@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=architt@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=pgwipeout@gmail.com \
--cc=phh@phh.me \
--cc=robert.foss@linaro.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.