All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	Gregory Fong
	<gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips
Date: Thu, 21 May 2015 19:16:07 -0300	[thread overview]
Message-ID: <CAOMZO5DtNa2-bgdGmiiJM4JZ7MHz2THSsNMwT=9oWO1ThNu2KA@mail.gmail.com> (raw)
In-Reply-To: <1431473303-18873-4-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, May 12, 2015 at 8:28 PM, Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> +       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci");
> +       ahci = devm_ioremap_resource(&pdev->dev, res);
> +       if (IS_ERR(ahci))
> +               return 0;

You should propagate 'return PTR_ERR(ahci)' instead.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kevin Cernekee <cernekee@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ide@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Gregory Fong <gregory.0xf0@gmail.com>,
	Kumar Gala <galak@codeaurora.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips
Date: Thu, 21 May 2015 19:16:07 -0300	[thread overview]
Message-ID: <CAOMZO5DtNa2-bgdGmiiJM4JZ7MHz2THSsNMwT=9oWO1ThNu2KA@mail.gmail.com> (raw)
In-Reply-To: <1431473303-18873-4-git-send-email-computersforpeace@gmail.com>

On Tue, May 12, 2015 at 8:28 PM, Brian Norris
<computersforpeace@gmail.com> wrote:

> +       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci");
> +       ahci = devm_ioremap_resource(&pdev->dev, res);
> +       if (IS_ERR(ahci))
> +               return 0;

You should propagate 'return PTR_ERR(ahci)' instead.

WARNING: multiple messages have this Message-ID (diff)
From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips
Date: Thu, 21 May 2015 19:16:07 -0300	[thread overview]
Message-ID: <CAOMZO5DtNa2-bgdGmiiJM4JZ7MHz2THSsNMwT=9oWO1ThNu2KA@mail.gmail.com> (raw)
In-Reply-To: <1431473303-18873-4-git-send-email-computersforpeace@gmail.com>

On Tue, May 12, 2015 at 8:28 PM, Brian Norris
<computersforpeace@gmail.com> wrote:

> +       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci");
> +       ahci = devm_ioremap_resource(&pdev->dev, res);
> +       if (IS_ERR(ahci))
> +               return 0;

You should propagate 'return PTR_ERR(ahci)' instead.

  parent reply	other threads:[~2015-05-21 22:16 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 23:28 [PATCH v3 0/5] AHCI and SATA PHY support for Broadcom STB SoCs Brian Norris
2015-05-12 23:28 ` Brian Norris
2015-05-12 23:28 ` Brian Norris
2015-05-12 23:28 ` [PATCH v3 1/5] Documentation: devicetree: add Broadcom SATA binding Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-25  0:11   ` Tejun Heo
2015-05-25  0:11     ` Tejun Heo
2015-05-12 23:28 ` [PATCH v3 2/5] Documentation: devicetree: add Broadcom SATA PHY binding Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-12 23:28 ` [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-21 22:03   ` Tejun Heo
2015-05-21 22:03     ` Tejun Heo
     [not found]   ` <1431473303-18873-4-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-21 22:16     ` Fabio Estevam [this message]
2015-05-21 22:16       ` Fabio Estevam
2015-05-21 22:16       ` Fabio Estevam
2015-05-21 22:20       ` Tejun Heo
2015-05-21 22:20         ` Tejun Heo
2015-05-21 22:20         ` Tejun Heo
2015-05-21 22:26         ` Brian Norris
2015-05-21 22:26           ` Brian Norris
2015-05-21 22:26           ` Brian Norris
2015-05-21 22:28           ` Tejun Heo
2015-05-21 22:28             ` Tejun Heo
2015-05-21 22:28             ` Tejun Heo
2015-05-12 23:28 ` [PATCH v3 4/5] phy: add Broadcom SATA3 PHY driver for Broadcom STB SoCs Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-13 11:07   ` Kishon Vijay Abraham I
2015-05-13 11:07     ` Kishon Vijay Abraham I
2015-05-13 11:07     ` Kishon Vijay Abraham I
2015-05-13 18:49     ` Brian Norris
2015-05-13 18:49       ` Brian Norris
2015-05-14  5:52       ` Kishon Vijay Abraham I
2015-05-14  5:52         ` Kishon Vijay Abraham I
2015-05-14  5:52         ` Kishon Vijay Abraham I
2015-05-14 17:39         ` Brian Norris
2015-05-14 17:39           ` Brian Norris
2015-05-14 17:42           ` Florian Fainelli
2015-05-14 17:42             ` Florian Fainelli
2015-05-21 13:23             ` Kishon Vijay Abraham I
2015-05-21 13:23               ` Kishon Vijay Abraham I
2015-05-21 13:23               ` Kishon Vijay Abraham I
2015-05-21  0:18   ` [PATCH v4] " Brian Norris
2015-05-21  0:18     ` Brian Norris
2015-05-21  0:18     ` Brian Norris
2015-05-12 23:28 ` [PATCH v3 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-12 23:28   ` Brian Norris
2015-05-13 18:02   ` Florian Fainelli
2015-05-13 18:02     ` Florian Fainelli
2015-05-21 13:22 ` [PATCH v3 0/5] AHCI and SATA PHY support for Broadcom STB SoCs Kishon Vijay Abraham I
2015-05-21 13:22   ` Kishon Vijay Abraham I
2015-05-21 13:22   ` Kishon Vijay Abraham I
2015-05-21 22:00   ` Tejun Heo
2015-05-21 22:00     ` Tejun Heo
2015-05-21 22:01     ` Tejun Heo
2015-05-21 22:01       ` Tejun Heo
2015-05-21 22:03       ` Brian Norris
2015-05-21 22:03         ` Brian Norris
2015-05-21 22:04         ` Tejun Heo
2015-05-21 22:04           ` Tejun Heo
2015-05-21 22:04           ` Tejun Heo
2015-05-21 22:13           ` Brian Norris
2015-05-21 22:13             ` Brian Norris
2015-05-21 22:23             ` Tejun Heo
2015-05-21 22:23               ` Tejun Heo
2015-05-21 22:38               ` Brian Norris
2015-05-21 22:38                 ` Brian Norris
2015-05-25  0:08                 ` Tejun Heo
2015-05-25  0:08                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5DtNa2-bgdGmiiJM4JZ7MHz2THSsNMwT=9oWO1ThNu2KA@mail.gmail.com' \
    --to=festevam-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=kishon-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.