All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: LTP List <ltp@lists.linux.it>, Jan Kara <jack@suse.com>,
	Khazhismel Kumykov <khazhy@google.com>,
	kernel@collabora.com, Ext4 <linux-ext4@vger.kernel.org>,
	Matthew Bobrowski <repnop@google.com>
Subject: Re: [PATCH v2 10/10] syscalls/fanotify20: Test capture of multiple errors
Date: Wed, 27 Oct 2021 13:00:07 +0300	[thread overview]
Message-ID: <CAOQ4uxia5Qhieui+keBLumWwGd2+wv88+FykWq-zMrDrHmZUrA@mail.gmail.com> (raw)
In-Reply-To: <20211026184239.151156-11-krisman@collabora.com>

On Tue, Oct 26, 2021 at 9:44 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>
> When multiple FS errors occur, only the first is stored.  This testcase
> validates this behavior by issuing two different errors and making sure
> only the first is stored, while the second is simply accumulated in
> error_count.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Reviewed-by: Amir Goldstein <amir73il@gmail.com>

> ---
>  .../kernel/syscalls/fanotify/fanotify20.c     | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c
> index 7bcddcaa98cb..0083a018f2c6 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify20.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c
> @@ -78,6 +78,18 @@ static void tcase2_trigger_lookup(void)
>                         ret, BAD_DIR, errno, EUCLEAN);
>  }
>
> +static void tcase3_trigger(void)
> +{
> +       trigger_fs_abort();
> +       tcase2_trigger_lookup();

So after remount,abort filesystem operations can still be executed?
Then I guess my comment from the previous patch about running the test in a loop
is not relevant?

Thanks,
Amir.

WARNING: multiple messages have this Message-ID (diff)
From: Amir Goldstein <amir73il@gmail.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
	Matthew Bobrowski <repnop@google.com>, Jan Kara <jack@suse.com>,
	Ext4 <linux-ext4@vger.kernel.org>, LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 10/10] syscalls/fanotify20: Test capture of multiple errors
Date: Wed, 27 Oct 2021 13:00:07 +0300	[thread overview]
Message-ID: <CAOQ4uxia5Qhieui+keBLumWwGd2+wv88+FykWq-zMrDrHmZUrA@mail.gmail.com> (raw)
In-Reply-To: <20211026184239.151156-11-krisman@collabora.com>

On Tue, Oct 26, 2021 at 9:44 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>
> When multiple FS errors occur, only the first is stored.  This testcase
> validates this behavior by issuing two different errors and making sure
> only the first is stored, while the second is simply accumulated in
> error_count.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Reviewed-by: Amir Goldstein <amir73il@gmail.com>

> ---
>  .../kernel/syscalls/fanotify/fanotify20.c     | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c
> index 7bcddcaa98cb..0083a018f2c6 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify20.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c
> @@ -78,6 +78,18 @@ static void tcase2_trigger_lookup(void)
>                         ret, BAD_DIR, errno, EUCLEAN);
>  }
>
> +static void tcase3_trigger(void)
> +{
> +       trigger_fs_abort();
> +       tcase2_trigger_lookup();

So after remount,abort filesystem operations can still be executed?
Then I guess my comment from the previous patch about running the test in a loop
is not relevant?

Thanks,
Amir.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-10-27 10:01 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 18:42 [PATCH v2 00/10] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-10-26 18:42 ` [LTP] " Gabriel Krisman Bertazi
2021-10-26 18:42 ` [PATCH v2 01/10] syscalls: fanotify: Add macro to require specific mark types Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  6:10   ` Amir Goldstein
2021-10-27  6:10     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 02/10] syscalls: fanotify: Add macro to require specific events Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  6:23   ` Amir Goldstein
2021-10-27  6:23     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 03/10] syscalls/fanotify20: Introduce helpers for FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  6:33   ` Amir Goldstein
2021-10-27  6:33     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 04/10] syscalls/fanotify20: Validate the generic error info Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  6:43   ` Amir Goldstein
2021-10-27  6:43     ` [LTP] " Amir Goldstein
2021-10-27 10:19     ` Amir Goldstein
2021-10-27 10:19       ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 05/10] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  6:48   ` Amir Goldstein
2021-10-27  6:48     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 06/10] syscalls/fanotify20: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  6:49   ` Amir Goldstein
2021-10-27  6:49     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 07/10] syscalls/fanotify20: Create a corrupted file Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  6:51   ` Amir Goldstein
2021-10-27  6:51     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 08/10] syscalls/fanotify20: Test event after filesystem abort Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  9:56   ` Amir Goldstein
2021-10-27  9:56     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 09/10] syscalls/fanotify20: Test file event with broken inode Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27  9:57   ` Amir Goldstein
2021-10-27  9:57     ` [LTP] " Amir Goldstein
2021-10-26 18:42 ` [PATCH v2 10/10] syscalls/fanotify20: Test capture of multiple errors Gabriel Krisman Bertazi
2021-10-26 18:42   ` [LTP] " Gabriel Krisman Bertazi
2021-10-27 10:00   ` Amir Goldstein [this message]
2021-10-27 10:00     ` Amir Goldstein
2021-10-29 15:03     ` Gabriel Krisman Bertazi
2021-10-29 15:03       ` [LTP] " Gabriel Krisman Bertazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxia5Qhieui+keBLumWwGd2+wv88+FykWq-zMrDrHmZUrA@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=jack@suse.com \
    --cc=kernel@collabora.com \
    --cc=khazhy@google.com \
    --cc=krisman@collabora.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=repnop@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.