* [PATCH] packagegroup: rrecommend perf also for musl
@ 2020-09-23 8:45 Christian Eggers
2020-09-23 16:38 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Christian Eggers @ 2020-09-23 8:45 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj, Christian Eggers
The perf recipe builds fine for musl.
Fixes: d758a4445a ("packagegroup: Disable packages not available on musl")
Signed-off-by: Christian Eggers <ceggers@arri.de>
---
.../packagegroups/packagegroup-core-tools-profile.bb | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index 1c94653d72..a5dca95c2a 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -17,7 +17,7 @@ PROFILE_TOOLS_X_nios2 = ""
PROFILE_TOOLS_SYSTEMD = "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd-analyze', '', d)}"
RRECOMMENDS_${PN} = "\
- ${PERF} \
+ perf \
blktrace \
${PROFILE_TOOLS_X} \
${PROFILE_TOOLS_SYSTEMD} \
@@ -26,8 +26,6 @@ RRECOMMENDS_${PN} = "\
PROFILETOOLS = "\
powertop \
"
-PERF = "perf"
-PERF_libc-musl = ""
# systemtap needs elfutils which is not fully buildable on some arches/libcs
SYSTEMTAP = "systemtap"
--
Christian Eggers
Embedded software developer
Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] packagegroup: rrecommend perf also for musl
2020-09-23 8:45 [PATCH] packagegroup: rrecommend perf also for musl Christian Eggers
@ 2020-09-23 16:38 ` Khem Raj
2020-09-24 9:32 ` [PATCH v2] packagegroup: rrecommend perf also for musl on ARM Christian Eggers
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2020-09-23 16:38 UTC (permalink / raw)
To: Christian Eggers; +Cc: Patches and discussions about the oe-core layer
On Wed, Sep 23, 2020 at 1:46 AM Christian Eggers <ceggers@arri.de> wrote:
>
> The perf recipe builds fine for musl.
which all architectures did you build on musl ?
Regardless of that we should still use PERF var so non-core
architectures can still override it
>
> Fixes: d758a4445a ("packagegroup: Disable packages not available on musl")
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> .../packagegroups/packagegroup-core-tools-profile.bb | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> index 1c94653d72..a5dca95c2a 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> @@ -17,7 +17,7 @@ PROFILE_TOOLS_X_nios2 = ""
> PROFILE_TOOLS_SYSTEMD = "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd-analyze', '', d)}"
>
> RRECOMMENDS_${PN} = "\
> - ${PERF} \
> + perf \
> blktrace \
> ${PROFILE_TOOLS_X} \
> ${PROFILE_TOOLS_SYSTEMD} \
> @@ -26,8 +26,6 @@ RRECOMMENDS_${PN} = "\
> PROFILETOOLS = "\
> powertop \
> "
> -PERF = "perf"
> -PERF_libc-musl = ""
>
> # systemtap needs elfutils which is not fully buildable on some arches/libcs
> SYSTEMTAP = "systemtap"
> --
> Christian Eggers
> Embedded software developer
>
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
> Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
> Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] packagegroup: rrecommend perf also for musl on ARM
2020-09-23 16:38 ` Khem Raj
@ 2020-09-24 9:32 ` Christian Eggers
2020-09-25 16:28 ` [OE-core] " Steve Sakoman
0 siblings, 1 reply; 5+ messages in thread
From: Christian Eggers @ 2020-09-24 9:32 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core, Christian Eggers
The perf recipe builds fine for musl on ARM.
Fixes: d758a4445a ("packagegroup: Disable packages not available on musl")
Signed-off-by: Christian Eggers <ceggers@arri.de>
---
On Wednesday, 23 September 2020, 18:38:06 CEST, Khem Raj wrote:
> On Wed, Sep 23, 2020 at 1:46 AM Christian Eggers <ceggers@arri.de> wrote:
> > The perf recipe builds fine for musl.
>
> which all architectures did you build on musl ?
only on ARM.
> Regardless of that we should still use PERF var so non-core
> architectures can still override it
.../packagegroups/packagegroup-core-tools-profile.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index 1c94653d72..d437e28311 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -28,6 +28,7 @@ PROFILETOOLS = "\
"
PERF = "perf"
PERF_libc-musl = ""
+PERF_libc-musl_arm = "perf"
# systemtap needs elfutils which is not fully buildable on some arches/libcs
SYSTEMTAP = "systemtap"
--
Christian Eggers
Embedded software developer
Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH v2] packagegroup: rrecommend perf also for musl on ARM
2020-09-24 9:32 ` [PATCH v2] packagegroup: rrecommend perf also for musl on ARM Christian Eggers
@ 2020-09-25 16:28 ` Steve Sakoman
[not found] ` <3205654.9nU1JGFCk1@n95hx1g2>
0 siblings, 1 reply; 5+ messages in thread
From: Steve Sakoman @ 2020-09-25 16:28 UTC (permalink / raw)
To: Christian Eggers
Cc: Khem Raj, Patches and discussions about the oe-core layer
Is this also suitable for dunfell inclusion?
Thanks!
Steve
On Wed, Sep 23, 2020 at 11:32 PM Christian Eggers <ceggers@arri.de> wrote:
>
> The perf recipe builds fine for musl on ARM.
>
> Fixes: d758a4445a ("packagegroup: Disable packages not available on musl")
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> On Wednesday, 23 September 2020, 18:38:06 CEST, Khem Raj wrote:
> > On Wed, Sep 23, 2020 at 1:46 AM Christian Eggers <ceggers@arri.de> wrote:
> > > The perf recipe builds fine for musl.
> >
> > which all architectures did you build on musl ?
> only on ARM.
>
> > Regardless of that we should still use PERF var so non-core
> > architectures can still override it
>
> .../packagegroups/packagegroup-core-tools-profile.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> index 1c94653d72..d437e28311 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> @@ -28,6 +28,7 @@ PROFILETOOLS = "\
> "
> PERF = "perf"
> PERF_libc-musl = ""
> +PERF_libc-musl_arm = "perf"
>
> # systemtap needs elfutils which is not fully buildable on some arches/libcs
> SYSTEMTAP = "systemtap"
> --
> Christian Eggers
> Embedded software developer
>
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
> Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
> Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-25 19:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 8:45 [PATCH] packagegroup: rrecommend perf also for musl Christian Eggers
2020-09-23 16:38 ` Khem Raj
2020-09-24 9:32 ` [PATCH v2] packagegroup: rrecommend perf also for musl on ARM Christian Eggers
2020-09-25 16:28 ` [OE-core] " Steve Sakoman
[not found] ` <3205654.9nU1JGFCk1@n95hx1g2>
2020-09-25 19:49 ` Steve Sakoman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.