usb-wacom-tablet failing to register

usb-wacom-tablet failing to register

[Michael Nazzareno Trimarchi]

Hi all

On my 4.17.0-rc1 linux kernel i386 running on qemu, I can't register
the wacom driver emulation
QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3)
Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers

[    0.395368] ata2.00: configured for MWDMA2
[    0.397049] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM
  2.5+ PQ: 0 ANSI: 5
[    0.584135] usb 2-1: new full-speed USB device number 2 using xhci_hcd
[    0.734449] usb 2-1: New USB device found, idVendor=056a,
idProduct=0000, bcdDevice=42.10
[    0.734461] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[    0.734466] usb 2-1: Product: Wacom PenPartner
[    0.734470] usb 2-1: Manufacturer: QEMU
[    0.734474] usb 2-1: SerialNumber: 1-0000:00:04.0-1
[    0.737347] usbhid 2-1:1.0: can't add hid device: -32
[    0.737366] usbhid: probe of 2-1:1.0 failed with error -32

I get back an error. Any suggestions?

Michael

Re: usb-wacom-tablet failing to register

[Michael Nazzareno Trimarchi]

Hi

What I have seen is that the parse fail to execute
hid ll_driver parse fai for

 ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
                        HID_DT_REPORT, rdesc, rsize);

Now this is not implemented in hw/dev-wacom.c . What am I missing?

#!/bin/sh
IMAGE_DIR="${0%/*}/"

if [ "${1}" = "serial-only" ]; then
    EXTRA_ARGS='-nographic'
else
    EXTRA_ARGS='-serial stdio'
fi

export PATH="/home/michael/work/amarula/buildroot/output/host/bin:${PATH}"
exec   qemu-system-i386 -M pc -kernel ${IMAGE_DIR}/bzImage -usb
-device usb-wacom-tablet -drive
file=${IMAGE_DIR}/rootfs.ext2,if=virtio,format=raw -append "rootwait
root=/dev/vda console=tty1 console=ttyS0"  -net nic,model=virtio -net
use
r  ${EXTRA_ARGS}

This is how I run it

Michael

On Sat, Jul 11, 2020 at 4:38 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi all
>
> On my 4.17.0-rc1 linux kernel i386 running on qemu, I can't register
> the wacom driver emulation
> QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3)
> Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
>
> [    0.395368] ata2.00: configured for MWDMA2
> [    0.397049] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM
>   2.5+ PQ: 0 ANSI: 5
> [    0.584135] usb 2-1: new full-speed USB device number 2 using xhci_hcd
> [    0.734449] usb 2-1: New USB device found, idVendor=056a,
> idProduct=0000, bcdDevice=42.10
> [    0.734461] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> [    0.734466] usb 2-1: Product: Wacom PenPartner
> [    0.734470] usb 2-1: Manufacturer: QEMU
> [    0.734474] usb 2-1: SerialNumber: 1-0000:00:04.0-1
> [    0.737347] usbhid 2-1:1.0: can't add hid device: -32
> [    0.737366] usbhid: probe of 2-1:1.0 failed with error -32
>
> I get back an error. Any suggestions?
>
> Michael



-- 
Michael Nazzareno Trimarchi
Amarula Solutions BV
COO Co-Founder
Cruquiuskade 47 Amsterdam 1018 AM NL
T. +31(0)851119172
M. +39(0)3479132170
[`as] https://www.amarulasolutions.com

Re: usb-wacom-tablet failing to register

[Michael Nazzareno Trimarchi]

Hi Markus

I have seen that you are a committer there so what I have seen that

This request is not implement
 switch (request) {
    case InterfaceRequest | USB_REQ_GET_DESCRIPTOR:

When linux probe it fail here

ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
>                         HID_DT_REPORT, rdesc, rsize);

I think that I miss something in documentation

Running 5.8.0-rc3 and qemu 4.2.0

Michael

On Sat, Aug 8, 2020 at 4:59 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi
>
> What I have seen is that the parse fail to execute
> hid ll_driver parse fai for
>
>  ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
>                         HID_DT_REPORT, rdesc, rsize);
>
> Now this is not implemented in hw/dev-wacom.c . What am I missing?
>
> #!/bin/sh
> IMAGE_DIR="${0%/*}/"
>
> if [ "${1}" = "serial-only" ]; then
>     EXTRA_ARGS='-nographic'
> else
>     EXTRA_ARGS='-serial stdio'
> fi
>
> export PATH="/home/michael/work/amarula/buildroot/output/host/bin:${PATH}"
> exec   qemu-system-i386 -M pc -kernel ${IMAGE_DIR}/bzImage -usb
> -device usb-wacom-tablet -drive
> file=${IMAGE_DIR}/rootfs.ext2,if=virtio,format=raw -append "rootwait
> root=/dev/vda console=tty1 console=ttyS0"  -net nic,model=virtio -net
> use
> r  ${EXTRA_ARGS}
>
> This is how I run it
>
> Michael
>
> On Sat, Jul 11, 2020 at 4:38 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi all
> >
> > On my 4.17.0-rc1 linux kernel i386 running on qemu, I can't register
> > the wacom driver emulation
> > QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3)
> > Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
> >
> > [    0.395368] ata2.00: configured for MWDMA2
> > [    0.397049] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM
> >   2.5+ PQ: 0 ANSI: 5
> > [    0.584135] usb 2-1: new full-speed USB device number 2 using xhci_hcd
> > [    0.734449] usb 2-1: New USB device found, idVendor=056a,
> > idProduct=0000, bcdDevice=42.10
> > [    0.734461] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> > [    0.734466] usb 2-1: Product: Wacom PenPartner
> > [    0.734470] usb 2-1: Manufacturer: QEMU
> > [    0.734474] usb 2-1: SerialNumber: 1-0000:00:04.0-1
> > [    0.737347] usbhid 2-1:1.0: can't add hid device: -32
> > [    0.737366] usbhid: probe of 2-1:1.0 failed with error -32
> >
> > I get back an error. Any suggestions?
> >
> > Michael
>
>
>
> --
> Michael Nazzareno Trimarchi
> Amarula Solutions BV
> COO Co-Founder
> Cruquiuskade 47 Amsterdam 1018 AM NL
> T. +31(0)851119172
> M. +39(0)3479132170
> [`as] https://www.amarulasolutions.com



-- 
Michael Nazzareno Trimarchi
Amarula Solutions BV
COO Co-Founder
Cruquiuskade 47 Amsterdam 1018 AM NL
T. +31(0)851119172
M. +39(0)3479132170
[`as] https://www.amarulasolutions.com

Re: usb-wacom-tablet failing to register

[Michael Nazzareno Trimarchi]

Hi

On Sat, Aug 8, 2020 at 6:06 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi Markus
>
> I have seen that you are a committer there so what I have seen that
>
> This request is not implement
>  switch (request) {
>     case InterfaceRequest | USB_REQ_GET_DESCRIPTOR:
>
> When linux probe it fail here
>
> ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
> >                         HID_DT_REPORT, rdesc, rsize);
>
> I think that I miss something in documentation
>
> Running 5.8.0-rc3 and qemu 4.2.0

If I implement
    case InterfaceRequest | USB_REQ_GET_DESCRIPTOR:
        switch (value >> 8) {
        case 0x22:
            p->actual_length = 0;
        default:
            break;
        }
    break;

Them modprobe wacom.ko works. Seems that the WACOM should be blacklist in kernel

Michael
>
> Michael
>
> On Sat, Aug 8, 2020 at 4:59 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi
> >
> > What I have seen is that the parse fail to execute
> > hid ll_driver parse fai for
> >
> >  ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
> >                         HID_DT_REPORT, rdesc, rsize);
> >
> > Now this is not implemented in hw/dev-wacom.c . What am I missing?
> >
> > #!/bin/sh
> > IMAGE_DIR="${0%/*}/"
> >
> > if [ "${1}" = "serial-only" ]; then
> >     EXTRA_ARGS='-nographic'
> > else
> >     EXTRA_ARGS='-serial stdio'
> > fi
> >
> > export PATH="/home/michael/work/amarula/buildroot/output/host/bin:${PATH}"
> > exec   qemu-system-i386 -M pc -kernel ${IMAGE_DIR}/bzImage -usb
> > -device usb-wacom-tablet -drive
> > file=${IMAGE_DIR}/rootfs.ext2,if=virtio,format=raw -append "rootwait
> > root=/dev/vda console=tty1 console=ttyS0"  -net nic,model=virtio -net
> > use
> > r  ${EXTRA_ARGS}
> >
> > This is how I run it
> >
> > Michael
> >
> > On Sat, Jul 11, 2020 at 4:38 PM Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > >
> > > Hi all
> > >
> > > On my 4.17.0-rc1 linux kernel i386 running on qemu, I can't register
> > > the wacom driver emulation
> > > QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3)
> > > Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
> > >
> > > [    0.395368] ata2.00: configured for MWDMA2
> > > [    0.397049] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM
> > >   2.5+ PQ: 0 ANSI: 5
> > > [    0.584135] usb 2-1: new full-speed USB device number 2 using xhci_hcd
> > > [    0.734449] usb 2-1: New USB device found, idVendor=056a,
> > > idProduct=0000, bcdDevice=42.10
> > > [    0.734461] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> > > [    0.734466] usb 2-1: Product: Wacom PenPartner
> > > [    0.734470] usb 2-1: Manufacturer: QEMU
> > > [    0.734474] usb 2-1: SerialNumber: 1-0000:00:04.0-1
> > > [    0.737347] usbhid 2-1:1.0: can't add hid device: -32
> > > [    0.737366] usbhid: probe of 2-1:1.0 failed with error -32
> > >
> > > I get back an error. Any suggestions?
> > >
> > > Michael
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Amarula Solutions BV
> > COO Co-Founder
> > Cruquiuskade 47 Amsterdam 1018 AM NL
> > T. +31(0)851119172
> > M. +39(0)3479132170
> > [`as] https://www.amarulasolutions.com
>
>
>
> --
> Michael Nazzareno Trimarchi
> Amarula Solutions BV
> COO Co-Founder
> Cruquiuskade 47 Amsterdam 1018 AM NL
> T. +31(0)851119172
> M. +39(0)3479132170
> [`as] https://www.amarulasolutions.com



-- 
Michael Nazzareno Trimarchi
Amarula Solutions BV
COO Co-Founder
Cruquiuskade 47 Amsterdam 1018 AM NL
T. +31(0)851119172
M. +39(0)3479132170
[`as] https://www.amarulasolutions.com

Re: usb-wacom-tablet failing to register

[Markus Armbruster]

Michael Nazzareno Trimarchi <michael@amarulasolutions.com> writes:

> Hi Markus
>
> I have seen that you are a committer there so what I have seen that

I know precious little about USB, and nothing about this particular
device.  I'm cc'ing our USB maintainer Gerd.

> This request is not implement
>  switch (request) {
>     case InterfaceRequest | USB_REQ_GET_DESCRIPTOR:
>
> When linux probe it fail here
>
> ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
>>                         HID_DT_REPORT, rdesc, rsize);
>
> I think that I miss something in documentation
>
> Running 5.8.0-rc3 and qemu 4.2.0
>
> Michael
>
> On Sat, Aug 8, 2020 at 4:59 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
>>
>> Hi
>>
>> What I have seen is that the parse fail to execute
>> hid ll_driver parse fai for
>>
>>  ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
>>                         HID_DT_REPORT, rdesc, rsize);
>>
>> Now this is not implemented in hw/dev-wacom.c . What am I missing?
>>
>> #!/bin/sh
>> IMAGE_DIR="${0%/*}/"
>>
>> if [ "${1}" = "serial-only" ]; then
>>     EXTRA_ARGS='-nographic'
>> else
>>     EXTRA_ARGS='-serial stdio'
>> fi
>>
>> export PATH="/home/michael/work/amarula/buildroot/output/host/bin:${PATH}"
>> exec   qemu-system-i386 -M pc -kernel ${IMAGE_DIR}/bzImage -usb
>> -device usb-wacom-tablet -drive
>> file=${IMAGE_DIR}/rootfs.ext2,if=virtio,format=raw -append "rootwait
>> root=/dev/vda console=tty1 console=ttyS0"  -net nic,model=virtio -net
>> use
>> r  ${EXTRA_ARGS}
>>
>> This is how I run it
>>
>> Michael
>>
>> On Sat, Jul 11, 2020 at 4:38 PM Michael Nazzareno Trimarchi
>> <michael@amarulasolutions.com> wrote:
>> >
>> > Hi all
>> >
>> > On my 4.17.0-rc1 linux kernel i386 running on qemu, I can't register
>> > the wacom driver emulation
>> > QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3)
>> > Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
>> >
>> > [    0.395368] ata2.00: configured for MWDMA2
>> > [    0.397049] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM
>> >   2.5+ PQ: 0 ANSI: 5
>> > [    0.584135] usb 2-1: new full-speed USB device number 2 using xhci_hcd
>> > [    0.734449] usb 2-1: New USB device found, idVendor=056a,
>> > idProduct=0000, bcdDevice=42.10
>> > [    0.734461] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>> > [    0.734466] usb 2-1: Product: Wacom PenPartner
>> > [    0.734470] usb 2-1: Manufacturer: QEMU
>> > [    0.734474] usb 2-1: SerialNumber: 1-0000:00:04.0-1
>> > [    0.737347] usbhid 2-1:1.0: can't add hid device: -32
>> > [    0.737366] usbhid: probe of 2-1:1.0 failed with error -32
>> >
>> > I get back an error. Any suggestions?
>> >
>> > Michael
>>
>>
>>
>> --
>> Michael Nazzareno Trimarchi
>> Amarula Solutions BV
>> COO Co-Founder
>> Cruquiuskade 47 Amsterdam 1018 AM NL
>> T. +31(0)851119172
>> M. +39(0)3479132170
>> [`as] https://www.amarulasolutions.com

Re: usb-wacom-tablet failing to register

[Philippe Mathieu-Daudé]

Hi Michael,

On 9/2/20 1:31 PM, Markus Armbruster wrote:
> Michael Nazzareno Trimarchi <michael@amarulasolutions.com> writes:
> 
>> Hi Markus
>>
>> I have seen that you are a committer there so what I have seen that
> 
> I know precious little about USB, and nothing about this particular
> device.  I'm cc'ing our USB maintainer Gerd.
> 
>> This request is not implement
>>  switch (request) {
>>     case InterfaceRequest | USB_REQ_GET_DESCRIPTOR:
>>
>> When linux probe it fail here
>>
>> ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
>>>                         HID_DT_REPORT, rdesc, rsize);
>>
>> I think that I miss something in documentation
>>
>> Running 5.8.0-rc3 and qemu 4.2.0
>>
>> Michael
>>
>> On Sat, Aug 8, 2020 at 4:59 PM Michael Nazzareno Trimarchi
>> <michael@amarulasolutions.com> wrote:
>>>
>>> Hi
>>>
>>> What I have seen is that the parse fail to execute
>>> hid ll_driver parse fai for
>>>
>>>  ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
>>>                         HID_DT_REPORT, rdesc, rsize);
>>>
>>> Now this is not implemented in hw/dev-wacom.c . What am I missing?
>>>
>>> #!/bin/sh
>>> IMAGE_DIR="${0%/*}/"
>>>
>>> if [ "${1}" = "serial-only" ]; then
>>>     EXTRA_ARGS='-nographic'
>>> else
>>>     EXTRA_ARGS='-serial stdio'
>>> fi
>>>
>>> export PATH="/home/michael/work/amarula/buildroot/output/host/bin:${PATH}"
>>> exec   qemu-system-i386 -M pc -kernel ${IMAGE_DIR}/bzImage -usb
>>> -device usb-wacom-tablet -drive
>>> file=${IMAGE_DIR}/rootfs.ext2,if=virtio,format=raw -append "rootwait
>>> root=/dev/vda console=tty1 console=ttyS0"  -net nic,model=virtio -net
>>> use
>>> r  ${EXTRA_ARGS}
>>>
>>> This is how I run it
>>>
>>> Michael
>>>
>>> On Sat, Jul 11, 2020 at 4:38 PM Michael Nazzareno Trimarchi
>>> <michael@amarulasolutions.com> wrote:
>>>>
>>>> Hi all
>>>>
>>>> On my 4.17.0-rc1 linux kernel i386 running on qemu, I can't register
>>>> the wacom driver emulation
>>>> QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3)
>>>> Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
>>>>
>>>> [    0.395368] ata2.00: configured for MWDMA2
>>>> [    0.397049] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM
>>>>   2.5+ PQ: 0 ANSI: 5
>>>> [    0.584135] usb 2-1: new full-speed USB device number 2 using xhci_hcd
>>>> [    0.734449] usb 2-1: New USB device found, idVendor=056a,
>>>> idProduct=0000, bcdDevice=42.10
>>>> [    0.734461] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>>>> [    0.734466] usb 2-1: Product: Wacom PenPartner
>>>> [    0.734470] usb 2-1: Manufacturer: QEMU
>>>> [    0.734474] usb 2-1: SerialNumber: 1-0000:00:04.0-1
>>>> [    0.737347] usbhid 2-1:1.0: can't add hid device: -32
>>>> [    0.737366] usbhid: probe of 2-1:1.0 failed with error -32
>>>>
>>>> I get back an error. Any suggestions?

Do you still have that issue?

Re: usb-wacom-tablet failing to register

[Michael Nazzareno Trimarchi]

Hi

On Wed, Feb 3, 2021 at 5:51 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Hi Michael,
>
> On 9/2/20 1:31 PM, Markus Armbruster wrote:
> > Michael Nazzareno Trimarchi <michael@amarulasolutions.com> writes:
> >
> >> Hi Markus
> >>
> >> I have seen that you are a committer there so what I have seen that
> >
> > I know precious little about USB, and nothing about this particular
> > device.  I'm cc'ing our USB maintainer Gerd.
> >
> >> This request is not implement
> >>  switch (request) {
> >>     case InterfaceRequest | USB_REQ_GET_DESCRIPTOR:
> >>
> >> When linux probe it fail here
> >>
> >> ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
> >>>                         HID_DT_REPORT, rdesc, rsize);
> >>
> >> I think that I miss something in documentation
> >>
> >> Running 5.8.0-rc3 and qemu 4.2.0
> >>
> >> Michael
> >>
> >> On Sat, Aug 8, 2020 at 4:59 PM Michael Nazzareno Trimarchi
> >> <michael@amarulasolutions.com> wrote:
> >>>
> >>> Hi
> >>>
> >>> What I have seen is that the parse fail to execute
> >>> hid ll_driver parse fai for
> >>>
> >>>  ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber,
> >>>                         HID_DT_REPORT, rdesc, rsize);
> >>>
> >>> Now this is not implemented in hw/dev-wacom.c . What am I missing?
> >>>
> >>> #!/bin/sh
> >>> IMAGE_DIR="${0%/*}/"
> >>>
> >>> if [ "${1}" = "serial-only" ]; then
> >>>     EXTRA_ARGS='-nographic'
> >>> else
> >>>     EXTRA_ARGS='-serial stdio'
> >>> fi
> >>>
> >>> export PATH="/home/michael/work/amarula/buildroot/output/host/bin:${PATH}"
> >>> exec   qemu-system-i386 -M pc -kernel ${IMAGE_DIR}/bzImage -usb
> >>> -device usb-wacom-tablet -drive
> >>> file=${IMAGE_DIR}/rootfs.ext2,if=virtio,format=raw -append "rootwait
> >>> root=/dev/vda console=tty1 console=ttyS0"  -net nic,model=virtio -net
> >>> use
> >>> r  ${EXTRA_ARGS}
> >>>
> >>> This is how I run it
> >>>
> >>> Michael
> >>>
> >>> On Sat, Jul 11, 2020 at 4:38 PM Michael Nazzareno Trimarchi
> >>> <michael@amarulasolutions.com> wrote:
> >>>>
> >>>> Hi all
> >>>>
> >>>> On my 4.17.0-rc1 linux kernel i386 running on qemu, I can't register
> >>>> the wacom driver emulation
> >>>> QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3)
> >>>> Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
> >>>>
> >>>> [    0.395368] ata2.00: configured for MWDMA2
> >>>> [    0.397049] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM
> >>>>   2.5+ PQ: 0 ANSI: 5
> >>>> [    0.584135] usb 2-1: new full-speed USB device number 2 using xhci_hcd
> >>>> [    0.734449] usb 2-1: New USB device found, idVendor=056a,
> >>>> idProduct=0000, bcdDevice=42.10
> >>>> [    0.734461] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> >>>> [    0.734466] usb 2-1: Product: Wacom PenPartner
> >>>> [    0.734470] usb 2-1: Manufacturer: QEMU
> >>>> [    0.734474] usb 2-1: SerialNumber: 1-0000:00:04.0-1
> >>>> [    0.737347] usbhid 2-1:1.0: can't add hid device: -32
> >>>> [    0.737366] usbhid: probe of 2-1:1.0 failed with error -32
> >>>>
> >>>> I get back an error. Any suggestions?
>
> Do you still have that issue?
>

Sorry, I'm really on a lot of programming. I have a patch, need to
clean up and send up, according to review
and I need to test it again

Michael

-- 
Michael Nazzareno Trimarchi
Amarula Solutions BV
COO Co-Founder
Cruquiuskade 47 Amsterdam 1018 AM NL
T. +31(0)851119172
M. +39(0)3479132170
[`as] https://www.amarulasolutions.com