From: Wei Liu <liuw@liuw.name>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"annie.li@oracle.com" <annie.li@oracle.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH 5/6] xen-netback: coalesce slots before copying
Date: Mon, 25 Mar 2013 17:06:01 +0000 [thread overview]
Message-ID: <CAOsiSVXcKc583rEb9hXhtuhpTtrQ+ib_pgxaX9h77v98BWfgKg@mail.gmail.com> (raw)
In-Reply-To: <CAOsiSVV8gtKqFxyAr3XN9YF78WjtFqzvx5mnA1dKTrS_4qzXBw@mail.gmail.com>
On Mon, Mar 25, 2013 at 4:58 PM, Wei Liu <liuw@liuw.name> wrote:
>
> So it is a bit tricky here. Let me clarify this, the head field is
> used to indicate the start of a new tx requests queue and the end of
> previous queue.
>
> Imagine a sequence of head fileds(I = INVALID_PENDING_RING_IDX below),
> the number is the starting index of pending ring.
>
> .... 0 I I I 5 I I ...
>
> consume all tx_info but not setting I to 0 (or any number other then
> I) makes the sequence remains the same as before. The in subsequent
> call to process next SKB, which has 3 extra slots, which makes the
Sorry, should be "4 extra slots"
sequence looks like
.... 8 | | | | | | ...
but in fact the correct sequence should be
.... 8 | | | | 0 0 ...
Wei.
next prev parent reply other threads:[~2013-03-25 17:06 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:08 [PATCH 0/6 V2] Bundle fixes for Xen netfront / netback Wei Liu
2013-03-25 11:08 ` [PATCH 1/6] xen-netfront: remove unused variable `extra' Wei Liu
2013-03-25 11:08 ` Wei Liu
2013-03-25 14:21 ` [Xen-devel] " David Vrabel
2013-03-25 14:21 ` David Vrabel
2013-03-25 16:20 ` David Miller
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` [PATCH 2/6] xen-netfront: reduce gso_max_size to account for ethernet header Wei Liu
2013-03-25 11:08 ` Wei Liu
2013-03-25 13:54 ` Malcolm Crossley
2013-03-25 14:23 ` [Xen-devel] " David Vrabel
2013-03-25 14:39 ` Jan Beulich
2013-03-25 14:39 ` Jan Beulich
2013-03-25 14:23 ` David Vrabel
2013-03-25 15:50 ` Sergei Shtylyov
2013-03-25 15:50 ` Sergei Shtylyov
2013-03-25 16:18 ` David Miller
2013-03-25 16:54 ` Eric Dumazet
2013-03-25 16:54 ` Eric Dumazet
2013-03-25 16:59 ` David Miller
2013-03-25 17:24 ` Eric Dumazet
2013-03-25 17:24 ` Eric Dumazet
2013-03-25 20:49 ` Ben Hutchings
2013-03-25 20:49 ` Ben Hutchings
2013-03-25 16:59 ` David Miller
2013-03-25 18:32 ` Wei Liu
2013-03-25 18:32 ` Wei Liu
2013-03-25 18:39 ` David Miller
2013-03-25 18:39 ` David Miller
2013-03-25 19:09 ` Malcolm Crossley
2013-03-25 16:18 ` David Miller
2013-03-25 16:56 ` Konrad Rzeszutek Wilk
2013-03-25 16:56 ` Konrad Rzeszutek Wilk
2013-03-25 11:08 ` [PATCH 3/6] xen-netfront: frags -> slots in xennet_get_responses Wei Liu
2013-03-25 11:08 ` Wei Liu
2013-03-25 14:25 ` [Xen-devel] " David Vrabel
2013-03-25 14:25 ` David Vrabel
2013-03-25 16:20 ` David Miller
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` [PATCH 4/6] xen-netback: remove skb in xen_netbk_alloc_page Wei Liu
2013-03-25 16:20 ` David Miller
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` Wei Liu
2013-03-25 11:08 ` [PATCH 5/6] xen-netback: coalesce slots before copying Wei Liu
2013-03-25 11:08 ` Wei Liu
2013-03-25 15:13 ` David Vrabel
2013-03-25 15:47 ` [Xen-devel] " Wei Liu
2013-03-25 16:34 ` David Vrabel
2013-03-25 16:58 ` Wei Liu
2013-03-25 17:06 ` Wei Liu [this message]
2013-03-25 17:06 ` Wei Liu
2013-03-25 18:29 ` [Xen-devel] " David Vrabel
2013-03-25 19:09 ` Wei Liu
2013-03-26 9:16 ` Paul Durrant
2013-03-26 9:16 ` [Xen-devel] " Paul Durrant
2013-03-26 9:51 ` Wei Liu
2013-03-26 9:51 ` [Xen-devel] " Wei Liu
2013-03-26 11:00 ` James Harper
2013-03-26 11:24 ` Paul Durrant
2013-03-26 11:29 ` James Harper
2013-03-26 11:38 ` Paul Durrant
2013-03-26 11:38 ` [Xen-devel] " Paul Durrant
2013-03-26 11:29 ` James Harper
2013-03-26 11:24 ` Paul Durrant
2013-03-26 11:27 ` David Laight
2013-03-26 11:27 ` [Xen-devel] " David Laight
2013-03-26 11:00 ` James Harper
2013-03-26 10:52 ` James Harper
2013-03-26 10:52 ` [Xen-devel] " James Harper
2013-03-26 11:06 ` David Vrabel
2013-03-26 11:15 ` James Harper
2013-03-26 11:15 ` [Xen-devel] " James Harper
2013-03-26 11:06 ` David Vrabel
2013-03-26 11:13 ` David Vrabel
2013-03-26 11:13 ` [Xen-devel] " David Vrabel
2013-03-26 11:29 ` Wei Liu
2013-03-26 11:29 ` [Xen-devel] " Wei Liu
2013-03-25 19:09 ` Wei Liu
2013-03-25 18:29 ` David Vrabel
2013-03-25 16:34 ` David Vrabel
2013-03-25 15:47 ` Wei Liu
2013-03-25 15:13 ` David Vrabel
2013-03-25 16:20 ` David Miller
2013-03-25 16:20 ` David Miller
2013-03-25 16:57 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-04-09 15:10 ` Ian Campbell
2013-04-09 15:10 ` Ian Campbell
2013-03-25 16:57 ` Konrad Rzeszutek Wilk
2013-03-26 18:02 ` David Vrabel
2013-03-26 18:02 ` David Vrabel
2013-03-25 11:08 ` [PATCH 6/6] xen-netback: don't disconnect frontend when seeing oversize frame Wei Liu
2013-03-25 11:08 ` Wei Liu
2013-03-25 11:47 ` David Vrabel
2013-03-25 12:00 ` Wei Liu
2013-03-25 12:00 ` Wei Liu
2013-03-25 11:47 ` David Vrabel
2013-03-25 12:53 ` Jan Beulich
2013-03-25 12:53 ` [Xen-devel] " Jan Beulich
2013-03-25 13:52 ` Wei Liu
2013-03-25 13:52 ` [Xen-devel] " Wei Liu
2013-03-25 16:21 ` David Miller
2013-03-25 16:21 ` David Miller
2013-03-25 16:58 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-27 10:03 ` William Dauchy
2013-03-27 10:03 ` William Dauchy
2013-03-25 16:58 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOsiSVXcKc583rEb9hXhtuhpTtrQ+ib_pgxaX9h77v98BWfgKg@mail.gmail.com \
--to=liuw@liuw.name \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.