All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilad Ben-Yossef <gilad@benyossef.com>
To: bincy_k_philip@yahoo.co.in
Cc: devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
Date: Tue, 11 Jul 2017 14:46:29 +0300	[thread overview]
Message-ID: <CAOtvUMf3CU7O6x8VpNzPLNtvmKhXC0eDCrueYTpkXErmHcg_hA@mail.gmail.com> (raw)
In-Reply-To: <1498797169-3093-1-git-send-email-bincy_k_philip@yahoo.co.in>

Hello Philip,

Thank your patch.

Your patch subject line is not descriptive and not formatted well.

A better subject would be something like:

staging: ccree: move comment to fit coding style

Thanks,
Gilad

On Fri, Jun 30, 2017 at 7:32 AM,  <bincy_k_philip@yahoo.co.in> wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
>
> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
> index aaa56c8..a18e6c9 100644
> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
> @@ -27,7 +27,8 @@
>  ******************************************************************************/
>
>  #define HW_DESC_SIZE_WORDS             6
> -#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
> +/* Define max. available slots in HW queue */
> +#define HW_QUEUE_SLOTS_MAX              15
>
>  #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>
> --
> 1.8.3.1
>



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

WARNING: multiple messages have this Message-ID (diff)
From: Gilad Ben-Yossef <gilad@benyossef.com>
To: bincy_k_philip@yahoo.co.in
Cc: devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
Date: Tue, 11 Jul 2017 14:46:29 +0300	[thread overview]
Message-ID: <CAOtvUMf3CU7O6x8VpNzPLNtvmKhXC0eDCrueYTpkXErmHcg_hA@mail.gmail.com> (raw)
In-Reply-To: <1498797169-3093-1-git-send-email-bincy_k_philip@yahoo.co.in>

Hello Philip,

Thank your patch.

Your patch subject line is not descriptive and not formatted well.

A better subject would be something like:

staging: ccree: move comment to fit coding style

Thanks,
Gilad

On Fri, Jun 30, 2017 at 7:32 AM,  <bincy_k_philip@yahoo.co.in> wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
>
> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
> index aaa56c8..a18e6c9 100644
> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
> @@ -27,7 +27,8 @@
>  ******************************************************************************/
>
>  #define HW_DESC_SIZE_WORDS             6
> -#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
> +/* Define max. available slots in HW queue */
> +#define HW_QUEUE_SLOTS_MAX              15
>
>  #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>
> --
> 1.8.3.1
>



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2017-07-11 11:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30  4:32 [PATCH] Stagingdriver cctree: Fix for checkpatch warning bincy_k_philip
2017-06-30  4:32 ` bincy_k_philip
2017-07-11 11:46 ` Gilad Ben-Yossef [this message]
2017-07-11 11:46   ` Gilad Ben-Yossef
2017-07-12  8:53   ` bincy
2017-07-12  8:53     ` bincy
  -- strict thread matches above, loose matches on Subject: below --
2017-06-27  6:17 bincy_k_philip
2017-06-27  6:17 ` bincy_k_philip
2017-06-29 14:36 ` Greg KH
2017-06-29 14:36   ` Greg KH
2017-06-29 14:36   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOtvUMf3CU7O6x8VpNzPLNtvmKhXC0eDCrueYTpkXErmHcg_hA@mail.gmail.com \
    --to=gilad@benyossef.com \
    --cc=bincy_k_philip@yahoo.co.in \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.