[PATCH] Stagingdriver cctree: Fix for checkpatch warning

[PATCH] Stagingdriver cctree: Fix for checkpatch warning

[bincy_k_philip]

From: Bincy K Philip <bincy_k_philip@yahoo.co.in>

Trivial fix for Line over 80 characters

Moved the comment to top of the definition

Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
---
 drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
 ******************************************************************************/
 
 #define HW_DESC_SIZE_WORDS		6
-#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX              15
 
 #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
 
-- 
1.8.3.1

[PATCH] Stagingdriver cctree: Fix for checkpatch warning

[bincy_k_philip]

From: Bincy K Philip <bincy_k_philip@yahoo.co.in>

Trivial fix for Line over 80 characters

Moved the comment to top of the definition

Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
---
 drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
 ******************************************************************************/
 
 #define HW_DESC_SIZE_WORDS		6
-#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX              15
 
 #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
 
-- 
1.8.3.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning

[Gilad Ben-Yossef]

Hello Philip,

Thank your patch.

Your patch subject line is not descriptive and not formatted well.

A better subject would be something like:

staging: ccree: move comment to fit coding style

Thanks,
Gilad

On Fri, Jun 30, 2017 at 7:32 AM,  <bincy_k_philip@yahoo.co.in> wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
>
> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
> index aaa56c8..a18e6c9 100644
> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
> @@ -27,7 +27,8 @@
>  ******************************************************************************/
>
>  #define HW_DESC_SIZE_WORDS             6
> -#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
> +/* Define max. available slots in HW queue */
> +#define HW_QUEUE_SLOTS_MAX              15
>
>  #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>
> --
> 1.8.3.1
>



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning

[Gilad Ben-Yossef]

Hello Philip,

Thank your patch.

Your patch subject line is not descriptive and not formatted well.

A better subject would be something like:

staging: ccree: move comment to fit coding style

Thanks,
Gilad

On Fri, Jun 30, 2017 at 7:32 AM,  <bincy_k_philip@yahoo.co.in> wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
>
> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
> index aaa56c8..a18e6c9 100644
> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
> @@ -27,7 +27,8 @@
>  ******************************************************************************/
>
>  #define HW_DESC_SIZE_WORDS             6
> -#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
> +/* Define max. available slots in HW queue */
> +#define HW_QUEUE_SLOTS_MAX              15
>
>  #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>
> --
> 1.8.3.1
>



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning

[bincy]

Hi Gilad,

I have added your comments and resent the patch.Thanks

On 11/07/17 17:16, Gilad Ben-Yossef wrote:
> Hello Philip,
>
> Thank your patch.
>
> Your patch subject line is not descriptive and not formatted well.
>
> A better subject would be something like:
>
> staging: ccree: move comment to fit coding style
>
> Thanks,
> Gilad
>
> On Fri, Jun 30, 2017 at 7:32 AM,  <bincy_k_philip@yahoo.co.in> wrote:
>> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>>
>> Trivial fix for Line over 80 characters
>>
>> Moved the comment to top of the definition
>>
>> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>> ---
>>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
>> index aaa56c8..a18e6c9 100644
>> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
>> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
>> @@ -27,7 +27,8 @@
>>  ******************************************************************************/
>>
>>  #define HW_DESC_SIZE_WORDS             6
>> -#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
>> +/* Define max. available slots in HW queue */
>> +#define HW_QUEUE_SLOTS_MAX              15
>>
>>  #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>>
>> --
>> 1.8.3.1
>>
>
>
>

Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning

[bincy]

Hi Gilad,

I have added your comments and resent the patch.Thanks

On 11/07/17 17:16, Gilad Ben-Yossef wrote:
> Hello Philip,
>
> Thank your patch.
>
> Your patch subject line is not descriptive and not formatted well.
>
> A better subject would be something like:
>
> staging: ccree: move comment to fit coding style
>
> Thanks,
> Gilad
>
> On Fri, Jun 30, 2017 at 7:32 AM,  <bincy_k_philip@yahoo.co.in> wrote:
>> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>>
>> Trivial fix for Line over 80 characters
>>
>> Moved the comment to top of the definition
>>
>> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>> ---
>>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
>> index aaa56c8..a18e6c9 100644
>> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
>> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
>> @@ -27,7 +27,8 @@
>>  ******************************************************************************/
>>
>>  #define HW_DESC_SIZE_WORDS             6
>> -#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
>> +/* Define max. available slots in HW queue */
>> +#define HW_QUEUE_SLOTS_MAX              15
>>
>>  #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>>
>> --
>> 1.8.3.1
>>
>
>
>

[PATCH] Stagingdriver cctree: Fix for checkpatch warning

[bincy_k_philip]

From: Bincy K Philip <bincy_k_philip@yahoo.co.in>

Trivial fix for Line over 80 characters

Moved the comment to top of the definition
---
 drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
 ******************************************************************************/
 
 #define HW_DESC_SIZE_WORDS		6
-#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX              15
 
 #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
 
-- 
1.8.3.1

[PATCH] Stagingdriver cctree: Fix for checkpatch warning

[bincy_k_philip]

From: Bincy K Philip <bincy_k_philip@yahoo.co.in>

Trivial fix for Line over 80 characters

Moved the comment to top of the definition
---
 drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
 ******************************************************************************/
 
 #define HW_DESC_SIZE_WORDS		6
-#define HW_QUEUE_SLOTS_MAX              15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX              15
 
 #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
 
-- 
1.8.3.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning

[Greg KH]

On Tue, Jun 27, 2017 at 11:47:56AM +0530, bincy_k_philip@yahoo.co.in wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> 
> Trivial fix for Line over 80 characters
> 
> Moved the comment to top of the definition
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)


Always use scripts/checkpatch.pl on your patch so you don't get a grumpy
maintaner telling you to run scripts/checkpatch.pl on your patch :(

Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning

[Greg KH]

On Tue, Jun 27, 2017 at 11:47:56AM +0530, bincy_k_philip@yahoo.co.in wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> 
> Trivial fix for Line over 80 characters
> 
> Moved the comment to top of the definition
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)


Always use scripts/checkpatch.pl on your patch so you don't get a grumpy
maintaner telling you to run scripts/checkpatch.pl on your patch :(

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning

[Greg KH]

On Tue, Jun 27, 2017 at 11:47:56AM +0530, bincy_k_philip@yahoo.co.in wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> 
> Trivial fix for Line over 80 characters
> 
> Moved the comment to top of the definition
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)


Always use scripts/checkpatch.pl on your patch so you don't get a grumpy
maintaner telling you to run scripts/checkpatch.pl on your patch :(