From: Pintu Kumar <pintu.ping@gmail.com>
To: "Daniel Díaz Rodríguez" <daniel.diaz@linaro.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Darren Hart <dvhart@infradead.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/android: Fix line continuation in Makefile
Date: Thu, 8 Feb 2018 10:45:14 +0530 [thread overview]
Message-ID: <CAOuPNLhwSaG2K2X_xE4PzaXQFWzNLVN=F+dtqPg=iBduWzRxTg@mail.gmail.com> (raw)
In-Reply-To: <CAEUSe79T9Miw==D6u3Wx-EMymzP8aABWf_Lfqb9KP57WZgU0ZQ@mail.gmail.com>
On Wed, Feb 7, 2018 at 10:46 PM, Daniel Díaz Rodríguez
<daniel.diaz@linaro.org> wrote:
> Hello!
>
>
> On 7 February 2018 at 00:01, Pintu Kumar <pintu.ping@gmail.com> wrote:
> [...]
>> Thanks for your patch.
>> However, I have copied this Makefile from
>> tools/testing/selftests/futex/Makefile before modifying it.
>> If there is a problem with backslash then the same problem must be
>> there in futex Makefile as well.
>
> There is. Patch coming.
OK
>
>
> [...]
>> Also is it because of make version ?
>> Can you check your make version ?
>
> It's make 3.81.
My make version was 4.1.
So I did not face any problem. I guess this problem is fixed from make
version 4.x on wards.
However, for backward compatibility we can include these change.
So, its looks good for me, however someone else must approve it.
>
> Thanks and greetings!
>
> Daniel Díaz
> daniel.diaz@linaro.org
WARNING: multiple messages have this Message-ID (diff)
From: pintu.ping at gmail.com (Pintu Kumar)
Subject: [Linux-kselftest-mirror] [PATCH] selftests/android: Fix line continuation in Makefile
Date: Thu, 8 Feb 2018 10:45:14 +0530 [thread overview]
Message-ID: <CAOuPNLhwSaG2K2X_xE4PzaXQFWzNLVN=F+dtqPg=iBduWzRxTg@mail.gmail.com> (raw)
In-Reply-To: <CAEUSe79T9Miw==D6u3Wx-EMymzP8aABWf_Lfqb9KP57WZgU0ZQ@mail.gmail.com>
On Wed, Feb 7, 2018 at 10:46 PM, Daniel Díaz Rodríguez
<daniel.diaz at linaro.org> wrote:
> Hello!
>
>
> On 7 February 2018 at 00:01, Pintu Kumar <pintu.ping at gmail.com> wrote:
> [...]
>> Thanks for your patch.
>> However, I have copied this Makefile from
>> tools/testing/selftests/futex/Makefile before modifying it.
>> If there is a problem with backslash then the same problem must be
>> there in futex Makefile as well.
>
> There is. Patch coming.
OK
>
>
> [...]
>> Also is it because of make version ?
>> Can you check your make version ?
>
> It's make 3.81.
My make version was 4.1.
So I did not face any problem. I guess this problem is fixed from make
version 4.x on wards.
However, for backward compatibility we can include these change.
So, its looks good for me, however someone else must approve it.
>
> Thanks and greetings!
>
> Daniel Díaz
> daniel.diaz at linaro.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: pintu.ping@gmail.com (Pintu Kumar)
Subject: [Linux-kselftest-mirror] [PATCH] selftests/android: Fix line continuation in Makefile
Date: Thu, 8 Feb 2018 10:45:14 +0530 [thread overview]
Message-ID: <CAOuPNLhwSaG2K2X_xE4PzaXQFWzNLVN=F+dtqPg=iBduWzRxTg@mail.gmail.com> (raw)
Message-ID: <20180208051514.W5_OZMFGnQjWH6i197mGxKO1n3m9VzFa7Ux-U-j6-Wk@z> (raw)
In-Reply-To: <CAEUSe79T9Miw==D6u3Wx-EMymzP8aABWf_Lfqb9KP57WZgU0ZQ@mail.gmail.com>
On Wed, Feb 7, 2018 at 10:46 PM, Daniel Díaz Rodríguez
<daniel.diaz@linaro.org> wrote:
> Hello!
>
>
> On 7 February 2018@00:01, Pintu Kumar <pintu.ping@gmail.com> wrote:
> [...]
>> Thanks for your patch.
>> However, I have copied this Makefile from
>> tools/testing/selftests/futex/Makefile before modifying it.
>> If there is a problem with backslash then the same problem must be
>> there in futex Makefile as well.
>
> There is. Patch coming.
OK
>
>
> [...]
>> Also is it because of make version ?
>> Can you check your make version ?
>
> It's make 3.81.
My make version was 4.1.
So I did not face any problem. I guess this problem is fixed from make
version 4.x on wards.
However, for backward compatibility we can include these change.
So, its looks good for me, however someone else must approve it.
>
> Thanks and greetings!
>
> Daniel Díaz
> daniel.diaz at linaro.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-08 5:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 23:52 [PATCH] selftests/android: Fix line continuation in Makefile Daniel Díaz
2018-02-06 23:52 ` [Linux-kselftest-mirror] " Daniel Díaz
2018-02-06 23:52 `
2018-02-07 6:01 ` Pintu Kumar
2018-02-07 6:01 ` [Linux-kselftest-mirror] " Pintu Kumar
2018-02-07 6:01 ` pintu.ping
2018-02-07 17:16 ` Daniel Díaz Rodríguez
2018-02-07 17:16 ` [Linux-kselftest-mirror] " Daniel Díaz Rodríguez
2018-02-07 17:16 `
2018-02-08 5:15 ` Pintu Kumar [this message]
2018-02-08 5:15 ` Pintu Kumar
2018-02-08 5:15 ` pintu.ping
2018-02-08 5:17 ` Pintu Kumar
2018-02-08 5:17 ` [Linux-kselftest-mirror] " Pintu Kumar
2018-02-08 5:17 ` pintu.ping
2018-02-13 21:25 ` Shuah Khan
2018-02-13 21:25 ` Shuah Khan
2018-02-13 21:25 ` shuahkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOuPNLhwSaG2K2X_xE4PzaXQFWzNLVN=F+dtqPg=iBduWzRxTg@mail.gmail.com' \
--to=pintu.ping@gmail.com \
--cc=daniel.diaz@linaro.org \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.