From: Sean Paul <seanpaul@chromium.org> To: Meghana Madhyastha <meghana.madhyastha@gmail.com> Cc: outreachy-kernel@googlegroups.com, dri-devel <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [Outreachy kernel] [PATCH v2 0/3] drm: Code cleanup Date: Wed, 13 Sep 2017 17:49:05 -0400 [thread overview] Message-ID: <CAOw6vbJ9m1g6vaQt8TNDV-8PDnJx_WLS_b11uUa+K=JLKHhdcw@mail.gmail.com> (raw) In-Reply-To: <20170913161235.GA3155@meghana-HP-Pavilion-Notebook> On Wed, Sep 13, 2017 at 12:12 PM, Meghana Madhyastha <meghana.madhyastha@gmail.com> wrote: > These patches fix the checkpath warnings and errors > in drm_agpsupport.c > > changes in v2: > -Changed the commit subject prefix to follow the style used in drm. > -Combine multiple redundant if conditions to a single condition in > patch 3. > > Meghana Madhyastha (3): > drm: Move EXPORT_SYMBOL so that it immediately follows its function > drm: Replace "foo * bar" with "foo *bar" > drm: Remove assignment in if condition Hi Meghana, Thank you for your submissions! Would you mind prefixing the subjects with drm/agpsupport instead of just drm? I know the git log shows mostly drm:, but I think that's more because the only time this file is touched is during subsystem wide refactors/cleanups. While this may seem like a small nit, narrowing down the affected file(s) in the subject really helps when glancing at the log. Sean > > drivers/gpu/drm/drm_agpsupport.c | 45 ++++++++++++++++++++-------------------- > 1 file changed, 23 insertions(+), 22 deletions(-) > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170913161235.GA3155%40meghana-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <seanpaul@chromium.org> To: Meghana Madhyastha <meghana.madhyastha@gmail.com> Cc: outreachy-kernel@googlegroups.com, Jani Nikula <jani.nikula@linux.intel.com>, dri-devel <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [Outreachy kernel] [PATCH v2 0/3] drm: Code cleanup Date: Wed, 13 Sep 2017 17:49:05 -0400 [thread overview] Message-ID: <CAOw6vbJ9m1g6vaQt8TNDV-8PDnJx_WLS_b11uUa+K=JLKHhdcw@mail.gmail.com> (raw) In-Reply-To: <20170913161235.GA3155@meghana-HP-Pavilion-Notebook> On Wed, Sep 13, 2017 at 12:12 PM, Meghana Madhyastha <meghana.madhyastha@gmail.com> wrote: > These patches fix the checkpath warnings and errors > in drm_agpsupport.c > > changes in v2: > -Changed the commit subject prefix to follow the style used in drm. > -Combine multiple redundant if conditions to a single condition in > patch 3. > > Meghana Madhyastha (3): > drm: Move EXPORT_SYMBOL so that it immediately follows its function > drm: Replace "foo * bar" with "foo *bar" > drm: Remove assignment in if condition Hi Meghana, Thank you for your submissions! Would you mind prefixing the subjects with drm/agpsupport instead of just drm? I know the git log shows mostly drm:, but I think that's more because the only time this file is touched is during subsystem wide refactors/cleanups. While this may seem like a small nit, narrowing down the affected file(s) in the subject really helps when glancing at the log. Sean > > drivers/gpu/drm/drm_agpsupport.c | 45 ++++++++++++++++++++-------------------- > 1 file changed, 23 insertions(+), 22 deletions(-) > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170913161235.GA3155%40meghana-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2017-09-13 21:49 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-13 16:12 [PATCH v2 0/3] drm: Code cleanup Meghana Madhyastha 2017-09-13 16:12 ` Meghana Madhyastha 2017-09-13 21:49 ` Sean Paul [this message] 2017-09-13 21:49 ` [Outreachy kernel] " Sean Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOw6vbJ9m1g6vaQt8TNDV-8PDnJx_WLS_b11uUa+K=JLKHhdcw@mail.gmail.com' \ --to=seanpaul@chromium.org \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=meghana.madhyastha@gmail.com \ --cc=outreachy-kernel@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.