* [PATCH v2 0/3] drm: Code cleanup
@ 2017-09-13 16:12 ` Meghana Madhyastha
0 siblings, 0 replies; 4+ messages in thread
From: Meghana Madhyastha @ 2017-09-13 16:12 UTC (permalink / raw)
To: outreachy-kernel, Jani Nikula, dri-devel
These patches fix the checkpath warnings and errors
in drm_agpsupport.c
changes in v2:
-Changed the commit subject prefix to follow the style used in drm.
-Combine multiple redundant if conditions to a single condition in
patch 3.
Meghana Madhyastha (3):
drm: Move EXPORT_SYMBOL so that it immediately follows its function
drm: Replace "foo * bar" with "foo *bar"
drm: Remove assignment in if condition
drivers/gpu/drm/drm_agpsupport.c | 45 ++++++++++++++++++++--------------------
1 file changed, 23 insertions(+), 22 deletions(-)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 0/3] drm: Code cleanup
@ 2017-09-13 16:12 ` Meghana Madhyastha
0 siblings, 0 replies; 4+ messages in thread
From: Meghana Madhyastha @ 2017-09-13 16:12 UTC (permalink / raw)
To: outreachy-kernel, Jani Nikula, dri-devel
These patches fix the checkpath warnings and errors
in drm_agpsupport.c
changes in v2:
-Changed the commit subject prefix to follow the style used in drm.
-Combine multiple redundant if conditions to a single condition in
patch 3.
Meghana Madhyastha (3):
drm: Move EXPORT_SYMBOL so that it immediately follows its function
drm: Replace "foo * bar" with "foo *bar"
drm: Remove assignment in if condition
drivers/gpu/drm/drm_agpsupport.c | 45 ++++++++++++++++++++--------------------
1 file changed, 23 insertions(+), 22 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 0/3] drm: Code cleanup
2017-09-13 16:12 ` Meghana Madhyastha
@ 2017-09-13 21:49 ` Sean Paul
-1 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2017-09-13 21:49 UTC (permalink / raw)
To: Meghana Madhyastha; +Cc: outreachy-kernel, dri-devel, Daniel Vetter
On Wed, Sep 13, 2017 at 12:12 PM, Meghana Madhyastha
<meghana.madhyastha@gmail.com> wrote:
> These patches fix the checkpath warnings and errors
> in drm_agpsupport.c
>
> changes in v2:
> -Changed the commit subject prefix to follow the style used in drm.
> -Combine multiple redundant if conditions to a single condition in
> patch 3.
>
> Meghana Madhyastha (3):
> drm: Move EXPORT_SYMBOL so that it immediately follows its function
> drm: Replace "foo * bar" with "foo *bar"
> drm: Remove assignment in if condition
Hi Meghana,
Thank you for your submissions!
Would you mind prefixing the subjects with drm/agpsupport instead of
just drm? I know the git log shows mostly drm:, but I think that's
more because the only time this file is touched is during subsystem
wide refactors/cleanups. While this may seem like a small nit,
narrowing down the affected file(s) in the subject really helps when
glancing at the log.
Sean
>
> drivers/gpu/drm/drm_agpsupport.c | 45 ++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 22 deletions(-)
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170913161235.GA3155%40meghana-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 0/3] drm: Code cleanup
@ 2017-09-13 21:49 ` Sean Paul
0 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2017-09-13 21:49 UTC (permalink / raw)
To: Meghana Madhyastha
Cc: outreachy-kernel, Jani Nikula, dri-devel, Daniel Vetter
On Wed, Sep 13, 2017 at 12:12 PM, Meghana Madhyastha
<meghana.madhyastha@gmail.com> wrote:
> These patches fix the checkpath warnings and errors
> in drm_agpsupport.c
>
> changes in v2:
> -Changed the commit subject prefix to follow the style used in drm.
> -Combine multiple redundant if conditions to a single condition in
> patch 3.
>
> Meghana Madhyastha (3):
> drm: Move EXPORT_SYMBOL so that it immediately follows its function
> drm: Replace "foo * bar" with "foo *bar"
> drm: Remove assignment in if condition
Hi Meghana,
Thank you for your submissions!
Would you mind prefixing the subjects with drm/agpsupport instead of
just drm? I know the git log shows mostly drm:, but I think that's
more because the only time this file is touched is during subsystem
wide refactors/cleanups. While this may seem like a small nit,
narrowing down the affected file(s) in the subject really helps when
glancing at the log.
Sean
>
> drivers/gpu/drm/drm_agpsupport.c | 45 ++++++++++++++++++++--------------------
> 1 file changed, 23 insertions(+), 22 deletions(-)
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170913161235.GA3155%40meghana-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-13 21:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 16:12 [PATCH v2 0/3] drm: Code cleanup Meghana Madhyastha
2017-09-13 16:12 ` Meghana Madhyastha
2017-09-13 21:49 ` [Outreachy kernel] " Sean Paul
2017-09-13 21:49 ` Sean Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.