From: Sean Paul <seanpaul@chromium.org> To: Brian Norris <briannorris@chromium.org> Cc: Mark Yao <mark.yao@rock-chips.com>, David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>, dri-devel <dri-devel@lists.freedesktop.org>, linux-rockchip@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Yakir Yang <ykk@rock-chips.com> Subject: Re: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print Date: Wed, 17 Aug 2016 14:21:28 -0700 [thread overview] Message-ID: <CAOw6vbLi+T+-JHgKR78GAhck=P+1fT90AKW0C9OBJ+tX5Sm5mQ@mail.gmail.com> (raw) In-Reply-To: <1471468209-31192-1-git-send-email-briannorris@chromium.org> On Wed, Aug 17, 2016 at 2:10 PM, Brian Norris <briannorris@chromium.org> wrote: > This driver is the only user of of_drm_find_panel() which prints an > error before doing probe deferral, yielding messages like this on boot, > before eventually succeeding: > > [ 2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel > ... > [ 4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel > ... > > Let's just drop the message. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Looks good. I'll add this to the rest of the rockchip patches I have queued for -next. Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 89aadbf465f8..045fcc46827c 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev) > > panel = of_drm_find_panel(panel_node); > of_node_put(panel_node); > - if (!panel) { > - DRM_ERROR("failed to find panel\n"); > + if (!panel) > return -EPROBE_DEFER; > - } > } > > dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL); > -- > 2.8.0.rc3.226.g39d4020 >
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <seanpaul@chromium.org> To: Brian Norris <briannorris@chromium.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print Date: Wed, 17 Aug 2016 14:21:28 -0700 [thread overview] Message-ID: <CAOw6vbLi+T+-JHgKR78GAhck=P+1fT90AKW0C9OBJ+tX5Sm5mQ@mail.gmail.com> (raw) In-Reply-To: <1471468209-31192-1-git-send-email-briannorris@chromium.org> On Wed, Aug 17, 2016 at 2:10 PM, Brian Norris <briannorris@chromium.org> wrote: > This driver is the only user of of_drm_find_panel() which prints an > error before doing probe deferral, yielding messages like this on boot, > before eventually succeeding: > > [ 2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel > ... > [ 4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel > ... > > Let's just drop the message. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Looks good. I'll add this to the rest of the rockchip patches I have queued for -next. Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 89aadbf465f8..045fcc46827c 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev) > > panel = of_drm_find_panel(panel_node); > of_node_put(panel_node); > - if (!panel) { > - DRM_ERROR("failed to find panel\n"); > + if (!panel) > return -EPROBE_DEFER; > - } > } > > dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL); > -- > 2.8.0.rc3.226.g39d4020 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-17 21:21 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-17 21:10 [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print Brian Norris 2016-08-17 21:10 ` Brian Norris 2016-08-17 21:21 ` Sean Paul [this message] 2016-08-17 21:21 ` Sean Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOw6vbLi+T+-JHgKR78GAhck=P+1fT90AKW0C9OBJ+tX5Sm5mQ@mail.gmail.com' \ --to=seanpaul@chromium.org \ --cc=airlied@linux.ie \ --cc=briannorris@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=heiko@sntech.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.yao@rock-chips.com \ --cc=ykk@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.