All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print
@ 2016-08-17 21:10 ` Brian Norris
  0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2016-08-17 21:10 UTC (permalink / raw)
  To: Mark Yao
  Cc: David Airlie, Heiko Stuebner, dri-devel, linux-rockchip,
	linux-kernel, Sean Paul, Yakir Yang, Brian Norris

This driver is the only user of of_drm_find_panel() which prints an
error before doing probe deferral, yielding messages like this on boot,
before eventually succeeding:

[    2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel
...
[    4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel
...

Let's just drop the message.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 89aadbf465f8..045fcc46827c 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
 
 		panel = of_drm_find_panel(panel_node);
 		of_node_put(panel_node);
-		if (!panel) {
-			DRM_ERROR("failed to find panel\n");
+		if (!panel)
 			return -EPROBE_DEFER;
-		}
 	}
 
 	dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
-- 
2.8.0.rc3.226.g39d4020

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print
@ 2016-08-17 21:10 ` Brian Norris
  0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2016-08-17 21:10 UTC (permalink / raw)
  To: Mark Yao
  Cc: David Airlie, Heiko Stuebner, dri-devel, linux-rockchip,
	linux-kernel, Sean Paul, Yakir Yang, Brian Norris

This driver is the only user of of_drm_find_panel() which prints an
error before doing probe deferral, yielding messages like this on boot,
before eventually succeeding:

[    2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel
...
[    4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel
...

Let's just drop the message.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 89aadbf465f8..045fcc46827c 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
 
 		panel = of_drm_find_panel(panel_node);
 		of_node_put(panel_node);
-		if (!panel) {
-			DRM_ERROR("failed to find panel\n");
+		if (!panel)
 			return -EPROBE_DEFER;
-		}
 	}
 
 	dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
-- 
2.8.0.rc3.226.g39d4020

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print
  2016-08-17 21:10 ` Brian Norris
@ 2016-08-17 21:21   ` Sean Paul
  -1 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2016-08-17 21:21 UTC (permalink / raw)
  To: Brian Norris
  Cc: Mark Yao, David Airlie, Heiko Stuebner, dri-devel,
	linux-rockchip, Linux Kernel Mailing List, Yakir Yang

On Wed, Aug 17, 2016 at 2:10 PM, Brian Norris <briannorris@chromium.org> wrote:
> This driver is the only user of of_drm_find_panel() which prints an
> error before doing probe deferral, yielding messages like this on boot,
> before eventually succeeding:
>
> [    2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel
> ...
> [    4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel
> ...
>
> Let's just drop the message.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>


Looks good. I'll add this to the rest of the rockchip patches I have
queued for -next.

Reviewed-by: Sean Paul <seanpaul@chromium.org>


> ---
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index 89aadbf465f8..045fcc46827c 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
>
>                 panel = of_drm_find_panel(panel_node);
>                 of_node_put(panel_node);
> -               if (!panel) {
> -                       DRM_ERROR("failed to find panel\n");
> +               if (!panel)
>                         return -EPROBE_DEFER;
> -               }
>         }
>
>         dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
> --
> 2.8.0.rc3.226.g39d4020
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print
@ 2016-08-17 21:21   ` Sean Paul
  0 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2016-08-17 21:21 UTC (permalink / raw)
  To: Brian Norris; +Cc: Linux Kernel Mailing List, dri-devel, linux-rockchip

On Wed, Aug 17, 2016 at 2:10 PM, Brian Norris <briannorris@chromium.org> wrote:
> This driver is the only user of of_drm_find_panel() which prints an
> error before doing probe deferral, yielding messages like this on boot,
> before eventually succeeding:
>
> [    2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel
> ...
> [    4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel
> ...
>
> Let's just drop the message.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>


Looks good. I'll add this to the rest of the rockchip patches I have
queued for -next.

Reviewed-by: Sean Paul <seanpaul@chromium.org>


> ---
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index 89aadbf465f8..045fcc46827c 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
>
>                 panel = of_drm_find_panel(panel_node);
>                 of_node_put(panel_node);
> -               if (!panel) {
> -                       DRM_ERROR("failed to find panel\n");
> +               if (!panel)
>                         return -EPROBE_DEFER;
> -               }
>         }
>
>         dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
> --
> 2.8.0.rc3.226.g39d4020
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-17 21:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-17 21:10 [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print Brian Norris
2016-08-17 21:10 ` Brian Norris
2016-08-17 21:21 ` Sean Paul
2016-08-17 21:21   ` Sean Paul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.