* [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation
@ 2012-07-16 13:31 Keshava Munegowda
2012-07-16 13:31 ` [PATCH V4 1/5] ARM: OMAP: Add the USB TLL clocks device name Keshava Munegowda
` (4 more replies)
0 siblings, 5 replies; 22+ messages in thread
From: Keshava Munegowda @ 2012-07-16 13:31 UTC (permalink / raw)
To: linux-omap, linux-usb; +Cc: Keshava Munegowda, balbi, sameo, parthab
The TLL (Transceiver Less Link) is an separate IP block, independent of
the host controller. Basically this TLL operates like USB PHY which allows
the user to connect two USB transceiver interfaces together directly
without the use of differential transceivers in omap3 and later chips.
The TLL configuration is removed from the UHH driver and implemented as
a seperate platform driver. Now, the UHH driver configures the TLL
through API's exported by the TLL platform driver.
Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
In v4:
- rebased on top of linux kernel version 3.5.rc7
- reworked as per the comments given by Paul Walmsley <paul@pwsan.com>
In v3:
- rebased on top V3 of Russ dill's patch
'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue'
fixes an issue where the ULPI PHYs were not held in reset
while initializing the EHCI controller
http://permalink.gmane.org/gmane.linux.usb.general/65988
- rebased on top of patch
OMAP: USB : Fix the EHCI enumeration and core retention issue
http://permalink.gmane.org/gmane.linux.usb.general/66239
In V2:
- covered review comments from linux omap and usb community
- rebased on top Russ dill's patch
'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue'
fixes an issue where the ULPI PHYs were not held in reset
while initializing the EHCI controller
Keshava Munegowda (5):
ARM: OMAP: Add the USB TLL clocks device name
ARM: OMAP: USB: HOST TLL platform driver
ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver
ARM: OMAP: USB: Remove TLL specific code from USB HS core driver
ARM: OMAP: Remove older device name of the USB TLL clocks
arch/arm/mach-omap2/clock3xxx_data.c | 8 +-
arch/arm/mach-omap2/clock44xx_data.c | 4 +-
arch/arm/mach-omap2/usb-host.c | 31 ++-
arch/arm/plat-omap/include/plat/usb.h | 7 +
drivers/mfd/Kconfig | 2 +-
drivers/mfd/Makefile | 2 +-
drivers/mfd/omap-usb-host.c | 238 ++---------------
drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++
8 files changed, 523 insertions(+), 240 deletions(-)
create mode 100644 drivers/mfd/omap-usb-tll.c
--
1.7.9.5
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH V4 1/5] ARM: OMAP: Add the USB TLL clocks device name 2012-07-16 13:31 [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Keshava Munegowda @ 2012-07-16 13:31 ` Keshava Munegowda [not found] ` <1342445471-18704-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> 2012-07-16 13:31 ` [PATCH V4 2/5] ARM: OMAP: USB: HOST TLL platform driver Keshava Munegowda ` (3 subsequent siblings) 4 siblings, 1 reply; 22+ messages in thread From: Keshava Munegowda @ 2012-07-16 13:31 UTC (permalink / raw) To: linux-omap, linux-usb; +Cc: Keshava Munegowda, balbi, sameo, parthab The platform device name "usbhs_tll" is added for the functional, interface and channel clocks of the TLL module. Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> Reviewed-by: Partha Basak <parthab@india.ti.com> --- arch/arm/mach-omap2/clock3xxx_data.c | 4 ++++ arch/arm/mach-omap2/clock44xx_data.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c index 1efdec2..d51840d 100644 --- a/arch/arm/mach-omap2/clock3xxx_data.c +++ b/arch/arm/mach-omap2/clock3xxx_data.c @@ -3307,6 +3307,7 @@ static struct omap_clk omap3xxx_clks[] = { CLK(NULL, "ts_fck", &ts_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK(NULL, "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("usbhs_omap", "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), + CLK("usbhs_tll", "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("omap-mcbsp.1", "prcm_fck", &core_96m_fck, CK_3XXX), CLK("omap-mcbsp.5", "prcm_fck", &core_96m_fck, CK_3XXX), CLK(NULL, "core_96m_fck", &core_96m_fck, CK_3XXX), @@ -3343,6 +3344,7 @@ static struct omap_clk omap3xxx_clks[] = { CLK(NULL, "core_l4_ick", &core_l4_ick, CK_3XXX), CLK(NULL, "usbtll_ick", &usbtll_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("usbhs_omap", "usbtll_ick", &usbtll_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), + CLK("usbhs_tll", "usbtll_ick", &usbtll_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("omap_hsmmc.2", "ick", &mmchs3_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK(NULL, "icr_ick", &icr_ick, CK_34XX | CK_36XX), CLK("omap-aes", "ick", &aes2_ick, CK_34XX | CK_36XX), @@ -3399,6 +3401,8 @@ static struct omap_clk omap3xxx_clks[] = { CLK("usbhs_omap", "usb_host_hs_utmi_p2_clk", &dummy_ck, CK_3XXX), CLK("usbhs_omap", "usb_tll_hs_usb_ch0_clk", &dummy_ck, CK_3XXX), CLK("usbhs_omap", "usb_tll_hs_usb_ch1_clk", &dummy_ck, CK_3XXX), + CLK("usbhs_tll", "usb_tll_hs_usb_ch0_clk", &dummy_ck, CK_3XXX), + CLK("usbhs_tll", "usb_tll_hs_usb_ch1_clk", &dummy_ck, CK_3XXX), CLK("usbhs_omap", "init_60m_fclk", &dummy_ck, CK_3XXX), CLK(NULL, "usim_fck", &usim_fck, CK_3430ES2PLUS | CK_36XX), CLK(NULL, "gpt1_fck", &gpt1_fck, CK_3XXX), diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index ba6f9a0..6adbccf 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -3334,6 +3334,7 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "usb_tll_hs_usb_ch0_clk", &usb_tll_hs_usb_ch0_clk, CK_443X), CLK(NULL, "usb_tll_hs_usb_ch1_clk", &usb_tll_hs_usb_ch1_clk, CK_443X), CLK("usbhs_omap", "usbtll_ick", &usb_tll_hs_ick, CK_443X), + CLK("usbhs_tll", "usbtll_ick", &usb_tll_hs_ick, CK_443X), CLK(NULL, "usim_ck", &usim_ck, CK_443X), CLK(NULL, "usim_fclk", &usim_fclk, CK_443X), CLK(NULL, "usim_fck", &usim_fck, CK_443X), @@ -3384,6 +3385,7 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "uart4_ick", &dummy_ck, CK_443X), CLK("usbhs_omap", "usbhost_ick", &dummy_ck, CK_443X), CLK("usbhs_omap", "usbtll_fck", &dummy_ck, CK_443X), + CLK("usbhs_tll", "usbtll_fck", &dummy_ck, CK_443X), CLK("omap_wdt", "ick", &dummy_ck, CK_443X), CLK("omap_timer.1", "32k_ck", &sys_32k_ck, CK_443X), CLK("omap_timer.2", "32k_ck", &sys_32k_ck, CK_443X), -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
[parent not found: <1342445471-18704-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH V4 1/5] ARM: OMAP: Add the USB TLL clocks device name [not found] ` <1342445471-18704-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> @ 2012-09-19 20:28 ` Paul Walmsley 0 siblings, 0 replies; 22+ messages in thread From: Paul Walmsley @ 2012-09-19 20:28 UTC (permalink / raw) To: Keshava Munegowda Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0, sameo-VuQAYsv1563Yd54FQh9/CA, parthab-PpE0FKYn9XJWk0Htik3J/w On Mon, 16 Jul 2012, Keshava Munegowda wrote: > The platform device name "usbhs_tll" is added for the functional, > interface and channel clocks of the TLL module. > > Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> > Reviewed-by: Partha Basak <parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org> Thanks, queued this patch for 3.7. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH V4 2/5] ARM: OMAP: USB: HOST TLL platform driver 2012-07-16 13:31 [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Keshava Munegowda 2012-07-16 13:31 ` [PATCH V4 1/5] ARM: OMAP: Add the USB TLL clocks device name Keshava Munegowda @ 2012-07-16 13:31 ` Keshava Munegowda 2012-07-16 13:31 ` [PATCH V4 3/5] ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver Keshava Munegowda ` (2 subsequent siblings) 4 siblings, 0 replies; 22+ messages in thread From: Keshava Munegowda @ 2012-07-16 13:31 UTC (permalink / raw) To: linux-omap, linux-usb; +Cc: Keshava Munegowda, balbi, sameo, parthab The platform driver for the TLL component of the OMAP USB host controller is implemented. Depending on the TLL hardware revision , the TLL channels are configured. The USB HS core driver uses this driver through exported APIs from the TLL platform driver. usb_tll_enable and usb_tll_disble are the exported APIs of the USB TLL platform driver. Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> Reviewed-by: Partha Basak <parthab@india.ti.com> --- arch/arm/plat-omap/include/plat/usb.h | 6 + drivers/mfd/Kconfig | 2 +- drivers/mfd/Makefile | 2 +- drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ 4 files changed, 479 insertions(+), 2 deletions(-) create mode 100644 drivers/mfd/omap-usb-tll.c diff --git a/arch/arm/plat-omap/include/plat/usb.h b/arch/arm/plat-omap/include/plat/usb.h index 762eeb0..b8a9d5e 100644 --- a/arch/arm/plat-omap/include/plat/usb.h +++ b/arch/arm/plat-omap/include/plat/usb.h @@ -62,6 +62,10 @@ struct usbhs_omap_platform_data { struct ehci_hcd_omap_platform_data *ehci_data; struct ohci_hcd_omap_platform_data *ohci_data; }; + +struct usbtll_omap_platform_data { + enum usbhs_omap_port_mode port_mode[OMAP3_HS_USB_PORTS]; +}; /*-------------------------------------------------------------------------*/ #define OMAP1_OTG_BASE 0xfffb0400 @@ -100,6 +104,8 @@ enum musb_interface {MUSB_INTERFACE_ULPI, MUSB_INTERFACE_UTMI}; extern void usb_musb_init(struct omap_musb_board_data *board_data); extern void usbhs_init(const struct usbhs_omap_board_data *pdata); +extern int omap_tll_enable(void); +extern int omap_tll_disable(void); extern int omap4430_phy_power(struct device *dev, int ID, int on); extern int omap4430_phy_set_clk(struct device *dev, int on); diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 92144ed..58e7f11 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -824,7 +824,7 @@ config MFD_WL1273_CORE audio codec. config MFD_OMAP_USB_HOST - bool "Support OMAP USBHS core driver" + bool "Support OMAP USBHS core and TLL driver" depends on USB_EHCI_HCD_OMAP || USB_OHCI_HCD_OMAP3 default y help diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 75f6ed6..6de605d 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -107,7 +107,7 @@ obj-$(CONFIG_MFD_TPS6586X) += tps6586x.o obj-$(CONFIG_MFD_VX855) += vx855.o obj-$(CONFIG_MFD_WL1273_CORE) += wl1273-core.o obj-$(CONFIG_MFD_CS5535) += cs5535-mfd.o -obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o +obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o omap-usb-tll.o obj-$(CONFIG_MFD_PM8921_CORE) += pm8921-core.o obj-$(CONFIG_MFD_PM8XXX_IRQ) += pm8xxx-irq.o obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c new file mode 100644 index 0000000..4b7757b --- /dev/null +++ b/drivers/mfd/omap-usb-tll.c @@ -0,0 +1,471 @@ +/** + * omap-usb-tll.c - The USB TLL driver for OMAP EHCI & OHCI + * + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com + * Author: Keshava Munegowda <keshava_mgowda@ti.com> + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 of + * the License as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */ +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/types.h> +#include <linux/slab.h> +#include <linux/spinlock.h> +#include <linux/platform_device.h> +#include <linux/clk.h> +#include <linux/io.h> +#include <linux/err.h> +#include <plat/usb.h> +#include <linux/pm_runtime.h> + +#define USBTLL_DRIVER_NAME "usbhs_tll" + +/* TLL Register Set */ +#define OMAP_USBTLL_REVISION (0x00) +#define OMAP_USBTLL_SYSCONFIG (0x10) +#define OMAP_USBTLL_SYSCONFIG_CACTIVITY (1 << 8) +#define OMAP_USBTLL_SYSCONFIG_SIDLEMODE (1 << 3) +#define OMAP_USBTLL_SYSCONFIG_ENAWAKEUP (1 << 2) +#define OMAP_USBTLL_SYSCONFIG_SOFTRESET (1 << 1) +#define OMAP_USBTLL_SYSCONFIG_AUTOIDLE (1 << 0) + +#define OMAP_USBTLL_SYSSTATUS (0x14) +#define OMAP_USBTLL_SYSSTATUS_RESETDONE (1 << 0) + +#define OMAP_USBTLL_IRQSTATUS (0x18) +#define OMAP_USBTLL_IRQENABLE (0x1C) + +#define OMAP_TLL_SHARED_CONF (0x30) +#define OMAP_TLL_SHARED_CONF_USB_90D_DDR_EN (1 << 6) +#define OMAP_TLL_SHARED_CONF_USB_180D_SDR_EN (1 << 5) +#define OMAP_TLL_SHARED_CONF_USB_DIVRATION (1 << 2) +#define OMAP_TLL_SHARED_CONF_FCLK_REQ (1 << 1) +#define OMAP_TLL_SHARED_CONF_FCLK_IS_ON (1 << 0) + +#define OMAP_TLL_CHANNEL_CONF(num) (0x040 + 0x004 * num) +#define OMAP_TLL_CHANNEL_CONF_FSLSMODE_SHIFT 24 +#define OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF (1 << 11) +#define OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE (1 << 10) +#define OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE (1 << 9) +#define OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE (1 << 8) +#define OMAP_TLL_CHANNEL_CONF_CHANMODE_FSLS (1 << 1) +#define OMAP_TLL_CHANNEL_CONF_CHANEN (1 << 0) + +#define OMAP_TLL_FSLSMODE_6PIN_PHY_DAT_SE0 0x0 +#define OMAP_TLL_FSLSMODE_6PIN_PHY_DP_DM 0x1 +#define OMAP_TLL_FSLSMODE_3PIN_PHY 0x2 +#define OMAP_TLL_FSLSMODE_4PIN_PHY 0x3 +#define OMAP_TLL_FSLSMODE_6PIN_TLL_DAT_SE0 0x4 +#define OMAP_TLL_FSLSMODE_6PIN_TLL_DP_DM 0x5 +#define OMAP_TLL_FSLSMODE_3PIN_TLL 0x6 +#define OMAP_TLL_FSLSMODE_4PIN_TLL 0x7 +#define OMAP_TLL_FSLSMODE_2PIN_TLL_DAT_SE0 0xA +#define OMAP_TLL_FSLSMODE_2PIN_DAT_DP_DM 0xB + +#define OMAP_TLL_ULPI_FUNCTION_CTRL(num) (0x804 + 0x100 * num) +#define OMAP_TLL_ULPI_INTERFACE_CTRL(num) (0x807 + 0x100 * num) +#define OMAP_TLL_ULPI_OTG_CTRL(num) (0x80A + 0x100 * num) +#define OMAP_TLL_ULPI_INT_EN_RISE(num) (0x80D + 0x100 * num) +#define OMAP_TLL_ULPI_INT_EN_FALL(num) (0x810 + 0x100 * num) +#define OMAP_TLL_ULPI_INT_STATUS(num) (0x813 + 0x100 * num) +#define OMAP_TLL_ULPI_INT_LATCH(num) (0x814 + 0x100 * num) +#define OMAP_TLL_ULPI_DEBUG(num) (0x815 + 0x100 * num) +#define OMAP_TLL_ULPI_SCRATCH_REGISTER(num) (0x816 + 0x100 * num) + +#define OMAP_REV2_TLL_CHANNEL_COUNT 2 +#define OMAP_TLL_CHANNEL_COUNT 3 +#define OMAP_TLL_CHANNEL_1_EN_MASK (1 << 0) +#define OMAP_TLL_CHANNEL_2_EN_MASK (1 << 1) +#define OMAP_TLL_CHANNEL_3_EN_MASK (1 << 2) + +/* Values of USBTLL_REVISION - Note: these are not given in the TRM */ +#define OMAP_USBTLL_REV1 0x00000015 /* OMAP3 */ +#define OMAP_USBTLL_REV2 0x00000018 /* OMAP 3630 */ +#define OMAP_USBTLL_REV3 0x00000004 /* OMAP4 */ + +#define is_ehci_tll_mode(x) (x == OMAP_EHCI_PORT_MODE_TLL) + +struct usbtll_omap { + struct clk *usbtll_p1_fck; + struct clk *usbtll_p2_fck; + struct usbtll_omap_platform_data platdata; + /* secure the register updates */ + spinlock_t lock; +}; + +/*-------------------------------------------------------------------------*/ + +const char usbtll_driver_name[] = USBTLL_DRIVER_NAME; +struct platform_device *tll_pdev; + +/*-------------------------------------------------------------------------*/ + +static inline void usbtll_write(void __iomem *base, u32 reg, u32 val) +{ + __raw_writel(val, base + reg); +} + +static inline u32 usbtll_read(void __iomem *base, u32 reg) +{ + return __raw_readl(base + reg); +} + +static inline void usbtll_writeb(void __iomem *base, u8 reg, u8 val) +{ + __raw_writeb(val, base + reg); +} + +static inline u8 usbtll_readb(void __iomem *base, u8 reg) +{ + return __raw_readb(base + reg); +} + +/*-------------------------------------------------------------------------*/ + +static bool is_ohci_port(enum usbhs_omap_port_mode pmode) +{ + switch (pmode) { + case OMAP_OHCI_PORT_MODE_PHY_6PIN_DATSE0: + case OMAP_OHCI_PORT_MODE_PHY_6PIN_DPDM: + case OMAP_OHCI_PORT_MODE_PHY_3PIN_DATSE0: + case OMAP_OHCI_PORT_MODE_PHY_4PIN_DPDM: + case OMAP_OHCI_PORT_MODE_TLL_6PIN_DATSE0: + case OMAP_OHCI_PORT_MODE_TLL_6PIN_DPDM: + case OMAP_OHCI_PORT_MODE_TLL_3PIN_DATSE0: + case OMAP_OHCI_PORT_MODE_TLL_4PIN_DPDM: + case OMAP_OHCI_PORT_MODE_TLL_2PIN_DATSE0: + case OMAP_OHCI_PORT_MODE_TLL_2PIN_DPDM: + return true; + + default: + return false; + } +} + +/* + * convert the port-mode enum to a value we can use in the FSLSMODE + * field of USBTLL_CHANNEL_CONF + */ +static unsigned ohci_omap3_fslsmode(enum usbhs_omap_port_mode mode) +{ + switch (mode) { + case OMAP_USBHS_PORT_MODE_UNUSED: + case OMAP_OHCI_PORT_MODE_PHY_6PIN_DATSE0: + return OMAP_TLL_FSLSMODE_6PIN_PHY_DAT_SE0; + + case OMAP_OHCI_PORT_MODE_PHY_6PIN_DPDM: + return OMAP_TLL_FSLSMODE_6PIN_PHY_DP_DM; + + case OMAP_OHCI_PORT_MODE_PHY_3PIN_DATSE0: + return OMAP_TLL_FSLSMODE_3PIN_PHY; + + case OMAP_OHCI_PORT_MODE_PHY_4PIN_DPDM: + return OMAP_TLL_FSLSMODE_4PIN_PHY; + + case OMAP_OHCI_PORT_MODE_TLL_6PIN_DATSE0: + return OMAP_TLL_FSLSMODE_6PIN_TLL_DAT_SE0; + + case OMAP_OHCI_PORT_MODE_TLL_6PIN_DPDM: + return OMAP_TLL_FSLSMODE_6PIN_TLL_DP_DM; + + case OMAP_OHCI_PORT_MODE_TLL_3PIN_DATSE0: + return OMAP_TLL_FSLSMODE_3PIN_TLL; + + case OMAP_OHCI_PORT_MODE_TLL_4PIN_DPDM: + return OMAP_TLL_FSLSMODE_4PIN_TLL; + + case OMAP_OHCI_PORT_MODE_TLL_2PIN_DATSE0: + return OMAP_TLL_FSLSMODE_2PIN_TLL_DAT_SE0; + + case OMAP_OHCI_PORT_MODE_TLL_2PIN_DPDM: + return OMAP_TLL_FSLSMODE_2PIN_DAT_DP_DM; + default: + pr_warn("Invalid port mode, using default\n"); + return OMAP_TLL_FSLSMODE_6PIN_PHY_DAT_SE0; + } +} + +/** + * usbtll_omap_probe - initialize TI-based HCDs + * + * Allocates basic resources for this USB host controller. + */ +static int __devinit usbtll_omap_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct usbtll_omap_platform_data *pdata = dev->platform_data; + void __iomem *base; + struct resource *res; + struct usbtll_omap *tll; + unsigned reg; + unsigned long flags; + int ret = 0; + int i, ver, count; + + dev_dbg(dev, "starting TI HSUSB TLL Controller\n"); + + tll = kzalloc(sizeof(struct usbtll_omap), GFP_KERNEL); + if (!tll) { + dev_err(dev, "Memory allocation failed\n"); + ret = -ENOMEM; + goto end; + } + + spin_lock_init(&tll->lock); + + for (i = 0; i < OMAP3_HS_USB_PORTS; i++) + tll->platdata.port_mode[i] = pdata->port_mode[i]; + + tll->usbtll_p1_fck = clk_get(dev, "usb_tll_hs_usb_ch0_clk"); + if (IS_ERR(tll->usbtll_p1_fck)) { + ret = PTR_ERR(tll->usbtll_p1_fck); + dev_err(dev, "usbtll_p1_fck failed error:%d\n", ret); + goto err_tll; + } + + tll->usbtll_p2_fck = clk_get(dev, "usb_tll_hs_usb_ch1_clk"); + if (IS_ERR(tll->usbtll_p2_fck)) { + ret = PTR_ERR(tll->usbtll_p2_fck); + dev_err(dev, "usbtll_p2_fck failed error:%d\n", ret); + goto err_usbtll_p1_fck; + } + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(dev, "usb tll get resource failed\n"); + ret = -ENODEV; + goto err_usbtll_p2_fck; + } + + base = ioremap(res->start, resource_size(res)); + if (!base) { + dev_err(dev, "TLL ioremap failed\n"); + ret = -ENOMEM; + goto err_usbtll_p2_fck; + } + + platform_set_drvdata(pdev, tll); + pm_runtime_enable(dev); + pm_runtime_get_sync(dev); + + spin_lock_irqsave(&tll->lock, flags); + + ver = usbtll_read(base, OMAP_USBTLL_REVISION); + switch (ver) { + case OMAP_USBTLL_REV1: + case OMAP_USBTLL_REV2: + count = OMAP_TLL_CHANNEL_COUNT; + break; + case OMAP_USBTLL_REV3: + count = OMAP_REV2_TLL_CHANNEL_COUNT; + break; + default: + dev_err(dev, "TLL version failed\n"); + ret = -ENODEV; + goto err_ioremap; + } + + if (is_ehci_tll_mode(pdata->port_mode[0]) || + is_ehci_tll_mode(pdata->port_mode[1]) || + is_ehci_tll_mode(pdata->port_mode[2]) || + is_ohci_port(pdata->port_mode[0]) || + is_ohci_port(pdata->port_mode[1]) || + is_ohci_port(pdata->port_mode[2])) { + + /* Program Common TLL register */ + reg = usbtll_read(base, OMAP_TLL_SHARED_CONF); + reg |= (OMAP_TLL_SHARED_CONF_FCLK_IS_ON + | OMAP_TLL_SHARED_CONF_USB_DIVRATION); + reg &= ~OMAP_TLL_SHARED_CONF_USB_90D_DDR_EN; + reg &= ~OMAP_TLL_SHARED_CONF_USB_180D_SDR_EN; + + usbtll_write(base, OMAP_TLL_SHARED_CONF, reg); + + /* Enable channels now */ + for (i = 0; i < count; i++) { + reg = usbtll_read(base, OMAP_TLL_CHANNEL_CONF(i)); + + if (is_ohci_port(pdata->port_mode[i])) { + reg |= ohci_omap3_fslsmode(pdata->port_mode[i]) + << OMAP_TLL_CHANNEL_CONF_FSLSMODE_SHIFT; + reg |= OMAP_TLL_CHANNEL_CONF_CHANMODE_FSLS; + } else if (pdata->port_mode[i] == + OMAP_EHCI_PORT_MODE_TLL) { + /* + * Disable AutoIdle, BitStuffing + * and use SDR Mode + */ + reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE + | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF + | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); + } else { + continue; + } + reg |= OMAP_TLL_CHANNEL_CONF_CHANEN; + usbtll_write(base, OMAP_TLL_CHANNEL_CONF(i), reg); + + usbtll_writeb(base, + OMAP_TLL_ULPI_SCRATCH_REGISTER(i), + 0xbe); + } + } + +err_ioremap: + spin_unlock_irqrestore(&tll->lock, flags); + iounmap(base); + pm_runtime_put_sync(dev); + tll_pdev = pdev; + if (!ret) + goto end; + pm_runtime_disable(dev); + +err_usbtll_p2_fck: + clk_put(tll->usbtll_p2_fck); + +err_usbtll_p1_fck: + clk_put(tll->usbtll_p1_fck); + +err_tll: + kfree(tll); + +end: + return ret; +} + +/** + * usbtll_omap_remove - shutdown processing for UHH & TLL HCDs + * @pdev: USB Host Controller being removed + * + * Reverses the effect of usbtll_omap_probe(). + */ +static int __devexit usbtll_omap_remove(struct platform_device *pdev) +{ + struct usbtll_omap *tll = platform_get_drvdata(pdev); + + clk_put(tll->usbtll_p2_fck); + clk_put(tll->usbtll_p1_fck); + pm_runtime_disable(&pdev->dev); + kfree(tll); + return 0; +} + +static int usbtll_runtime_resume(struct device *dev) +{ + struct usbtll_omap *tll = dev_get_drvdata(dev); + struct usbtll_omap_platform_data *pdata = &tll->platdata; + unsigned long flags; + + dev_dbg(dev, "usbtll_runtime_resume\n"); + + if (!pdata) { + dev_dbg(dev, "missing platform_data\n"); + return -ENODEV; + } + + spin_lock_irqsave(&tll->lock, flags); + + if (is_ehci_tll_mode(pdata->port_mode[0])) + clk_enable(tll->usbtll_p1_fck); + + if (is_ehci_tll_mode(pdata->port_mode[1])) + clk_enable(tll->usbtll_p2_fck); + + spin_unlock_irqrestore(&tll->lock, flags); + + return 0; +} + +static int usbtll_runtime_suspend(struct device *dev) +{ + struct usbtll_omap *tll = dev_get_drvdata(dev); + struct usbtll_omap_platform_data *pdata = &tll->platdata; + unsigned long flags; + + dev_dbg(dev, "usbtll_runtime_suspend\n"); + + if (!pdata) { + dev_dbg(dev, "missing platform_data\n"); + return -ENODEV; + } + + spin_lock_irqsave(&tll->lock, flags); + + if (is_ehci_tll_mode(pdata->port_mode[0])) + clk_disable(tll->usbtll_p1_fck); + + if (is_ehci_tll_mode(pdata->port_mode[1])) + clk_disable(tll->usbtll_p2_fck); + + spin_unlock_irqrestore(&tll->lock, flags); + + return 0; +} + +static const struct dev_pm_ops usbtllomap_dev_pm_ops = { + SET_RUNTIME_PM_OPS(usbtll_runtime_suspend, + usbtll_runtime_resume, + NULL) +}; + +static struct platform_driver usbtll_omap_driver = { + .driver = { + .name = (char *)usbtll_driver_name, + .owner = THIS_MODULE, + .pm = &usbtllomap_dev_pm_ops, + }, + .probe = usbtll_omap_probe, + .remove = __devexit_p(usbtll_omap_remove), +}; + +int omap_tll_enable(void) +{ + if (!tll_pdev) { + pr_err("missing omap usbhs tll platform_data\n"); + return -ENODEV; + } + return pm_runtime_get_sync(&tll_pdev->dev); +} +EXPORT_SYMBOL_GPL(omap_tll_enable); + +int omap_tll_disable(void) +{ + if (!tll_pdev) { + pr_err("missing omap usbhs tll platform_data\n"); + return -ENODEV; + } + return pm_runtime_put_sync(&tll_pdev->dev); +} +EXPORT_SYMBOL_GPL(omap_tll_disable); + +MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>"); +MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers"); + +static int __init omap_usbtll_drvinit(void) +{ + return platform_driver_register(&usbtll_omap_driver); +} + +/* + * init before usbhs core driver; + * The usbtll driver should be initialized before + * the usbhs core driver probe function is called. + */ +fs_initcall(omap_usbtll_drvinit); + +static void __exit omap_usbtll_drvexit(void) +{ + platform_driver_unregister(&usbtll_omap_driver); +} +module_exit(omap_usbtll_drvexit); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH V4 3/5] ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver 2012-07-16 13:31 [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Keshava Munegowda 2012-07-16 13:31 ` [PATCH V4 1/5] ARM: OMAP: Add the USB TLL clocks device name Keshava Munegowda 2012-07-16 13:31 ` [PATCH V4 2/5] ARM: OMAP: USB: HOST TLL platform driver Keshava Munegowda @ 2012-07-16 13:31 ` Keshava Munegowda [not found] ` <1342445471-18704-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> 2012-07-19 10:18 ` Munegowda, Keshava 4 siblings, 0 replies; 22+ messages in thread From: Keshava Munegowda @ 2012-07-16 13:31 UTC (permalink / raw) To: linux-omap, linux-usb; +Cc: Keshava Munegowda, balbi, sameo, parthab The usbhs driver invokes the enable/disable APIs of the usb tll driver in the runtime resume/suspend callbacks of the runtime get sync and put sync of the usbhs driver. Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> Reviewed-by: Partha Basak <parthab@india.ti.com> --- arch/arm/plat-omap/include/plat/usb.h | 1 + drivers/mfd/omap-usb-host.c | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/usb.h b/arch/arm/plat-omap/include/plat/usb.h index b8a9d5e..8eac78c 100644 --- a/arch/arm/plat-omap/include/plat/usb.h +++ b/arch/arm/plat-omap/include/plat/usb.h @@ -4,6 +4,7 @@ #define __ASM_ARCH_OMAP_USB_H #include <linux/io.h> +#include <linux/platform_device.h> #include <linux/usb/musb.h> #include <plat/board.h> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 41088ec..8a256df 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -21,7 +21,6 @@ #include <linux/types.h> #include <linux/slab.h> #include <linux/delay.h> -#include <linux/platform_device.h> #include <linux/clk.h> #include <linux/dma-mapping.h> #include <linux/spinlock.h> @@ -436,6 +435,7 @@ static int usbhs_runtime_resume(struct device *dev) return -ENODEV; } + omap_tll_enable(); spin_lock_irqsave(&omap->lock, flags); if (omap->ehci_logic_fck && !IS_ERR(omap->ehci_logic_fck)) @@ -487,6 +487,7 @@ static int usbhs_runtime_suspend(struct device *dev) clk_disable(omap->ehci_logic_fck); spin_unlock_irqrestore(&omap->lock, flags); + omap_tll_disable(); return 0; } @@ -910,8 +911,10 @@ static int __init omap_usbhs_drvinit(void) * init before ehci and ohci drivers; * The usbhs core driver should be initialized much before * the omap ehci and ohci probe functions are called. + * This usbhs core driver should be initialized after + * usb tll driver */ -fs_initcall(omap_usbhs_drvinit); +fs_initcall_sync(omap_usbhs_drvinit); static void __exit omap_usbhs_drvexit(void) { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 22+ messages in thread
[parent not found: <1342445471-18704-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>]
* [PATCH V4 4/5] ARM: OMAP: USB: Remove TLL specific code from USB HS core driver [not found] ` <1342445471-18704-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> @ 2012-07-16 13:31 ` Keshava Munegowda 2012-07-16 13:31 ` [PATCH V4 5/5] ARM: OMAP: Remove older device name of the USB TLL clocks Keshava Munegowda 2012-09-19 11:27 ` [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Samuel Ortiz 2 siblings, 0 replies; 22+ messages in thread From: Keshava Munegowda @ 2012-07-16 13:31 UTC (permalink / raw) To: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA Cc: Keshava Munegowda, balbi-l0cyMroinI0, sameo-VuQAYsv1563Yd54FQh9/CA, parthab-PpE0FKYn9XJWk0Htik3J/w The TLL specific code such as channels clocks enable/disable, initialization functions are removed from the USBHS core driver. The hwmod of the usb tll is retrieved and omap device build is performed to created the platform device for the usb tll component. Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> Reviewed-by: Partha Basak <parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org> --- arch/arm/mach-omap2/usb-host.c | 31 ++++-- drivers/mfd/omap-usb-host.c | 231 ++-------------------------------------- 2 files changed, 32 insertions(+), 230 deletions(-) diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c index dde8a11..b2a2dd7 100644 --- a/arch/arm/mach-omap2/usb-host.c +++ b/arch/arm/mach-omap2/usb-host.c @@ -35,10 +35,12 @@ #ifdef CONFIG_MFD_OMAP_USB_HOST #define OMAP_USBHS_DEVICE "usbhs_omap" +#define OMAP_USBTLL_DEVICE "usbhs_tll" #define USBHS_UHH_HWMODNAME "usb_host_hs" #define USBHS_TLL_HWMODNAME "usb_tll_hs" static struct usbhs_omap_platform_data usbhs_data; +static struct usbtll_omap_platform_data usbtll_data; static struct ehci_hcd_omap_platform_data ehci_data; static struct ohci_hcd_omap_platform_data ohci_data; @@ -487,13 +489,14 @@ void __init setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode) void __init usbhs_init(const struct usbhs_omap_board_data *pdata) { - struct omap_hwmod *oh[2]; + struct omap_hwmod *uhh_hwm, *tll_hwm; struct platform_device *pdev; int bus_id = -1; int i; for (i = 0; i < OMAP3_HS_USB_PORTS; i++) { usbhs_data.port_mode[i] = pdata->port_mode[i]; + usbtll_data.port_mode[i] = pdata->port_mode[i]; ohci_data.port_mode[i] = pdata->port_mode[i]; ehci_data.port_mode[i] = pdata->port_mode[i]; ehci_data.reset_gpio_port[i] = pdata->reset_gpio_port[i]; @@ -512,25 +515,35 @@ void __init usbhs_init(const struct usbhs_omap_board_data *pdata) setup_4430ohci_io_mux(pdata->port_mode); } - oh[0] = omap_hwmod_lookup(USBHS_UHH_HWMODNAME); - if (!oh[0]) { + uhh_hwm = omap_hwmod_lookup(USBHS_UHH_HWMODNAME); + if (!uhh_hwm) { pr_err("Could not look up %s\n", USBHS_UHH_HWMODNAME); return; } - oh[1] = omap_hwmod_lookup(USBHS_TLL_HWMODNAME); - if (!oh[1]) { + tll_hwm = omap_hwmod_lookup(USBHS_TLL_HWMODNAME); + if (!tll_hwm) { pr_err("Could not look up %s\n", USBHS_TLL_HWMODNAME); return; } - pdev = omap_device_build_ss(OMAP_USBHS_DEVICE, bus_id, oh, 2, - (void *)&usbhs_data, sizeof(usbhs_data), + pdev = omap_device_build(OMAP_USBTLL_DEVICE, bus_id, tll_hwm, + &usbtll_data, sizeof(usbtll_data), omap_uhhtll_latency, ARRAY_SIZE(omap_uhhtll_latency), false); if (IS_ERR(pdev)) { - pr_err("Could not build hwmod devices %s,%s\n", - USBHS_UHH_HWMODNAME, USBHS_TLL_HWMODNAME); + pr_err("Could not build hwmod device %s\n", + USBHS_TLL_HWMODNAME); + return; + } + + pdev = omap_device_build(OMAP_USBHS_DEVICE, bus_id, uhh_hwm, + &usbhs_data, sizeof(usbhs_data), + omap_uhhtll_latency, + ARRAY_SIZE(omap_uhhtll_latency), false); + if (IS_ERR(pdev)) { + pr_err("Could not build hwmod devices %s\n", + USBHS_UHH_HWMODNAME); return; } } diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 8a256df..23cec57 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -35,63 +35,6 @@ /* OMAP USBHOST Register addresses */ -/* TLL Register Set */ -#define OMAP_USBTLL_REVISION (0x00) -#define OMAP_USBTLL_SYSCONFIG (0x10) -#define OMAP_USBTLL_SYSCONFIG_CACTIVITY (1 << 8) -#define OMAP_USBTLL_SYSCONFIG_SIDLEMODE (1 << 3) -#define OMAP_USBTLL_SYSCONFIG_ENAWAKEUP (1 << 2) -#define OMAP_USBTLL_SYSCONFIG_SOFTRESET (1 << 1) -#define OMAP_USBTLL_SYSCONFIG_AUTOIDLE (1 << 0) - -#define OMAP_USBTLL_SYSSTATUS (0x14) -#define OMAP_USBTLL_SYSSTATUS_RESETDONE (1 << 0) - -#define OMAP_USBTLL_IRQSTATUS (0x18) -#define OMAP_USBTLL_IRQENABLE (0x1C) - -#define OMAP_TLL_SHARED_CONF (0x30) -#define OMAP_TLL_SHARED_CONF_USB_90D_DDR_EN (1 << 6) -#define OMAP_TLL_SHARED_CONF_USB_180D_SDR_EN (1 << 5) -#define OMAP_TLL_SHARED_CONF_USB_DIVRATION (1 << 2) -#define OMAP_TLL_SHARED_CONF_FCLK_REQ (1 << 1) -#define OMAP_TLL_SHARED_CONF_FCLK_IS_ON (1 << 0) - -#define OMAP_TLL_CHANNEL_CONF(num) (0x040 + 0x004 * num) -#define OMAP_TLL_CHANNEL_CONF_FSLSMODE_SHIFT 24 -#define OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF (1 << 11) -#define OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE (1 << 10) -#define OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE (1 << 9) -#define OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE (1 << 8) -#define OMAP_TLL_CHANNEL_CONF_CHANMODE_FSLS (1 << 1) -#define OMAP_TLL_CHANNEL_CONF_CHANEN (1 << 0) - -#define OMAP_TLL_FSLSMODE_6PIN_PHY_DAT_SE0 0x0 -#define OMAP_TLL_FSLSMODE_6PIN_PHY_DP_DM 0x1 -#define OMAP_TLL_FSLSMODE_3PIN_PHY 0x2 -#define OMAP_TLL_FSLSMODE_4PIN_PHY 0x3 -#define OMAP_TLL_FSLSMODE_6PIN_TLL_DAT_SE0 0x4 -#define OMAP_TLL_FSLSMODE_6PIN_TLL_DP_DM 0x5 -#define OMAP_TLL_FSLSMODE_3PIN_TLL 0x6 -#define OMAP_TLL_FSLSMODE_4PIN_TLL 0x7 -#define OMAP_TLL_FSLSMODE_2PIN_TLL_DAT_SE0 0xA -#define OMAP_TLL_FSLSMODE_2PIN_DAT_DP_DM 0xB - -#define OMAP_TLL_ULPI_FUNCTION_CTRL(num) (0x804 + 0x100 * num) -#define OMAP_TLL_ULPI_INTERFACE_CTRL(num) (0x807 + 0x100 * num) -#define OMAP_TLL_ULPI_OTG_CTRL(num) (0x80A + 0x100 * num) -#define OMAP_TLL_ULPI_INT_EN_RISE(num) (0x80D + 0x100 * num) -#define OMAP_TLL_ULPI_INT_EN_FALL(num) (0x810 + 0x100 * num) -#define OMAP_TLL_ULPI_INT_STATUS(num) (0x813 + 0x100 * num) -#define OMAP_TLL_ULPI_INT_LATCH(num) (0x814 + 0x100 * num) -#define OMAP_TLL_ULPI_DEBUG(num) (0x815 + 0x100 * num) -#define OMAP_TLL_ULPI_SCRATCH_REGISTER(num) (0x816 + 0x100 * num) - -#define OMAP_TLL_CHANNEL_COUNT 3 -#define OMAP_TLL_CHANNEL_1_EN_MASK (1 << 0) -#define OMAP_TLL_CHANNEL_2_EN_MASK (1 << 1) -#define OMAP_TLL_CHANNEL_3_EN_MASK (1 << 2) - /* UHH Register Set */ #define OMAP_UHH_REVISION (0x00) #define OMAP_UHH_SYSCONFIG (0x10) @@ -131,8 +74,6 @@ #define OMAP4_P2_MODE_TLL (1 << 18) #define OMAP4_P2_MODE_HSIC (3 << 18) -#define OMAP_REV2_TLL_CHANNEL_COUNT 2 - #define OMAP_UHH_DEBUG_CSR (0x44) /* Values of UHH_REVISION - Note: these are not given in the TRM */ @@ -152,15 +93,12 @@ struct usbhs_hcd_omap { struct clk *xclk60mhsp2_ck; struct clk *utmi_p1_fck; struct clk *usbhost_p1_fck; - struct clk *usbtll_p1_fck; struct clk *utmi_p2_fck; struct clk *usbhost_p2_fck; - struct clk *usbtll_p2_fck; struct clk *init_60m_fclk; struct clk *ehci_logic_fck; void __iomem *uhh_base; - void __iomem *tll_base; struct usbhs_omap_platform_data platdata; @@ -335,93 +273,6 @@ static bool is_ohci_port(enum usbhs_omap_port_mode pmode) } } -/* - * convert the port-mode enum to a value we can use in the FSLSMODE - * field of USBTLL_CHANNEL_CONF - */ -static unsigned ohci_omap3_fslsmode(enum usbhs_omap_port_mode mode) -{ - switch (mode) { - case OMAP_USBHS_PORT_MODE_UNUSED: - case OMAP_OHCI_PORT_MODE_PHY_6PIN_DATSE0: - return OMAP_TLL_FSLSMODE_6PIN_PHY_DAT_SE0; - - case OMAP_OHCI_PORT_MODE_PHY_6PIN_DPDM: - return OMAP_TLL_FSLSMODE_6PIN_PHY_DP_DM; - - case OMAP_OHCI_PORT_MODE_PHY_3PIN_DATSE0: - return OMAP_TLL_FSLSMODE_3PIN_PHY; - - case OMAP_OHCI_PORT_MODE_PHY_4PIN_DPDM: - return OMAP_TLL_FSLSMODE_4PIN_PHY; - - case OMAP_OHCI_PORT_MODE_TLL_6PIN_DATSE0: - return OMAP_TLL_FSLSMODE_6PIN_TLL_DAT_SE0; - - case OMAP_OHCI_PORT_MODE_TLL_6PIN_DPDM: - return OMAP_TLL_FSLSMODE_6PIN_TLL_DP_DM; - - case OMAP_OHCI_PORT_MODE_TLL_3PIN_DATSE0: - return OMAP_TLL_FSLSMODE_3PIN_TLL; - - case OMAP_OHCI_PORT_MODE_TLL_4PIN_DPDM: - return OMAP_TLL_FSLSMODE_4PIN_TLL; - - case OMAP_OHCI_PORT_MODE_TLL_2PIN_DATSE0: - return OMAP_TLL_FSLSMODE_2PIN_TLL_DAT_SE0; - - case OMAP_OHCI_PORT_MODE_TLL_2PIN_DPDM: - return OMAP_TLL_FSLSMODE_2PIN_DAT_DP_DM; - default: - pr_warning("Invalid port mode, using default\n"); - return OMAP_TLL_FSLSMODE_6PIN_PHY_DAT_SE0; - } -} - -static void usbhs_omap_tll_init(struct device *dev, u8 tll_channel_count) -{ - struct usbhs_hcd_omap *omap = dev_get_drvdata(dev); - struct usbhs_omap_platform_data *pdata = dev->platform_data; - unsigned reg; - int i; - - /* Program Common TLL register */ - reg = usbhs_read(omap->tll_base, OMAP_TLL_SHARED_CONF); - reg |= (OMAP_TLL_SHARED_CONF_FCLK_IS_ON - | OMAP_TLL_SHARED_CONF_USB_DIVRATION); - reg &= ~OMAP_TLL_SHARED_CONF_USB_90D_DDR_EN; - reg &= ~OMAP_TLL_SHARED_CONF_USB_180D_SDR_EN; - - usbhs_write(omap->tll_base, OMAP_TLL_SHARED_CONF, reg); - - /* Enable channels now */ - for (i = 0; i < tll_channel_count; i++) { - reg = usbhs_read(omap->tll_base, - OMAP_TLL_CHANNEL_CONF(i)); - - if (is_ohci_port(pdata->port_mode[i])) { - reg |= ohci_omap3_fslsmode(pdata->port_mode[i]) - << OMAP_TLL_CHANNEL_CONF_FSLSMODE_SHIFT; - reg |= OMAP_TLL_CHANNEL_CONF_CHANMODE_FSLS; - } else if (pdata->port_mode[i] == OMAP_EHCI_PORT_MODE_TLL) { - - /* Disable AutoIdle, BitStuffing and use SDR Mode */ - reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE - | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF - | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); - - } else - continue; - - reg |= OMAP_TLL_CHANNEL_CONF_CHANEN; - usbhs_write(omap->tll_base, - OMAP_TLL_CHANNEL_CONF(i), reg); - - usbhs_writeb(omap->tll_base, - OMAP_TLL_ULPI_SCRATCH_REGISTER(i), 0xbe); - } -} - static int usbhs_runtime_resume(struct device *dev) { struct usbhs_hcd_omap *omap = dev_get_drvdata(dev); @@ -441,14 +292,11 @@ static int usbhs_runtime_resume(struct device *dev) if (omap->ehci_logic_fck && !IS_ERR(omap->ehci_logic_fck)) clk_enable(omap->ehci_logic_fck); - if (is_ehci_tll_mode(pdata->port_mode[0])) { + if (is_ehci_tll_mode(pdata->port_mode[0])) clk_enable(omap->usbhost_p1_fck); - clk_enable(omap->usbtll_p1_fck); - } - if (is_ehci_tll_mode(pdata->port_mode[1])) { + if (is_ehci_tll_mode(pdata->port_mode[1])) clk_enable(omap->usbhost_p2_fck); - clk_enable(omap->usbtll_p2_fck); - } + clk_enable(omap->utmi_p1_fck); clk_enable(omap->utmi_p2_fck); @@ -472,14 +320,11 @@ static int usbhs_runtime_suspend(struct device *dev) spin_lock_irqsave(&omap->lock, flags); - if (is_ehci_tll_mode(pdata->port_mode[0])) { + if (is_ehci_tll_mode(pdata->port_mode[0])) clk_disable(omap->usbhost_p1_fck); - clk_disable(omap->usbtll_p1_fck); - } - if (is_ehci_tll_mode(pdata->port_mode[1])) { + if (is_ehci_tll_mode(pdata->port_mode[1])) clk_disable(omap->usbhost_p2_fck); - clk_disable(omap->usbtll_p2_fck); - } + clk_disable(omap->utmi_p2_fck); clk_disable(omap->utmi_p1_fck); @@ -501,8 +346,6 @@ static void omap_usbhs_init(struct device *dev) dev_dbg(dev, "starting TI HSUSB Controller\n"); - pm_runtime_get_sync(dev); - if (pdata->ehci_data->phy_reset) { if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0])) gpio_request_one(pdata->ehci_data->reset_gpio_port[0], @@ -516,6 +359,7 @@ static void omap_usbhs_init(struct device *dev) udelay(10); } + pm_runtime_get_sync(dev); spin_lock_irqsave(&omap->lock, flags); omap->usbhs_rev = usbhs_read(omap->uhh_base, OMAP_UHH_REVISION); dev_dbg(dev, "OMAP UHH_REVISION 0x%x\n", omap->usbhs_rev); @@ -581,22 +425,9 @@ static void omap_usbhs_init(struct device *dev) usbhs_write(omap->uhh_base, OMAP_UHH_HOSTCONFIG, reg); dev_dbg(dev, "UHH setup done, uhh_hostconfig=%x\n", reg); - if (is_ehci_tll_mode(pdata->port_mode[0]) || - is_ehci_tll_mode(pdata->port_mode[1]) || - is_ehci_tll_mode(pdata->port_mode[2]) || - (is_ohci_port(pdata->port_mode[0])) || - (is_ohci_port(pdata->port_mode[1])) || - (is_ohci_port(pdata->port_mode[2]))) { - - /* Enable UTMI mode for required TLL channels */ - if (is_omap_usbhs_rev2(omap)) - usbhs_omap_tll_init(dev, OMAP_REV2_TLL_CHANNEL_COUNT); - else - usbhs_omap_tll_init(dev, OMAP_TLL_CHANNEL_COUNT); - } - spin_unlock_irqrestore(&omap->lock, flags); + pm_runtime_put_sync(dev); if (pdata->ehci_data->phy_reset) { /* Hold the PHY in RESET for enough time till * PHY is settled and ready @@ -611,8 +442,6 @@ static void omap_usbhs_init(struct device *dev) gpio_set_value_cansleep (pdata->ehci_data->reset_gpio_port[1], 1); } - - pm_runtime_put_sync(dev); } static void omap_usbhs_deinit(struct device *dev) @@ -715,32 +544,18 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev) goto err_xclk60mhsp2_ck; } - omap->usbtll_p1_fck = clk_get(dev, "usb_tll_hs_usb_ch0_clk"); - if (IS_ERR(omap->usbtll_p1_fck)) { - ret = PTR_ERR(omap->usbtll_p1_fck); - dev_err(dev, "usbtll_p1_fck failed error:%d\n", ret); - goto err_usbhost_p1_fck; - } - omap->usbhost_p2_fck = clk_get(dev, "usb_host_hs_utmi_p2_clk"); if (IS_ERR(omap->usbhost_p2_fck)) { ret = PTR_ERR(omap->usbhost_p2_fck); dev_err(dev, "usbhost_p2_fck failed error:%d\n", ret); - goto err_usbtll_p1_fck; - } - - omap->usbtll_p2_fck = clk_get(dev, "usb_tll_hs_usb_ch1_clk"); - if (IS_ERR(omap->usbtll_p2_fck)) { - ret = PTR_ERR(omap->usbtll_p2_fck); - dev_err(dev, "usbtll_p2_fck failed error:%d\n", ret); - goto err_usbhost_p2_fck; + goto err_usbhost_p1_fck; } omap->init_60m_fclk = clk_get(dev, "init_60m_fclk"); if (IS_ERR(omap->init_60m_fclk)) { ret = PTR_ERR(omap->init_60m_fclk); dev_err(dev, "init_60m_fclk failed error:%d\n", ret); - goto err_usbtll_p2_fck; + goto err_usbhost_p2_fck; } if (is_ehci_phy_mode(pdata->port_mode[0])) { @@ -786,20 +601,6 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev) goto err_init_60m_fclk; } - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "tll"); - if (!res) { - dev_err(dev, "UHH EHCI get resource failed\n"); - ret = -ENODEV; - goto err_tll; - } - - omap->tll_base = ioremap(res->start, resource_size(res)); - if (!omap->tll_base) { - dev_err(dev, "TLL ioremap failed\n"); - ret = -ENOMEM; - goto err_tll; - } - platform_set_drvdata(pdev, omap); omap_usbhs_init(dev); @@ -813,23 +614,14 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev) err_alloc: omap_usbhs_deinit(&pdev->dev); - iounmap(omap->tll_base); - -err_tll: iounmap(omap->uhh_base); err_init_60m_fclk: clk_put(omap->init_60m_fclk); -err_usbtll_p2_fck: - clk_put(omap->usbtll_p2_fck); - err_usbhost_p2_fck: clk_put(omap->usbhost_p2_fck); -err_usbtll_p1_fck: - clk_put(omap->usbtll_p1_fck); ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH V4 5/5] ARM: OMAP: Remove older device name of the USB TLL clocks [not found] ` <1342445471-18704-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> 2012-07-16 13:31 ` [PATCH V4 4/5] ARM: OMAP: USB: Remove TLL specific code " Keshava Munegowda @ 2012-07-16 13:31 ` Keshava Munegowda [not found] ` <1342445471-18704-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> 2012-09-19 11:27 ` [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Samuel Ortiz 2 siblings, 1 reply; 22+ messages in thread From: Keshava Munegowda @ 2012-07-16 13:31 UTC (permalink / raw) To: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA Cc: Keshava Munegowda, balbi-l0cyMroinI0, sameo-VuQAYsv1563Yd54FQh9/CA, parthab-PpE0FKYn9XJWk0Htik3J/w The usbhs device name of the functional, interface and channel clocks of the TLL module is removed. Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> Reviewed-by: Partha Basak <parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org> --- arch/arm/mach-omap2/clock3xxx_data.c | 4 ---- arch/arm/mach-omap2/clock44xx_data.c | 2 -- 2 files changed, 6 deletions(-) diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c index d51840d..a5b6f88 100644 --- a/arch/arm/mach-omap2/clock3xxx_data.c +++ b/arch/arm/mach-omap2/clock3xxx_data.c @@ -3306,7 +3306,6 @@ static struct omap_clk omap3xxx_clks[] = { CLK(NULL, "cpefuse_fck", &cpefuse_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK(NULL, "ts_fck", &ts_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK(NULL, "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), - CLK("usbhs_omap", "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("usbhs_tll", "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("omap-mcbsp.1", "prcm_fck", &core_96m_fck, CK_3XXX), CLK("omap-mcbsp.5", "prcm_fck", &core_96m_fck, CK_3XXX), @@ -3343,7 +3342,6 @@ static struct omap_clk omap3xxx_clks[] = { CLK(NULL, "pka_ick", &pka_ick, CK_34XX | CK_36XX), CLK(NULL, "core_l4_ick", &core_l4_ick, CK_3XXX), CLK(NULL, "usbtll_ick", &usbtll_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), - CLK("usbhs_omap", "usbtll_ick", &usbtll_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("usbhs_tll", "usbtll_ick", &usbtll_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK("omap_hsmmc.2", "ick", &mmchs3_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK(NULL, "icr_ick", &icr_ick, CK_34XX | CK_36XX), @@ -3399,8 +3397,6 @@ static struct omap_clk omap3xxx_clks[] = { CLK("usbhs_omap", "xclk60mhsp2_ck", &dummy_ck, CK_3XXX), CLK("usbhs_omap", "usb_host_hs_utmi_p1_clk", &dummy_ck, CK_3XXX), CLK("usbhs_omap", "usb_host_hs_utmi_p2_clk", &dummy_ck, CK_3XXX), - CLK("usbhs_omap", "usb_tll_hs_usb_ch0_clk", &dummy_ck, CK_3XXX), - CLK("usbhs_omap", "usb_tll_hs_usb_ch1_clk", &dummy_ck, CK_3XXX), CLK("usbhs_tll", "usb_tll_hs_usb_ch0_clk", &dummy_ck, CK_3XXX), CLK("usbhs_tll", "usb_tll_hs_usb_ch1_clk", &dummy_ck, CK_3XXX), CLK("usbhs_omap", "init_60m_fclk", &dummy_ck, CK_3XXX), diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 6adbccf..35e65b6 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -3333,7 +3333,6 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "usb_tll_hs_usb_ch2_clk", &usb_tll_hs_usb_ch2_clk, CK_443X), CLK(NULL, "usb_tll_hs_usb_ch0_clk", &usb_tll_hs_usb_ch0_clk, CK_443X), CLK(NULL, "usb_tll_hs_usb_ch1_clk", &usb_tll_hs_usb_ch1_clk, CK_443X), - CLK("usbhs_omap", "usbtll_ick", &usb_tll_hs_ick, CK_443X), CLK("usbhs_tll", "usbtll_ick", &usb_tll_hs_ick, CK_443X), CLK(NULL, "usim_ck", &usim_ck, CK_443X), CLK(NULL, "usim_fclk", &usim_fclk, CK_443X), @@ -3384,7 +3383,6 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "uart3_ick", &dummy_ck, CK_443X), CLK(NULL, "uart4_ick", &dummy_ck, CK_443X), CLK("usbhs_omap", "usbhost_ick", &dummy_ck, CK_443X), - CLK("usbhs_omap", "usbtll_fck", &dummy_ck, CK_443X), CLK("usbhs_tll", "usbtll_fck", &dummy_ck, CK_443X), CLK("omap_wdt", "ick", &dummy_ck, CK_443X), CLK("omap_timer.1", "32k_ck", &sys_32k_ck, CK_443X), -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 22+ messages in thread
[parent not found: <1342445471-18704-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH V4 5/5] ARM: OMAP: Remove older device name of the USB TLL clocks [not found] ` <1342445471-18704-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> @ 2012-09-19 20:29 ` Paul Walmsley 0 siblings, 0 replies; 22+ messages in thread From: Paul Walmsley @ 2012-09-19 20:29 UTC (permalink / raw) To: Keshava Munegowda Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0, sameo-VuQAYsv1563Yd54FQh9/CA, parthab-PpE0FKYn9XJWk0Htik3J/w Hi On Mon, 16 Jul 2012, Keshava Munegowda wrote: > The usbhs device name of the functional, interface and > channel clocks of the TLL module is removed. > > Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> > Reviewed-by: Partha Basak <parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org> Please re-send this one separately once patches 2-4 of this series have been merged. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation [not found] ` <1342445471-18704-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> 2012-07-16 13:31 ` [PATCH V4 4/5] ARM: OMAP: USB: Remove TLL specific code " Keshava Munegowda 2012-07-16 13:31 ` [PATCH V4 5/5] ARM: OMAP: Remove older device name of the USB TLL clocks Keshava Munegowda @ 2012-09-19 11:27 ` Samuel Ortiz 2 siblings, 0 replies; 22+ messages in thread From: Samuel Ortiz @ 2012-09-19 11:27 UTC (permalink / raw) To: Keshava Munegowda Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0, parthab-PpE0FKYn9XJWk0Htik3J/w Hi Keshava, On Mon, Jul 16, 2012 at 07:01:06PM +0530, Keshava Munegowda wrote: > The TLL (Transceiver Less Link) is an separate IP block, independent of > the host controller. Basically this TLL operates like USB PHY which allows > the user to connect two USB transceiver interfaces together directly > without the use of differential transceivers in omap3 and later chips. > The TLL configuration is removed from the UHH driver and implemented as > a seperate platform driver. Now, the UHH driver configures the TLL > through API's exported by the TLL platform driver. > > Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> > > In v4: > - rebased on top of linux kernel version 3.5.rc7 > - reworked as per the comments given by Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org> > > In v3: > - rebased on top V3 of Russ dill's patch > 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > fixes an issue where the ULPI PHYs were not held in reset > while initializing the EHCI controller > http://permalink.gmane.org/gmane.linux.usb.general/65988 > > - rebased on top of patch > OMAP: USB : Fix the EHCI enumeration and core retention issue > http://permalink.gmane.org/gmane.linux.usb.general/66239 > > In V2: > - covered review comments from linux omap and usb community > - rebased on top Russ dill's patch > 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > fixes an issue where the ULPI PHYs were not held in reset > while initializing the EHCI controller > > Keshava Munegowda (5): > ARM: OMAP: Add the USB TLL clocks device name > ARM: OMAP: USB: HOST TLL platform driver > ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver > ARM: OMAP: USB: Remove TLL specific code from USB HS core driver > ARM: OMAP: Remove older device name of the USB TLL clocks All 5 patches applied now. I had to manually apply patches #1 and #5. Could you please check that it's looking good to you ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-07-16 13:31 [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Keshava Munegowda ` (3 preceding siblings ...) [not found] ` <1342445471-18704-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> @ 2012-07-19 10:18 ` Munegowda, Keshava 2012-07-23 14:01 ` Munegowda, Keshava 4 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-07-19 10:18 UTC (permalink / raw) To: linux-omap, Samuel Ortiz, balbi, Paul Walmsley; +Cc: Keshava Munegowda, parthab On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote: > The TLL (Transceiver Less Link) is an separate IP block, independent of > the host controller. Basically this TLL operates like USB PHY which allows > the user to connect two USB transceiver interfaces together directly > without the use of differential transceivers in omap3 and later chips. > The TLL configuration is removed from the UHH driver and implemented as > a seperate platform driver. Now, the UHH driver configures the TLL > through API's exported by the TLL platform driver. > > Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> > > In v4: > - rebased on top of linux kernel version 3.5.rc7 > - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> > > In v3: > - rebased on top V3 of Russ dill's patch > 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > fixes an issue where the ULPI PHYs were not held in reset > while initializing the EHCI controller > http://permalink.gmane.org/gmane.linux.usb.general/65988 > > - rebased on top of patch > OMAP: USB : Fix the EHCI enumeration and core retention issue > http://permalink.gmane.org/gmane.linux.usb.general/66239 > > In V2: > - covered review comments from linux omap and usb community > - rebased on top Russ dill's patch > 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > fixes an issue where the ULPI PHYs were not held in reset > while initializing the EHCI controller > > Keshava Munegowda (5): > ARM: OMAP: Add the USB TLL clocks device name > ARM: OMAP: USB: HOST TLL platform driver > ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver > ARM: OMAP: USB: Remove TLL specific code from USB HS core driver > ARM: OMAP: Remove older device name of the USB TLL clocks > > arch/arm/mach-omap2/clock3xxx_data.c | 8 +- > arch/arm/mach-omap2/clock44xx_data.c | 4 +- > arch/arm/mach-omap2/usb-host.c | 31 ++- > arch/arm/plat-omap/include/plat/usb.h | 7 + > drivers/mfd/Kconfig | 2 +- > drivers/mfd/Makefile | 2 +- > drivers/mfd/omap-usb-host.c | 238 ++--------------- > drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ > 8 files changed, 523 insertions(+), 240 deletions(-) > create mode 100644 drivers/mfd/omap-usb-tll.c > > -- > 1.7.9.5 Felipe/ Paul please let me know if you have any review comments on this v4 series. regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-07-19 10:18 ` Munegowda, Keshava @ 2012-07-23 14:01 ` Munegowda, Keshava 2012-07-23 14:08 ` Felipe Balbi 0 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-07-23 14:01 UTC (permalink / raw) To: linux-omap, Samuel Ortiz, balbi, Paul Walmsley; +Cc: Keshava Munegowda, parthab On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava <keshava_mgowda@ti.com> wrote: > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda > <keshava_mgowda@ti.com> wrote: >> The TLL (Transceiver Less Link) is an separate IP block, independent of >> the host controller. Basically this TLL operates like USB PHY which allows >> the user to connect two USB transceiver interfaces together directly >> without the use of differential transceivers in omap3 and later chips. >> The TLL configuration is removed from the UHH driver and implemented as >> a seperate platform driver. Now, the UHH driver configures the TLL >> through API's exported by the TLL platform driver. >> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >> >> In v4: >> - rebased on top of linux kernel version 3.5.rc7 >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> >> >> In v3: >> - rebased on top V3 of Russ dill's patch >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> fixes an issue where the ULPI PHYs were not held in reset >> while initializing the EHCI controller >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >> >> - rebased on top of patch >> OMAP: USB : Fix the EHCI enumeration and core retention issue >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >> >> In V2: >> - covered review comments from linux omap and usb community >> - rebased on top Russ dill's patch >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> fixes an issue where the ULPI PHYs were not held in reset >> while initializing the EHCI controller >> >> Keshava Munegowda (5): >> ARM: OMAP: Add the USB TLL clocks device name >> ARM: OMAP: USB: HOST TLL platform driver >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >> ARM: OMAP: Remove older device name of the USB TLL clocks >> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >> arch/arm/mach-omap2/usb-host.c | 31 ++- >> arch/arm/plat-omap/include/plat/usb.h | 7 + >> drivers/mfd/Kconfig | 2 +- >> drivers/mfd/Makefile | 2 +- >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >> 8 files changed, 523 insertions(+), 240 deletions(-) >> create mode 100644 drivers/mfd/omap-usb-tll.c >> >> -- >> 1.7.9.5 > > > Felipe/ Paul > please let me know if you have any review comments on this v4 series. > > regards > keshava Hi Felipe please let me know if you have any review comments on this series now. regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-07-23 14:01 ` Munegowda, Keshava @ 2012-07-23 14:08 ` Felipe Balbi 2012-07-23 14:34 ` Munegowda, Keshava 0 siblings, 1 reply; 22+ messages in thread From: Felipe Balbi @ 2012-07-23 14:08 UTC (permalink / raw) To: Munegowda, Keshava Cc: linux-omap, Samuel Ortiz, balbi, Paul Walmsley, parthab [-- Attachment #1: Type: text/plain, Size: 3123 bytes --] Hi, On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: > On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava > <keshava_mgowda@ti.com> wrote: > > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda > > <keshava_mgowda@ti.com> wrote: > >> The TLL (Transceiver Less Link) is an separate IP block, independent of > >> the host controller. Basically this TLL operates like USB PHY which allows > >> the user to connect two USB transceiver interfaces together directly > >> without the use of differential transceivers in omap3 and later chips. > >> The TLL configuration is removed from the UHH driver and implemented as > >> a seperate platform driver. Now, the UHH driver configures the TLL > >> through API's exported by the TLL platform driver. > >> > >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> > >> > >> In v4: > >> - rebased on top of linux kernel version 3.5.rc7 > >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> > >> > >> In v3: > >> - rebased on top V3 of Russ dill's patch > >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > >> fixes an issue where the ULPI PHYs were not held in reset > >> while initializing the EHCI controller > >> http://permalink.gmane.org/gmane.linux.usb.general/65988 > >> > >> - rebased on top of patch > >> OMAP: USB : Fix the EHCI enumeration and core retention issue > >> http://permalink.gmane.org/gmane.linux.usb.general/66239 > >> > >> In V2: > >> - covered review comments from linux omap and usb community > >> - rebased on top Russ dill's patch > >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > >> fixes an issue where the ULPI PHYs were not held in reset > >> while initializing the EHCI controller > >> > >> Keshava Munegowda (5): > >> ARM: OMAP: Add the USB TLL clocks device name > >> ARM: OMAP: USB: HOST TLL platform driver > >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver > >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver > >> ARM: OMAP: Remove older device name of the USB TLL clocks > >> > >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- > >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- > >> arch/arm/mach-omap2/usb-host.c | 31 ++- > >> arch/arm/plat-omap/include/plat/usb.h | 7 + > >> drivers/mfd/Kconfig | 2 +- > >> drivers/mfd/Makefile | 2 +- > >> drivers/mfd/omap-usb-host.c | 238 ++--------------- > >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ > >> 8 files changed, 523 insertions(+), 240 deletions(-) > >> create mode 100644 drivers/mfd/omap-usb-tll.c > >> > >> -- > >> 1.7.9.5 > > > > > > Felipe/ Paul > > please let me know if you have any review comments on this v4 series. > > > > regards > > keshava > > Hi Felipe > please let me know if you have any review comments on this series now. looks ok... pretty much just moving code around. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-07-23 14:08 ` Felipe Balbi @ 2012-07-23 14:34 ` Munegowda, Keshava 2012-07-27 12:14 ` Munegowda, Keshava 0 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-07-23 14:34 UTC (permalink / raw) To: balbi; +Cc: linux-omap, Samuel Ortiz, Paul Walmsley, parthab On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi <balbi@ti.com> wrote: > Hi, > > On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: >> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava >> <keshava_mgowda@ti.com> wrote: >> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda >> > <keshava_mgowda@ti.com> wrote: >> >> The TLL (Transceiver Less Link) is an separate IP block, independent of >> >> the host controller. Basically this TLL operates like USB PHY which allows >> >> the user to connect two USB transceiver interfaces together directly >> >> without the use of differential transceivers in omap3 and later chips. >> >> The TLL configuration is removed from the UHH driver and implemented as >> >> a seperate platform driver. Now, the UHH driver configures the TLL >> >> through API's exported by the TLL platform driver. >> >> >> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >> >> >> >> In v4: >> >> - rebased on top of linux kernel version 3.5.rc7 >> >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> >> >> >> >> In v3: >> >> - rebased on top V3 of Russ dill's patch >> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> >> fixes an issue where the ULPI PHYs were not held in reset >> >> while initializing the EHCI controller >> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >> >> >> >> - rebased on top of patch >> >> OMAP: USB : Fix the EHCI enumeration and core retention issue >> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >> >> >> >> In V2: >> >> - covered review comments from linux omap and usb community >> >> - rebased on top Russ dill's patch >> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> >> fixes an issue where the ULPI PHYs were not held in reset >> >> while initializing the EHCI controller >> >> >> >> Keshava Munegowda (5): >> >> ARM: OMAP: Add the USB TLL clocks device name >> >> ARM: OMAP: USB: HOST TLL platform driver >> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >> >> ARM: OMAP: Remove older device name of the USB TLL clocks >> >> >> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >> >> arch/arm/mach-omap2/usb-host.c | 31 ++- >> >> arch/arm/plat-omap/include/plat/usb.h | 7 + >> >> drivers/mfd/Kconfig | 2 +- >> >> drivers/mfd/Makefile | 2 +- >> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >> >> 8 files changed, 523 insertions(+), 240 deletions(-) >> >> create mode 100644 drivers/mfd/omap-usb-tll.c >> >> >> >> -- >> >> 1.7.9.5 >> > >> > >> > Felipe/ Paul >> > please let me know if you have any review comments on this v4 series. >> > >> > regards >> > keshava >> >> Hi Felipe >> please let me know if you have any review comments on this series now. > > looks ok... pretty much just moving code around. > > -- > balbi Thanks Felipe then I request please give your Ack by for this series. regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-07-23 14:34 ` Munegowda, Keshava @ 2012-07-27 12:14 ` Munegowda, Keshava 2012-08-13 13:22 ` Munegowda, Keshava 0 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-07-27 12:14 UTC (permalink / raw) To: balbi; +Cc: linux-omap, Samuel Ortiz, Paul Walmsley, parthab On Mon, Jul 23, 2012 at 8:04 PM, Munegowda, Keshava <keshava_mgowda@ti.com> wrote: > On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi <balbi@ti.com> wrote: >> Hi, >> >> On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: >>> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava >>> <keshava_mgowda@ti.com> wrote: >>> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda >>> > <keshava_mgowda@ti.com> wrote: >>> >> The TLL (Transceiver Less Link) is an separate IP block, independent of >>> >> the host controller. Basically this TLL operates like USB PHY which allows >>> >> the user to connect two USB transceiver interfaces together directly >>> >> without the use of differential transceivers in omap3 and later chips. >>> >> The TLL configuration is removed from the UHH driver and implemented as >>> >> a seperate platform driver. Now, the UHH driver configures the TLL >>> >> through API's exported by the TLL platform driver. >>> >> >>> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >>> >> >>> >> In v4: >>> >> - rebased on top of linux kernel version 3.5.rc7 >>> >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> >>> >> >>> >> In v3: >>> >> - rebased on top V3 of Russ dill's patch >>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>> >> fixes an issue where the ULPI PHYs were not held in reset >>> >> while initializing the EHCI controller >>> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >>> >> >>> >> - rebased on top of patch >>> >> OMAP: USB : Fix the EHCI enumeration and core retention issue >>> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >>> >> >>> >> In V2: >>> >> - covered review comments from linux omap and usb community >>> >> - rebased on top Russ dill's patch >>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>> >> fixes an issue where the ULPI PHYs were not held in reset >>> >> while initializing the EHCI controller >>> >> >>> >> Keshava Munegowda (5): >>> >> ARM: OMAP: Add the USB TLL clocks device name >>> >> ARM: OMAP: USB: HOST TLL platform driver >>> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >>> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >>> >> ARM: OMAP: Remove older device name of the USB TLL clocks >>> >> >>> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >>> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >>> >> arch/arm/mach-omap2/usb-host.c | 31 ++- >>> >> arch/arm/plat-omap/include/plat/usb.h | 7 + >>> >> drivers/mfd/Kconfig | 2 +- >>> >> drivers/mfd/Makefile | 2 +- >>> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >>> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >>> >> 8 files changed, 523 insertions(+), 240 deletions(-) >>> >> create mode 100644 drivers/mfd/omap-usb-tll.c >>> >> >>> >> -- >>> >> 1.7.9.5 >>> > >>> > >>> > Felipe/ Paul >>> > please let me know if you have any review comments on this v4 series. >>> > >>> > regards >>> > keshava >>> >>> Hi Felipe >>> please let me know if you have any review comments on this series now. >> >> looks ok... pretty much just moving code around. >> >> -- >> balbi > > > Thanks Felipe > > then I request please give your Ack by for this series. > > regards > keshava Hi Paul do you have any review comments on this series? Felipe is OK with this series. if there are no review comments on this series I request your ack by for the same. Once this series gets in to mainline. i will start the Device tree conversion for usb2 host. regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-07-27 12:14 ` Munegowda, Keshava @ 2012-08-13 13:22 ` Munegowda, Keshava 2012-08-13 14:09 ` Felipe Balbi 0 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-08-13 13:22 UTC (permalink / raw) To: balbi, Samuel Ortiz; +Cc: linux-omap, Paul Walmsley, parthab On Fri, Jul 27, 2012 at 5:44 PM, Munegowda, Keshava <keshava_mgowda@ti.com> wrote: > On Mon, Jul 23, 2012 at 8:04 PM, Munegowda, Keshava > <keshava_mgowda@ti.com> wrote: >> On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi <balbi@ti.com> wrote: >>> Hi, >>> >>> On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: >>>> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava >>>> <keshava_mgowda@ti.com> wrote: >>>> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda >>>> > <keshava_mgowda@ti.com> wrote: >>>> >> The TLL (Transceiver Less Link) is an separate IP block, independent of >>>> >> the host controller. Basically this TLL operates like USB PHY which allows >>>> >> the user to connect two USB transceiver interfaces together directly >>>> >> without the use of differential transceivers in omap3 and later chips. >>>> >> The TLL configuration is removed from the UHH driver and implemented as >>>> >> a seperate platform driver. Now, the UHH driver configures the TLL >>>> >> through API's exported by the TLL platform driver. >>>> >> >>>> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >>>> >> >>>> >> In v4: >>>> >> - rebased on top of linux kernel version 3.5.rc7 >>>> >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> >>>> >> >>>> >> In v3: >>>> >> - rebased on top V3 of Russ dill's patch >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>>> >> fixes an issue where the ULPI PHYs were not held in reset >>>> >> while initializing the EHCI controller >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >>>> >> >>>> >> - rebased on top of patch >>>> >> OMAP: USB : Fix the EHCI enumeration and core retention issue >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >>>> >> >>>> >> In V2: >>>> >> - covered review comments from linux omap and usb community >>>> >> - rebased on top Russ dill's patch >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>>> >> fixes an issue where the ULPI PHYs were not held in reset >>>> >> while initializing the EHCI controller >>>> >> >>>> >> Keshava Munegowda (5): >>>> >> ARM: OMAP: Add the USB TLL clocks device name >>>> >> ARM: OMAP: USB: HOST TLL platform driver >>>> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >>>> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >>>> >> ARM: OMAP: Remove older device name of the USB TLL clocks >>>> >> >>>> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >>>> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >>>> >> arch/arm/mach-omap2/usb-host.c | 31 ++- >>>> >> arch/arm/plat-omap/include/plat/usb.h | 7 + >>>> >> drivers/mfd/Kconfig | 2 +- >>>> >> drivers/mfd/Makefile | 2 +- >>>> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >>>> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >>>> >> 8 files changed, 523 insertions(+), 240 deletions(-) >>>> >> create mode 100644 drivers/mfd/omap-usb-tll.c >>>> >> >>>> >> -- >>>> >> 1.7.9.5 >>>> > >>>> > >>>> > Felipe/ Paul >>>> > please let me know if you have any review comments on this v4 series. >>>> > >>>> > regards >>>> > keshava >>>> >>>> Hi Felipe >>>> please let me know if you have any review comments on this series now. >>> >>> looks ok... pretty much just moving code around. >>> >>> -- >>> balbi >> >> >> Thanks Felipe >> >> then I request please give your Ack by for this series. >> >> regards >> keshava > > Hi Paul > do you have any review comments on this series? > Felipe is OK with this series. if there are no review comments on this series > I request your ack by for the same. > Once this series gets in to mainline. i will start the Device tree > conversion for usb2 host. > > regards > keshava Hi Felipe please give you ack by this series , so that I request samuel to merge to mainline. regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-08-13 13:22 ` Munegowda, Keshava @ 2012-08-13 14:09 ` Felipe Balbi 2012-08-13 14:53 ` Munegowda, Keshava 0 siblings, 1 reply; 22+ messages in thread From: Felipe Balbi @ 2012-08-13 14:09 UTC (permalink / raw) To: Munegowda, Keshava Cc: balbi, Samuel Ortiz, linux-omap, Paul Walmsley, parthab [-- Attachment #1: Type: text/plain, Size: 4479 bytes --] On Mon, Aug 13, 2012 at 06:52:13PM +0530, Munegowda, Keshava wrote: > On Fri, Jul 27, 2012 at 5:44 PM, Munegowda, Keshava > <keshava_mgowda@ti.com> wrote: > > On Mon, Jul 23, 2012 at 8:04 PM, Munegowda, Keshava > > <keshava_mgowda@ti.com> wrote: > >> On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi <balbi@ti.com> wrote: > >>> Hi, > >>> > >>> On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: > >>>> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava > >>>> <keshava_mgowda@ti.com> wrote: > >>>> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda > >>>> > <keshava_mgowda@ti.com> wrote: > >>>> >> The TLL (Transceiver Less Link) is an separate IP block, independent of > >>>> >> the host controller. Basically this TLL operates like USB PHY which allows > >>>> >> the user to connect two USB transceiver interfaces together directly > >>>> >> without the use of differential transceivers in omap3 and later chips. > >>>> >> The TLL configuration is removed from the UHH driver and implemented as > >>>> >> a seperate platform driver. Now, the UHH driver configures the TLL > >>>> >> through API's exported by the TLL platform driver. > >>>> >> > >>>> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> > >>>> >> > >>>> >> In v4: > >>>> >> - rebased on top of linux kernel version 3.5.rc7 > >>>> >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> > >>>> >> > >>>> >> In v3: > >>>> >> - rebased on top V3 of Russ dill's patch > >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > >>>> >> fixes an issue where the ULPI PHYs were not held in reset > >>>> >> while initializing the EHCI controller > >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 > >>>> >> > >>>> >> - rebased on top of patch > >>>> >> OMAP: USB : Fix the EHCI enumeration and core retention issue > >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 > >>>> >> > >>>> >> In V2: > >>>> >> - covered review comments from linux omap and usb community > >>>> >> - rebased on top Russ dill's patch > >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' > >>>> >> fixes an issue where the ULPI PHYs were not held in reset > >>>> >> while initializing the EHCI controller > >>>> >> > >>>> >> Keshava Munegowda (5): > >>>> >> ARM: OMAP: Add the USB TLL clocks device name > >>>> >> ARM: OMAP: USB: HOST TLL platform driver > >>>> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver > >>>> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver > >>>> >> ARM: OMAP: Remove older device name of the USB TLL clocks > >>>> >> > >>>> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- > >>>> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- > >>>> >> arch/arm/mach-omap2/usb-host.c | 31 ++- > >>>> >> arch/arm/plat-omap/include/plat/usb.h | 7 + > >>>> >> drivers/mfd/Kconfig | 2 +- > >>>> >> drivers/mfd/Makefile | 2 +- > >>>> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- > >>>> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ > >>>> >> 8 files changed, 523 insertions(+), 240 deletions(-) > >>>> >> create mode 100644 drivers/mfd/omap-usb-tll.c > >>>> >> > >>>> >> -- > >>>> >> 1.7.9.5 > >>>> > > >>>> > > >>>> > Felipe/ Paul > >>>> > please let me know if you have any review comments on this v4 series. > >>>> > > >>>> > regards > >>>> > keshava > >>>> > >>>> Hi Felipe > >>>> please let me know if you have any review comments on this series now. > >>> > >>> looks ok... pretty much just moving code around. > >>> > >>> -- > >>> balbi > >> > >> > >> Thanks Felipe > >> > >> then I request please give your Ack by for this series. > >> > >> regards > >> keshava > > > > Hi Paul > > do you have any review comments on this series? > > Felipe is OK with this series. if there are no review comments on this series > > I request your ack by for the same. > > Once this series gets in to mainline. i will start the Device tree > > conversion for usb2 host. > > > > regards > > keshava > > Hi Felipe > please give you ack by this series , so that I request > samuel to merge to mainline. sure, here you go Acked-by: Felipe Balbi <balbi@ti.com> -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-08-13 14:09 ` Felipe Balbi @ 2012-08-13 14:53 ` Munegowda, Keshava 2012-09-13 11:44 ` Munegowda, Keshava 0 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-08-13 14:53 UTC (permalink / raw) To: linux-omap, Samuel Ortiz; +Cc: Paul Walmsley, parthab On Mon, Aug 13, 2012 at 7:39 PM, Felipe Balbi <balbi@ti.com> wrote: > On Mon, Aug 13, 2012 at 06:52:13PM +0530, Munegowda, Keshava wrote: >> On Fri, Jul 27, 2012 at 5:44 PM, Munegowda, Keshava >> <keshava_mgowda@ti.com> wrote: >> > On Mon, Jul 23, 2012 at 8:04 PM, Munegowda, Keshava >> > <keshava_mgowda@ti.com> wrote: >> >> On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi <balbi@ti.com> wrote: >> >>> Hi, >> >>> >> >>> On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: >> >>>> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava >> >>>> <keshava_mgowda@ti.com> wrote: >> >>>> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda >> >>>> > <keshava_mgowda@ti.com> wrote: >> >>>> >> The TLL (Transceiver Less Link) is an separate IP block, independent of >> >>>> >> the host controller. Basically this TLL operates like USB PHY which allows >> >>>> >> the user to connect two USB transceiver interfaces together directly >> >>>> >> without the use of differential transceivers in omap3 and later chips. >> >>>> >> The TLL configuration is removed from the UHH driver and implemented as >> >>>> >> a seperate platform driver. Now, the UHH driver configures the TLL >> >>>> >> through API's exported by the TLL platform driver. >> >>>> >> >> >>>> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >> >>>> >> >> >>>> >> In v4: >> >>>> >> - rebased on top of linux kernel version 3.5.rc7 >> >>>> >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> >> >>>> >> >> >>>> >> In v3: >> >>>> >> - rebased on top V3 of Russ dill's patch >> >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> >>>> >> fixes an issue where the ULPI PHYs were not held in reset >> >>>> >> while initializing the EHCI controller >> >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >> >>>> >> >> >>>> >> - rebased on top of patch >> >>>> >> OMAP: USB : Fix the EHCI enumeration and core retention issue >> >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >> >>>> >> >> >>>> >> In V2: >> >>>> >> - covered review comments from linux omap and usb community >> >>>> >> - rebased on top Russ dill's patch >> >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> >>>> >> fixes an issue where the ULPI PHYs were not held in reset >> >>>> >> while initializing the EHCI controller >> >>>> >> >> >>>> >> Keshava Munegowda (5): >> >>>> >> ARM: OMAP: Add the USB TLL clocks device name >> >>>> >> ARM: OMAP: USB: HOST TLL platform driver >> >>>> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >> >>>> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >> >>>> >> ARM: OMAP: Remove older device name of the USB TLL clocks >> >>>> >> >> >>>> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >> >>>> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >> >>>> >> arch/arm/mach-omap2/usb-host.c | 31 ++- >> >>>> >> arch/arm/plat-omap/include/plat/usb.h | 7 + >> >>>> >> drivers/mfd/Kconfig | 2 +- >> >>>> >> drivers/mfd/Makefile | 2 +- >> >>>> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >> >>>> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >> >>>> >> 8 files changed, 523 insertions(+), 240 deletions(-) >> >>>> >> create mode 100644 drivers/mfd/omap-usb-tll.c >> >>>> >> >> >>>> >> -- >> >>>> >> 1.7.9.5 >> >>>> > >> >>>> > >> >>>> > Felipe/ Paul >> >>>> > please let me know if you have any review comments on this v4 series. >> >>>> > >> >>>> > regards >> >>>> > keshava >> >>>> >> >>>> Hi Felipe >> >>>> please let me know if you have any review comments on this series now. >> >>> >> >>> looks ok... pretty much just moving code around. >> >>> >> >>> -- >> >>> balbi >> >> >> >> >> >> Thanks Felipe >> >> >> >> then I request please give your Ack by for this series. >> >> >> >> regards >> >> keshava >> > >> > Hi Paul >> > do you have any review comments on this series? >> > Felipe is OK with this series. if there are no review comments on this series >> > I request your ack by for the same. >> > Once this series gets in to mainline. i will start the Device tree >> > conversion for usb2 host. >> > >> > regards >> > keshava >> >> Hi Felipe >> please give you ack by this series , so that I request >> samuel to merge to mainline. > > sure, here you go > > Acked-by: Felipe Balbi <balbi@ti.com> > > -- > balbi Thanks Felipe Samuel I request please queue this series for the next merge window. regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-08-13 14:53 ` Munegowda, Keshava @ 2012-09-13 11:44 ` Munegowda, Keshava 2012-09-18 9:57 ` Munegowda, Keshava 0 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-09-13 11:44 UTC (permalink / raw) To: linux-omap, Samuel Ortiz; +Cc: Paul Walmsley, parthab On Mon, Aug 13, 2012 at 8:23 PM, Munegowda, Keshava <keshava_mgowda@ti.com> wrote: > On Mon, Aug 13, 2012 at 7:39 PM, Felipe Balbi <balbi@ti.com> wrote: >> On Mon, Aug 13, 2012 at 06:52:13PM +0530, Munegowda, Keshava wrote: >>> On Fri, Jul 27, 2012 at 5:44 PM, Munegowda, Keshava >>> <keshava_mgowda@ti.com> wrote: >>> > On Mon, Jul 23, 2012 at 8:04 PM, Munegowda, Keshava >>> > <keshava_mgowda@ti.com> wrote: >>> >> On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi <balbi@ti.com> wrote: >>> >>> Hi, >>> >>> >>> >>> On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: >>> >>>> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava >>> >>>> <keshava_mgowda@ti.com> wrote: >>> >>>> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda >>> >>>> > <keshava_mgowda@ti.com> wrote: >>> >>>> >> The TLL (Transceiver Less Link) is an separate IP block, independent of >>> >>>> >> the host controller. Basically this TLL operates like USB PHY which allows >>> >>>> >> the user to connect two USB transceiver interfaces together directly >>> >>>> >> without the use of differential transceivers in omap3 and later chips. >>> >>>> >> The TLL configuration is removed from the UHH driver and implemented as >>> >>>> >> a seperate platform driver. Now, the UHH driver configures the TLL >>> >>>> >> through API's exported by the TLL platform driver. >>> >>>> >> >>> >>>> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >>> >>>> >> >>> >>>> >> In v4: >>> >>>> >> - rebased on top of linux kernel version 3.5.rc7 >>> >>>> >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> >>> >>>> >> >>> >>>> >> In v3: >>> >>>> >> - rebased on top V3 of Russ dill's patch >>> >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>> >>>> >> fixes an issue where the ULPI PHYs were not held in reset >>> >>>> >> while initializing the EHCI controller >>> >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >>> >>>> >> >>> >>>> >> - rebased on top of patch >>> >>>> >> OMAP: USB : Fix the EHCI enumeration and core retention issue >>> >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >>> >>>> >> >>> >>>> >> In V2: >>> >>>> >> - covered review comments from linux omap and usb community >>> >>>> >> - rebased on top Russ dill's patch >>> >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>> >>>> >> fixes an issue where the ULPI PHYs were not held in reset >>> >>>> >> while initializing the EHCI controller >>> >>>> >> >>> >>>> >> Keshava Munegowda (5): >>> >>>> >> ARM: OMAP: Add the USB TLL clocks device name >>> >>>> >> ARM: OMAP: USB: HOST TLL platform driver >>> >>>> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >>> >>>> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >>> >>>> >> ARM: OMAP: Remove older device name of the USB TLL clocks >>> >>>> >> >>> >>>> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >>> >>>> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >>> >>>> >> arch/arm/mach-omap2/usb-host.c | 31 ++- >>> >>>> >> arch/arm/plat-omap/include/plat/usb.h | 7 + >>> >>>> >> drivers/mfd/Kconfig | 2 +- >>> >>>> >> drivers/mfd/Makefile | 2 +- >>> >>>> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >>> >>>> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >>> >>>> >> 8 files changed, 523 insertions(+), 240 deletions(-) >>> >>>> >> create mode 100644 drivers/mfd/omap-usb-tll.c >>> >>>> >> >>> >>>> >> -- >>> >>>> >> 1.7.9.5 >>> >>>> > >>> >>>> > >>> >>>> > Felipe/ Paul >>> >>>> > please let me know if you have any review comments on this v4 series. >>> >>>> > >>> >>>> > regards >>> >>>> > keshava >>> >>>> >>> >>>> Hi Felipe >>> >>>> please let me know if you have any review comments on this series now. >>> >>> >>> >>> looks ok... pretty much just moving code around. >>> >>> >>> >>> -- >>> >>> balbi >>> >> >>> >> >>> >> Thanks Felipe >>> >> >>> >> then I request please give your Ack by for this series. >>> >> >>> >> regards >>> >> keshava >>> > >>> > Hi Paul >>> > do you have any review comments on this series? >>> > Felipe is OK with this series. if there are no review comments on this series >>> > I request your ack by for the same. >>> > Once this series gets in to mainline. i will start the Device tree >>> > conversion for usb2 host. >>> > >>> > regards >>> > keshava >>> >>> Hi Felipe >>> please give you ack by this series , so that I request >>> samuel to merge to mainline. >> >> sure, here you go >> >> Acked-by: Felipe Balbi <balbi@ti.com> >> >> -- >> balbi > > > Thanks Felipe > > Samuel > I request please queue this series for the next merge window. > > regards > keshava samuel : ping regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-09-13 11:44 ` Munegowda, Keshava @ 2012-09-18 9:57 ` Munegowda, Keshava 2012-09-19 20:39 ` Paul Walmsley 0 siblings, 1 reply; 22+ messages in thread From: Munegowda, Keshava @ 2012-09-18 9:57 UTC (permalink / raw) To: Samuel Ortiz; +Cc: Paul Walmsley, parthab, linux-omap, Linux USB Devel On Thu, Sep 13, 2012 at 5:14 PM, Munegowda, Keshava <keshava_mgowda@ti.com> wrote: > On Mon, Aug 13, 2012 at 8:23 PM, Munegowda, Keshava > <keshava_mgowda@ti.com> wrote: >> On Mon, Aug 13, 2012 at 7:39 PM, Felipe Balbi <balbi@ti.com> wrote: >>> On Mon, Aug 13, 2012 at 06:52:13PM +0530, Munegowda, Keshava wrote: >>>> On Fri, Jul 27, 2012 at 5:44 PM, Munegowda, Keshava >>>> <keshava_mgowda@ti.com> wrote: >>>> > On Mon, Jul 23, 2012 at 8:04 PM, Munegowda, Keshava >>>> > <keshava_mgowda@ti.com> wrote: >>>> >> On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi <balbi@ti.com> wrote: >>>> >>> Hi, >>>> >>> >>>> >>> On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: >>>> >>>> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava >>>> >>>> <keshava_mgowda@ti.com> wrote: >>>> >>>> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda >>>> >>>> > <keshava_mgowda@ti.com> wrote: >>>> >>>> >> The TLL (Transceiver Less Link) is an separate IP block, independent of >>>> >>>> >> the host controller. Basically this TLL operates like USB PHY which allows >>>> >>>> >> the user to connect two USB transceiver interfaces together directly >>>> >>>> >> without the use of differential transceivers in omap3 and later chips. >>>> >>>> >> The TLL configuration is removed from the UHH driver and implemented as >>>> >>>> >> a seperate platform driver. Now, the UHH driver configures the TLL >>>> >>>> >> through API's exported by the TLL platform driver. >>>> >>>> >> >>>> >>>> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >>>> >>>> >> >>>> >>>> >> In v4: >>>> >>>> >> - rebased on top of linux kernel version 3.5.rc7 >>>> >>>> >> - reworked as per the comments given by Paul Walmsley <paul@pwsan.com> >>>> >>>> >> >>>> >>>> >> In v3: >>>> >>>> >> - rebased on top V3 of Russ dill's patch >>>> >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>>> >>>> >> fixes an issue where the ULPI PHYs were not held in reset >>>> >>>> >> while initializing the EHCI controller >>>> >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >>>> >>>> >> >>>> >>>> >> - rebased on top of patch >>>> >>>> >> OMAP: USB : Fix the EHCI enumeration and core retention issue >>>> >>>> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >>>> >>>> >> >>>> >>>> >> In V2: >>>> >>>> >> - covered review comments from linux omap and usb community >>>> >>>> >> - rebased on top Russ dill's patch >>>> >>>> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >>>> >>>> >> fixes an issue where the ULPI PHYs were not held in reset >>>> >>>> >> while initializing the EHCI controller >>>> >>>> >> >>>> >>>> >> Keshava Munegowda (5): >>>> >>>> >> ARM: OMAP: Add the USB TLL clocks device name >>>> >>>> >> ARM: OMAP: USB: HOST TLL platform driver >>>> >>>> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >>>> >>>> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >>>> >>>> >> ARM: OMAP: Remove older device name of the USB TLL clocks >>>> >>>> >> >>>> >>>> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >>>> >>>> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >>>> >>>> >> arch/arm/mach-omap2/usb-host.c | 31 ++- >>>> >>>> >> arch/arm/plat-omap/include/plat/usb.h | 7 + >>>> >>>> >> drivers/mfd/Kconfig | 2 +- >>>> >>>> >> drivers/mfd/Makefile | 2 +- >>>> >>>> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >>>> >>>> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >>>> >>>> >> 8 files changed, 523 insertions(+), 240 deletions(-) >>>> >>>> >> create mode 100644 drivers/mfd/omap-usb-tll.c >>>> >>>> >> >>>> >>>> >> -- >>>> >>>> >> 1.7.9.5 >>>> >>>> > >>>> >>>> > >>>> >>>> > Felipe/ Paul >>>> >>>> > please let me know if you have any review comments on this v4 series. >>>> >>>> > >>>> >>>> > regards >>>> >>>> > keshava >>>> >>>> >>>> >>>> Hi Felipe >>>> >>>> please let me know if you have any review comments on this series now. >>>> >>> >>>> >>> looks ok... pretty much just moving code around. >>>> >>> >>>> >>> -- >>>> >>> balbi >>>> >> >>>> >> >>>> >> Thanks Felipe >>>> >> >>>> >> then I request please give your Ack by for this series. >>>> >> >>>> >> regards >>>> >> keshava >>>> > >>>> > Hi Paul >>>> > do you have any review comments on this series? >>>> > Felipe is OK with this series. if there are no review comments on this series >>>> > I request your ack by for the same. >>>> > Once this series gets in to mainline. i will start the Device tree >>>> > conversion for usb2 host. >>>> > >>>> > regards >>>> > keshava >>>> >>>> Hi Felipe >>>> please give you ack by this series , so that I request >>>> samuel to merge to mainline. >>> >>> sure, here you go >>> >>> Acked-by: Felipe Balbi <balbi@ti.com> >>> >>> -- >>> balbi >> >> >> Thanks Felipe >> >> Samuel >> I request please queue this series for the next merge window. >> >> regards >> keshava > > > samuel : ping > > regards > keshava samuel: ping regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-09-18 9:57 ` Munegowda, Keshava @ 2012-09-19 20:39 ` Paul Walmsley [not found] ` <alpine.DEB.2.00.1209192030270.5264-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org> 0 siblings, 1 reply; 22+ messages in thread From: Paul Walmsley @ 2012-09-19 20:39 UTC (permalink / raw) To: Samuel Ortiz; +Cc: Munegowda, Keshava, parthab, linux-omap, Linux USB Devel Hi Samuel, I've queued patch 1 of this series for 3.7, which should go upstream via the OMAP -> arm-soc path. Also asked Keshava to re-send patch 5 to me once patches 2-4 have been merged. It's up to you how to handle patches 2-4. The series is a good step forward for us in terms of cleanup. But what is probably worthwhile at some point is for that USB TLL "phy" code (added in patch 2) to be moved into some place like drivers/usb/phy, since it's not MFD-related. - Paul ^ permalink raw reply [flat|nested] 22+ messages in thread
[parent not found: <alpine.DEB.2.00.1209192030270.5264-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation [not found] ` <alpine.DEB.2.00.1209192030270.5264-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org> @ 2012-09-21 22:07 ` Samuel Ortiz 2012-09-24 7:09 ` Munegowda, Keshava 0 siblings, 1 reply; 22+ messages in thread From: Samuel Ortiz @ 2012-09-21 22:07 UTC (permalink / raw) To: Paul Walmsley Cc: Munegowda, Keshava, parthab-PpE0FKYn9XJWk0Htik3J/w, linux-omap-u79uwXL29TY76Z2rM5mHXA, Linux USB Devel Hi Paul, On Wed, Sep 19, 2012 at 08:39:40PM +0000, Paul Walmsley wrote: > > Hi Samuel, > > I've queued patch 1 of this series for 3.7, which should go upstream via > the OMAP -> arm-soc path. Also asked Keshava to re-send patch 5 to me > once patches 2-4 have been merged. > > It's up to you how to handle patches 2-4. The series is a good step > forward for us in terms of cleanup. But what is probably worthwhile at > some point is for that USB TLL "phy" code (added in patch 2) to be moved > into some place like drivers/usb/phy, since it's not MFD-related. That would be ideal, yes. I kept patches 2-4 as they're alreeady going in the right direction (I dropped patches 1 and 5). Thanks for the heads up. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation 2012-09-21 22:07 ` Samuel Ortiz @ 2012-09-24 7:09 ` Munegowda, Keshava 0 siblings, 0 replies; 22+ messages in thread From: Munegowda, Keshava @ 2012-09-24 7:09 UTC (permalink / raw) To: Samuel Ortiz; +Cc: Paul Walmsley, parthab, linux-omap, Linux USB Devel On Sat, Sep 22, 2012 at 3:37 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > Hi Paul, > > On Wed, Sep 19, 2012 at 08:39:40PM +0000, Paul Walmsley wrote: >> >> Hi Samuel, >> >> I've queued patch 1 of this series for 3.7, which should go upstream via >> the OMAP -> arm-soc path. Also asked Keshava to re-send patch 5 to me >> once patches 2-4 have been merged. >> >> It's up to you how to handle patches 2-4. The series is a good step >> forward for us in terms of cleanup. But what is probably worthwhile at >> some point is for that USB TLL "phy" code (added in patch 2) to be moved >> into some place like drivers/usb/phy, since it's not MFD-related. > That would be ideal, yes. I kept patches 2-4 as they're alreeady going in the > right direction (I dropped patches 1 and 5). > > Thanks for the heads up. > > Cheers, > Samuel. > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ thanks paul and Samuel regards keshava regards keshava ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2012-09-24 7:09 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-16 13:31 [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Keshava Munegowda
2012-07-16 13:31 ` [PATCH V4 1/5] ARM: OMAP: Add the USB TLL clocks device name Keshava Munegowda
[not found] ` <1342445471-18704-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-09-19 20:28 ` Paul Walmsley
2012-07-16 13:31 ` [PATCH V4 2/5] ARM: OMAP: USB: HOST TLL platform driver Keshava Munegowda
2012-07-16 13:31 ` [PATCH V4 3/5] ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver Keshava Munegowda
[not found] ` <1342445471-18704-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-07-16 13:31 ` [PATCH V4 4/5] ARM: OMAP: USB: Remove TLL specific code " Keshava Munegowda
2012-07-16 13:31 ` [PATCH V4 5/5] ARM: OMAP: Remove older device name of the USB TLL clocks Keshava Munegowda
[not found] ` <1342445471-18704-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-09-19 20:29 ` Paul Walmsley
2012-09-19 11:27 ` [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Samuel Ortiz
2012-07-19 10:18 ` Munegowda, Keshava
2012-07-23 14:01 ` Munegowda, Keshava
2012-07-23 14:08 ` Felipe Balbi
2012-07-23 14:34 ` Munegowda, Keshava
2012-07-27 12:14 ` Munegowda, Keshava
2012-08-13 13:22 ` Munegowda, Keshava
2012-08-13 14:09 ` Felipe Balbi
2012-08-13 14:53 ` Munegowda, Keshava
2012-09-13 11:44 ` Munegowda, Keshava
2012-09-18 9:57 ` Munegowda, Keshava
2012-09-19 20:39 ` Paul Walmsley
[not found] ` <alpine.DEB.2.00.1209192030270.5264-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2012-09-21 22:07 ` Samuel Ortiz
2012-09-24 7:09 ` Munegowda, Keshava
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.