* Resizing panels in the gitk window [not found] <CAP94bnOyrx6hCmWSjmejVfopUydk10ga42wJzm1M4nk_OXn9Mg@mail.gmail.com> @ 2022-05-05 7:06 ` Christian Grün 2022-05-06 12:00 ` Matthias Aßhauer 2022-05-06 7:46 ` Christian Grün 1 sibling, 1 reply; 14+ messages in thread From: Christian Grün @ 2022-05-05 7:06 UTC (permalink / raw) To: git Resizing panels in the gitk window leads to a error message that’s presented multiple times in a dialog: expected integer but got "" expected integer but got "" while executing "$win sash place 0 $sash0 [lindex $s0 1]" (procedure "resizeclistpanes" line 38) invoked from within "resizeclistpanes .tf.histframe.pwclist 1834" (command bound to event) Is this a known bug? I’ll be happy to give more details. Best, Christian ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-05 7:06 ` Resizing panels in the gitk window Christian Grün @ 2022-05-06 12:00 ` Matthias Aßhauer 2022-05-06 12:12 ` Christian Grün 2022-05-06 16:23 ` Junio C Hamano 0 siblings, 2 replies; 14+ messages in thread From: Matthias Aßhauer @ 2022-05-06 12:00 UTC (permalink / raw) To: Christian Grün; +Cc: git, Paul Mackerras, Halil Sen, Stefan Naewe On Thu, 5 May 2022, Christian Grün wrote: > Resizing panels in the gitk window leads to a error message that’s > presented multiple times in a dialog: > > expected integer but got "" > expected integer but got "" > while executing > "$win sash place 0 $sash0 [lindex $s0 1]" > (procedure "resizeclistpanes" line 38) > invoked from within > "resizeclistpanes .tf.histframe.pwclist 1834" > (command bound to event) > > Is this a known bug? It looks like the issue at [1]. It sadly seems like nobody ever reviewed or applied thos suggested patches, but there is some more off-list discussion at [2]. > I’ll be happy to give more details. > Best, Christian > Best regards Matthias [1] https://lore.kernel.org/git/pull.1219.git.git.1645386457.gitgitgadget@gmail.com/#t [2] https://github.com/git/git/pull/1219#issuecomment-1113122632 ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-06 12:00 ` Matthias Aßhauer @ 2022-05-06 12:12 ` Christian Grün 2022-05-06 16:23 ` Junio C Hamano 1 sibling, 0 replies; 14+ messages in thread From: Christian Grün @ 2022-05-06 12:12 UTC (permalink / raw) To: Matthias Aßhauer; +Cc: git, Paul Mackerras, Halil Sen, Stefan Naewe Thanks, Matthias, for the clarification. I’ll follow the discussion on GitHub. On Fri, May 6, 2022 at 2:00 PM Matthias Aßhauer <mha1993@live.de> wrote: > > > On Thu, 5 May 2022, Christian Grün wrote: > > > Resizing panels in the gitk window leads to a error message that’s > > presented multiple times in a dialog: > > > > expected integer but got "" > > expected integer but got "" > > while executing > > "$win sash place 0 $sash0 [lindex $s0 1]" > > (procedure "resizeclistpanes" line 38) > > invoked from within > > "resizeclistpanes .tf.histframe.pwclist 1834" > > (command bound to event) > > > > Is this a known bug? > > It looks like the issue at [1]. It sadly seems like nobody ever reviewed > or applied thos suggested patches, but there is some more off-list > discussion at [2]. > > > I’ll be happy to give more details. > > Best, Christian > > > > Best regards > > Matthias > > [1] https://lore.kernel.org/git/pull.1219.git.git.1645386457.gitgitgadget@gmail.com/#t > [2] https://github.com/git/git/pull/1219#issuecomment-1113122632 ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-06 12:00 ` Matthias Aßhauer 2022-05-06 12:12 ` Christian Grün @ 2022-05-06 16:23 ` Junio C Hamano 2022-05-09 12:46 ` Halil SEN 2022-05-11 8:17 ` Paul Mackerras 1 sibling, 2 replies; 14+ messages in thread From: Junio C Hamano @ 2022-05-06 16:23 UTC (permalink / raw) To: Matthias Aßhauer Cc: Christian Grün, git, Paul Mackerras, Halil Sen, Stefan Naewe Matthias Aßhauer <mha1993@live.de> writes: > It looks like the issue at [1]. It sadly seems like nobody ever > reviewed or applied thos suggested patches, but there is some more > off-list discussion at [2]. > > [1] https://lore.kernel.org/git/pull.1219.git.git.1645386457.gitgitgadget@gmail.com/#t > [2] https://github.com/git/git/pull/1219#issuecomment-1113122632 Thanks for a pointer. I do recall seeing [1] but I do not see anything happened on the thread since then. I didn't look at it back then primarily because the patches were made against a wrong history (no, you do not want to make a gitk patch against my tree nor throw a pull request at my repository), and there was no way for me to pick it up. As Documentation/SubmittingPatches says: Some parts of the system have dedicated maintainers with their own repositories. ... Patches to these parts should be based on their trees. Having said that, gitk has been quiescent for quite a while, and I wonder if Paul's been too busy for (or no longer interested in) maintaining it and perhaps he can use a replacement maintainer? ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-06 16:23 ` Junio C Hamano @ 2022-05-09 12:46 ` Halil SEN 2022-05-09 17:11 ` Junio C Hamano 2022-05-11 8:17 ` Paul Mackerras 1 sibling, 1 reply; 14+ messages in thread From: Halil SEN @ 2022-05-09 12:46 UTC (permalink / raw) To: Junio C Hamano Cc: Matthias Aßhauer, Christian Grün, git, Paul Mackerras, Stefan Naewe Junio C Hamano, <gitster@pobox.com> wrote: > I didn't look at it back then primarily because > the patches were made against a wrong history I remember looking for Paul's repository but I failed to find it so created the patch against the main git repo. Maybe I should have mentioned this in my message since I knew the documentation included that note. I am happy to rebase my patch if someone could point me in the right direction. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-09 12:46 ` Halil SEN @ 2022-05-09 17:11 ` Junio C Hamano 2022-05-11 8:20 ` Paul Mackerras [not found] ` <CAOeUTusOW1=cDKNhrBCzdzfbVLmY_qb7yg114ukRfy904S34uA@mail.gmail.com> 0 siblings, 2 replies; 14+ messages in thread From: Junio C Hamano @ 2022-05-09 17:11 UTC (permalink / raw) To: Halil SEN Cc: Matthias Aßhauer, Christian Grün, git, Paul Mackerras, Stefan Naewe Halil SEN <halilsen@gmail.com> writes: > Junio C Hamano, <gitster@pobox.com> wrote: >> I didn't look at it back then primarily because >> the patches were made against a wrong history > > I remember looking for Paul's repository but I > failed to find it so created the patch against > the main git repo. Maybe I should have > mentioned this in my message since I knew > the documentation included that note. > > I am happy to rebase my patch if someone > could point me in the right direction. Thanks for giving me a chance to double-check what we have in Documentation/SubmittingPatches is not stale: - `gitk-git/` comes from Paul Mackerras's gitk project: git://ozlabs.org/~paulus/gitk I just made a fresh clone of it just to make sure. The latest commit in the repository is 6cd80496 (gitk: Resize panes correctly when reducing window size, 2020-10-03). It seems to be related to the topic you are working on? Again, I wonder if Paul's been too busy for (or no longer interested in) maintaining it and perhaps he can use a replacement maintainer? Thanks. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-09 17:11 ` Junio C Hamano @ 2022-05-11 8:20 ` Paul Mackerras 2022-05-11 15:08 ` Junio C Hamano [not found] ` <CAOeUTusOW1=cDKNhrBCzdzfbVLmY_qb7yg114ukRfy904S34uA@mail.gmail.com> 1 sibling, 1 reply; 14+ messages in thread From: Paul Mackerras @ 2022-05-11 8:20 UTC (permalink / raw) To: Junio C Hamano Cc: Halil SEN, Matthias Aßhauer, Christian Grün, git, Stefan Naewe On Mon, May 09, 2022 at 10:11:06AM -0700, Junio C Hamano wrote: > Halil SEN <halilsen@gmail.com> writes: > > > Junio C Hamano, <gitster@pobox.com> wrote: > >> I didn't look at it back then primarily because > >> the patches were made against a wrong history > > > > I remember looking for Paul's repository but I > > failed to find it so created the patch against > > the main git repo. Maybe I should have > > mentioned this in my message since I knew > > the documentation included that note. > > > > I am happy to rebase my patch if someone > > could point me in the right direction. > > Thanks for giving me a chance to double-check what we have in > Documentation/SubmittingPatches is not stale: > > - `gitk-git/` comes from Paul Mackerras's gitk project: > > git://ozlabs.org/~paulus/gitk Could you change that to git://git.ozlabs.org/~paulus/gitk please? The ozlabs.org infrastructure changes every so often, and while the plain ozlabs.org works now and is not expected to stop working, git.ozlabs.org would be a little more future-proof. Thanks, Paul. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-11 8:20 ` Paul Mackerras @ 2022-05-11 15:08 ` Junio C Hamano 0 siblings, 0 replies; 14+ messages in thread From: Junio C Hamano @ 2022-05-11 15:08 UTC (permalink / raw) To: Paul Mackerras Cc: Halil SEN, Matthias Aßhauer, Christian Grün, git, Stefan Naewe Paul Mackerras <paulus@ozlabs.org> writes: > The ozlabs.org infrastructure changes every so often, and while the > plain ozlabs.org works now and is not expected to stop working, > git.ozlabs.org would be a little more future-proof. Will do. Thanks. ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CAOeUTusOW1=cDKNhrBCzdzfbVLmY_qb7yg114ukRfy904S34uA@mail.gmail.com>]
* Re: Resizing panels in the gitk window [not found] ` <CAOeUTusOW1=cDKNhrBCzdzfbVLmY_qb7yg114ukRfy904S34uA@mail.gmail.com> @ 2022-05-11 8:21 ` Paul Mackerras 2022-05-11 15:25 ` Junio C Hamano 0 siblings, 1 reply; 14+ messages in thread From: Paul Mackerras @ 2022-05-11 8:21 UTC (permalink / raw) To: Halil SEN Cc: Junio C Hamano, Matthias Aßhauer, Christian Grün, git, Stefan Naewe On Mon, May 09, 2022 at 10:19:21PM +0200, Halil SEN wrote: > Junio C Hamano <gitster@pobox.com> writes: > > > It seems to be related to the topic you are working on? > > It indeed is related. Sorry for troubling you with the repo, I don't > remember exactly how I failed before, thanks for sharing it. > > > Again, I wonder if Paul's been too busy for (or no longer interested > > in) maintaining it and perhaps he can use a replacement maintainer? > > I guess I should rebase my patch and resubmit it nevertheless. > I'll do it within the next few days. Now that I thought about it, > I think I had trouble creating and e-mailing the patch to the mail > list and the gitgitgadget was available only for the main repo. > I shall ask for help if I fail to do so again. No need to rebase, I have manually applied your patches. Junio, could you do a pull from my repository to get them? Thanks, Paul. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-11 8:21 ` Paul Mackerras @ 2022-05-11 15:25 ` Junio C Hamano 0 siblings, 0 replies; 14+ messages in thread From: Junio C Hamano @ 2022-05-11 15:25 UTC (permalink / raw) To: Paul Mackerras Cc: Halil SEN, Matthias Aßhauer, Christian Grün, git, Stefan Naewe Paul Mackerras <paulus@ozlabs.org> writes: > Junio, could you do a pull from my repository to get them? Thanks, done. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-06 16:23 ` Junio C Hamano 2022-05-09 12:46 ` Halil SEN @ 2022-05-11 8:17 ` Paul Mackerras 1 sibling, 0 replies; 14+ messages in thread From: Paul Mackerras @ 2022-05-11 8:17 UTC (permalink / raw) To: Junio C Hamano Cc: Matthias Aßhauer, Christian Grün, git, Halil Sen, Stefan Naewe On Fri, May 06, 2022 at 09:23:27AM -0700, Junio C Hamano wrote: > Matthias Aßhauer <mha1993@live.de> writes: > > > It looks like the issue at [1]. It sadly seems like nobody ever > > reviewed or applied thos suggested patches, but there is some more > > off-list discussion at [2]. > > > > [1] https://lore.kernel.org/git/pull.1219.git.git.1645386457.gitgitgadget@gmail.com/#t > > [2] https://github.com/git/git/pull/1219#issuecomment-1113122632 > > Thanks for a pointer. > > I do recall seeing [1] but I do not see anything happened on the > thread since then. I didn't look at it back then primarily because > the patches were made against a wrong history (no, you do not want > to make a gitk patch against my tree nor throw a pull request at my > repository), and there was no way for me to pick it up. I have just picked up Halil Sen's two patches and applied them, and pushed the result out to git.ozlabs.org. > As Documentation/SubmittingPatches says: > > Some parts of the system have dedicated maintainers with their own > repositories. > ... > Patches to these parts should be based on their trees. > > Having said that, gitk has been quiescent for quite a while, and I > wonder if Paul's been too busy for (or no longer interested in) > maintaining it and perhaps he can use a replacement maintainer? I am indeed very busy and would welcome a replacement maintainer for gitk, if somebody was willing to take it up. Thanks, Paul. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window [not found] <CAP94bnOyrx6hCmWSjmejVfopUydk10ga42wJzm1M4nk_OXn9Mg@mail.gmail.com> 2022-05-05 7:06 ` Resizing panels in the gitk window Christian Grün @ 2022-05-06 7:46 ` Christian Grün 2022-05-06 8:32 ` AW: " stefan.naewe 1 sibling, 1 reply; 14+ messages in thread From: Christian Grün @ 2022-05-06 7:46 UTC (permalink / raw) To: git Maybe there’s a better place to address gitk? Anyone? Thanks in advance, Christian On Thu, May 5, 2022 at 9:01 AM Christian Grün <christian.gruen@gmail.com> wrote: > > Resizing panels in the gitk window leads to a error message that’s presented multiple times in a dialog: > > expected integer but got "" > expected integer but got "" > while executing > "$win sash place 0 $sash0 [lindex $s0 1]" > (procedure "resizeclistpanes" line 38) > invoked from within > "resizeclistpanes .tf.histframe.pwclist 1834" > (command bound to event) > > Is this a known bug? > > I’ll be happy to give more details. > Best, Christian > ^ permalink raw reply [flat|nested] 14+ messages in thread
* AW: Resizing panels in the gitk window 2022-05-06 7:46 ` Christian Grün @ 2022-05-06 8:32 ` stefan.naewe 2022-05-06 9:01 ` Christian Grün 0 siblings, 1 reply; 14+ messages in thread From: stefan.naewe @ 2022-05-06 8:32 UTC (permalink / raw) To: christian.gruen, git > -----Ursprüngliche Nachricht----- > Von: Christian Grün <christian.gruen@gmail.com> > Gesendet: Freitag, 6. Mai 2022 09:46 > An: git@vger.kernel.org > Betreff: Re: Resizing panels in the gitk window > > Maybe there’s a better place to address gitk? Anyone? > Thanks in advance, Christian I think it would be a good idea to at least say on which OS you're using gitk and which version of git is installed. Regards, Stefan > > On Thu, May 5, 2022 at 9:01 AM Christian Grün <christian.gruen@gmail.com> > wrote: > > > > Resizing panels in the gitk window leads to a error message that’s presented > multiple times in a dialog: > > > > expected integer but got "" > > expected integer but got "" > > while executing > > "$win sash place 0 $sash0 [lindex $s0 1]" > > (procedure "resizeclistpanes" line 38) > > invoked from within > > "resizeclistpanes .tf.histframe.pwclist 1834" > > (command bound to event) > > > > Is this a known bug? > > > > I’ll be happy to give more details. > > Best, Christian > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Resizing panels in the gitk window 2022-05-06 8:32 ` AW: " stefan.naewe @ 2022-05-06 9:01 ` Christian Grün 0 siblings, 0 replies; 14+ messages in thread From: Christian Grün @ 2022-05-06 9:01 UTC (permalink / raw) To: stefan.naewe; +Cc: git Thanks, Stefan. I use Windows 10 Pro (latest version, 10.0.19044 Build 19044) and git version 2.36.0.windows.1. On Fri, May 6, 2022 at 10:32 AM <stefan.naewe@atlas-elektronik.com> wrote: > > > > > -----Ursprüngliche Nachricht----- > > Von: Christian Grün <christian.gruen@gmail.com> > > Gesendet: Freitag, 6. Mai 2022 09:46 > > An: git@vger.kernel.org > > Betreff: Re: Resizing panels in the gitk window > > > > Maybe there’s a better place to address gitk? Anyone? > > Thanks in advance, Christian > > I think it would be a good idea to at least say on which OS you're using gitk > and which version of git is installed. > > Regards, > Stefan > > > > > On Thu, May 5, 2022 at 9:01 AM Christian Grün <christian.gruen@gmail.com> > > wrote: > > > > > > Resizing panels in the gitk window leads to a error message that’s presented > > multiple times in a dialog: > > > > > > expected integer but got "" > > > expected integer but got "" > > > while executing > > > "$win sash place 0 $sash0 [lindex $s0 1]" > > > (procedure "resizeclistpanes" line 38) > > > invoked from within > > > "resizeclistpanes .tf.histframe.pwclist 1834" > > > (command bound to event) > > > > > > Is this a known bug? > > > > > > I’ll be happy to give more details. > > > Best, Christian > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-05-11 15:25 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CAP94bnOyrx6hCmWSjmejVfopUydk10ga42wJzm1M4nk_OXn9Mg@mail.gmail.com> 2022-05-05 7:06 ` Resizing panels in the gitk window Christian Grün 2022-05-06 12:00 ` Matthias Aßhauer 2022-05-06 12:12 ` Christian Grün 2022-05-06 16:23 ` Junio C Hamano 2022-05-09 12:46 ` Halil SEN 2022-05-09 17:11 ` Junio C Hamano 2022-05-11 8:20 ` Paul Mackerras 2022-05-11 15:08 ` Junio C Hamano [not found] ` <CAOeUTusOW1=cDKNhrBCzdzfbVLmY_qb7yg114ukRfy904S34uA@mail.gmail.com> 2022-05-11 8:21 ` Paul Mackerras 2022-05-11 15:25 ` Junio C Hamano 2022-05-11 8:17 ` Paul Mackerras 2022-05-06 7:46 ` Christian Grün 2022-05-06 8:32 ` AW: " stefan.naewe 2022-05-06 9:01 ` Christian Grün
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.