[PATCH] Revert "libubootenv: inherit uboot-config"

[PATCH] Revert "libubootenv: inherit uboot-config"

[Peter Bergin]

This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.

As there is no build dependency between libubootenv and the configuration
of u-boot there is no reason to check for UBOOT_CONFIG or UBOOT_MACHINE
by adding the class uboot-config. Revert this in order to remove useless
workaround in bsp layer (meta-freescale).

Signed-off-by: Peter Bergin <peter@berginkonsult.se>
---
 meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
index 2cf87c794e..306296922c 100644
--- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
@@ -15,7 +15,7 @@ SRCREV = "ba7564f5006d09bec51058cf4f5ac90d4dc18b3c"
 
 S = "${WORKDIR}/git"
 
-inherit uboot-config cmake lib_package
+inherit cmake lib_package
 
 EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
 
-- 
2.25.1

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Otavio Salvador]

Em sex., 2 de jul. de 2021 às 08:59, Peter Bergin
<peter@berginkonsult.se> escreveu:
>
> This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
>
> As there is no build dependency between libubootenv and the configuration
> of u-boot there is no reason to check for UBOOT_CONFIG or UBOOT_MACHINE
> by adding the class uboot-config. Revert this in order to remove useless
> workaround in bsp layer (meta-freescale).
>
> Signed-off-by: Peter Bergin <peter@berginkonsult.se>

Thank you; I second the revert of this for sure.

Acked-by: Otavio Salvador <otavio@ossystems.com.br>


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Anuj Mittal]

On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
> This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
> 
> As there is no build dependency between libubootenv and the
> configuration
> of u-boot there is no reason to check for UBOOT_CONFIG or UBOOT_MACHINE
> by adding the class uboot-config. Revert this in order to remove
> useless
> workaround in bsp layer (meta-freescale).

This was added to address failures in world builds:

https://lists.openembedded.org/g/openembedded-core/message/141757

If this is not required, then I think we'd need to address those
failures.

Thanks,

Anuj

> 
> Signed-off-by: Peter Bergin <peter@berginkonsult.se>
> ---
>  meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> index 2cf87c794e..306296922c 100644
> --- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> @@ -15,7 +15,7 @@ SRCREV = "ba7564f5006d09bec51058cf4f5ac90d4dc18b3c"
>  
>  S = "${WORKDIR}/git"
>  
> -inherit uboot-config cmake lib_package
> +inherit cmake lib_package
>  
>  EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
>  
> 
> 
> 

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Peter Bergin]

On 2021-07-03 16:55, Mittal, Anuj wrote:
> On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
>> This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
>>
>> As there is no build dependency between libubootenv and the
>> configuration
>> of u-boot there is no reason to check for UBOOT_CONFIG or UBOOT_MACHINE
>> by adding the class uboot-config. Revert this in order to remove
>> useless
>> workaround in bsp layer (meta-freescale).
> This was added to address failures in world builds:
>
> https://lists.openembedded.org/g/openembedded-core/message/141757
>
> If this is not required, then I think we'd need to address those
> failures.

Thanks for the pointer about the reason for this patch. I searched a bit 
but could not find it.

Can you please help me define 'world builds'?

By reading the mail thread my thoughts are that the obvious thing is 
that the build has a bad configuration as u-boot is skipped. This should 
be the thing to solve.

Do we have other examples in oe-core where we have a RRECOMMENDS and a 
requirement that another package is built. Isn't RDEPENDS used for that 
case?

Best regards,
/Peter

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Richard Purdie]

On Sun, 2021-07-04 at 10:59 +0200, Peter Bergin wrote:
> On 2021-07-03 16:55, Mittal, Anuj wrote:
> > On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
> > > This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
> > > 
> > > As there is no build dependency between libubootenv and the
> > > configuration
> > > of u-boot there is no reason to check for UBOOT_CONFIG or UBOOT_MACHINE
> > > by adding the class uboot-config. Revert this in order to remove
> > > useless
> > > workaround in bsp layer (meta-freescale).
> > This was added to address failures in world builds:
> > 
> > https://lists.openembedded.org/g/openembedded-core/message/141757
> > 
> > If this is not required, then I think we'd need to address those
> > failures.
> 
> Thanks for the pointer about the reason for this patch. I searched a bit 
> but could not find it.
> 
> Can you please help me define 'world builds'?

"bitbake world"

i.e. build everything

> By reading the mail thread my thoughts are that the obvious thing is 
> that the build has a bad configuration as u-boot is skipped. This should 
> be the thing to solve.

Not every MACHINE will support u-boot or have a configuration for it.

> Do we have other examples in oe-core where we have a RRECOMMENDS and a 
> requirement that another package is built. Isn't RDEPENDS used for that 
> case?

RDEPENDS is a hard requirement, RRECOMMENDS is a "soft" one. Bitbake
treats them the same in the sense it will always follow them, the destinction
is left to the package manager at the root filesystem creation time.

Cheers,

Richard

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Anuj Mittal]

Hi Peter,

On Sun, 2021-07-04 at 10:21 +0100, Richard Purdie wrote:
> On Sun, 2021-07-04 at 10:59 +0200, Peter Bergin wrote:
> > On 2021-07-03 16:55, Mittal, Anuj wrote:
> > > On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
> > > > This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
> > > > 
> > > > As there is no build dependency between libubootenv and the
> > > > configuration
> > > > of u-boot there is no reason to check for UBOOT_CONFIG or
> > > > UBOOT_MACHINE
> > > > by adding the class uboot-config. Revert this in order to
> > > > remove
> > > > useless
> > > > workaround in bsp layer (meta-freescale).
> > > This was added to address failures in world builds:
> > > 
> > > https://lists.openembedded.org/g/openembedded-core/message/141757
> > > 
> > > If this is not required, then I think we'd need to address those
> > > failures.
> > 
> > Thanks for the pointer about the reason for this patch. I searched
> > a bit 
> > but could not find it.
> > 
> > Can you please help me define 'world builds'?
> 
> "bitbake world"
> 
> i.e. build everything
> 
> > By reading the mail thread my thoughts are that the obvious thing
> > is 
> > that the build has a bad configuration as u-boot is skipped. This
> > should 
> > be the thing to solve.
> 
> Not every MACHINE will support u-boot or have a configuration for it.

Do you have a fix for this? This patch was applied and now the world
builds for MACHINEs not supporting u-boot are failing. Do you mind if I
send a revert of your patch?

Thanks,

Anuj

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Richard Purdie]

On Tue, 2021-07-06 at 02:44 +0000, Mittal, Anuj wrote:
> Hi Peter,
> 
> On Sun, 2021-07-04 at 10:21 +0100, Richard Purdie wrote:
> > On Sun, 2021-07-04 at 10:59 +0200, Peter Bergin wrote:
> > > On 2021-07-03 16:55, Mittal, Anuj wrote:
> > > > On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
> > > > > This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
> > > > > 
> > > > > As there is no build dependency between libubootenv and the
> > > > > configuration
> > > > > of u-boot there is no reason to check for UBOOT_CONFIG or
> > > > > UBOOT_MACHINE
> > > > > by adding the class uboot-config. Revert this in order to
> > > > > remove
> > > > > useless
> > > > > workaround in bsp layer (meta-freescale).
> > > > This was added to address failures in world builds:
> > > > 
> > > > https://lists.openembedded.org/g/openembedded-core/message/141757
> > > > 
> > > > If this is not required, then I think we'd need to address those
> > > > failures.
> > > 
> > > Thanks for the pointer about the reason for this patch. I searched
> > > a bit 
> > > but could not find it.
> > > 
> > > Can you please help me define 'world builds'?
> > 
> > "bitbake world"
> > 
> > i.e. build everything
> > 
> > > By reading the mail thread my thoughts are that the obvious thing
> > > is 
> > > that the build has a bad configuration as u-boot is skipped. This
> > > should 
> > > be the thing to solve.
> > 
> > Not every MACHINE will support u-boot or have a configuration for it.
> 
> Do you have a fix for this? This patch was applied and now the world
> builds for MACHINEs not supporting u-boot are failing. Do you mind if I
> send a revert of your patch?

I agree with reverting it FWIW.

Cheers,

Richard

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 2153 bytes --]

Em ter., 6 de jul. de 2021 às 10:04, Richard Purdie <
richard.purdie@linuxfoundation.org> escreveu:

> On Tue, 2021-07-06 at 02:44 +0000, Mittal, Anuj wrote:
> > Hi Peter,
> >
> > On Sun, 2021-07-04 at 10:21 +0100, Richard Purdie wrote:
> > > On Sun, 2021-07-04 at 10:59 +0200, Peter Bergin wrote:
> > > > On 2021-07-03 16:55, Mittal, Anuj wrote:
> > > > > On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
> > > > > > This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
> > > > > >
> > > > > > As there is no build dependency between libubootenv and the
> > > > > > configuration
> > > > > > of u-boot there is no reason to check for UBOOT_CONFIG or
> > > > > > UBOOT_MACHINE
> > > > > > by adding the class uboot-config. Revert this in order to
> > > > > > remove
> > > > > > useless
> > > > > > workaround in bsp layer (meta-freescale).
> > > > > This was added to address failures in world builds:
> > > > >
> > > > > https://lists.openembedded.org/g/openembedded-core/message/141757
> > > > >
> > > > > If this is not required, then I think we'd need to address those
> > > > > failures.
> > > >
> > > > Thanks for the pointer about the reason for this patch. I searched
> > > > a bit
> > > > but could not find it.
> > > >
> > > > Can you please help me define 'world builds'?
> > >
> > > "bitbake world"
> > >
> > > i.e. build everything
> > >
> > > > By reading the mail thread my thoughts are that the obvious thing
> > > > is
> > > > that the build has a bad configuration as u-boot is skipped. This
> > > > should
> > > > be the thing to solve.
> > >
> > > Not every MACHINE will support u-boot or have a configuration for it.
> >
> > Do you have a fix for this? This patch was applied and now the world
> > builds for MACHINEs not supporting u-boot are failing. Do you mind if I
> > send a revert of your patch?
>
> I agree with reverting it FWIW.
>

Is there a log somewhere?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[-- Attachment #2: Type: text/html, Size: 3345 bytes --]

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Peter Bergin]

Hi,

On 2021-07-06 04:44, Anuj Mittal wrote:
> Hi Peter,
>
> On Sun, 2021-07-04 at 10:21 +0100, Richard Purdie wrote:
>> On Sun, 2021-07-04 at 10:59 +0200, Peter Bergin wrote:
>>> On 2021-07-03 16:55, Mittal, Anuj wrote:
>>>> On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
>>>>> This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
>>>>>
>>>>> As there is no build dependency between libubootenv and the
>>>>> configuration
>>>>> of u-boot there is no reason to check for UBOOT_CONFIG or
>>>>> UBOOT_MACHINE
>>>>> by adding the class uboot-config. Revert this in order to
>>>>> remove
>>>>> useless
>>>>> workaround in bsp layer (meta-freescale).
>>>> This was added to address failures in world builds:
>>>>
>>>> https://lists.openembedded.org/g/openembedded-core/message/141757
>>>>
>>>> If this is not required, then I think we'd need to address those
>>>> failures.
>>> Thanks for the pointer about the reason for this patch. I searched
>>> a bit
>>> but could not find it.
>>>
>>> Can you please help me define 'world builds'?
>> "bitbake world"
>>
>> i.e. build everything
>>
>>> By reading the mail thread my thoughts are that the obvious thing
>>> is
>>> that the build has a bad configuration as u-boot is skipped. This
>>> should
>>> be the thing to solve.
>> Not every MACHINE will support u-boot or have a configuration for it.
> Do you have a fix for this? This patch was applied and now the world
> builds for MACHINEs not supporting u-boot are failing. Do you mind if I
> send a revert of your patch?
>

I don't mind but I think it is the wrong thing to do, at least without 
analyzing the failing builds and get to the root of the problem.

My view on this, correct me if I'm wrong here. If you just want to build 
libubootenv you should be able to do it for any machine, with or without 
u-boot support as there is no build dependency between libubootenv and 
u-boot. If you have libubootenv in your image there will be a 
RRECOMMENDS to u-boot-env and in that case you must have 
NO_RECOMMENDATION=0 or a valid u-boot configuration. If the world build 
is failing I guess there is a configuration for a target without u-boot 
that includes libubootenv in an image. Or what is the exact failure? Can 
you send a reference with a log to the failing build?

/Peter

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Peter Bergin]

Hi again,

sorry for the noise but did some investigations and was able to 
reproduce....

On 2021-07-06 15:42, Peter Bergin wrote:
> Hi,
>
> On 2021-07-06 04:44, Anuj Mittal wrote:
>> Hi Peter,
>>
>> On Sun, 2021-07-04 at 10:21 +0100, Richard Purdie wrote:
>>> On Sun, 2021-07-04 at 10:59 +0200, Peter Bergin wrote:
>>>> On 2021-07-03 16:55, Mittal, Anuj wrote:
>>>>> On Fri, 2021-07-02 at 13:59 +0200, Peter Bergin wrote:
>>>>>> This reverts commit 10aa1291979fb90bed1beb49be4d406ed0e1e4d5.
>>>>>>
>>>>>> As there is no build dependency between libubootenv and the
>>>>>> configuration
>>>>>> of u-boot there is no reason to check for UBOOT_CONFIG or
>>>>>> UBOOT_MACHINE
>>>>>> by adding the class uboot-config. Revert this in order to
>>>>>> remove
>>>>>> useless
>>>>>> workaround in bsp layer (meta-freescale).
>>>>> This was added to address failures in world builds:
>>>>>
>>>>> https://lists.openembedded.org/g/openembedded-core/message/141757
>>>>>
>>>>> If this is not required, then I think we'd need to address those
>>>>> failures.
>>>> Thanks for the pointer about the reason for this patch. I searched
>>>> a bit
>>>> but could not find it.
>>>>
>>>> Can you please help me define 'world builds'?
>>> "bitbake world"
>>>
>>> i.e. build everything
>>>
>>>> By reading the mail thread my thoughts are that the obvious thing
>>>> is
>>>> that the build has a bad configuration as u-boot is skipped. This
>>>> should
>>>> be the thing to solve.
>>> Not every MACHINE will support u-boot or have a configuration for it.
>> Do you have a fix for this? This patch was applied and now the world
>> builds for MACHINEs not supporting u-boot are failing. Do you mind if I
>> send a revert of your patch?
>>
>
> I don't mind but I think it is the wrong thing to do, at least without 
> analyzing the failing builds and get to the root of the problem.
>
> My view on this, correct me if I'm wrong here. If you just want to 
> build libubootenv you should be able to do it for any machine, with or 
> without u-boot support as there is no build dependency between 
> libubootenv and u-boot. If you have libubootenv in your image there 
> will be a RRECOMMENDS to u-boot-env and in that case you must have 
> NO_RECOMMENDATION=0 or a valid u-boot configuration. If the world 
> build is failing I guess there is a configuration for a target without 
> u-boot that includes libubootenv in an image. Or what is the exact 
> failure? Can you send a reference with a log to the failing build?
>
> /Peter
>
>
>
     $ bitbake libubootenv
     Loading cache: 100% 
|######################################################################################################| 
     Time: 0:00:00
     Loaded 3462 entries from dependency cache.
     NOTE: Resolving any missing task queue dependencies
     ERROR: Nothing RPROVIDES 'u-boot-default-env' (but 
meta/recipes-bsp/u-boot/libubootenv_0.3.1.bb RDEPENDS on or otherwise 
requires it)
     NOTE: Runtime target 'u-boot-default-env' is unbuildable, removing...
     Missing or unbuildable dependency chain was: ['u-boot-default-env']
     ERROR: Required build target 'libubootenv' has no buildable providers.
     Missing or unbuildable dependency chain was: ['libubootenv', 
'u-boot-default-env']

     Summary: There was 1 WARNING message shown.
     Summary: There were 2 ERROR messages shown, returning a non-zero 
exit code.

The setup above was to use a machine from (meta-intel) with grub as 
bootloader.

Then I can correct my earlier statement and a new wisdom that run-time 
dependecies are scanned already in the early phases. Apparently it is 
not possible to build libubootenv due to RRECOMMENDS to 
u-boot-default-env. The build for a 'non-u-boot config' will fail if we 
add 'inherit uboot-config' and it will fail without. What is the 
difference for a 'world' build?

/Peter

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

Em ter., 6 de jul. de 2021 às 12:12, Peter Bergin <peter@berginkonsult.se>
escreveu:

> Then I can correct my earlier statement and a new wisdom that run-time
> dependecies are scanned already in the early phases. Apparently it is
> not possible to build libubootenv due to RRECOMMENDS to
> u-boot-default-env. The build for a 'non-u-boot config' will fail if we
> add 'inherit uboot-config' and it will fail without. What is the
> difference for a 'world' build?
>

The dependency on the default-env seems too strong. It could be relaxed as
it works without it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[-- Attachment #2: Type: text/html, Size: 1343 bytes --]

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Peter Bergin]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Hi Otavio,

On 2021-07-06 18:56, Otavio Salvador wrote:
>
>
> Em ter., 6 de jul. de 2021 às 12:12, Peter Bergin 
> <peter@berginkonsult.se <mailto:peter@berginkonsult.se>> escreveu:
>
>     Then I can correct my earlier statement and a new wisdom that
>     run-time
>     dependecies are scanned already in the early phases. Apparently it is
>     not possible to build libubootenv due to RRECOMMENDS to
>     u-boot-default-env. The build for a 'non-u-boot config' will fail
>     if we
>     add 'inherit uboot-config' and it will fail without. What is the
>     difference for a 'world' build?
>
>
> The dependency on the default-env seems too strong. It could be 
> relaxed as it works without it.
>
Do we have a run-time dependency that is 'lesser than' RRECOMMENDS? Or 
do you suggest removing the dependency?

/Peter


[-- Attachment #2: Type: text/html, Size: 1951 bytes --]

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

Em ter., 6 de jul. de 2021 às 15:39, Peter Bergin <peter@berginkonsult.se>
escreveu:

> Hi Otavio,
> On 2021-07-06 18:56, Otavio Salvador wrote:
>
>
>
> Em ter., 6 de jul. de 2021 às 12:12, Peter Bergin <peter@berginkonsult.se>
> escreveu:
>
>> Then I can correct my earlier statement and a new wisdom that run-time
>> dependecies are scanned already in the early phases. Apparently it is
>> not possible to build libubootenv due to RRECOMMENDS to
>> u-boot-default-env. The build for a 'non-u-boot config' will fail if we
>> add 'inherit uboot-config' and it will fail without. What is the
>> difference for a 'world' build?
>>
>
> The dependency on the default-env seems too strong. It could be relaxed as
> it works without it.
>
> Do we have a run-time dependency that is 'lesser than' RRECOMMENDS? Or do
> you suggest removing the dependency?
>

There is RSUGGESTS but I am unsure package managers handle it properly.
Ideally, we'd have a dummy one which would be replaced by the machine one
if available.



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[-- Attachment #2: Type: text/html, Size: 2628 bytes --]

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Ming Liu]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

@Otavio Salvador <otavio.salvador@ossystems.com.br>

libubootenv will fall back to read environment from /etc/u-boot-initial-env
if loading /etc/fw_env.config fails, so attempt to say it's not too wrong.

To avoid world build failures, maybe set EXCLUDE_FROM_WORLD = "1"?

//Ming Liu

Otavio Salvador <otavio.salvador@ossystems.com.br> 於 2021年7月6日 週二 下午6:56寫道：

>
>
> Em ter., 6 de jul. de 2021 às 12:12, Peter Bergin <peter@berginkonsult.se>
> escreveu:
>
>> Then I can correct my earlier statement and a new wisdom that run-time
>> dependecies are scanned already in the early phases. Apparently it is
>> not possible to build libubootenv due to RRECOMMENDS to
>> u-boot-default-env. The build for a 'non-u-boot config' will fail if we
>> add 'inherit uboot-config' and it will fail without. What is the
>> difference for a 'world' build?
>>
>
> The dependency on the default-env seems too strong. It could be relaxed as
> it works without it.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
>

[-- Attachment #2: Type: text/html, Size: 2179 bytes --]

Re: [OE-core] [PATCH] Revert "libubootenv: inherit uboot-config"

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Em qua., 7 de jul. de 2021 às 06:50, Ming Liu <liu.ming50@gmail.com>
escreveu:

> @Otavio Salvador <otavio.salvador@ossystems.com.br>
>
> libubootenv will fall back to read environment
> from /etc/u-boot-initial-env if loading /etc/fw_env.config fails, so
> attempt to say it's not too wrong.
>
> To avoid world build failures, maybe set EXCLUDE_FROM_WORLD = "1"?
>

If Richard accepts it, it is good enough for me.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[-- Attachment #2: Type: text/html, Size: 1321 bytes --]