[meta-browser][PATCH 1/2] firefox: remove nss private libs setting

[meta-browser][PATCH 1/2] firefox: remove nss private libs setting

[Max Krummenacher]

Commit 8cc038d uses the system's nss rather than building a private
one. So one should remove the nss libs from PRIVATE_LIBS also.
Otherwise bitbake does not add nss to RDEPENDS automatically resulting
in a potentially missing nss package in an image.
Additianlly bitbake shows the following warning:

| WARNING: firefox-45.6.0esr-r0 do_package_qa: QA Issue: /usr/lib/firefox/libxul.so
|   contained in package firefox requires libnss3.so(NSS_3.12),
|   but no providers found in RDEPENDS_firefox? [file-rdeps]

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 recipes-mozilla/firefox/firefox_45.6.0esr.bb | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/recipes-mozilla/firefox/firefox_45.6.0esr.bb b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
index bed50dd..31b3353 100644
--- a/recipes-mozilla/firefox/firefox_45.6.0esr.bb
+++ b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
@@ -95,15 +95,3 @@ PRIVATE_LIBS = "libmozjs.so \
                 libmozsqlite3.so \
                 libbrowsercomps.so \
                 libclearkey.so"
-
-# mark libraries also provided by nss as private too
-PRIVATE_LIBS += " \
-    libfreebl3.so \
-    libnss3.so \
-    libnssckbi.so \
-    libsmime3.so \
-    libnssutil3.so \
-    libnssdbm3.so \
-    libssl3.so \
-    libsoftokn3.so \
-"
-- 
2.6.6

[meta-browser][PATCH 2/2] README: add -s to git send-email example

[Max Krummenacher]

Prevent missing Signed-off-by lines.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README b/README
index 647404b..effe2f9 100644
--- a/README
+++ b/README
@@ -26,7 +26,7 @@ Maintainers: Eric Bénard <eric@eukrea.com>
              Otavio Salvador <otavio@ossystems.com.br>
 
 When sending single patches, please use something like :
-git send-email -1 --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
+git send-email -1 -s --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
 
 TODO
 ----
-- 
2.6.6

Re: [meta-browser][PATCH 1/2] firefox: remove nss private libs setting

[Max Krummenacher]

ping

Any comments on this one?

Max


2017-01-17 0:09 GMT+01:00 Max Krummenacher <max.oss.09@gmail.com>:
> Commit 8cc038d uses the system's nss rather than building a private
> one. So one should remove the nss libs from PRIVATE_LIBS also.
> Otherwise bitbake does not add nss to RDEPENDS automatically resulting
> in a potentially missing nss package in an image.
> Additianlly bitbake shows the following warning:
>
> | WARNING: firefox-45.6.0esr-r0 do_package_qa: QA Issue: /usr/lib/firefox/libxul.so
> |   contained in package firefox requires libnss3.so(NSS_3.12),
> |   but no providers found in RDEPENDS_firefox? [file-rdeps]
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> ---
>  recipes-mozilla/firefox/firefox_45.6.0esr.bb | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/recipes-mozilla/firefox/firefox_45.6.0esr.bb b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
> index bed50dd..31b3353 100644
> --- a/recipes-mozilla/firefox/firefox_45.6.0esr.bb
> +++ b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
> @@ -95,15 +95,3 @@ PRIVATE_LIBS = "libmozjs.so \
>                  libmozsqlite3.so \
>                  libbrowsercomps.so \
>                  libclearkey.so"
> -
> -# mark libraries also provided by nss as private too
> -PRIVATE_LIBS += " \
> -    libfreebl3.so \
> -    libnss3.so \
> -    libnssckbi.so \
> -    libsmime3.so \
> -    libnssutil3.so \
> -    libnssdbm3.so \
> -    libssl3.so \
> -    libsoftokn3.so \
> -"
> --
> 2.6.6
>

Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example

[Max Krummenacher]

ping

Any comments on this one?

Max

2017-01-17 0:09 GMT+01:00 Max Krummenacher <max.oss.09@gmail.com>:
> Prevent missing Signed-off-by lines.
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README b/README
> index 647404b..effe2f9 100644
> --- a/README
> +++ b/README
> @@ -26,7 +26,7 @@ Maintainers: Eric Bénard <eric@eukrea.com>
>               Otavio Salvador <otavio@ossystems.com.br>
>
>  When sending single patches, please use something like :
> -git send-email -1 --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
> +git send-email -1 -s --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
>
>  TODO
>  ----
> --
> 2.6.6
>

Re: [meta-browser][PATCH 1/2] firefox: remove nss private libs setting

[Khem Raj]

this is ok to install.

On 1/26/17 2:27 PM, Max Krummenacher wrote:
> ping
> 
> Any comments on this one?
> 
> Max
> 
> 
> 2017-01-17 0:09 GMT+01:00 Max Krummenacher <max.oss.09@gmail.com>:
>> Commit 8cc038d uses the system's nss rather than building a private
>> one. So one should remove the nss libs from PRIVATE_LIBS also.
>> Otherwise bitbake does not add nss to RDEPENDS automatically resulting
>> in a potentially missing nss package in an image.
>> Additianlly bitbake shows the following warning:
>>
>> | WARNING: firefox-45.6.0esr-r0 do_package_qa: QA Issue: /usr/lib/firefox/libxul.so
>> |   contained in package firefox requires libnss3.so(NSS_3.12),
>> |   but no providers found in RDEPENDS_firefox? [file-rdeps]
>>
>> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>> ---
>>  recipes-mozilla/firefox/firefox_45.6.0esr.bb | 12 ------------
>>  1 file changed, 12 deletions(-)
>>
>> diff --git a/recipes-mozilla/firefox/firefox_45.6.0esr.bb b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
>> index bed50dd..31b3353 100644
>> --- a/recipes-mozilla/firefox/firefox_45.6.0esr.bb
>> +++ b/recipes-mozilla/firefox/firefox_45.6.0esr.bb
>> @@ -95,15 +95,3 @@ PRIVATE_LIBS = "libmozjs.so \
>>                  libmozsqlite3.so \
>>                  libbrowsercomps.so \
>>                  libclearkey.so"
>> -
>> -# mark libraries also provided by nss as private too
>> -PRIVATE_LIBS += " \
>> -    libfreebl3.so \
>> -    libnss3.so \
>> -    libnssckbi.so \
>> -    libsmime3.so \
>> -    libnssutil3.so \
>> -    libnssdbm3.so \
>> -    libssl3.so \
>> -    libsoftokn3.so \
>> -"
>> --
>> 2.6.6
>>

Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example

[Khem Raj]

what happens if commits are already having a sign-off ?

On 1/26/17 2:27 PM, Max Krummenacher wrote:
> ping
> 
> Any comments on this one?
> 
> Max
> 
> 2017-01-17 0:09 GMT+01:00 Max Krummenacher <max.oss.09@gmail.com>:
>> Prevent missing Signed-off-by lines.
>>
>> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>> ---
>>  README | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/README b/README
>> index 647404b..effe2f9 100644
>> --- a/README
>> +++ b/README
>> @@ -26,7 +26,7 @@ Maintainers: Eric Bénard <eric@eukrea.com>
>>               Otavio Salvador <otavio@ossystems.com.br>
>>
>>  When sending single patches, please use something like :
>> -git send-email -1 --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
>> +git send-email -1 -s --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
>>
>>  TODO
>>  ----
>> --
>> 2.6.6
>>

Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example

[Otavio Salvador]

On Thu, Jan 26, 2017 at 11:03 PM, Khem Raj <raj.khem@gmail.com> wrote:
> what happens if commits are already having a sign-off ?

A new one is added.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example

[Anders Darander]

* Otavio Salvador <otavio.salvador@ossystems.com.br> [170127 11:12]:

> On Thu, Jan 26, 2017 at 11:03 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > what happens if commits are already having a sign-off ?

> A new one is added.

Then I don't think this change should be made.

Cheers,
Anders

-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB

Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example

[Max Krummenacher]

Am Freitag, den 27.01.2017, 11:28 +0100 schrieb Anders Darander:
> * Otavio Salvador <otavio.salvador@ossystems.com.br> [170127 11:12]:
> 
> > On Thu, Jan 26, 2017 at 11:03 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > > what happens if commits are already having a sign-off ?
> 
> > A new one is added.
> 
> Then I don't think this change should be made.

I tested it. That depends on who did the sign-off.

You end up with two sign-off lines only if the are not identical, e.g. the committer and submitter
are different.

I went now through the READMEs of all installed layers and about half of them propose the '-s' while
the other half does not.
So I guess we should drop this patch.

Max

> 
> Cheers,
> Anders
> 
> -- 
> Anders Darander, Senior System Architect
> ChargeStorm AB / eStorm AB

Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example

[Otavio Salvador]

On Fri, Jan 27, 2017 at 9:15 AM, Max Krummenacher <max.oss.09@gmail.com> wrote:
> Am Freitag, den 27.01.2017, 11:28 +0100 schrieb Anders Darander:
>> * Otavio Salvador <otavio.salvador@ossystems.com.br> [170127 11:12]:
>>
>> > On Thu, Jan 26, 2017 at 11:03 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> > > what happens if commits are already having a sign-off ?
>>
>> > A new one is added.
>>
>> Then I don't think this change should be made.
>
> I tested it. That depends on who did the sign-off.
>
> You end up with two sign-off lines only if the are not identical, e.g. the committer and submitter
> are different.
>
> I went now through the READMEs of all installed layers and about half of them propose the '-s' while
> the other half does not.
> So I guess we should drop this patch.

I prefer if we adopt it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-browser][PATCH 2/2] README: add -s to git send-email example

[Khem Raj]

On 1/27/17 3:55 AM, Otavio Salvador wrote:
> On Fri, Jan 27, 2017 at 9:15 AM, Max Krummenacher <max.oss.09@gmail.com> wrote:
>> Am Freitag, den 27.01.2017, 11:28 +0100 schrieb Anders Darander:
>>> * Otavio Salvador <otavio.salvador@ossystems.com.br> [170127 11:12]:
>>>
>>>> On Thu, Jan 26, 2017 at 11:03 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>>>> what happens if commits are already having a sign-off ?
>>>
>>>> A new one is added.
>>>
>>> Then I don't think this change should be made.
>>
>> I tested it. That depends on who did the sign-off.
>>
>> You end up with two sign-off lines only if the are not identical, e.g. the committer and submitter
>> are different.
>>
>> I went now through the READMEs of all installed layers and about half of them propose the '-s' while
>> the other half does not.
>> So I guess we should drop this patch.
> 
> I prefer if we adopt it.
> 

I think, its better to suggest to do git commit with -s instead.