[PATCH] qemu.inc: Drop rng-tools

[PATCH] qemu.inc: Drop rng-tools

[Richard Purdie]

This was included to allow hwrng to feed data to /dev/random. Since the
kernel does this itself (confirmed by the recent kernel Kconfig text change
, code inspection and local testing), we can drop rng-tools from these
images.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/conf/machine/include/qemu.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
index 0e4103b..9094279 100644
--- a/meta/conf/machine/include/qemu.inc
+++ b/meta/conf/machine/include/qemu.inc
@@ -26,6 +26,4 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
 
-MACHINE_EXTRA_RRECOMMENDS += "rng-tools"
-
 IMAGE_CLASSES += "qemuboot"
-- 
2.7.4

Re: [PATCH] qemu.inc: Drop rng-tools

[Otavio Salvador]

On Mon, Nov 13, 2017 at 3:35 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> This was included to allow hwrng to feed data to /dev/random. Since the
> kernel does this itself (confirmed by the recent kernel Kconfig text change
> , code inspection and local testing), we can drop rng-tools from these
> images.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

This is still needed for QEMU ARM.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] qemu.inc: Drop rng-tools

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

Can you explain why?

Ross

On 13 November 2017 at 19:30, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> On Mon, Nov 13, 2017 at 3:35 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > This was included to allow hwrng to feed data to /dev/random. Since the
> > kernel does this itself (confirmed by the recent kernel Kconfig text
> change
> > , code inspection and local testing), we can drop rng-tools from these
> > images.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> This is still needed for QEMU ARM.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2144 bytes --]

Re: [PATCH] qemu.inc: Drop rng-tools

[Otavio Salvador]

Hello Ross,

On Mon, Nov 13, 2017 at 5:55 PM, Burton, Ross <ross.burton@intel.com> wrote:
> Can you explain why?

We are using QEMU ARM for runtime tests on CI for updatehub, on this,
when we run something that required entropy just after boot and
especially if running inside of a Docker, it fails badly for 140s.
Adding rng-tools solves it :-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] qemu.inc: Drop rng-tools

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

On 14 November 2017 at 17:16, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> Hello Ross,
>
> On Mon, Nov 13, 2017 at 5:55 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
> > Can you explain why?
>
> We are using QEMU ARM for runtime tests on CI for updatehub, on this,
> when we run something that required entropy just after boot and
> especially if running inside of a Docker, it fails badly for 140s.
> Adding rng-tools solves it :-)


Are you enabling the virtio-rng driver so qemu can bridge the host entropy
into the guest?

Ross

[-- Attachment #2: Type: text/html, Size: 973 bytes --]

Re: [PATCH] qemu.inc: Drop rng-tools

[Otavio Salvador]

On Wed, Nov 15, 2017 at 10:26 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 14 November 2017 at 17:16, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> Hello Ross,
>>
>> On Mon, Nov 13, 2017 at 5:55 PM, Burton, Ross <ross.burton@intel.com>
>> wrote:
>> > Can you explain why?
>>
>> We are using QEMU ARM for runtime tests on CI for updatehub, on this,
>> when we run something that required entropy just after boot and
>> especially if running inside of a Docker, it fails badly for 140s.
>> Adding rng-tools solves it :-)
>
>
> Are you enabling the virtio-rng driver so qemu can bridge the host entropy
> into the guest?

I am not. Do you have an example of command line for it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] qemu.inc: Drop rng-tools

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On 15 November 2017 at 19:59, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> > Are you enabling the virtio-rng driver so qemu can bridge the host
> entropy
> > into the guest?
>
> I am not. Do you have an example of command line for it?


 https://wiki.qemu.org/Features/VirtIORNG talks about qemu's support and
what to turn on there (the default qemu machines enable that).

http://elixir.free-electrons.com/linux/latest/source/drivers/char/hw_random/Kconfig
documents HW_RANDOM_VIRTIO and says at the top that the devices feed into
the kernel pool.

Ross

[-- Attachment #2: Type: text/html, Size: 1230 bytes --]

Re: [PATCH] qemu.inc: Drop rng-tools

[Richard Purdie]

On Thu, 2017-11-16 at 13:11 +0000, Burton, Ross wrote:
> On 15 November 2017 at 19:59, Otavio Salvador <otavio.salvador@ossyst
> ems.com.br> wrote:
> > > Are you enabling the virtio-rng driver so qemu can bridge the
> > host entropy
> > > into the guest?
> > 
> > I am not. Do you have an example of command line for it?
>  https://wiki.qemu.org/Features/VirtIORNG talks about qemu's support
> and what to turn on there (the default qemu machines enable that).
> 
> http://elixir.free-electrons.com/linux/latest/source/drivers/char/hw_
> random/Kconfig documents HW_RANDOM_VIRTIO and says at the top that
> the devices feed into the kernel pool.

Just to add, for qemuarm:

machine/qemuarm.conf:QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet -device virtio-rng-pci"

the key piece being virtio-rng-pci on the commandline.

Cheers,

Richard

Re: [PATCH] qemu.inc: Drop rng-tools

[Otavio Salvador]

Hello Richard,
Hello Ross,

On Thu, Nov 16, 2017 at 11:14 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Thu, 2017-11-16 at 13:11 +0000, Burton, Ross wrote:
>> On 15 November 2017 at 19:59, Otavio Salvador <otavio.salvador@ossyst
>> ems.com.br> wrote:
>> > > Are you enabling the virtio-rng driver so qemu can bridge the
>> > host entropy
>> > > into the guest?
>> >
>> > I am not. Do you have an example of command line for it?
>>  https://wiki.qemu.org/Features/VirtIORNG talks about qemu's support
>> and what to turn on there (the default qemu machines enable that).
>>
>> http://elixir.free-electrons.com/linux/latest/source/drivers/char/hw_
>> random/Kconfig documents HW_RANDOM_VIRTIO and says at the top that
>> the devices feed into the kernel pool.
>
> Just to add, for qemuarm:
>
> machine/qemuarm.conf:QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet -device virtio-rng-pci"
>
> the key piece being virtio-rng-pci on the commandline.

I did try it here. Thanks for the pointers.

We use a Docker container to run QEMU and in this environment, it does
not work well. At least I did not get it working.

I don't know if it is a problem or not for OE-Core. Possibly people
will run things inside a container and keep rng-tools makes it working
in those environments.

I will keep investigating here if I can make it work in a container ...

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] qemu.inc: Drop rng-tools

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2521 bytes --]

Hi all,

I was just hit by this issue as well, we're using VirtualBox instead of
QEmu, so of course we were missing "-device virtio-rng-pci" and I haven't
found some equivalent of this for VirtualBox.

Adding rng-tools back to our images allows to use ssh again (without
rng-tools sshd never started because ssh-keygen got stuck trying to read
/dev/random).

I don't know how many people are using VirtualBox or docker to run qemu
images built with OE, but it's probably worth mentioning in 2.6 release
notes.

Cheers,

On Thu, Nov 16, 2017 at 2:26 PM Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> Hello Richard,
> Hello Ross,
>
> On Thu, Nov 16, 2017 at 11:14 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Thu, 2017-11-16 at 13:11 +0000, Burton, Ross wrote:
> >> On 15 November 2017 at 19:59, Otavio Salvador <otavio.salvador@ossyst
> >> ems.com.br> wrote:
> >> > > Are you enabling the virtio-rng driver so qemu can bridge the
> >> > host entropy
> >> > > into the guest?
> >> >
> >> > I am not. Do you have an example of command line for it?
> >>  https://wiki.qemu.org/Features/VirtIORNG talks about qemu's support
> >> and what to turn on there (the default qemu machines enable that).
> >>
> >> http://elixir.free-electrons.com/linux/latest/source/drivers/char/hw_
> >> random/Kconfig documents HW_RANDOM_VIRTIO and says at the top that
> >> the devices feed into the kernel pool.
> >
> > Just to add, for qemuarm:
> >
> > machine/qemuarm.conf:QB_OPT_APPEND = "-show-cursor -usb -device
> usb-tablet -device virtio-rng-pci"
> >
> > the key piece being virtio-rng-pci on the commandline.
>
> I did try it here. Thanks for the pointers.
>
> We use a Docker container to run QEMU and in this environment, it does
> not work well. At least I did not get it working.
>
> I don't know if it is a problem or not for OE-Core. Possibly people
> will run things inside a container and keep rng-tools makes it working
> in those environments.
>
> I will keep investigating here if I can make it work in a container ...
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3851 bytes --]

Re: [PATCH] qemu.inc: Drop rng-tools

[Otavio Salvador]

On Thu, Nov 22, 2018 at 3:40 PM Martin Jansa <martin.jansa@gmail.com> wrote:
> I was just hit by this issue as well, we're using VirtualBox instead of QEmu, so of course we were missing "-device virtio-rng-pci" and I haven't found some equivalent of this for VirtualBox.
>
> Adding rng-tools back to our images allows to use ssh again (without rng-tools sshd never started because ssh-keygen got stuck trying to read /dev/random).
>
> I don't know how many people are using VirtualBox or docker to run qemu images built with OE, but it's probably worth mentioning in 2.6 release notes.

Agreed :-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[PATCH] qemu.inc: Drop rng-tools

[Richard Purdie]

This was included to allow hwrng to feed data to /dev/random. Since the
kernel does this itself (confirmed by the recent kernel Kconfig text change
, code inspection and local testing), we can drop rng-tools from these
images.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/conf/machine/include/qemu.inc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
index 0e4103b..eb387d0 100644
--- a/meta/conf/machine/include/qemu.inc
+++ b/meta/conf/machine/include/qemu.inc
@@ -26,6 +26,3 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
 
-MACHINE_EXTRA_RRECOMMENDS += "rng-tools"
-
-IMAGE_CLASSES += "qemuboot"
-- 
2.7.4