[PATCH] Revert "Revert "libubootenv: inherit uboot-config""

[PATCH] Revert "Revert "libubootenv: inherit uboot-config""

[Anuj Mittal]

This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.

The original change was added to resolve build errors [1] for MACHINE
values that don't have u-boot support. This recipe was, after that
change, skipped in world builds for those MACHINEs.

But we should be able to build libubootenv with or without u-boot
support [2] so the original solution to inherit uboot-config was not
perfect. But until we have a better solution, revert this so
builds don't fail for others.

[1] https://lists.openembedded.org/g/openembedded-core/message/153508
[2] https://lists.openembedded.org/g/openembedded-core/message/153614

Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
---
 meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
index 6774290ea5..cb59dd3f1d 100644
--- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
@@ -15,7 +15,7 @@ SRCREV = "ba7564f5006d09bec51058cf4f5ac90d4dc18b3c"
 
 S = "${WORKDIR}/git"
 
-inherit cmake lib_package
+inherit uboot-config cmake lib_package
 
 EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
 
-- 
2.31.1

Re: [OE-core] [PATCH] Revert "Revert "libubootenv: inherit uboot-config""

[Otavio Salvador]

I am against reverting it again. We discussed alternatives, which
could solve the problem.

Em qui., 22 de jul. de 2021 às 21:19, Anuj Mittal
<anuj.mittal@intel.com> escreveu:
>
> This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.
>
> The original change was added to resolve build errors [1] for MACHINE
> values that don't have u-boot support. This recipe was, after that
> change, skipped in world builds for those MACHINEs.
>
> But we should be able to build libubootenv with or without u-boot
> support [2] so the original solution to inherit uboot-config was not
> perfect. But until we have a better solution, revert this so
> builds don't fail for others.
>
> [1] https://lists.openembedded.org/g/openembedded-core/message/153508
> [2] https://lists.openembedded.org/g/openembedded-core/message/153614
>
> Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
> ---
>  meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> index 6774290ea5..cb59dd3f1d 100644
> --- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> @@ -15,7 +15,7 @@ SRCREV = "ba7564f5006d09bec51058cf4f5ac90d4dc18b3c"
>
>  S = "${WORKDIR}/git"
>
> -inherit cmake lib_package
> +inherit uboot-config cmake lib_package
>
>  EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
>
> --
> 2.31.1
>
>
> 
>


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

Re: [OE-core] [PATCH] Revert "Revert "libubootenv: inherit uboot-config""

[Richard Purdie]

On Fri, 2021-07-23 at 17:52 -0300, Otavio Salvador wrote:
> I am against reverting it again. We discussed alternatives, which
> could solve the problem.
> 
> Em qui., 22 de jul. de 2021 às 21:19, Anuj Mittal
> <anuj.mittal@intel.com> escreveu:
> > 
> > This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.
> > 
> > The original change was added to resolve build errors [1] for MACHINE
> > values that don't have u-boot support. This recipe was, after that
> > change, skipped in world builds for those MACHINEs.
> > 
> > But we should be able to build libubootenv with or without u-boot
> > support [2] so the original solution to inherit uboot-config was not
> > perfect. But until we have a better solution, revert this so
> > builds don't fail for others.
> > 
> > [1] https://lists.openembedded.org/g/openembedded-core/message/153508
> > [2] https://lists.openembedded.org/g/openembedded-core/message/153614
> > 

Something needs to change. Perhaps the RRECOMMENDS should just be removed
as that seems to be the cause of the problems?

Cheers,

Richard

Re: [OE-core] [PATCH] Revert "Revert "libubootenv: inherit uboot-config""

[Otavio Salvador]

Em sex., 23 de jul. de 2021 às 18:10, Richard Purdie
<richard.purdie@linuxfoundation.org> escreveu:
> On Fri, 2021-07-23 at 17:52 -0300, Otavio Salvador wrote:
> > I am against reverting it again. We discussed alternatives, which
> > could solve the problem.
> >
> > Em qui., 22 de jul. de 2021 às 21:19, Anuj Mittal
> > <anuj.mittal@intel.com> escreveu:
> > >
> > > This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.
> > >
> > > The original change was added to resolve build errors [1] for MACHINE
> > > values that don't have u-boot support. This recipe was, after that
> > > change, skipped in world builds for those MACHINEs.
> > >
> > > But we should be able to build libubootenv with or without u-boot
> > > support [2] so the original solution to inherit uboot-config was not
> > > perfect. But until we have a better solution, revert this so
> > > builds don't fail for others.
> > >
> > > [1] https://lists.openembedded.org/g/openembedded-core/message/153508
> > > [2] https://lists.openembedded.org/g/openembedded-core/message/153614
> > >
>
> Something needs to change. Perhaps the RRECOMMENDS should just be removed
> as that seems to be the cause of the problems?

I'd be fine in dropping it. This would be a better fix for sure.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750