* [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
@ 2018-12-23 20:59 ` Stefan Wahren
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Wahren @ 2018-12-23 20:59 UTC (permalink / raw)
To: Al Cooper, Adrian Hunter, Ulf Hansson
Cc: Stefan Wahren, Florian Fainelli, Scott Branden, Ray Jui,
linux-mmc, stable, Eric Anholt, bcm-kernel-feedback-list,
Gregory Fong, Brian Norris, linux-arm-kernel
We need to handle mmc_of_parse() errors during probe.
This finally fixes the wifi regression on Raspberry Pi 3 series.
In error case the wifi chip was permanently in reset because of
the power sequence depending on the deferred probe of the GPIO expander.
Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
Cc: stable@vger.kernel.org
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/mmc/host/sdhci-iproc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 0db9905..9d12c06 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -296,7 +296,10 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
iproc_host->data = iproc_data;
- mmc_of_parse(host->mmc);
+ ret = mmc_of_parse(host->mmc);
+ if (ret)
+ goto err;
+
sdhci_get_property(pdev);
host->mmc->caps |= iproc_host->data->mmc_caps;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/2] mmc: sdhci-brcmstb: handle mmc_of_parse() errors during probe
2018-12-23 20:59 ` Stefan Wahren
@ 2018-12-23 20:59 ` Stefan Wahren
-1 siblings, 0 replies; 16+ messages in thread
From: Stefan Wahren @ 2018-12-23 20:59 UTC (permalink / raw)
To: Al Cooper, Adrian Hunter, Ulf Hansson
Cc: Stefan Wahren, Florian Fainelli, Scott Branden, Ray Jui,
linux-mmc, Eric Anholt, bcm-kernel-feedback-list, Gregory Fong,
Brian Norris, linux-arm-kernel
We need to handle mmc_of_parse() errors during probe otherwise the
MMC driver could start without proper initialization (e.g. power sequence).
Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
Hi,
since i don't have this hardware, so it is only compile tested.
Would be nice to get a Tested-by.
Regards
Stefan
drivers/mmc/host/sdhci-brcmstb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index 552bddc..1cd1035 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
}
sdhci_get_of_property(pdev);
- mmc_of_parse(host->mmc);
+ res = mmc_of_parse(host->mmc);
+ if (res)
+ goto err;
/*
* Supply the existing CAPS, but clear the UHS modes. This
--
2.7.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/2] mmc: sdhci-brcmstb: handle mmc_of_parse() errors during probe
@ 2018-12-23 20:59 ` Stefan Wahren
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Wahren @ 2018-12-23 20:59 UTC (permalink / raw)
To: Al Cooper, Adrian Hunter, Ulf Hansson
Cc: Stefan Wahren, Florian Fainelli, Scott Branden, Ray Jui,
linux-mmc, Eric Anholt, bcm-kernel-feedback-list, Gregory Fong,
Brian Norris, linux-arm-kernel
We need to handle mmc_of_parse() errors during probe otherwise the
MMC driver could start without proper initialization (e.g. power sequence).
Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
Hi,
since i don't have this hardware, so it is only compile tested.
Would be nice to get a Tested-by.
Regards
Stefan
drivers/mmc/host/sdhci-brcmstb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index 552bddc..1cd1035 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
}
sdhci_get_of_property(pdev);
- mmc_of_parse(host->mmc);
+ res = mmc_of_parse(host->mmc);
+ if (res)
+ goto err;
/*
* Supply the existing CAPS, but clear the UHS modes. This
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 2/2] mmc: sdhci-brcmstb: handle mmc_of_parse() errors during probe
2018-12-23 20:59 ` Stefan Wahren
@ 2018-12-27 7:06 ` Adrian Hunter
-1 siblings, 0 replies; 16+ messages in thread
From: Adrian Hunter @ 2018-12-27 7:06 UTC (permalink / raw)
To: Stefan Wahren, Al Cooper, Ulf Hansson
Cc: Florian Fainelli, Scott Branden, Ray Jui, linux-mmc, Eric Anholt,
bcm-kernel-feedback-list, Gregory Fong, Brian Norris,
linux-arm-kernel
On 23/12/18 10:59 PM, Stefan Wahren wrote:
> We need to handle mmc_of_parse() errors during probe otherwise the
> MMC driver could start without proper initialization (e.g. power sequence).
>
> Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> Hi,
> since i don't have this hardware, so it is only compile tested.
> Would be nice to get a Tested-by.
>
> Regards
> Stefan
>
>
> drivers/mmc/host/sdhci-brcmstb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index 552bddc..1cd1035 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
> }
>
> sdhci_get_of_property(pdev);
> - mmc_of_parse(host->mmc);
> + res = mmc_of_parse(host->mmc);
> + if (res)
> + goto err;
>
> /*
> * Supply the existing CAPS, but clear the UHS modes. This
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 2/2] mmc: sdhci-brcmstb: handle mmc_of_parse() errors during probe
@ 2018-12-27 7:06 ` Adrian Hunter
0 siblings, 0 replies; 16+ messages in thread
From: Adrian Hunter @ 2018-12-27 7:06 UTC (permalink / raw)
To: Stefan Wahren, Al Cooper, Ulf Hansson
Cc: Florian Fainelli, Scott Branden, Ray Jui, linux-mmc, Eric Anholt,
bcm-kernel-feedback-list, Gregory Fong, Brian Norris,
linux-arm-kernel
On 23/12/18 10:59 PM, Stefan Wahren wrote:
> We need to handle mmc_of_parse() errors during probe otherwise the
> MMC driver could start without proper initialization (e.g. power sequence).
>
> Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> Hi,
> since i don't have this hardware, so it is only compile tested.
> Would be nice to get a Tested-by.
>
> Regards
> Stefan
>
>
> drivers/mmc/host/sdhci-brcmstb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index 552bddc..1cd1035 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
> }
>
> sdhci_get_of_property(pdev);
> - mmc_of_parse(host->mmc);
> + res = mmc_of_parse(host->mmc);
> + if (res)
> + goto err;
>
> /*
> * Supply the existing CAPS, but clear the UHS modes. This
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] mmc: sdhci-brcmstb: handle mmc_of_parse() errors during probe
2018-12-23 20:59 ` Stefan Wahren
@ 2019-01-14 11:44 ` Ulf Hansson
-1 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2019-01-14 11:44 UTC (permalink / raw)
To: Stefan Wahren
Cc: Florian Fainelli, Scott Branden, Ray Jui, Al Cooper, linux-mmc,
Adrian Hunter, Eric Anholt, BCM Kernel Feedback, Gregory Fong,
Brian Norris, Linux ARM
On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> We need to handle mmc_of_parse() errors during probe otherwise the
> MMC driver could start without proper initialization (e.g. power sequence).
>
> Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Hi,
> since i don't have this hardware, so it is only compile tested.
> Would be nice to get a Tested-by.
>
> Regards
> Stefan
>
>
> drivers/mmc/host/sdhci-brcmstb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index 552bddc..1cd1035 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
> }
>
> sdhci_get_of_property(pdev);
> - mmc_of_parse(host->mmc);
> + res = mmc_of_parse(host->mmc);
> + if (res)
> + goto err;
>
> /*
> * Supply the existing CAPS, but clear the UHS modes. This
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 2/2] mmc: sdhci-brcmstb: handle mmc_of_parse() errors during probe
@ 2019-01-14 11:44 ` Ulf Hansson
0 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2019-01-14 11:44 UTC (permalink / raw)
To: Stefan Wahren
Cc: Florian Fainelli, Scott Branden, Ray Jui, Al Cooper, linux-mmc,
Adrian Hunter, Eric Anholt, BCM Kernel Feedback, Gregory Fong,
Brian Norris, Linux ARM
On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> We need to handle mmc_of_parse() errors during probe otherwise the
> MMC driver could start without proper initialization (e.g. power sequence).
>
> Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Hi,
> since i don't have this hardware, so it is only compile tested.
> Would be nice to get a Tested-by.
>
> Regards
> Stefan
>
>
> drivers/mmc/host/sdhci-brcmstb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index 552bddc..1cd1035 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
> }
>
> sdhci_get_of_property(pdev);
> - mmc_of_parse(host->mmc);
> + res = mmc_of_parse(host->mmc);
> + if (res)
> + goto err;
>
> /*
> * Supply the existing CAPS, but clear the UHS modes. This
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
2018-12-23 20:59 ` Stefan Wahren
@ 2018-12-27 7:02 ` Adrian Hunter
-1 siblings, 0 replies; 16+ messages in thread
From: Adrian Hunter @ 2018-12-27 7:02 UTC (permalink / raw)
To: Stefan Wahren, Al Cooper, Ulf Hansson
Cc: Brian Norris, Gregory Fong, Florian Fainelli, Ray Jui,
Scott Branden, Eric Anholt, bcm-kernel-feedback-list, linux-mmc,
linux-arm-kernel, stable
On 23/12/18 10:59 PM, Stefan Wahren wrote:
> We need to handle mmc_of_parse() errors during probe.
>
> This finally fixes the wifi regression on Raspberry Pi 3 series.
> In error case the wifi chip was permanently in reset because of
> the power sequence depending on the deferred probe of the GPIO expander.
>
> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-iproc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 0db9905..9d12c06 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -296,7 +296,10 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
>
> iproc_host->data = iproc_data;
>
> - mmc_of_parse(host->mmc);
> + ret = mmc_of_parse(host->mmc);
> + if (ret)
> + goto err;
> +
> sdhci_get_property(pdev);
>
> host->mmc->caps |= iproc_host->data->mmc_caps;
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
@ 2018-12-27 7:02 ` Adrian Hunter
0 siblings, 0 replies; 16+ messages in thread
From: Adrian Hunter @ 2018-12-27 7:02 UTC (permalink / raw)
To: Stefan Wahren, Al Cooper, Ulf Hansson
Cc: Florian Fainelli, Scott Branden, Ray Jui, linux-mmc, stable,
Eric Anholt, bcm-kernel-feedback-list, Gregory Fong,
Brian Norris, linux-arm-kernel
On 23/12/18 10:59 PM, Stefan Wahren wrote:
> We need to handle mmc_of_parse() errors during probe.
>
> This finally fixes the wifi regression on Raspberry Pi 3 series.
> In error case the wifi chip was permanently in reset because of
> the power sequence depending on the deferred probe of the GPIO expander.
>
> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-iproc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 0db9905..9d12c06 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -296,7 +296,10 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
>
> iproc_host->data = iproc_data;
>
> - mmc_of_parse(host->mmc);
> + ret = mmc_of_parse(host->mmc);
> + if (ret)
> + goto err;
> +
> sdhci_get_property(pdev);
>
> host->mmc->caps |= iproc_host->data->mmc_caps;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
2018-12-23 20:59 ` Stefan Wahren
@ 2019-01-14 11:44 ` Ulf Hansson
-1 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2019-01-14 11:44 UTC (permalink / raw)
To: Stefan Wahren
Cc: Al Cooper, Adrian Hunter, Brian Norris, Gregory Fong,
Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt,
BCM Kernel Feedback, linux-mmc, Linux ARM, # 4.0+
On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> We need to handle mmc_of_parse() errors during probe.
>
> This finally fixes the wifi regression on Raspberry Pi 3 series.
> In error case the wifi chip was permanently in reset because of
> the power sequence depending on the deferred probe of the GPIO expander.
>
> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 0db9905..9d12c06 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -296,7 +296,10 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
>
> iproc_host->data = iproc_data;
>
> - mmc_of_parse(host->mmc);
> + ret = mmc_of_parse(host->mmc);
> + if (ret)
> + goto err;
> +
> sdhci_get_property(pdev);
>
> host->mmc->caps |= iproc_host->data->mmc_caps;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
@ 2019-01-14 11:44 ` Ulf Hansson
0 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2019-01-14 11:44 UTC (permalink / raw)
To: Stefan Wahren
Cc: Florian Fainelli, Scott Branden, Ray Jui, Al Cooper, linux-mmc,
Adrian Hunter, # 4.0+,
Eric Anholt, BCM Kernel Feedback, Gregory Fong, Brian Norris,
Linux ARM
On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> We need to handle mmc_of_parse() errors during probe.
>
> This finally fixes the wifi regression on Raspberry Pi 3 series.
> In error case the wifi chip was permanently in reset because of
> the power sequence depending on the deferred probe of the GPIO expander.
>
> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 0db9905..9d12c06 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -296,7 +296,10 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
>
> iproc_host->data = iproc_data;
>
> - mmc_of_parse(host->mmc);
> + ret = mmc_of_parse(host->mmc);
> + if (ret)
> + goto err;
> +
> sdhci_get_property(pdev);
>
> host->mmc->caps |= iproc_host->data->mmc_caps;
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
2019-01-14 11:44 ` Ulf Hansson
@ 2019-01-14 12:01 ` Stefan Wahren
-1 siblings, 0 replies; 16+ messages in thread
From: Stefan Wahren @ 2019-01-14 12:01 UTC (permalink / raw)
To: Ulf Hansson
Cc: Al Cooper, Adrian Hunter, Brian Norris, Gregory Fong,
Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt,
BCM Kernel Feedback, linux-mmc, Linux ARM, # 4.0+
Hi Ulf,
Am 14.01.2019 um 12:44 schrieb Ulf Hansson:
> On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>> We need to handle mmc_of_parse() errors during probe.
>>
>> This finally fixes the wifi regression on Raspberry Pi 3 series.
>> In error case the wifi chip was permanently in reset because of
>> the power sequence depending on the deferred probe of the GPIO expander.
>>
>> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Applied for next, thanks!
since this fixes a regression can this applied to fixes, please?
Stefan
>
> Kind regards
> Uffe
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
@ 2019-01-14 12:01 ` Stefan Wahren
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Wahren @ 2019-01-14 12:01 UTC (permalink / raw)
To: Ulf Hansson
Cc: Florian Fainelli, Scott Branden, Ray Jui, Al Cooper, linux-mmc,
Adrian Hunter, # 4.0+,
Eric Anholt, BCM Kernel Feedback, Gregory Fong, Brian Norris,
Linux ARM
Hi Ulf,
Am 14.01.2019 um 12:44 schrieb Ulf Hansson:
> On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>> We need to handle mmc_of_parse() errors during probe.
>>
>> This finally fixes the wifi regression on Raspberry Pi 3 series.
>> In error case the wifi chip was permanently in reset because of
>> the power sequence depending on the deferred probe of the GPIO expander.
>>
>> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Applied for next, thanks!
since this fixes a regression can this applied to fixes, please?
Stefan
>
> Kind regards
> Uffe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
2019-01-14 12:01 ` Stefan Wahren
@ 2019-01-14 13:19 ` Ulf Hansson
-1 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2019-01-14 13:19 UTC (permalink / raw)
To: Stefan Wahren
Cc: Al Cooper, Adrian Hunter, Brian Norris, Gregory Fong,
Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt,
BCM Kernel Feedback, linux-mmc, Linux ARM, # 4.0+
On Mon, 14 Jan 2019 at 13:01, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Hi Ulf,
>
> Am 14.01.2019 um 12:44 schrieb Ulf Hansson:
> > On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> >> We need to handle mmc_of_parse() errors during probe.
> >>
> >> This finally fixes the wifi regression on Raspberry Pi 3 series.
> >> In error case the wifi chip was permanently in reset because of
> >> the power sequence depending on the deferred probe of the GPIO expander.
> >>
> >> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> > Applied for next, thanks!
>
> since this fixes a regression can this applied to fixes, please?
Of course, my apologies! I don't know why I didn't notice earlier,
especially due to your descriptive changelog.
I moved patch to fixes, thanks!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe
@ 2019-01-14 13:19 ` Ulf Hansson
0 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2019-01-14 13:19 UTC (permalink / raw)
To: Stefan Wahren
Cc: Florian Fainelli, Scott Branden, Ray Jui, Al Cooper, linux-mmc,
Adrian Hunter, # 4.0+,
Eric Anholt, BCM Kernel Feedback, Gregory Fong, Brian Norris,
Linux ARM
On Mon, 14 Jan 2019 at 13:01, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Hi Ulf,
>
> Am 14.01.2019 um 12:44 schrieb Ulf Hansson:
> > On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> >> We need to handle mmc_of_parse() errors during probe.
> >>
> >> This finally fixes the wifi regression on Raspberry Pi 3 series.
> >> In error case the wifi chip was permanently in reset because of
> >> the power sequence depending on the deferred probe of the GPIO expander.
> >>
> >> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> > Applied for next, thanks!
>
> since this fixes a regression can this applied to fixes, please?
Of course, my apologies! I don't know why I didn't notice earlier,
especially due to your descriptive changelog.
I moved patch to fixes, thanks!
Kind regards
Uffe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread