From: Ulf Hansson <ulf.hansson@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, robh@kernel.org,
bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org, agross@kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz
Date: Mon, 15 Aug 2022 20:27:42 +0200 [thread overview]
Message-ID: <CAPDyKFqK3ywB9HW_FDdHTLNJ0rcVt3t7uMfJsBwfC1p0YhLrXg@mail.gmail.com> (raw)
In-Reply-To: <20220726084520.2895454-1-bhupesh.sharma@linaro.org>
On Tue, 26 Jul 2022 at 10:45, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
>
> As Ulf noted in [1], the maximum operating frequency
> documented in the mmc-controller device-tree bindings
> should be updated to the maximum frequency supported
> by the mmc controller(s).
>
> Without this fix in place, the 'make dtbs_check' reports
> issues with 'max-frequency' value for ipq8074 sdhci node:
>
> arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: mmc@7824900:
> max-frequency:0:0: 384000000 is greater than the maximum of 200000000
>
> [1]. https://www.spinics.net/lists/kernel/msg4442049.html
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220725180916.2850228-1-bhupesh.sharma@linaro.org/
> - Rebased on linux-next/master
>
> .../devicetree/bindings/mmc/mmc-controller.yaml | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index ff5ce89e5111..802e3ca8be4d 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -88,11 +88,18 @@ properties:
> default: 1
>
> max-frequency:
> - description:
> - Maximum operating frequency of the bus.
> + description: |
> + Maximum operating frequency of the bus:
> + - for eMMC, the maximum supported frequency is 200MHz,
> + - for SD/SDIO cards the SDR104 mode has a max supported
> + frequency of 208MHz,
> + - some mmc host controllers do support a max frequency upto
> + 384MHz.
> + So, lets keep the maximum supported value here.
> +
> $ref: /schemas/types.yaml#/definitions/uint32
> minimum: 400000
> - maximum: 200000000
> + maximum: 384000000
>
> disable-wp:
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.35.3
>
prev parent reply other threads:[~2022-08-15 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 8:45 [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz Bhupesh Sharma
2022-07-27 15:04 ` Rob Herring
2022-08-15 18:27 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqK3ywB9HW_FDdHTLNJ0rcVt3t7uMfJsBwfC1p0YhLrXg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.