* [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz
@ 2022-07-26 8:45 Bhupesh Sharma
2022-07-27 15:04 ` Rob Herring
2022-08-15 18:27 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Bhupesh Sharma @ 2022-07-26 8:45 UTC (permalink / raw)
To: linux-mmc, devicetree
Cc: linux-arm-msm, ulf.hansson, robh, bhupesh.sharma, bhupesh.linux,
linux-kernel, bjorn.andersson, agross
As Ulf noted in [1], the maximum operating frequency
documented in the mmc-controller device-tree bindings
should be updated to the maximum frequency supported
by the mmc controller(s).
Without this fix in place, the 'make dtbs_check' reports
issues with 'max-frequency' value for ipq8074 sdhci node:
arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: mmc@7824900:
max-frequency:0:0: 384000000 is greater than the maximum of 200000000
[1]. https://www.spinics.net/lists/kernel/msg4442049.html
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
- v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220725180916.2850228-1-bhupesh.sharma@linaro.org/
- Rebased on linux-next/master
.../devicetree/bindings/mmc/mmc-controller.yaml | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index ff5ce89e5111..802e3ca8be4d 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -88,11 +88,18 @@ properties:
default: 1
max-frequency:
- description:
- Maximum operating frequency of the bus.
+ description: |
+ Maximum operating frequency of the bus:
+ - for eMMC, the maximum supported frequency is 200MHz,
+ - for SD/SDIO cards the SDR104 mode has a max supported
+ frequency of 208MHz,
+ - some mmc host controllers do support a max frequency upto
+ 384MHz.
+ So, lets keep the maximum supported value here.
+
$ref: /schemas/types.yaml#/definitions/uint32
minimum: 400000
- maximum: 200000000
+ maximum: 384000000
disable-wp:
$ref: /schemas/types.yaml#/definitions/flag
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz
2022-07-26 8:45 [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz Bhupesh Sharma
@ 2022-07-27 15:04 ` Rob Herring
2022-08-15 18:27 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-07-27 15:04 UTC (permalink / raw)
To: Bhupesh Sharma
Cc: linux-mmc, bjorn.andersson, linux-arm-msm, ulf.hansson,
linux-kernel, bhupesh.linux, devicetree, agross
On Tue, 26 Jul 2022 14:15:20 +0530, Bhupesh Sharma wrote:
> As Ulf noted in [1], the maximum operating frequency
> documented in the mmc-controller device-tree bindings
> should be updated to the maximum frequency supported
> by the mmc controller(s).
>
> Without this fix in place, the 'make dtbs_check' reports
> issues with 'max-frequency' value for ipq8074 sdhci node:
>
> arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: mmc@7824900:
> max-frequency:0:0: 384000000 is greater than the maximum of 200000000
>
> [1]. https://www.spinics.net/lists/kernel/msg4442049.html
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220725180916.2850228-1-bhupesh.sharma@linaro.org/
> - Rebased on linux-next/master
>
> .../devicetree/bindings/mmc/mmc-controller.yaml | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz
2022-07-26 8:45 [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz Bhupesh Sharma
2022-07-27 15:04 ` Rob Herring
@ 2022-08-15 18:27 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2022-08-15 18:27 UTC (permalink / raw)
To: Bhupesh Sharma
Cc: linux-mmc, devicetree, linux-arm-msm, robh, bhupesh.linux,
linux-kernel, bjorn.andersson, agross
On Tue, 26 Jul 2022 at 10:45, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
>
> As Ulf noted in [1], the maximum operating frequency
> documented in the mmc-controller device-tree bindings
> should be updated to the maximum frequency supported
> by the mmc controller(s).
>
> Without this fix in place, the 'make dtbs_check' reports
> issues with 'max-frequency' value for ipq8074 sdhci node:
>
> arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: mmc@7824900:
> max-frequency:0:0: 384000000 is greater than the maximum of 200000000
>
> [1]. https://www.spinics.net/lists/kernel/msg4442049.html
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220725180916.2850228-1-bhupesh.sharma@linaro.org/
> - Rebased on linux-next/master
>
> .../devicetree/bindings/mmc/mmc-controller.yaml | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index ff5ce89e5111..802e3ca8be4d 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -88,11 +88,18 @@ properties:
> default: 1
>
> max-frequency:
> - description:
> - Maximum operating frequency of the bus.
> + description: |
> + Maximum operating frequency of the bus:
> + - for eMMC, the maximum supported frequency is 200MHz,
> + - for SD/SDIO cards the SDR104 mode has a max supported
> + frequency of 208MHz,
> + - some mmc host controllers do support a max frequency upto
> + 384MHz.
> + So, lets keep the maximum supported value here.
> +
> $ref: /schemas/types.yaml#/definitions/uint32
> minimum: 400000
> - maximum: 200000000
> + maximum: 384000000
>
> disable-wp:
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-15 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 8:45 [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz Bhupesh Sharma
2022-07-27 15:04 ` Rob Herring
2022-08-15 18:27 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.