All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Protsenko <semen.protsenko@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Russell King <linux@armlinux.org.uk>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH v2 3/3] soc: samsung: exynos-chipid: do not enforce built-in
Date: Tue, 5 Oct 2021 15:10:34 +0300	[thread overview]
Message-ID: <CAPLW+4=0K-BLGSR2O05OmRNaLuHaYandZBBUTRYm6-JnBT7QrA@mail.gmail.com> (raw)
In-Reply-To: <20210919093114.35987-4-krzysztof.kozlowski@canonical.com>

On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> After converting the Exynos ChipID and ASV driver to a module, allow to
> actually choose it to be a module, while being a default built-in.  The
> side effect is that driver could be now entirely disabled even for
> kernel with ARCH_EXYNOS, but this is not a critical issue because driver
> is not necessary for the proper platform boot.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>  arch/arm/mach-exynos/Kconfig | 1 -
>  drivers/soc/samsung/Kconfig  | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 5a48abac6af4..30f930e20599 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -13,7 +13,6 @@ menuconfig ARCH_EXYNOS
>         select ARM_GIC
>         select EXYNOS_IRQ_COMBINER
>         select COMMON_CLK_SAMSUNG
> -       select EXYNOS_CHIPID
>         select EXYNOS_THERMAL
>         select EXYNOS_PMU
>         select EXYNOS_SROM
> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
> index fe139f26d093..e2cedef1e8d1 100644
> --- a/drivers/soc/samsung/Kconfig
> +++ b/drivers/soc/samsung/Kconfig
> @@ -13,8 +13,9 @@ config EXYNOS_ASV_ARM
>         depends on EXYNOS_CHIPID
>
>  config EXYNOS_CHIPID
> -       tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST
> +       tristate "Exynos ChipID controller and ASV driver"
>         depends on ARCH_EXYNOS || COMPILE_TEST
> +       default ARCH_EXYNOS
>         select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS
>         select MFD_SYSCON
>         select SOC_BUS
> --
> 2.30.2
>

WARNING: multiple messages have this Message-ID (diff)
From: Sam Protsenko <semen.protsenko@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Russell King <linux@armlinux.org.uk>,
	 linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	 Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	 Sylwester Nawrocki <snawrocki@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	 Tomasz Figa <tomasz.figa@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	 Alim Akhtar <alim.akhtar@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	 Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH v2 3/3] soc: samsung: exynos-chipid: do not enforce built-in
Date: Tue, 5 Oct 2021 15:10:34 +0300	[thread overview]
Message-ID: <CAPLW+4=0K-BLGSR2O05OmRNaLuHaYandZBBUTRYm6-JnBT7QrA@mail.gmail.com> (raw)
In-Reply-To: <20210919093114.35987-4-krzysztof.kozlowski@canonical.com>

On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> After converting the Exynos ChipID and ASV driver to a module, allow to
> actually choose it to be a module, while being a default built-in.  The
> side effect is that driver could be now entirely disabled even for
> kernel with ARCH_EXYNOS, but this is not a critical issue because driver
> is not necessary for the proper platform boot.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>  arch/arm/mach-exynos/Kconfig | 1 -
>  drivers/soc/samsung/Kconfig  | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 5a48abac6af4..30f930e20599 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -13,7 +13,6 @@ menuconfig ARCH_EXYNOS
>         select ARM_GIC
>         select EXYNOS_IRQ_COMBINER
>         select COMMON_CLK_SAMSUNG
> -       select EXYNOS_CHIPID
>         select EXYNOS_THERMAL
>         select EXYNOS_PMU
>         select EXYNOS_SROM
> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
> index fe139f26d093..e2cedef1e8d1 100644
> --- a/drivers/soc/samsung/Kconfig
> +++ b/drivers/soc/samsung/Kconfig
> @@ -13,8 +13,9 @@ config EXYNOS_ASV_ARM
>         depends on EXYNOS_CHIPID
>
>  config EXYNOS_CHIPID
> -       tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST
> +       tristate "Exynos ChipID controller and ASV driver"
>         depends on ARCH_EXYNOS || COMPILE_TEST
> +       default ARCH_EXYNOS
>         select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS
>         select MFD_SYSCON
>         select SOC_BUS
> --
> 2.30.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-05 12:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19  9:31 [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! Krzysztof Kozlowski
2021-09-19  9:31 ` Krzysztof Kozlowski
2021-09-19  9:31 ` [PATCH v2 1/3] soc: samsung: exynos-chipid: avoid soc_device_to_device() Krzysztof Kozlowski
2021-09-19  9:31   ` Krzysztof Kozlowski
2021-10-05 12:06   ` Sam Protsenko
2021-10-05 12:06     ` Sam Protsenko
2021-09-19  9:31 ` [PATCH v2 2/3] soc: samsung: exynos-chipid: convert to a module Krzysztof Kozlowski
2021-09-19  9:31   ` Krzysztof Kozlowski
2021-10-05 12:07   ` Sam Protsenko
2021-10-05 12:07     ` Sam Protsenko
2021-09-19  9:31 ` [PATCH v2 3/3] soc: samsung: exynos-chipid: do not enforce built-in Krzysztof Kozlowski
2021-09-19  9:31   ` Krzysztof Kozlowski
2021-10-05 12:10   ` Sam Protsenko [this message]
2021-10-05 12:10     ` Sam Protsenko
2021-09-19 17:32 ` [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! Alim Akhtar
2021-09-19 17:32   ` Alim Akhtar
2021-09-21 10:03 ` Sylwester Nawrocki
2021-09-21 10:03   ` Sylwester Nawrocki
2021-09-29 13:58 ` Krzysztof Kozlowski
2021-09-29 13:58   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPLW+4=0K-BLGSR2O05OmRNaLuHaYandZBBUTRYm6-JnBT7QrA@mail.gmail.com' \
    --to=semen.protsenko@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=olof@lixom.net \
    --cc=pankaj.dubey@samsung.com \
    --cc=snawrocki@kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.