From: Dan Williams <dan.j.williams@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux MM <linux-mm@kvack.org>,
Souptick Joarder <jrdr.linux@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] dax: Change return type to vm_fault_t
Date: Mon, 16 Apr 2018 21:08:50 -0700 [thread overview]
Message-ID: <CAPcyv4jYbmEEWYEhn8epDVQL=L7_cx3g7F5MNAqq6P7hTpJoOg@mail.gmail.com> (raw)
In-Reply-To: <20180417001907.GB25048@bombadil.infradead.org>
On Mon, Apr 16, 2018 at 5:19 PM, Matthew Wilcox <willy@infradead.org> wrote:
> On Mon, Apr 16, 2018 at 08:14:22PM -0400, Theodore Y. Ts'o wrote:
>> On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote:
>> > Ugh, so this change to vmf_insert_mixed() went upstream without fixing
>> > the users? This changelog is now misleading as it does not mention
>> > that is now an urgent standalone fix. On first read I assumed this was
>> > part of a wider effort for 4.18.
>>
>> Why is this an urgent fix? I thought all the return type change was
>> did something completely innocuous that would not cause any real
>> difference.
>
> Keep reading the thread; Dan is mistaken.
Yes, false alarm, sorry. But we at least got a better changelog for the trouble.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Souptick Joarder <jrdr.linux@gmail.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] dax: Change return type to vm_fault_t
Date: Mon, 16 Apr 2018 21:08:50 -0700 [thread overview]
Message-ID: <CAPcyv4jYbmEEWYEhn8epDVQL=L7_cx3g7F5MNAqq6P7hTpJoOg@mail.gmail.com> (raw)
In-Reply-To: <20180417001907.GB25048@bombadil.infradead.org>
On Mon, Apr 16, 2018 at 5:19 PM, Matthew Wilcox <willy@infradead.org> wrote:
> On Mon, Apr 16, 2018 at 08:14:22PM -0400, Theodore Y. Ts'o wrote:
>> On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote:
>> > Ugh, so this change to vmf_insert_mixed() went upstream without fixing
>> > the users? This changelog is now misleading as it does not mention
>> > that is now an urgent standalone fix. On first read I assumed this was
>> > part of a wider effort for 4.18.
>>
>> Why is this an urgent fix? I thought all the return type change was
>> did something completely innocuous that would not cause any real
>> difference.
>
> Keep reading the thread; Dan is mistaken.
Yes, false alarm, sorry. But we at least got a better changelog for the trouble.
next prev parent reply other threads:[~2018-04-17 4:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 15:50 [PATCH] dax: Change return type to vm_fault_t Souptick Joarder
2018-04-16 16:14 ` Dan Williams
2018-04-16 16:14 ` Dan Williams
2018-04-16 16:29 ` Randy Dunlap
2018-04-16 16:29 ` Randy Dunlap
2018-04-16 16:38 ` Souptick Joarder
2018-04-16 16:38 ` Souptick Joarder
2018-04-16 17:47 ` Matthew Wilcox
2018-04-16 18:00 ` Dan Williams
2018-04-16 18:00 ` Dan Williams
2018-04-16 18:21 ` Matthew Wilcox
2018-04-16 18:28 ` Souptick Joarder
2018-04-16 18:28 ` Souptick Joarder
2018-04-16 18:35 ` Dan Williams
2018-04-16 18:37 ` Souptick Joarder
2018-04-16 18:41 ` Randy Dunlap
2018-04-16 18:41 ` Randy Dunlap
2018-04-17 0:14 ` Theodore Y. Ts'o
2018-04-17 0:14 ` Theodore Y. Ts'o
2018-04-17 0:19 ` Matthew Wilcox
2018-04-17 0:19 ` Matthew Wilcox
2018-04-17 4:08 ` Dan Williams [this message]
2018-04-17 4:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jYbmEEWYEhn8epDVQL=L7_cx3g7F5MNAqq6P7hTpJoOg@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.