From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Michal Hocko <mhocko@suse.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Matthew Wilcox <willy@infradead.org>,
Linux MM <linux-mm@kvack.org>,
Souptick Joarder <jrdr.linux@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] dax: Change return type to vm_fault_t
Date: Mon, 16 Apr 2018 20:14:22 -0400 [thread overview]
Message-ID: <20180417001421.GH22870@thunk.org> (raw)
In-Reply-To: <CAPcyv4g+Gdc2tJ1qrM5Xn9vtARw-ZqFXaMbiaBKJJsYDtSNBig@mail.gmail.com>
On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote:
> Ugh, so this change to vmf_insert_mixed() went upstream without fixing
> the users? This changelog is now misleading as it does not mention
> that is now an urgent standalone fix. On first read I assumed this was
> part of a wider effort for 4.18.
Why is this an urgent fix? I thought all the return type change was
did something completely innocuous that would not cause any real
difference.
Otherwise there are a dozen plus "fixups" to change the users that
will now become urgent fixes, which I did *not* expect to be the case.
(Where two are in ext2 and ext4, and where I planned to take my time
and get them fixed in the next merge window, precisely becuase I did
not *think* they were urgent.)
- Ted
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Matthew Wilcox <willy@infradead.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] dax: Change return type to vm_fault_t
Date: Mon, 16 Apr 2018 20:14:22 -0400 [thread overview]
Message-ID: <20180417001421.GH22870@thunk.org> (raw)
In-Reply-To: <CAPcyv4g+Gdc2tJ1qrM5Xn9vtARw-ZqFXaMbiaBKJJsYDtSNBig@mail.gmail.com>
On Mon, Apr 16, 2018 at 09:14:48AM -0700, Dan Williams wrote:
> Ugh, so this change to vmf_insert_mixed() went upstream without fixing
> the users? This changelog is now misleading as it does not mention
> that is now an urgent standalone fix. On first read I assumed this was
> part of a wider effort for 4.18.
Why is this an urgent fix? I thought all the return type change was
did something completely innocuous that would not cause any real
difference.
Otherwise there are a dozen plus "fixups" to change the users that
will now become urgent fixes, which I did *not* expect to be the case.
(Where two are in ext2 and ext4, and where I planned to take my time
and get them fixed in the next merge window, precisely becuase I did
not *think* they were urgent.)
- Ted
next prev parent reply other threads:[~2018-04-17 0:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 15:50 [PATCH] dax: Change return type to vm_fault_t Souptick Joarder
2018-04-16 16:14 ` Dan Williams
2018-04-16 16:14 ` Dan Williams
2018-04-16 16:29 ` Randy Dunlap
2018-04-16 16:29 ` Randy Dunlap
2018-04-16 16:38 ` Souptick Joarder
2018-04-16 16:38 ` Souptick Joarder
2018-04-16 17:47 ` Matthew Wilcox
2018-04-16 18:00 ` Dan Williams
2018-04-16 18:00 ` Dan Williams
2018-04-16 18:21 ` Matthew Wilcox
2018-04-16 18:28 ` Souptick Joarder
2018-04-16 18:28 ` Souptick Joarder
2018-04-16 18:35 ` Dan Williams
2018-04-16 18:37 ` Souptick Joarder
2018-04-16 18:41 ` Randy Dunlap
2018-04-16 18:41 ` Randy Dunlap
2018-04-17 0:14 ` Theodore Y. Ts'o [this message]
2018-04-17 0:14 ` Theodore Y. Ts'o
2018-04-17 0:19 ` Matthew Wilcox
2018-04-17 0:19 ` Matthew Wilcox
2018-04-17 4:08 ` Dan Williams
2018-04-17 4:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417001421.GH22870@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.