* [Buildroot] [PATCH 1/1] package/libnss: fix build on powerpc
@ 2022-04-05 21:33 Fabrice Fontaine
2022-04-06 9:57 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2022-04-05 21:33 UTC (permalink / raw)
To: buildroot; +Cc: Joseph Kogut, Giulio Benetti, Fabrice Fontaine
Set NSS_DISABLE_CRYPTO_VSX which is available since version 3.64 and
https://github.com/nss-dev/nss/commit/9dab43371d4d924419523e18ba84f02804880533
to avoid the following build failure on powerpc:
cc1: warning: '-mvsx' requires hardware floating point
cc1: error: '-mno-vsx' turns off '-mcrypto'
Fixes:
- http://autobuild.buildroot.org/results/6bedb5b658f6c9c16c26c73a524a995e5e84fcc8
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libnss/libnss.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
index 2f7a265136..4582c55ada 100644
--- a/package/libnss/libnss.mk
+++ b/package/libnss/libnss.mk
@@ -51,6 +51,7 @@ LIBNSS_BUILD_VARS = \
NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \
NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \
NS_USE_GCC=1 \
+ NSS_DISABLE_CRYPTO_VSX=1 \
NSS_DISABLE_GTESTS=1 \
NSS_USE_SYSTEM_SQLITE=1 \
NATIVE_CC="$(HOSTCC)" \
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libnss: fix build on powerpc
2022-04-05 21:33 [Buildroot] [PATCH 1/1] package/libnss: fix build on powerpc Fabrice Fontaine
@ 2022-04-06 9:57 ` Joel Stanley
2022-04-06 10:07 ` Fabrice Fontaine
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2022-04-06 9:57 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Joseph Kogut, Giulio Benetti, buildroot
Hi Fabrice,
On Tue, 5 Apr 2022 at 21:35, Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Set NSS_DISABLE_CRYPTO_VSX which is available since version 3.64 and
> https://github.com/nss-dev/nss/commit/9dab43371d4d924419523e18ba84f02804880533
> to avoid the following build failure on powerpc:
>
> cc1: warning: '-mvsx' requires hardware floating point
> cc1: error: '-mno-vsx' turns off '-mcrypto'
>
> Fixes:
> - http://autobuild.buildroot.org/results/6bedb5b658f6c9c16c26c73a524a995e5e84fcc8
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libnss/libnss.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
> index 2f7a265136..4582c55ada 100644
> --- a/package/libnss/libnss.mk
> +++ b/package/libnss/libnss.mk
> @@ -51,6 +51,7 @@ LIBNSS_BUILD_VARS = \
> NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \
> NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \
> NS_USE_GCC=1 \
> + NSS_DISABLE_CRYPTO_VSX=1 \
How about we introduce a BR2_POWERPC_CPU_HAS_VSX, in a similar fashion
to BR2_POWERPC_CPU_HAS_ALITIVEC?
I've prepared a patch to do that, and rebased your change to use it:
https://github.com/shenki/buildroot/commits/powerpc-vsx
I did a build test of the autobuilder config you linked to and it succeeded.
I'll send them out tomorrow unless you have an alternative proposal.
Cheers,
Joel
> NSS_DISABLE_GTESTS=1 \
> NSS_USE_SYSTEM_SQLITE=1 \
> NATIVE_CC="$(HOSTCC)" \
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libnss: fix build on powerpc
2022-04-06 9:57 ` Joel Stanley
@ 2022-04-06 10:07 ` Fabrice Fontaine
0 siblings, 0 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-04-06 10:07 UTC (permalink / raw)
To: Joel Stanley; +Cc: Joseph Kogut, Giulio Benetti, Buildroot Mailing List
Hi Joel,
Le mer. 6 avr. 2022 à 11:57, Joel Stanley <joel@jms.id.au> a écrit :
>
> Hi Fabrice,
>
> On Tue, 5 Apr 2022 at 21:35, Fabrice Fontaine
> <fontaine.fabrice@gmail.com> wrote:
> >
> > Set NSS_DISABLE_CRYPTO_VSX which is available since version 3.64 and
> > https://github.com/nss-dev/nss/commit/9dab43371d4d924419523e18ba84f02804880533
> > to avoid the following build failure on powerpc:
> >
> > cc1: warning: '-mvsx' requires hardware floating point
> > cc1: error: '-mno-vsx' turns off '-mcrypto'
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/6bedb5b658f6c9c16c26c73a524a995e5e84fcc8
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/libnss/libnss.mk | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
> > index 2f7a265136..4582c55ada 100644
> > --- a/package/libnss/libnss.mk
> > +++ b/package/libnss/libnss.mk
> > @@ -51,6 +51,7 @@ LIBNSS_BUILD_VARS = \
> > NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \
> > NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \
> > NS_USE_GCC=1 \
> > + NSS_DISABLE_CRYPTO_VSX=1 \
>
> How about we introduce a BR2_POWERPC_CPU_HAS_VSX, in a similar fashion
> to BR2_POWERPC_CPU_HAS_ALITIVEC?
>
> I've prepared a patch to do that, and rebased your change to use it:
>
> https://github.com/shenki/buildroot/commits/powerpc-vsx
>
> I did a build test of the autobuilder config you linked to and it succeeded.
>
> I'll send them out tomorrow unless you have an alternative proposal.
Sure, I'll set my patch as superseded in patchwork.
I would advise to add support for this new option to flac as vsx was
unconditonally disabled with
https://git.buildroot.net/buildroot/commit/package/flac?id=5197ce5ff30d1a23b811ddddca8030f13658d7da
>
> Cheers,
>
> Joel
>
> > NSS_DISABLE_GTESTS=1 \
> > NSS_USE_SYSTEM_SQLITE=1 \
> > NATIVE_CC="$(HOSTCC)" \
> > --
> > 2.35.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-06 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 21:33 [Buildroot] [PATCH 1/1] package/libnss: fix build on powerpc Fabrice Fontaine
2022-04-06 9:57 ` Joel Stanley
2022-04-06 10:07 ` Fabrice Fontaine
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.