From: Daniel Stone <daniel@fooishbar.org>
To: Randy Li <ayaka@soulik.info>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Li Randy" <randy.li@rock-chips.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Vetter, Daniel" <daniel.vetter@intel.com>,
mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format
Date: Wed, 4 Jan 2017 17:02:57 +0000 [thread overview]
Message-ID: <CAPj87rPbM2Qm0v8S5++5Qpgv51AWxgTpRoAXaY8-CL2_hCSC6g@mail.gmail.com> (raw)
In-Reply-To: <1483547351-5792-2-git-send-email-ayaka@soulik.info>
Hi Randy,
On 4 January 2017 at 16:29, Randy Li <ayaka@soulik.info> wrote:
> index 90d2cc8..23c8e99 100644
> --- a/drivers/gpu/drm/drm_fourcc.c
> +++ b/drivers/gpu/drm/drm_fourcc.c
> @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 format)
> { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 },
> { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 },
> { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1 },
> + /* FIXME a pixel in Y for P010 is 10 bits */
> + { .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 },
It seems like P010 stores each Y component in a 16-bit value, with the
bottom 6 bits ignored. So I think cpp here should be 2.
Cheers,
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Stone <daniel@fooishbar.org>
To: Randy Li <ayaka@soulik.info>
Cc: Li Randy <randy.li@rock-chips.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Vetter, Daniel" <daniel.vetter@intel.com>,
mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format
Date: Wed, 4 Jan 2017 17:02:57 +0000 [thread overview]
Message-ID: <CAPj87rPbM2Qm0v8S5++5Qpgv51AWxgTpRoAXaY8-CL2_hCSC6g@mail.gmail.com> (raw)
In-Reply-To: <1483547351-5792-2-git-send-email-ayaka@soulik.info>
Hi Randy,
On 4 January 2017 at 16:29, Randy Li <ayaka@soulik.info> wrote:
> index 90d2cc8..23c8e99 100644
> --- a/drivers/gpu/drm/drm_fourcc.c
> +++ b/drivers/gpu/drm/drm_fourcc.c
> @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 format)
> { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 },
> { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 },
> { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1 },
> + /* FIXME a pixel in Y for P010 is 10 bits */
> + { .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 },
It seems like P010 stores each Y component in a 16-bit value, with the
bottom 6 bits ignored. So I think cpp here should be 2.
Cheers,
Daniel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-04 17:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 16:29 [PATCH v2 0/2] Add pixel formats for 10/16 bits YUV video Randy Li
2017-01-04 16:29 ` [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format Randy Li
2017-01-04 17:02 ` Daniel Stone [this message]
2017-01-04 17:02 ` Daniel Stone
2017-01-05 2:00 ` Ayaka
2017-01-23 21:16 ` Clint Taylor
2017-02-23 23:58 ` [PATCH v3 " clinton.a.taylor
2017-02-24 11:10 ` Ville Syrjälä
2017-02-27 17:21 ` [PATCH v4 " clinton.a.taylor
2017-02-27 17:41 ` Ville Syrjälä
2017-02-27 18:28 ` Clint Taylor
2017-02-27 18:47 ` Ville Syrjälä
2017-02-27 22:57 ` [PATCH v5 " clinton.a.taylor
2017-02-28 10:58 ` ayaka
2017-02-28 16:37 ` Clint Taylor
2017-02-28 11:56 ` Ville Syrjälä
2017-02-28 16:08 ` Clint Taylor
2017-02-28 16:22 ` Ville Syrjälä
2017-02-28 23:21 ` [PATCH v6 " clinton.a.taylor
2017-10-12 11:56 ` Tapani Pälli
2017-10-17 11:43 ` ayaka
2017-10-24 6:30 ` Tapani Pälli
2017-01-04 16:29 ` [PATCH v2 2/2] [media] v4l: Add 10/16-bits per channel YUV pixel formats Randy Li
2017-01-05 10:30 ` Sakari Ailus
2017-01-05 10:30 ` Sakari Ailus
2017-01-05 15:22 ` ayaka
2017-01-05 18:27 ` Sakari Ailus
2017-01-05 18:27 ` Sakari Ailus
2017-02-03 14:04 ` Mauro Carvalho Chehab
2017-02-08 9:17 ` Ayaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPj87rPbM2Qm0v8S5++5Qpgv51AWxgTpRoAXaY8-CL2_hCSC6g@mail.gmail.com \
--to=daniel@fooishbar.org \
--cc=ayaka@soulik.info \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=randy.li@rock-chips.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.