All of lore.kernel.org
 help / color / mirror / Atom feed
From: Himadri Pandya <himadri18.07@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org
Subject: Re: rtl8192e: need help with variable naming convention
Date: Sat, 12 Jan 2019 22:31:08 -0800	[thread overview]
Message-ID: <CAPnhUpb7huehqHpLZ+Kz657xAZVCqLWYTW2RfK6Yy=mAP5QgYg@mail.gmail.com> (raw)
In-Reply-To: <20190107130314.GD3200@kadam>

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

On Mon, Jan 7, 2019 at 5:04 AM Dan Carpenter <dan.carpenter@oracle.com>
wrote:

>
> Ending a name with an underscore is quite ugly.


Yeah. That's right. So renaming it to channel_array[ ] instead.


> Feel free to get more
> creative with the naming scheme.  Rethink things as much as you can,
> don't assume the original code is something to copy.
>

I wasn't sure if I'm allowed to do so. Thank you for letting me know.

- Himadri

[-- Attachment #2: Type: text/html, Size: 966 bytes --]

  reply	other threads:[~2019-01-13  6:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 10:34 rtl8192e: need help with variable naming convention Himadri Pandya
2019-01-07 10:45 ` Himadri Pandya
2019-01-07 10:52 ` Greg KH
2019-01-07 13:03   ` Dan Carpenter
2019-01-13  6:31     ` Himadri Pandya [this message]
2019-01-14 10:51       ` Dan Carpenter
2019-01-14 12:09         ` Himadri Pandya
2019-01-14 12:37           ` Dan Carpenter
2019-01-15  8:03             ` Himadri Pandya
2019-01-13  6:26   ` Himadri Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnhUpb7huehqHpLZ+Kz657xAZVCqLWYTW2RfK6Yy=mAP5QgYg@mail.gmail.com' \
    --to=himadri18.07@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.