From: Dan Carpenter <dan.carpenter@oracle.com>
To: Himadri Pandya <himadri18.07@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org
Subject: Re: rtl8192e: need help with variable naming convention
Date: Mon, 14 Jan 2019 13:51:24 +0300 [thread overview]
Message-ID: <20190114105123.GA22496@kadam> (raw)
In-Reply-To: <CAPnhUpb7huehqHpLZ+Kz657xAZVCqLWYTW2RfK6Yy=mAP5QgYg@mail.gmail.com>
On Sat, Jan 12, 2019 at 10:31:08PM -0800, Himadri Pandya wrote:
> On Mon, Jan 7, 2019 at 5:04 AM Dan Carpenter <dan.carpenter@oracle.com>
> wrote:
>
> >
> > Ending a name with an underscore is quite ugly.
>
>
> Yeah. That's right. So renaming it to channel_array[ ] instead.
>
Naming is hard. Having "_array" in the name isn't great either. It's
normally obvious it's an array because of the [] characters.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-01-14 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 10:34 rtl8192e: need help with variable naming convention Himadri Pandya
2019-01-07 10:45 ` Himadri Pandya
2019-01-07 10:52 ` Greg KH
2019-01-07 13:03 ` Dan Carpenter
2019-01-13 6:31 ` Himadri Pandya
2019-01-14 10:51 ` Dan Carpenter [this message]
2019-01-14 12:09 ` Himadri Pandya
2019-01-14 12:37 ` Dan Carpenter
2019-01-15 8:03 ` Himadri Pandya
2019-01-13 6:26 ` Himadri Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114105123.GA22496@kadam \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=himadri18.07@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.