All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: driverdev-devel@linuxdriverproject.org
Subject: Re: rtl8192e: need help with variable naming convention
Date: Mon, 7 Jan 2019 16:03:14 +0300	[thread overview]
Message-ID: <20190107130314.GD3200@kadam> (raw)
In-Reply-To: <20190107105214.GA31559@kroah.com>

On Mon, Jan 07, 2019 at 11:52:14AM +0100, Greg KH wrote:
> On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote:
> > Hello,
> > 
> > I'm getting started with device drivers. And as a starter, I'm working on
> > some clean-up patches.  I'm particularly targeting to rename a structure
> > array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning "Avoid
> > CamelCase". According to the coding style, it should be converted to
> > "channel_plan". But the code contains a function argument with the same
> > name "channel_plan". Should I then rename the array to something like
> > "channel_name_"?


Ending a name with an underscore is quite ugly.  Feel free to get more
creative with the naming scheme.  Rethink things as much as you can,
don't assume the original code is something to copy.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2019-01-07 13:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 10:34 rtl8192e: need help with variable naming convention Himadri Pandya
2019-01-07 10:45 ` Himadri Pandya
2019-01-07 10:52 ` Greg KH
2019-01-07 13:03   ` Dan Carpenter [this message]
2019-01-13  6:31     ` Himadri Pandya
2019-01-14 10:51       ` Dan Carpenter
2019-01-14 12:09         ` Himadri Pandya
2019-01-14 12:37           ` Dan Carpenter
2019-01-15  8:03             ` Himadri Pandya
2019-01-13  6:26   ` Himadri Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107130314.GD3200@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.