* [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes
@ 2015-07-20 11:41 Mirza Krak
2015-07-20 13:13 ` Simon Glass
2015-07-21 9:02 ` Thierry Reding
0 siblings, 2 replies; 4+ messages in thread
From: Mirza Krak @ 2015-07-20 11:41 UTC (permalink / raw)
To: u-boot
From: Mirza Krak <mirza.krak@hostmobility.com>
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
---
arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
index b8c8a923017e..82168c9012e3 100644
--- a/arch/arm/dts/tegra20.dtsi
+++ b/arch/arm/dts/tegra20.dtsi
@@ -268,6 +268,50 @@
#pwm-cells = <2>;
};
+ spi at 7000d400 {
+ compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+ reg = <0x7000d400 0x200>;
+ interrupts = <0 59 0x04>;
+ nvidia,dma-request-selector = <&apbdma 15>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 41>;
+ status = "disabled";
+ };
+
+ spi at 7000d600 {
+ compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+ reg = <0x7000d600 0x200>;
+ interrupts = <0 82 0x04>;
+ nvidia,dma-request-selector = <&apbdma 16>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 44>;
+ status = "disabled";
+ };
+
+ spi at 7000d800 {
+ compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+ reg = <0x7000d480 0x200>;
+ interrupts = <0 83 0x04>;
+ nvidia,dma-request-selector = <&apbdma 17>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 46>;
+ status = "disabled";
+ };
+
+ spi at 7000da00 {
+ compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+ reg = <0x7000da00 0x200>;
+ interrupts = <0 93 0x04>;
+ nvidia,dma-request-selector = <&apbdma 18>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 68>;
+ status = "disabled";
+ };
+
i2c at 7000c000 {
#address-cells = <1>;
#size-cells = <0>;
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes
2015-07-20 11:41 [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes Mirza Krak
@ 2015-07-20 13:13 ` Simon Glass
2015-07-21 9:02 ` Thierry Reding
1 sibling, 0 replies; 4+ messages in thread
From: Simon Glass @ 2015-07-20 13:13 UTC (permalink / raw)
To: u-boot
On 20 July 2015 at 05:41, Mirza Krak <mirza.krak@hostmobility.com> wrote:
> From: Mirza Krak <mirza.krak@hostmobility.com>
>
> Add the device tree node for the SPI controllers found on Tegra20 SOCs.
>
> Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
>
> ---
> arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes
2015-07-20 11:41 [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes Mirza Krak
2015-07-20 13:13 ` Simon Glass
@ 2015-07-21 9:02 ` Thierry Reding
2015-07-21 9:41 ` Mirza Krak
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2015-07-21 9:02 UTC (permalink / raw)
To: u-boot
On Mon, Jul 20, 2015 at 01:41:00PM +0200, Mirza Krak wrote:
> From: Mirza Krak <mirza.krak@hostmobility.com>
>
> Add the device tree node for the SPI controllers found on Tegra20 SOCs.
>
> Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
>
> ---
> arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> index b8c8a923017e..82168c9012e3 100644
> --- a/arch/arm/dts/tegra20.dtsi
> +++ b/arch/arm/dts/tegra20.dtsi
> @@ -268,6 +268,50 @@
> #pwm-cells = <2>;
> };
>
> + spi at 7000d400 {
> + compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
This can't be correct on Tegra20 since Tegra30 didn't exist at the time.
You'll need to drop the first string in the list for this to be correct.
Also, might be worth copying these from the Linux kernel's copy of the
device tree files, since they are slightly different. That might involve
pulling in a couple of headers too, though, so might not be worth it.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150721/738ef42c/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes
2015-07-21 9:02 ` Thierry Reding
@ 2015-07-21 9:41 ` Mirza Krak
0 siblings, 0 replies; 4+ messages in thread
From: Mirza Krak @ 2015-07-21 9:41 UTC (permalink / raw)
To: u-boot
2015-07-21 11:02 GMT+02:00 Thierry Reding <treding@nvidia.com>:
>
> On Mon, Jul 20, 2015 at 01:41:00PM +0200, Mirza Krak wrote:
> > From: Mirza Krak <mirza.krak@hostmobility.com>
> >
> > Add the device tree node for the SPI controllers found on Tegra20 SOCs.
> >
> > Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
> >
> > ---
> > arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> > index b8c8a923017e..82168c9012e3 100644
> > --- a/arch/arm/dts/tegra20.dtsi
> > +++ b/arch/arm/dts/tegra20.dtsi
> > @@ -268,6 +268,50 @@
> > #pwm-cells = <2>;
> > };
> >
> > + spi at 7000d400 {
> > + compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
>
> This can't be correct on Tegra20 since Tegra30 didn't exist at the time.
> You'll need to drop the first string in the list for this to be correct.
Sent v2 of patch dropping tegra30 compatible string.
>
> Also, might be worth copying these from the Linux kernel's copy of the
> device tree files, since they are slightly different. That might involve
> pulling in a couple of headers too, though, so might not be worth it.
>
> Thierry
Pulling from Linux kernel's copy of these files is not something I am
up for at the moment.
--
Med V?nliga H?lsningar / Best Regards
*******************************************************************
Mirza Krak
Host Mobility AB
mirza.krak at hostmobility.com
Anders Personsgatan 12, 416 64 G?teborg
Sweden
http://www.hostmobility.com
Direct: +46 31 31 32 704
Phone: +46 31 31 32 700
Fax: +46 31 80 67 51
Mobile: +46 730 28 06 22
*******************************************************************
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-21 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-20 11:41 [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes Mirza Krak
2015-07-20 13:13 ` Simon Glass
2015-07-21 9:02 ` Thierry Reding
2015-07-21 9:41 ` Mirza Krak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.