* [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver
@ 2020-02-03 13:06 Wolfgang Wallner
2020-02-03 13:06 ` [PATCH 2/2] x86: apl: Include " Wolfgang Wallner
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Wolfgang Wallner @ 2020-02-03 13:06 UTC (permalink / raw)
To: u-boot
Currently the ITSS driver is built unconditionally. Add a Kconfig option
to support enabling/disabling the inclusion of the ITSS driver depending
on the platform.
Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
---
arch/x86/Kconfig | 6 ++++++
arch/x86/cpu/intel_common/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 89b93e5de2..b733d2264e 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -709,6 +709,12 @@ config ROM_TABLE_SIZE
hex
default 0x10000
+config HAVE_ITSS
+ bool "Enable ITSS"
+ help
+ Select this to include the driver for the Interrupt Timer
+ Subsystem (ITSS) which is found on several Intel devices.
+
menu "System tables"
depends on !EFI && !SYS_COREBOOT
diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile
index 266e6e26fa..e22c70781d 100644
--- a/arch/x86/cpu/intel_common/Makefile
+++ b/arch/x86/cpu/intel_common/Makefile
@@ -27,7 +27,7 @@ obj-y += microcode.o
endif
endif
obj-y += pch.o
-obj-y += itss.o
+obj-$(CONFIG_HAVE_ITSS) += itss.o
ifdef CONFIG_SPL
ifndef CONFIG_SPL_BUILD
--
2.25.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] x86: apl: Include ITSS driver
2020-02-03 13:06 [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver Wolfgang Wallner
@ 2020-02-03 13:06 ` Wolfgang Wallner
2020-02-03 13:36 ` Simon Glass
2020-02-03 14:23 ` Bin Meng
2020-02-03 13:36 ` [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable " Simon Glass
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Wolfgang Wallner @ 2020-02-03 13:06 UTC (permalink / raw)
To: u-boot
Atuomatically select the ITSS driver when building for Apollo Lake.
Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
---
arch/x86/cpu/apollolake/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/cpu/apollolake/Kconfig b/arch/x86/cpu/apollolake/Kconfig
index fcff176c27..a760e0ac68 100644
--- a/arch/x86/cpu/apollolake/Kconfig
+++ b/arch/x86/cpu/apollolake/Kconfig
@@ -39,6 +39,7 @@ config INTEL_APOLLOLAKE
imply HAVE_X86_FIT
imply INTEL_GPIO
imply SMP
+ imply HAVE_ITSS
if INTEL_APOLLOLAKE
--
2.25.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver
2020-02-03 13:06 [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver Wolfgang Wallner
2020-02-03 13:06 ` [PATCH 2/2] x86: apl: Include " Wolfgang Wallner
@ 2020-02-03 13:36 ` Simon Glass
2020-02-03 14:23 ` Bin Meng
2020-02-04 2:35 ` Bin Meng
3 siblings, 0 replies; 9+ messages in thread
From: Simon Glass @ 2020-02-03 13:36 UTC (permalink / raw)
To: u-boot
On Mon, 3 Feb 2020 at 06:07, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently the ITSS driver is built unconditionally. Add a Kconfig option
> to support enabling/disabling the inclusion of the ITSS driver depending
> on the platform.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
> arch/x86/Kconfig | 6 ++++++
> arch/x86/cpu/intel_common/Makefile | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] x86: apl: Include ITSS driver
2020-02-03 13:06 ` [PATCH 2/2] x86: apl: Include " Wolfgang Wallner
@ 2020-02-03 13:36 ` Simon Glass
2020-02-03 14:23 ` Bin Meng
1 sibling, 0 replies; 9+ messages in thread
From: Simon Glass @ 2020-02-03 13:36 UTC (permalink / raw)
To: u-boot
On Mon, 3 Feb 2020 at 06:07, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Atuomatically select the ITSS driver when building for Apollo Lake.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
> arch/x86/cpu/apollolake/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver
2020-02-03 13:06 [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver Wolfgang Wallner
2020-02-03 13:06 ` [PATCH 2/2] x86: apl: Include " Wolfgang Wallner
2020-02-03 13:36 ` [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable " Simon Glass
@ 2020-02-03 14:23 ` Bin Meng
2020-02-04 2:35 ` Bin Meng
3 siblings, 0 replies; 9+ messages in thread
From: Bin Meng @ 2020-02-03 14:23 UTC (permalink / raw)
To: u-boot
On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently the ITSS driver is built unconditionally. Add a Kconfig option
> to support enabling/disabling the inclusion of the ITSS driver depending
> on the platform.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
> arch/x86/Kconfig | 6 ++++++
> arch/x86/cpu/intel_common/Makefile | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] x86: apl: Include ITSS driver
2020-02-03 13:06 ` [PATCH 2/2] x86: apl: Include " Wolfgang Wallner
2020-02-03 13:36 ` Simon Glass
@ 2020-02-03 14:23 ` Bin Meng
2020-02-04 5:05 ` Bin Meng
1 sibling, 1 reply; 9+ messages in thread
From: Bin Meng @ 2020-02-03 14:23 UTC (permalink / raw)
To: u-boot
On Mon, Feb 3, 2020 at 9:07 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Atuomatically select the ITSS driver when building for Apollo Lake.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
> arch/x86/cpu/apollolake/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver
2020-02-03 13:06 [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver Wolfgang Wallner
` (2 preceding siblings ...)
2020-02-03 14:23 ` Bin Meng
@ 2020-02-04 2:35 ` Bin Meng
2020-02-04 5:03 ` Bin Meng
3 siblings, 1 reply; 9+ messages in thread
From: Bin Meng @ 2020-02-04 2:35 UTC (permalink / raw)
To: u-boot
Hi Wolfgang,
On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently the ITSS driver is built unconditionally. Add a Kconfig option
> to support enabling/disabling the inclusion of the ITSS driver depending
> on the platform.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
> arch/x86/Kconfig | 6 ++++++
> arch/x86/cpu/intel_common/Makefile | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 89b93e5de2..b733d2264e 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -709,6 +709,12 @@ config ROM_TABLE_SIZE
> hex
> default 0x10000
>
> +config HAVE_ITSS
> + bool "Enable ITSS"
> + help
> + Select this to include the driver for the Interrupt Timer
> + Subsystem (ITSS) which is found on several Intel devices.
> +
> menu "System tables"
> depends on !EFI && !SYS_COREBOOT
>
> diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile
> index 266e6e26fa..e22c70781d 100644
> --- a/arch/x86/cpu/intel_common/Makefile
> +++ b/arch/x86/cpu/intel_common/Makefile
> @@ -27,7 +27,7 @@ obj-y += microcode.o
> endif
> endif
> obj-y += pch.o
> -obj-y += itss.o
> +obj-$(CONFIG_HAVE_ITSS) += itss.o
>
I will have to squash this patch into the previous one, because the
unconditional build causes issues for other x86 targets, see:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=153&view=logs&j=8a1d3be7-a4c9-55b6-774d-e7f1a8f80847&t=b2f224a7-1103-5b52-edbc-3784ae727e03
Regards,
Bin
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver
2020-02-04 2:35 ` Bin Meng
@ 2020-02-04 5:03 ` Bin Meng
0 siblings, 0 replies; 9+ messages in thread
From: Bin Meng @ 2020-02-04 5:03 UTC (permalink / raw)
To: u-boot
On Tue, Feb 4, 2020 at 10:35 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Wolfgang,
>
> On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner
> <wolfgang.wallner@br-automation.com> wrote:
> >
> > Currently the ITSS driver is built unconditionally. Add a Kconfig option
> > to support enabling/disabling the inclusion of the ITSS driver depending
> > on the platform.
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > ---
> >
> > arch/x86/Kconfig | 6 ++++++
> > arch/x86/cpu/intel_common/Makefile | 2 +-
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 89b93e5de2..b733d2264e 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -709,6 +709,12 @@ config ROM_TABLE_SIZE
> > hex
> > default 0x10000
> >
> > +config HAVE_ITSS
> > + bool "Enable ITSS"
> > + help
> > + Select this to include the driver for the Interrupt Timer
> > + Subsystem (ITSS) which is found on several Intel devices.
> > +
> > menu "System tables"
> > depends on !EFI && !SYS_COREBOOT
> >
> > diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile
> > index 266e6e26fa..e22c70781d 100644
> > --- a/arch/x86/cpu/intel_common/Makefile
> > +++ b/arch/x86/cpu/intel_common/Makefile
> > @@ -27,7 +27,7 @@ obj-y += microcode.o
> > endif
> > endif
> > obj-y += pch.o
> > -obj-y += itss.o
> > +obj-$(CONFIG_HAVE_ITSS) += itss.o
> >
>
> I will have to squash this patch into the previous one, because the
> unconditional build causes issues for other x86 targets, see:
> https://dev.azure.com/bmeng/GitHub/_build/results?buildId=153&view=logs&j=8a1d3be7-a4c9-55b6-774d-e7f1a8f80847&t=b2f224a7-1103-5b52-edbc-3784ae727e03
>
Squashed in http://patchwork.ozlabs.org/patch/1232761/, and updated
previous patch to conditionally built itss.o.
see https://gitlab.denx.de/u-boot/custodians/u-boot-x86/commit/43709fa0888cc80648939ae1588307334e6cc267#ddd927c365d5269dbf9372226e38641da8d7c208_30_30
This way will keep bisectability.
applied to u-boot-x86, thanks!
Regards,
Bin
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] x86: apl: Include ITSS driver
2020-02-03 14:23 ` Bin Meng
@ 2020-02-04 5:05 ` Bin Meng
0 siblings, 0 replies; 9+ messages in thread
From: Bin Meng @ 2020-02-04 5:05 UTC (permalink / raw)
To: u-boot
On Mon, Feb 3, 2020 at 10:23 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Feb 3, 2020 at 9:07 PM Wolfgang Wallner
> <wolfgang.wallner@br-automation.com> wrote:
> >
> > Atuomatically select the ITSS driver when building for Apollo Lake.
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> >
> > ---
> >
> > arch/x86/cpu/apollolake/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Squashed into https://gitlab.denx.de/u-boot/custodians/u-boot-x86/commit/1d5bf32f0feaac806f85f128befd619cc81e7e08
for bisectability.
Regards,
Bin
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-02-04 5:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 13:06 [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver Wolfgang Wallner
2020-02-03 13:06 ` [PATCH 2/2] x86: apl: Include " Wolfgang Wallner
2020-02-03 13:36 ` Simon Glass
2020-02-03 14:23 ` Bin Meng
2020-02-04 5:05 ` Bin Meng
2020-02-03 13:36 ` [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable " Simon Glass
2020-02-03 14:23 ` Bin Meng
2020-02-04 2:35 ` Bin Meng
2020-02-04 5:03 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.