[PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

[PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

[Wolfgang Wallner]

Currently the ITSS driver is built unconditionally. Add a Kconfig option
to support enabling/disabling the inclusion of the ITSS driver depending
on the platform.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
---

 arch/x86/Kconfig                   | 6 ++++++
 arch/x86/cpu/intel_common/Makefile | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 89b93e5de2..b733d2264e 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -709,6 +709,12 @@ config ROM_TABLE_SIZE
 	hex
 	default 0x10000
 
+config HAVE_ITSS
+	bool "Enable ITSS"
+	help
+	  Select this to include the driver for the Interrupt Timer
+	  Subsystem (ITSS) which is found on several Intel devices.
+
 menu "System tables"
 	depends on !EFI && !SYS_COREBOOT
 
diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile
index 266e6e26fa..e22c70781d 100644
--- a/arch/x86/cpu/intel_common/Makefile
+++ b/arch/x86/cpu/intel_common/Makefile
@@ -27,7 +27,7 @@ obj-y += microcode.o
 endif
 endif
 obj-y += pch.o
-obj-y += itss.o
+obj-$(CONFIG_HAVE_ITSS) += itss.o
 
 ifdef CONFIG_SPL
 ifndef CONFIG_SPL_BUILD
-- 
2.25.0

[PATCH 2/2] x86: apl: Include ITSS driver

[Wolfgang Wallner]

Atuomatically select the ITSS driver when building for Apollo Lake.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>

---

 arch/x86/cpu/apollolake/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/cpu/apollolake/Kconfig b/arch/x86/cpu/apollolake/Kconfig
index fcff176c27..a760e0ac68 100644
--- a/arch/x86/cpu/apollolake/Kconfig
+++ b/arch/x86/cpu/apollolake/Kconfig
@@ -39,6 +39,7 @@ config INTEL_APOLLOLAKE
 	imply HAVE_X86_FIT
 	imply INTEL_GPIO
 	imply SMP
+	imply HAVE_ITSS
 
 if INTEL_APOLLOLAKE
 
-- 
2.25.0

[PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

[Simon Glass]

On Mon, 3 Feb 2020 at 06:07, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently the ITSS driver is built unconditionally. Add a Kconfig option
> to support enabling/disabling the inclusion of the ITSS driver depending
> on the platform.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
>  arch/x86/Kconfig                   | 6 ++++++
>  arch/x86/cpu/intel_common/Makefile | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH 2/2] x86: apl: Include ITSS driver

[Simon Glass]

On Mon, 3 Feb 2020 at 06:07, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Atuomatically select the ITSS driver when building for Apollo Lake.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
>  arch/x86/cpu/apollolake/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

[Bin Meng]

On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently the ITSS driver is built unconditionally. Add a Kconfig option
> to support enabling/disabling the inclusion of the ITSS driver depending
> on the platform.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
>  arch/x86/Kconfig                   | 6 ++++++
>  arch/x86/cpu/intel_common/Makefile | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[PATCH 2/2] x86: apl: Include ITSS driver

[Bin Meng]

On Mon, Feb 3, 2020 at 9:07 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Atuomatically select the ITSS driver when building for Apollo Lake.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
>  arch/x86/cpu/apollolake/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

[Bin Meng]

Hi Wolfgang,

On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently the ITSS driver is built unconditionally. Add a Kconfig option
> to support enabling/disabling the inclusion of the ITSS driver depending
> on the platform.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
>  arch/x86/Kconfig                   | 6 ++++++
>  arch/x86/cpu/intel_common/Makefile | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 89b93e5de2..b733d2264e 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -709,6 +709,12 @@ config ROM_TABLE_SIZE
>         hex
>         default 0x10000
>
> +config HAVE_ITSS
> +       bool "Enable ITSS"
> +       help
> +         Select this to include the driver for the Interrupt Timer
> +         Subsystem (ITSS) which is found on several Intel devices.
> +
>  menu "System tables"
>         depends on !EFI && !SYS_COREBOOT
>
> diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile
> index 266e6e26fa..e22c70781d 100644
> --- a/arch/x86/cpu/intel_common/Makefile
> +++ b/arch/x86/cpu/intel_common/Makefile
> @@ -27,7 +27,7 @@ obj-y += microcode.o
>  endif
>  endif
>  obj-y += pch.o
> -obj-y += itss.o
> +obj-$(CONFIG_HAVE_ITSS) += itss.o
>

I will have to squash this patch into the previous one, because the
unconditional build causes issues for other x86 targets, see:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=153&view=logs&j=8a1d3be7-a4c9-55b6-774d-e7f1a8f80847&t=b2f224a7-1103-5b52-edbc-3784ae727e03

Regards,
Bin

[PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

[Bin Meng]

On Tue, Feb 4, 2020 at 10:35 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Wolfgang,
>
> On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner
> <wolfgang.wallner@br-automation.com> wrote:
> >
> > Currently the ITSS driver is built unconditionally. Add a Kconfig option
> > to support enabling/disabling the inclusion of the ITSS driver depending
> > on the platform.
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > ---
> >
> >  arch/x86/Kconfig                   | 6 ++++++
> >  arch/x86/cpu/intel_common/Makefile | 2 +-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 89b93e5de2..b733d2264e 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -709,6 +709,12 @@ config ROM_TABLE_SIZE
> >         hex
> >         default 0x10000
> >
> > +config HAVE_ITSS
> > +       bool "Enable ITSS"
> > +       help
> > +         Select this to include the driver for the Interrupt Timer
> > +         Subsystem (ITSS) which is found on several Intel devices.
> > +
> >  menu "System tables"
> >         depends on !EFI && !SYS_COREBOOT
> >
> > diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile
> > index 266e6e26fa..e22c70781d 100644
> > --- a/arch/x86/cpu/intel_common/Makefile
> > +++ b/arch/x86/cpu/intel_common/Makefile
> > @@ -27,7 +27,7 @@ obj-y += microcode.o
> >  endif
> >  endif
> >  obj-y += pch.o
> > -obj-y += itss.o
> > +obj-$(CONFIG_HAVE_ITSS) += itss.o
> >
>
> I will have to squash this patch into the previous one, because the
> unconditional build causes issues for other x86 targets, see:
> https://dev.azure.com/bmeng/GitHub/_build/results?buildId=153&view=logs&j=8a1d3be7-a4c9-55b6-774d-e7f1a8f80847&t=b2f224a7-1103-5b52-edbc-3784ae727e03
>

Squashed in http://patchwork.ozlabs.org/patch/1232761/, and updated
previous patch to conditionally built itss.o.
see https://gitlab.denx.de/u-boot/custodians/u-boot-x86/commit/43709fa0888cc80648939ae1588307334e6cc267#ddd927c365d5269dbf9372226e38641da8d7c208_30_30

This way will keep bisectability.

applied to u-boot-x86, thanks!

Regards,
Bin

[PATCH 2/2] x86: apl: Include ITSS driver

[Bin Meng]

On Mon, Feb 3, 2020 at 10:23 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Feb 3, 2020 at 9:07 PM Wolfgang Wallner
> <wolfgang.wallner@br-automation.com> wrote:
> >
> > Atuomatically select the ITSS driver when building for Apollo Lake.
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> >
> > ---
> >
> >  arch/x86/cpu/apollolake/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Squashed into https://gitlab.denx.de/u-boot/custodians/u-boot-x86/commit/1d5bf32f0feaac806f85f128befd619cc81e7e08
for bisectability.

Regards,
Bin