* [U-Boot] [PATCH v3 0/2] mtd: nand: atmel: use another functions to set gpio value
@ 2017-03-23 4:55 Wenyou Yang
2017-03-23 4:55 ` [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define Wenyou Yang
2017-03-23 4:55 ` [U-Boot] [PATCH v3 2/2] mtd: nand: atmel: use another functions to set gpio value Wenyou Yang
0 siblings, 2 replies; 6+ messages in thread
From: Wenyou Yang @ 2017-03-23 4:55 UTC (permalink / raw)
To: u-boot
The purpose of the patch set is to use another functions to set
and get the gpio value for the atmel nand driver to fix the error
to set and get the gpio value after the at91 gpio driver conversion
to support the driver model.
Changes in v3:
_ Rebase on v2017.03.
Changes in v2:
- Improve the commit log.
- Add Reviewed-by tag.
Wenyou Yang (2):
ARM: at91: gpio: fix at91_set_gpio_value() define
mtd: nand: atmel: use another functions to set gpio value
arch/arm/mach-at91/include/mach/gpio.h | 12 +++++-------
drivers/mtd/nand/atmel_nand.c | 5 +++--
2 files changed, 8 insertions(+), 9 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define
2017-03-23 4:55 [U-Boot] [PATCH v3 0/2] mtd: nand: atmel: use another functions to set gpio value Wenyou Yang
@ 2017-03-23 4:55 ` Wenyou Yang
2017-04-01 4:21 ` Simon Glass
2017-03-23 4:55 ` [U-Boot] [PATCH v3 2/2] mtd: nand: atmel: use another functions to set gpio value Wenyou Yang
1 sibling, 1 reply; 6+ messages in thread
From: Wenyou Yang @ 2017-03-23 4:55 UTC (permalink / raw)
To: u-boot
When the CONFIG_ATMEL_LEGACY is undefined, according to the following
defines, at91_set_gpio_value() references to at91_set_pio_value(x, y)
with two parameters.
#define at91_set_gpio_value(x, y) at91_set_pio_value(x, y)
#define at91_get_gpio_value(x) at91_get_pio_value(x)
But there isn't the implementation of at91_set_pio_value(x, y) with
two parameters in U-Boot. This is an error.
Same as at91_get_gpio_value(x) define.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
Changes in v3: None
Changes in v2:
- Improve the commit log.
arch/arm/mach-at91/include/mach/gpio.h | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-at91/include/mach/gpio.h b/arch/arm/mach-at91/include/mach/gpio.h
index 5a32bdba8d..df0f71975a 100644
--- a/arch/arm/mach-at91/include/mach/gpio.h
+++ b/arch/arm/mach-at91/include/mach/gpio.h
@@ -223,15 +223,13 @@ static inline unsigned pin_to_mask(unsigned pin)
at91_set_pio_output((x - PIN_BASE) / 32,(x % 32), y)
#define at91_set_gpio_input(x, y) \
at91_set_pio_input((x - PIN_BASE) / 32,(x % 32), y)
-#define at91_set_gpio_value(x, y) \
- at91_set_pio_value((x - PIN_BASE) / 32,(x % 32), y)
-#define at91_get_gpio_value(x) \
- at91_get_pio_value((x - PIN_BASE) / 32,(x % 32))
-#else
-#define at91_set_gpio_value(x, y) at91_set_pio_value(x, y)
-#define at91_get_gpio_value(x) at91_get_pio_value(x)
#endif
+#define at91_set_gpio_value(x, y) \
+ at91_set_pio_value((x / 32), (x % 32), y)
+#define at91_get_gpio_value(x) \
+ at91_get_pio_value((x / 32), (x % 32))
+
#define GPIO_PIOA_BASE (0)
#define GPIO_PIOB_BASE (GPIO_PIOA_BASE + 32)
#define GPIO_PIOC_BASE (GPIO_PIOB_BASE + 32)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 2/2] mtd: nand: atmel: use another functions to set gpio value
2017-03-23 4:55 [U-Boot] [PATCH v3 0/2] mtd: nand: atmel: use another functions to set gpio value Wenyou Yang
2017-03-23 4:55 ` [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define Wenyou Yang
@ 2017-03-23 4:55 ` Wenyou Yang
2017-04-13 21:16 ` Simon Glass
1 sibling, 1 reply; 6+ messages in thread
From: Wenyou Yang @ 2017-03-23 4:55 UTC (permalink / raw)
To: u-boot
Because there isn't the implementation of gpio_set/get_value()
and gpio_set/get_value() after the at91 gpio driver is converted
to support the driver model, use at91_set_gpio_value() and
at91_get_gpio_value()
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
_ Rebase on v2017.03.
Changes in v2:
- Add Reviewed-by tag.
drivers/mtd/nand/atmel_nand.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 8669432deb..21d5d0e70d 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1222,7 +1222,8 @@ static void at91_nand_hwcontrol(struct mtd_info *mtd,
IO_ADDR_W |= CONFIG_SYS_NAND_MASK_ALE;
#ifdef CONFIG_SYS_NAND_ENABLE_PIN
- gpio_set_value(CONFIG_SYS_NAND_ENABLE_PIN, !(ctrl & NAND_NCE));
+ at91_set_gpio_value(CONFIG_SYS_NAND_ENABLE_PIN,
+ !(ctrl & NAND_NCE));
#endif
this->IO_ADDR_W = (void *) IO_ADDR_W;
}
@@ -1234,7 +1235,7 @@ static void at91_nand_hwcontrol(struct mtd_info *mtd,
#ifdef CONFIG_SYS_NAND_READY_PIN
static int at91_nand_ready(struct mtd_info *mtd)
{
- return gpio_get_value(CONFIG_SYS_NAND_READY_PIN);
+ return at91_get_gpio_value(CONFIG_SYS_NAND_READY_PIN);
}
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define
2017-03-23 4:55 ` [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define Wenyou Yang
@ 2017-04-01 4:21 ` Simon Glass
2017-04-13 21:16 ` Simon Glass
0 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2017-04-01 4:21 UTC (permalink / raw)
To: u-boot
On 22 March 2017 at 22:55, Wenyou Yang <wenyou.yang@atmel.com> wrote:
> When the CONFIG_ATMEL_LEGACY is undefined, according to the following
> defines, at91_set_gpio_value() references to at91_set_pio_value(x, y)
> with two parameters.
> #define at91_set_gpio_value(x, y) at91_set_pio_value(x, y)
> #define at91_get_gpio_value(x) at91_get_pio_value(x)
>
> But there isn't the implementation of at91_set_pio_value(x, y) with
> two parameters in U-Boot. This is an error.
>
> Same as at91_get_gpio_value(x) define.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Improve the commit log.
>
> arch/arm/mach-at91/include/mach/gpio.h | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define
2017-04-01 4:21 ` Simon Glass
@ 2017-04-13 21:16 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2017-04-13 21:16 UTC (permalink / raw)
To: u-boot
On 31 March 2017 at 22:21, Simon Glass <sjg@chromium.org> wrote:
> On 22 March 2017 at 22:55, Wenyou Yang <wenyou.yang@atmel.com> wrote:
>> When the CONFIG_ATMEL_LEGACY is undefined, according to the following
>> defines, at91_set_gpio_value() references to at91_set_pio_value(x, y)
>> with two parameters.
>> #define at91_set_gpio_value(x, y) at91_set_pio_value(x, y)
>> #define at91_get_gpio_value(x) at91_get_pio_value(x)
>>
>> But there isn't the implementation of at91_set_pio_value(x, y) with
>> two parameters in U-Boot. This is an error.
>>
>> Same as at91_get_gpio_value(x) define.
>>
>> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
>> ---
>>
>> Changes in v3: None
>> Changes in v2:
>> - Improve the commit log.
>>
>> arch/arm/mach-at91/include/mach/gpio.h | 12 +++++-------
>> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 2/2] mtd: nand: atmel: use another functions to set gpio value
2017-03-23 4:55 ` [U-Boot] [PATCH v3 2/2] mtd: nand: atmel: use another functions to set gpio value Wenyou Yang
@ 2017-04-13 21:16 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2017-04-13 21:16 UTC (permalink / raw)
To: u-boot
On 22 March 2017 at 22:55, Wenyou Yang <wenyou.yang@atmel.com> wrote:
> Because there isn't the implementation of gpio_set/get_value()
> and gpio_set/get_value() after the at91 gpio driver is converted
> to support the driver model, use at91_set_gpio_value() and
> at91_get_gpio_value()
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v3:
> _ Rebase on v2017.03.
>
> Changes in v2:
> - Add Reviewed-by tag.
>
> drivers/mtd/nand/atmel_nand.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-13 21:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-23 4:55 [U-Boot] [PATCH v3 0/2] mtd: nand: atmel: use another functions to set gpio value Wenyou Yang
2017-03-23 4:55 ` [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define Wenyou Yang
2017-04-01 4:21 ` Simon Glass
2017-04-13 21:16 ` Simon Glass
2017-03-23 4:55 ` [U-Boot] [PATCH v3 2/2] mtd: nand: atmel: use another functions to set gpio value Wenyou Yang
2017-04-13 21:16 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.