From: Simon Glass <sjg@chromium.org>
To: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Cc: Heiko Thiery <heiko.thiery@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type
Date: Tue, 8 Feb 2022 20:39:28 +0000 [thread overview]
Message-ID: <CAPnjgZ1s_0sE_pMV6O9ZX4DZe5KXGxMDAj93EyjqLUAUg4RxdA@mail.gmail.com> (raw)
In-Reply-To: <20220207220809.4497-5-alpernebiyasak@gmail.com>
The binman FIT entry type shares some code with the Section entry type.
This shared code is bound to grow, since FIT entries are conceptually a
variation of Section entries.
Make FIT entry type a subclass of Section entry type, simplifying it a
bit and providing us the features that Section implements. Also fix the
subentry alignment test which now attempts to write symbols to a
nonexistent SPL ELF test file by creating it first.
Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Add tag: "Reviewed-by: Simon Glass <sjg@chromium.org>"
tools/binman/etype/fit.py | 70 +++++++++++----------------------------
tools/binman/ftest.py | 1 +
2 files changed, 20 insertions(+), 51 deletions(-)
Applied to u-boot-dm, thanks!
next prev parent reply other threads:[~2022-02-08 20:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 22:08 [PATCH v2 0/5] binman: Improvements to FIT entry type Alper Nebi Yasak
2022-02-07 22:08 ` [PATCH v2 1/5] binman: Fix subentry expansion for " Alper Nebi Yasak
2022-02-08 15:05 ` Simon Glass
2022-02-08 20:39 ` Simon Glass
2022-02-07 22:08 ` [PATCH v2 2/5] binman: Register and check bintools from FIT subentries Alper Nebi Yasak
2022-02-07 22:08 ` [PATCH v2 3/5] binman: Check missing bintools of Section subclasses Alper Nebi Yasak
2022-02-07 22:08 ` [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type Alper Nebi Yasak
2022-02-14 9:09 ` Jan Kiszka
2022-02-15 12:27 ` Alper Nebi Yasak
2022-02-15 16:50 ` Jan Kiszka
2022-02-15 17:06 ` Jan Kiszka
2022-02-18 16:50 ` Jan Kiszka
2022-02-18 17:34 ` Alper Nebi Yasak
2022-02-19 15:53 ` Simon Glass
2022-02-21 4:40 ` Simon Glass
2022-02-22 18:58 ` Alper Nebi Yasak
2022-02-23 22:59 ` Simon Glass
2022-02-28 11:48 ` Jan Kiszka
2022-02-28 13:51 ` Alper Nebi Yasak
2022-02-28 13:56 ` Simon Glass
2022-02-28 14:14 ` Jan Kiszka
2022-02-07 22:08 ` [PATCH v2 5/5] binman: Update image positions of FIT subentries Alper Nebi Yasak
2022-02-08 20:43 ` Simon Glass
2022-02-23 2:35 ` Simon Glass
2022-02-08 20:39 ` Simon Glass [this message]
2022-02-08 20:39 ` [PATCH v2 3/5] binman: Check missing bintools of Section subclasses Simon Glass
2022-02-08 20:39 ` [PATCH v2 2/5] binman: Register and check bintools from FIT subentries Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ1s_0sE_pMV6O9ZX4DZe5KXGxMDAj93EyjqLUAUg4RxdA@mail.gmail.com \
--to=sjg@chromium.org \
--cc=alpernebiyasak@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.