Re: [PATCH v2 1/5] binman: Fix subentry expansion for FIT entry type

[Simon Glass <sjg@chromium.org>]

On Mon, 7 Feb 2022 at 15:08, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> Binman tries to expand some entries into parts that make it up, e.g.
> 'u-boot' into a 'u-boot-expanded' section that contains 'u-boot-nodtb'
> and 'u-boot-dtb'. Entries with child entries must call ExpandEntries()
> on them to build a correct image, as it's possible that unexpanded child
> entries have no data of their own. The FIT entry type doesn't currently
> do this, which means putting a "u-boot" entry inside it doesn't work as
> expected.
>
> Implement ExpandEntries() for FIT and add a copy of a simple FIT image
> test that checks subentry expansion in FIT entries.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
> ---
>
> Changes in v2:
> - Split reused testSimpleFit code into a helper function
>
>  tools/binman/etype/fit.py |  5 +++++
>  tools/binman/ftest.py     | 33 ++++++++++++++++++++++++---------
>  2 files changed, 29 insertions(+), 9 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

I missed the duplicate number on the dts, but will fix that when applying.

>
Applied to u-boot-dm, thanks!