* [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV @ 2017-05-30 7:57 Martin Jansa 2017-05-30 16:07 ` Khem Raj 0 siblings, 1 reply; 12+ messages in thread From: Martin Jansa @ 2017-05-30 7:57 UTC (permalink / raw) To: yocto * use latest revision in rpi-4.11.y branch * using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order to convert AUTOREV to currently latest SRCREV even when you don't use linux-raspberrypi_dev at all, just happen to have meta-raspberrypi layer in your bblayers.conf, that's bad for people who want to be able to build without network access (completely from premirror) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> --- recipes-kernel/linux/linux-raspberrypi_dev.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes-kernel/linux/linux-raspberrypi_dev.bb b/recipes-kernel/linux/linux-raspberrypi_dev.bb index 239d630..06771b9 100644 --- a/recipes-kernel/linux/linux-raspberrypi_dev.bb +++ b/recipes-kernel/linux/linux-raspberrypi_dev.bb @@ -3,7 +3,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-dev:" LINUX_VERSION ?= "4.11" LINUX_RPI_DEV_BRANCH ?= "rpi-4.11.y" -SRCREV = "${AUTOREV}" +SRCREV = "3b3178eb6c0ddea0a6856f16f52b5d2c21ed9299" SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=${LINUX_RPI_DEV_BRANCH} \ file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \ " -- 2.13.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-05-30 7:57 [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV Martin Jansa @ 2017-05-30 16:07 ` Khem Raj 2017-05-30 17:15 ` Paul Barker 0 siblings, 1 reply; 12+ messages in thread From: Khem Raj @ 2017-05-30 16:07 UTC (permalink / raw) To: Martin Jansa; +Cc: yocto On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <martin.jansa@gmail.com> wrote: > * use latest revision in rpi-4.11.y branch > * using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order > to convert AUTOREV to currently latest SRCREV even when you don't use linux-raspberrypi_dev > at all, just happen to have meta-raspberrypi layer in your bblayers.conf, that's bad for > people who want to be able to build without network access (completely from premirror) > These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is. 1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?= 2. Delete the recipe completely. We lose some of upstream testing. > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > --- > recipes-kernel/linux/linux-raspberrypi_dev.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-kernel/linux/linux-raspberrypi_dev.bb b/recipes-kernel/linux/linux-raspberrypi_dev.bb > index 239d630..06771b9 100644 > --- a/recipes-kernel/linux/linux-raspberrypi_dev.bb > +++ b/recipes-kernel/linux/linux-raspberrypi_dev.bb > @@ -3,7 +3,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-dev:" > LINUX_VERSION ?= "4.11" > LINUX_RPI_DEV_BRANCH ?= "rpi-4.11.y" > > -SRCREV = "${AUTOREV}" > +SRCREV = "3b3178eb6c0ddea0a6856f16f52b5d2c21ed9299" > SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=${LINUX_RPI_DEV_BRANCH} \ > file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \ > " > -- > 2.13.0 > > -- > _______________________________________________ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-05-30 16:07 ` Khem Raj @ 2017-05-30 17:15 ` Paul Barker 2017-05-30 17:25 ` Andre McCurdy 0 siblings, 1 reply; 12+ messages in thread From: Paul Barker @ 2017-05-30 17:15 UTC (permalink / raw) To: Khem Raj; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 1075 bytes --] On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <martin.jansa@gmail.com> wrote: > * use latest revision in rpi-4.11.y branch > * using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order > to convert AUTOREV to currently latest SRCREV even when you don't use linux-raspberrypi_dev > at all, just happen to have meta-raspberrypi layer in your bblayers.conf, that's bad for > people who want to be able to build without network access (completely from premirror) > These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is. 1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?= 2. Delete the recipe completely. We lose some of upstream testing. We should be able to skip the recipe if it isn't selected as the preferred version and/or provider of "virtual/kernel". I'm out at the minute so can't look at it now but will try to take a look later this week. [-- Attachment #2: Type: text/html, Size: 1678 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-05-30 17:15 ` Paul Barker @ 2017-05-30 17:25 ` Andre McCurdy 2017-05-30 17:29 ` Khem Raj 0 siblings, 1 reply; 12+ messages in thread From: Andre McCurdy @ 2017-05-30 17:25 UTC (permalink / raw) To: Paul Barker; +Cc: yocto On Tue, May 30, 2017 at 10:15 AM, Paul Barker <pbarker@toganlabs.com> wrote: > On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: > > On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <martin.jansa@gmail.com> > wrote: >> * use latest revision in rpi-4.11.y branch >> * using AUTOREV causes bitbake to run git ls-remote on the github.com >> repository in order >> to convert AUTOREV to currently latest SRCREV even when you don't use >> linux-raspberrypi_dev >> at all, just happen to have meta-raspberrypi layer in your >> bblayers.conf, that's bad for >> people who want to be able to build without network access (completely >> from premirror) >> > > These branches get rebased often so locking SRCREV caused another > kind of problem. what we can do is. > > 1. Let user like you override the SRCREC via a bbappend or conf file. > so change the assignment to ?= > 2. Delete the recipe completely. We lose some of upstream testing. > > We should be able to skip the recipe if it isn't selected as the preferred > version and/or provider of "virtual/kernel". I'm out at the minute so can't > look at it now but will try to take a look later this week. The linux-yocto-dev.bb recipe contains an example of doing that. > -- > _______________________________________________ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-05-30 17:25 ` Andre McCurdy @ 2017-05-30 17:29 ` Khem Raj 2017-06-01 0:00 ` Andrei Gherzan 0 siblings, 1 reply; 12+ messages in thread From: Khem Raj @ 2017-05-30 17:29 UTC (permalink / raw) To: Andre McCurdy; +Cc: yocto On Tue, May 30, 2017 at 10:25 AM, Andre McCurdy <armccurdy@gmail.com> wrote: > On Tue, May 30, 2017 at 10:15 AM, Paul Barker <pbarker@toganlabs.com> wrote: >> On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: >> >> On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <martin.jansa@gmail.com> >> wrote: >>> * use latest revision in rpi-4.11.y branch >>> * using AUTOREV causes bitbake to run git ls-remote on the github.com >>> repository in order >>> to convert AUTOREV to currently latest SRCREV even when you don't use >>> linux-raspberrypi_dev >>> at all, just happen to have meta-raspberrypi layer in your >>> bblayers.conf, that's bad for >>> people who want to be able to build without network access (completely >>> from premirror) >>> >> >> These branches get rebased often so locking SRCREV caused another >> kind of problem. what we can do is. >> >> 1. Let user like you override the SRCREC via a bbappend or conf file. >> so change the assignment to ?= >> 2. Delete the recipe completely. We lose some of upstream testing. >> >> We should be able to skip the recipe if it isn't selected as the preferred >> version and/or provider of "virtual/kernel". I'm out at the minute so can't >> look at it now but will try to take a look later this week. > > The linux-yocto-dev.bb recipe contains an example of doing that. > ah perfect. Thats what we need here http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28 please rename the recipe to be linux-raspberrypi-dev.bb and add the magic above and send a v2 >> -- >> _______________________________________________ >> yocto mailing list >> yocto@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/yocto >> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-05-30 17:29 ` Khem Raj @ 2017-06-01 0:00 ` Andrei Gherzan 2017-06-01 0:17 ` Khem Raj 0 siblings, 1 reply; 12+ messages in thread From: Andrei Gherzan @ 2017-06-01 0:00 UTC (permalink / raw) To: Khem Raj; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 1970 bytes --] On Tue, May 30, 2017 at 6:29 PM, Khem Raj <raj.khem@gmail.com> wrote: > On Tue, May 30, 2017 at 10:25 AM, Andre McCurdy <armccurdy@gmail.com> > wrote: > > On Tue, May 30, 2017 at 10:15 AM, Paul Barker <pbarker@toganlabs.com> > wrote: > >> On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: > >> > >> On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <martin.jansa@gmail.com> > >> wrote: > >>> * use latest revision in rpi-4.11.y branch > >>> * using AUTOREV causes bitbake to run git ls-remote on the github.com > >>> repository in order > >>> to convert AUTOREV to currently latest SRCREV even when you don't use > >>> linux-raspberrypi_dev > >>> at all, just happen to have meta-raspberrypi layer in your > >>> bblayers.conf, that's bad for > >>> people who want to be able to build without network access > (completely > >>> from premirror) > >>> > >> > >> These branches get rebased often so locking SRCREV caused another > >> kind of problem. what we can do is. > >> > >> 1. Let user like you override the SRCREC via a bbappend or conf file. > >> so change the assignment to ?= > >> 2. Delete the recipe completely. We lose some of upstream testing. > >> > >> We should be able to skip the recipe if it isn't selected as the > preferred > >> version and/or provider of "virtual/kernel". I'm out at the minute so > can't > >> look at it now but will try to take a look later this week. > > > > The linux-yocto-dev.bb recipe contains an example of doing that. > > > > ah perfect. Thats what we need here > > http://cgit.openembedded.org/openembedded-core/tree/meta/ > recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28 > > please rename the recipe to be linux-raspberrypi-dev.bb and add the magic > above and send a v2 > > Using the magic above we still hardcode a revision there. So if a user wants to compile the recipe without setting the preferred provider it will fail. -- Andrei Gherzan [-- Attachment #2: Type: text/html, Size: 3333 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-06-01 0:00 ` Andrei Gherzan @ 2017-06-01 0:17 ` Khem Raj 2017-06-01 6:10 ` Paul Barker 0 siblings, 1 reply; 12+ messages in thread From: Khem Raj @ 2017-06-01 0:17 UTC (permalink / raw) To: Andrei Gherzan; +Cc: yocto On Wed, May 31, 2017 at 5:00 PM, Andrei Gherzan <andrei@gherzan.ro> wrote: > > On Tue, May 30, 2017 at 6:29 PM, Khem Raj <raj.khem@gmail.com> wrote: >> >> On Tue, May 30, 2017 at 10:25 AM, Andre McCurdy <armccurdy@gmail.com> >> wrote: >> > On Tue, May 30, 2017 at 10:15 AM, Paul Barker <pbarker@toganlabs.com> >> > wrote: >> >> On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: >> >> >> >> On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <martin.jansa@gmail.com> >> >> wrote: >> >>> * use latest revision in rpi-4.11.y branch >> >>> * using AUTOREV causes bitbake to run git ls-remote on the github.com >> >>> repository in order >> >>> to convert AUTOREV to currently latest SRCREV even when you don't >> >>> use >> >>> linux-raspberrypi_dev >> >>> at all, just happen to have meta-raspberrypi layer in your >> >>> bblayers.conf, that's bad for >> >>> people who want to be able to build without network access >> >>> (completely >> >>> from premirror) >> >>> >> >> >> >> These branches get rebased often so locking SRCREV caused another >> >> kind of problem. what we can do is. >> >> >> >> 1. Let user like you override the SRCREC via a bbappend or conf file. >> >> so change the assignment to ?= >> >> 2. Delete the recipe completely. We lose some of upstream testing. >> >> >> >> We should be able to skip the recipe if it isn't selected as the >> >> preferred >> >> version and/or provider of "virtual/kernel". I'm out at the minute so >> >> can't >> >> look at it now but will try to take a look later this week. >> > >> > The linux-yocto-dev.bb recipe contains an example of doing that. >> > >> >> ah perfect. Thats what we need here >> >> >> http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28 >> >> please rename the recipe to be linux-raspberrypi-dev.bb and add the magic >> above and send a v2 >> > > Using the magic above we still hardcode a revision there. So if a user wants > to compile the recipe without setting the preferred provider it will fail. what will be the usecase ? when you have a different kernel selected but woould like to compile yet another kernel that rev can be a well known rev like branchpoint. Moreover, I think if someone wants to use the dev recipe then its expected that they switch to using AUTOREV or some other local mechanism for pinning if needed. > > -- > Andrei Gherzan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-06-01 0:17 ` Khem Raj @ 2017-06-01 6:10 ` Paul Barker 2017-06-01 7:08 ` Martin Jansa 0 siblings, 1 reply; 12+ messages in thread From: Paul Barker @ 2017-06-01 6:10 UTC (permalink / raw) To: Khem Raj; +Cc: yocto On Thu, Jun 1, 2017 at 1:17 AM, Khem Raj <raj.khem@gmail.com> wrote: > On Wed, May 31, 2017 at 5:00 PM, Andrei Gherzan <andrei@gherzan.ro> wrote: >> >> On Tue, May 30, 2017 at 6:29 PM, Khem Raj <raj.khem@gmail.com> wrote: >>> >>> On Tue, May 30, 2017 at 10:25 AM, Andre McCurdy <armccurdy@gmail.com> >>> wrote: >>> > On Tue, May 30, 2017 at 10:15 AM, Paul Barker <pbarker@toganlabs.com> >>> > wrote: >>> >> On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: >>> >> >>> >> On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <martin.jansa@gmail.com> >>> >> wrote: >>> >>> * use latest revision in rpi-4.11.y branch >>> >>> * using AUTOREV causes bitbake to run git ls-remote on the github.com >>> >>> repository in order >>> >>> to convert AUTOREV to currently latest SRCREV even when you don't >>> >>> use >>> >>> linux-raspberrypi_dev >>> >>> at all, just happen to have meta-raspberrypi layer in your >>> >>> bblayers.conf, that's bad for >>> >>> people who want to be able to build without network access >>> >>> (completely >>> >>> from premirror) >>> >>> >>> >> >>> >> These branches get rebased often so locking SRCREV caused another >>> >> kind of problem. what we can do is. >>> >> >>> >> 1. Let user like you override the SRCREC via a bbappend or conf file. >>> >> so change the assignment to ?= >>> >> 2. Delete the recipe completely. We lose some of upstream testing. >>> >> >>> >> We should be able to skip the recipe if it isn't selected as the >>> >> preferred >>> >> version and/or provider of "virtual/kernel". I'm out at the minute so >>> >> can't >>> >> look at it now but will try to take a look later this week. >>> > >>> > The linux-yocto-dev.bb recipe contains an example of doing that. >>> > >>> >>> ah perfect. Thats what we need here >>> >>> >>> http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28 >>> >>> please rename the recipe to be linux-raspberrypi-dev.bb and add the magic >>> above and send a v2 >>> >> >> Using the magic above we still hardcode a revision there. So if a user wants >> to compile the recipe without setting the preferred provider it will fail. > > what will be the usecase ? when you have a different kernel selected but > woould like to compile yet another kernel > > that rev can be a well known rev like branchpoint. Moreover, I think > if someone wants to use the dev recipe then its expected that they > switch > to using AUTOREV or some other local mechanism for pinning if needed. > I was thinking of a different approach entirerly. We can add the following at the top of the recipe file: python __anonymous() { if "linux-raspberrypi-dev" not in d.getVar("PREFERRED_PROVIDER_virtual/kernel"): msg = "Skipping linux-raspberrypi-dev as it is not the preferred " + \ "provider of virtual/kernel." raise bb.parse.SkipRecipe(msg) } (Hopefully gmail won't mangle that too much) I've just tested it and it works fine as long as it's before the use of ${AUTOREV}. If there's no objections to this approach I'll submit a patch. Cheers, -- Paul Barker Co-Founder & Principal Engineer Togán Labs Ltd ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-06-01 6:10 ` Paul Barker @ 2017-06-01 7:08 ` Martin Jansa 2017-06-01 7:10 ` Martin Jansa 0 siblings, 1 reply; 12+ messages in thread From: Martin Jansa @ 2017-06-01 7:08 UTC (permalink / raw) To: Paul Barker; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 3927 bytes --] Yes, Paul approach looks good to me, I think it was what was suggested in first replies to my SRCREV change and I agree with that, I just haven't had time to send updated patch. Paul if you have the patch ready please send it, thanks!. On Thu, Jun 1, 2017 at 8:10 AM, Paul Barker <pbarker@toganlabs.com> wrote: > On Thu, Jun 1, 2017 at 1:17 AM, Khem Raj <raj.khem@gmail.com> wrote: > > On Wed, May 31, 2017 at 5:00 PM, Andrei Gherzan <andrei@gherzan.ro> > wrote: > >> > >> On Tue, May 30, 2017 at 6:29 PM, Khem Raj <raj.khem@gmail.com> wrote: > >>> > >>> On Tue, May 30, 2017 at 10:25 AM, Andre McCurdy <armccurdy@gmail.com> > >>> wrote: > >>> > On Tue, May 30, 2017 at 10:15 AM, Paul Barker <pbarker@toganlabs.com > > > >>> > wrote: > >>> >> On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: > >>> >> > >>> >> On Tue, May 30, 2017 at 12:57 AM, Martin Jansa < > martin.jansa@gmail.com> > >>> >> wrote: > >>> >>> * use latest revision in rpi-4.11.y branch > >>> >>> * using AUTOREV causes bitbake to run git ls-remote on the > github.com > >>> >>> repository in order > >>> >>> to convert AUTOREV to currently latest SRCREV even when you don't > >>> >>> use > >>> >>> linux-raspberrypi_dev > >>> >>> at all, just happen to have meta-raspberrypi layer in your > >>> >>> bblayers.conf, that's bad for > >>> >>> people who want to be able to build without network access > >>> >>> (completely > >>> >>> from premirror) > >>> >>> > >>> >> > >>> >> These branches get rebased often so locking SRCREV caused another > >>> >> kind of problem. what we can do is. > >>> >> > >>> >> 1. Let user like you override the SRCREC via a bbappend or conf > file. > >>> >> so change the assignment to ?= > >>> >> 2. Delete the recipe completely. We lose some of upstream testing. > >>> >> > >>> >> We should be able to skip the recipe if it isn't selected as the > >>> >> preferred > >>> >> version and/or provider of "virtual/kernel". I'm out at the minute > so > >>> >> can't > >>> >> look at it now but will try to take a look later this week. > >>> > > >>> > The linux-yocto-dev.bb recipe contains an example of doing that. > >>> > > >>> > >>> ah perfect. Thats what we need here > >>> > >>> > >>> http://cgit.openembedded.org/openembedded-core/tree/meta/ > recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28 > >>> > >>> please rename the recipe to be linux-raspberrypi-dev.bb and add the > magic > >>> above and send a v2 > >>> > >> > >> Using the magic above we still hardcode a revision there. So if a user > wants > >> to compile the recipe without setting the preferred provider it will > fail. > > > > what will be the usecase ? when you have a different kernel selected but > > woould like to compile yet another kernel > > > > that rev can be a well known rev like branchpoint. Moreover, I think > > if someone wants to use the dev recipe then its expected that they > > switch > > to using AUTOREV or some other local mechanism for pinning if needed. > > > > I was thinking of a different approach entirerly. We can add the > following at the top of the recipe file: > > python __anonymous() { > if "linux-raspberrypi-dev" not in > d.getVar("PREFERRED_PROVIDER_virtual/kernel"): > msg = "Skipping linux-raspberrypi-dev as it is not the preferred " > + \ > "provider of virtual/kernel." > raise bb.parse.SkipRecipe(msg) > } > > (Hopefully gmail won't mangle that too much) > > I've just tested it and it works fine as long as it's before the use > of ${AUTOREV}. If there's no objections to this approach I'll submit a > patch. > > Cheers, > > -- > Paul Barker > Co-Founder & Principal Engineer > Togán Labs Ltd > -- > _______________________________________________ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto > [-- Attachment #2: Type: text/html, Size: 6241 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-06-01 7:08 ` Martin Jansa @ 2017-06-01 7:10 ` Martin Jansa 2017-06-01 11:23 ` Paul Barker 0 siblings, 1 reply; 12+ messages in thread From: Martin Jansa @ 2017-06-01 7:10 UTC (permalink / raw) To: Paul Barker; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 4344 bytes --] And it's not clear from the diff you send, but like linux-yocto-dev.bb example above, the recipe needs to be renamed from linux-raspberrypi_dev.bb to linux-raspberrypi-dev.bb to make it different provider. On Thu, Jun 1, 2017 at 9:08 AM, Martin Jansa <martin.jansa@gmail.com> wrote: > Yes, Paul approach looks good to me, I think it was what was suggested in > first replies to my SRCREV change and I agree with that, I just haven't had > time to send updated patch. > > Paul if you have the patch ready please send it, thanks!. > > On Thu, Jun 1, 2017 at 8:10 AM, Paul Barker <pbarker@toganlabs.com> wrote: > >> On Thu, Jun 1, 2017 at 1:17 AM, Khem Raj <raj.khem@gmail.com> wrote: >> > On Wed, May 31, 2017 at 5:00 PM, Andrei Gherzan <andrei@gherzan.ro> >> wrote: >> >> >> >> On Tue, May 30, 2017 at 6:29 PM, Khem Raj <raj.khem@gmail.com> wrote: >> >>> >> >>> On Tue, May 30, 2017 at 10:25 AM, Andre McCurdy <armccurdy@gmail.com> >> >>> wrote: >> >>> > On Tue, May 30, 2017 at 10:15 AM, Paul Barker < >> pbarker@toganlabs.com> >> >>> > wrote: >> >>> >> On 30 May 2017 5:08 p.m., "Khem Raj" <raj.khem@gmail.com> wrote: >> >>> >> >> >>> >> On Tue, May 30, 2017 at 12:57 AM, Martin Jansa < >> martin.jansa@gmail.com> >> >>> >> wrote: >> >>> >>> * use latest revision in rpi-4.11.y branch >> >>> >>> * using AUTOREV causes bitbake to run git ls-remote on the >> github.com >> >>> >>> repository in order >> >>> >>> to convert AUTOREV to currently latest SRCREV even when you >> don't >> >>> >>> use >> >>> >>> linux-raspberrypi_dev >> >>> >>> at all, just happen to have meta-raspberrypi layer in your >> >>> >>> bblayers.conf, that's bad for >> >>> >>> people who want to be able to build without network access >> >>> >>> (completely >> >>> >>> from premirror) >> >>> >>> >> >>> >> >> >>> >> These branches get rebased often so locking SRCREV caused another >> >>> >> kind of problem. what we can do is. >> >>> >> >> >>> >> 1. Let user like you override the SRCREC via a bbappend or conf >> file. >> >>> >> so change the assignment to ?= >> >>> >> 2. Delete the recipe completely. We lose some of upstream testing. >> >>> >> >> >>> >> We should be able to skip the recipe if it isn't selected as the >> >>> >> preferred >> >>> >> version and/or provider of "virtual/kernel". I'm out at the minute >> so >> >>> >> can't >> >>> >> look at it now but will try to take a look later this week. >> >>> > >> >>> > The linux-yocto-dev.bb recipe contains an example of doing that. >> >>> > >> >>> >> >>> ah perfect. Thats what we need here >> >>> >> >>> >> >>> http://cgit.openembedded.org/openembedded-core/tree/meta/rec >> ipes-kernel/linux/linux-yocto-dev.bb?h=master#n28 >> >>> >> >>> please rename the recipe to be linux-raspberrypi-dev.bb and add the >> magic >> >>> above and send a v2 >> >>> >> >> >> >> Using the magic above we still hardcode a revision there. So if a user >> wants >> >> to compile the recipe without setting the preferred provider it will >> fail. >> > >> > what will be the usecase ? when you have a different kernel selected but >> > woould like to compile yet another kernel >> > >> > that rev can be a well known rev like branchpoint. Moreover, I think >> > if someone wants to use the dev recipe then its expected that they >> > switch >> > to using AUTOREV or some other local mechanism for pinning if needed. >> > >> >> I was thinking of a different approach entirerly. We can add the >> following at the top of the recipe file: >> >> python __anonymous() { >> if "linux-raspberrypi-dev" not in >> d.getVar("PREFERRED_PROVIDER_virtual/kernel"): >> msg = "Skipping linux-raspberrypi-dev as it is not the preferred >> " + \ >> "provider of virtual/kernel." >> raise bb.parse.SkipRecipe(msg) >> } >> >> (Hopefully gmail won't mangle that too much) >> >> I've just tested it and it works fine as long as it's before the use >> of ${AUTOREV}. If there's no objections to this approach I'll submit a >> patch. >> >> Cheers, >> >> -- >> Paul Barker >> Co-Founder & Principal Engineer >> Togán Labs Ltd >> -- >> _______________________________________________ >> yocto mailing list >> yocto@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/yocto >> > > [-- Attachment #2: Type: text/html, Size: 7230 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-06-01 7:10 ` Martin Jansa @ 2017-06-01 11:23 ` Paul Barker 2017-06-01 12:48 ` Andrei Gherzan 0 siblings, 1 reply; 12+ messages in thread From: Paul Barker @ 2017-06-01 11:23 UTC (permalink / raw) To: Martin Jansa; +Cc: yocto On Thu, Jun 1, 2017 at 8:10 AM, Martin Jansa <martin.jansa@gmail.com> wrote: > And it's not clear from the diff you send, but like linux-yocto-dev.bb > example above, the recipe needs to be renamed from linux-raspberrypi_dev.bb > to linux-raspberrypi-dev.bb to make it different provider. > > On Thu, Jun 1, 2017 at 9:08 AM, Martin Jansa <martin.jansa@gmail.com> wrote: >> >> Yes, Paul approach looks good to me, I think it was what was suggested in >> first replies to my SRCREV change and I agree with that, I just haven't had >> time to send updated patch. >> >> Paul if you have the patch ready please send it, thanks!. >> I've submitted the patch via GitHub as per the new contributing instructions for meta-raspberrypi. https://github.com/agherzan/meta-raspberrypi/pull/82 Cheers, -- Paul Barker Co-Founder & Principal Engineer Togán Labs Ltd ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV 2017-06-01 11:23 ` Paul Barker @ 2017-06-01 12:48 ` Andrei Gherzan 0 siblings, 0 replies; 12+ messages in thread From: Andrei Gherzan @ 2017-06-01 12:48 UTC (permalink / raw) To: Paul Barker; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 1102 bytes --] On Thu, Jun 1, 2017 at 12:23 PM, Paul Barker <pbarker@toganlabs.com> wrote: > On Thu, Jun 1, 2017 at 8:10 AM, Martin Jansa <martin.jansa@gmail.com> > wrote: > > And it's not clear from the diff you send, but like linux-yocto-dev.bb > > example above, the recipe needs to be renamed from > linux-raspberrypi_dev.bb > > to linux-raspberrypi-dev.bb to make it different provider. > > > > On Thu, Jun 1, 2017 at 9:08 AM, Martin Jansa <martin.jansa@gmail.com> > wrote: > >> > >> Yes, Paul approach looks good to me, I think it was what was suggested > in > >> first replies to my SRCREV change and I agree with that, I just haven't > had > >> time to send updated patch. > >> > >> Paul if you have the patch ready please send it, thanks!. > >> > > I've submitted the patch via GitHub as per the new contributing > instructions for meta-raspberrypi. > > https://github.com/agherzan/meta-raspberrypi/pull/82 > > Funny. This was exactly what I wanted to propose. If the warning noise does not bother anyone, I'm up for this solution. PR merged to master. -- Andrei Gherzan [-- Attachment #2: Type: text/html, Size: 2405 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-06-01 12:49 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-30 7:57 [PATCH][meta-raspberrypi] linux-raspberrypi_dev: don't use AUTOREV Martin Jansa 2017-05-30 16:07 ` Khem Raj 2017-05-30 17:15 ` Paul Barker 2017-05-30 17:25 ` Andre McCurdy 2017-05-30 17:29 ` Khem Raj 2017-06-01 0:00 ` Andrei Gherzan 2017-06-01 0:17 ` Khem Raj 2017-06-01 6:10 ` Paul Barker 2017-06-01 7:08 ` Martin Jansa 2017-06-01 7:10 ` Martin Jansa 2017-06-01 11:23 ` Paul Barker 2017-06-01 12:48 ` Andrei Gherzan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.