* [PATCH] drm/amdkfd: Fix a compiling warning
@ 2020-01-11 0:40 Yong Zhao
2020-01-11 0:46 ` Felix Kuehling
2020-01-13 14:12 ` Deucher, Alexander
0 siblings, 2 replies; 3+ messages in thread
From: Yong Zhao @ 2020-01-11 0:40 UTC (permalink / raw)
To: amd-gfx; +Cc: Yong Zhao
The warning was introduced in
commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e
Author: Yong Zhao <Yong.Zhao@amd.com>
Date: Fri Dec 13 11:31:48 2019 -0500
drm/amdkfd: Improve function get_sdma_rlc_reg_offset()
Change-Id: I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
index 2b26925623eb..f9011a07cb90 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
@@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
unsigned int engine_id,
unsigned int queue_id)
{
- uint32_t sdma_engine_reg_base;
+ uint32_t sdma_engine_reg_base = 0;
uint32_t sdma_rlc_reg_offset;
switch (engine_id) {
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdkfd: Fix a compiling warning
2020-01-11 0:40 [PATCH] drm/amdkfd: Fix a compiling warning Yong Zhao
@ 2020-01-11 0:46 ` Felix Kuehling
2020-01-13 14:12 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Felix Kuehling @ 2020-01-11 0:46 UTC (permalink / raw)
To: amd-gfx, Yong Zhao
On 2020-01-10 7:40 p.m., Yong Zhao wrote:
> The warning was introduced in
>
> commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e
> Author: Yong Zhao <Yong.Zhao@amd.com>
> Date: Fri Dec 13 11:31:48 2019 -0500
>
> drm/amdkfd: Improve function get_sdma_rlc_reg_offset()
>
> Change-Id: I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
> Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
Instead of quoting the whole change description, the usual way to point
to a prior patch that you're fixing is with a tag
Fixes: <12 digits of sha1> ("commit title")
With that fixed, this patch is
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> index 2b26925623eb..f9011a07cb90 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> @@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
> unsigned int engine_id,
> unsigned int queue_id)
> {
> - uint32_t sdma_engine_reg_base;
> + uint32_t sdma_engine_reg_base = 0;
> uint32_t sdma_rlc_reg_offset;
>
> switch (engine_id) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdkfd: Fix a compiling warning
2020-01-11 0:40 [PATCH] drm/amdkfd: Fix a compiling warning Yong Zhao
2020-01-11 0:46 ` Felix Kuehling
@ 2020-01-13 14:12 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2020-01-13 14:12 UTC (permalink / raw)
To: Zhao, Yong, amd-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1992 bytes --]
[AMD Official Use Only - Internal Distribution Only]
FWIW:
https://patchwork.freedesktop.org/patch/347923/
Alex
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Yong Zhao <Yong.Zhao@amd.com>
Sent: Friday, January 10, 2020 7:40 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Zhao, Yong <Yong.Zhao@amd.com>
Subject: [PATCH] drm/amdkfd: Fix a compiling warning
The warning was introduced in
commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e
Author: Yong Zhao <Yong.Zhao@amd.com>
Date: Fri Dec 13 11:31:48 2019 -0500
drm/amdkfd: Improve function get_sdma_rlc_reg_offset()
Change-Id: I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
index 2b26925623eb..f9011a07cb90 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
@@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
unsigned int engine_id,
unsigned int queue_id)
{
- uint32_t sdma_engine_reg_base;
+ uint32_t sdma_engine_reg_base = 0;
uint32_t sdma_rlc_reg_offset;
switch (engine_id) {
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C6428020902c0464fb20408d7962ee8c9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637143000578441842&sdata=VP7%2FbA3lxSX2l9Hx2TySiChP4VKBch2SQRNOei2wElw%3D&reserved=0
[-- Attachment #1.2: Type: text/html, Size: 4431 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-13 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-11 0:40 [PATCH] drm/amdkfd: Fix a compiling warning Yong Zhao
2020-01-11 0:46 ` Felix Kuehling
2020-01-13 14:12 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.