All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling
Date: Fri, 06 May 2016 06:44:01 +0000	[thread overview]
Message-ID: <CY1PR11MB0218498E60CACA99E39CA608947D0@CY1PR11MB0218.namprd11.prod.outlook.com> (raw)
In-Reply-To: <yq1inysvv12.fsf@sermon.lab.mkp.net>

Apologies for the delay. Patch looks good.

Acked by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>


-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com] 
Sent: 06 May 2016 06:54
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>; Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>; James E.J. Bottomley <jejb@linux.vnet.ibm.com>; Martin K. Petersen <martin.petersen@oracle.com>; linux-scsi <linux-scsi@vger.kernel.org>; kernel-janitors@vger.kernel.org
Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

>>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:

Dan> The caller assumes that "itnim" is NULL on error and non-NULL on 
Dan> success but really "itnim" is uninitialized on error.  This 
Dan> function should just use normal error handling where it returns 
Dan> zero on success and negative on failure.

Anil, please review:

	https://patchwork.kernel.org/patch/8820751/

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling
Date: Fri, 6 May 2016 06:44:01 +0000	[thread overview]
Message-ID: <CY1PR11MB0218498E60CACA99E39CA608947D0@CY1PR11MB0218.namprd11.prod.outlook.com> (raw)
In-Reply-To: <yq1inysvv12.fsf@sermon.lab.mkp.net>

Apologies for the delay. Patch looks good.

Acked by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>


-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com] 
Sent: 06 May 2016 06:54
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>; Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>; James E.J. Bottomley <jejb@linux.vnet.ibm.com>; Martin K. Petersen <martin.petersen@oracle.com>; linux-scsi <linux-scsi@vger.kernel.org>; kernel-janitors@vger.kernel.org
Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:

Dan> The caller assumes that "itnim" is NULL on error and non-NULL on 
Dan> success but really "itnim" is uninitialized on error.  This 
Dan> function should just use normal error handling where it returns 
Dan> zero on success and negative on failure.

Anil, please review:

	https://patchwork.kernel.org/patch/8820751/

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2016-05-06  6:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 10:59 [SCSI resend] bfa: fix bfa_fcb_itnim_alloc() error handling Dan Carpenter
2016-04-13 10:59 ` Dan Carpenter
2016-04-13 11:14 ` [PATCH resend v2] [SCSI] " Dan Carpenter
2016-04-13 11:14   ` Dan Carpenter
2016-05-06  1:23   ` Martin K. Petersen
2016-05-06  1:23     ` Martin K. Petersen
2016-05-06  6:44     ` Anil Gurumurthy [this message]
2016-05-06  6:44       ` Anil Gurumurthy
2016-05-10  2:19       ` Martin K. Petersen
2016-05-10  2:19         ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY1PR11MB0218498E60CACA99E39CA608947D0@CY1PR11MB0218.namprd11.prod.outlook.com \
    --to=anil.gurumurthy@qlogic.com \
    --cc=Sudarsana.Kalluru@qlogic.com \
    --cc=dan.carpenter@oracle.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.