From: Ilya Smith <blackzert@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
Rich Felker <dalias@libc.org>, Jan Kara <jack@suse.cz>,
linux-sh <linux-sh@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Bhupesh Sharma <bhsharma@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Michal Hocko <mhocko@kernel.org>, Linux-MM <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux <sparclinux@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
Helge Deller <deller@gmx.de>, X86 ML <x86@kernel.org>,
Hugh Dickins <hu
Subject: Re: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.
Date: Tue, 3 Apr 2018 03:11:50 +0300 [thread overview]
Message-ID: <D9173B50-39D6-4EE5-AF8B-3EB50D0C9A3B@gmail.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7B3B8BC5@ORSMSX110.amr.corp.intel.com>
PiBPbiAyOSBNYXIgMjAxOCwgYXQgMDA6MDcsIEx1Y2ssIFRvbnkgPHRvbnkubHVja0BpbnRlbC5j
b20+IHdyb3RlOgo+IAo+PiBUaGUgZGVmYXVsdCBsaW1pdCBvZiBvbmx5IDY1NTM2IFZNQXMgd2ls
bCBhbHNvIHF1aWNrbHkgY29tZSBpbnRvIHBsYXkKPj4gaWYgY29uc2VjdXRpdmUgYW5vbiBtbWFw
cyBkb24ndCBnZXQgbWVyZ2VkLiBPZiBjb3Vyc2UgdGhpcyBjYW4gYmUKPj4gcmFpc2VkLCBidXQg
aXQgaGFzIHNpZ25pZmljYW50IHJlc291cmNlIGFuZCBwZXJmb3JtYW5jZSAoZm9yaykgY29zdHMu
Cj4gCj4gQ291bGQgdGhlIHJhbmRvbSBtbWFwIGFkZHJlc3MgY2hvb3NlciBsb29rIGZvciBob3cg
bWFueSBleGlzdGluZwo+IFZNQXMgaGF2ZSBzcGFjZSBiZWZvcmUvYWZ0ZXIgYW5kIHRoZSByaWdo
dCBhdHRyaWJ1dGVzIHRvIG1lcmdlIHdpdGggdGhlCj4gbmV3IG9uZSB5b3Ugd2FudCB0byBjcmVh
dGU/IElmIHRoaXMgaXMgYWJvdmUgc29tZSB0aHJlc2hvbGQgKDEwMD8pIHRoZW4KPiBwaWNrIG9u
ZSBvZiB0aGVtIHJhbmRvbWx5IGFuZCBhbGxvY2F0ZSB0aGUgbmV3IGFkZHJlc3Mgc28gdGhhdCBp
dCB3aWxsCj4gbWVyZ2UgZnJvbSBiZWxvdy9hYm92ZSB3aXRoIGFuIGV4aXN0aW5nIG9uZS4KPiAK
PiBUaGF0IHNob3VsZCBzdGlsbCBnaXZlIHlvdSBhIHZlcnkgaGlnaCBkZWdyZWUgb2YgcmFuZG9t
bmVzcywgYnV0IHByZXZlbnQKPiBvdXQgb2YgY29udHJvbCBudW1iZXJzIG9mIFZNQXMgZnJvbSBi
ZWluZyBjcmVhdGVkLgoKSSB0aGluayB0aGlzIHdvdWxkbuKAmXQgd29yay4gRm9yIGV4YW1wbGUg
dGhlc2UgMTAwIGFsbG9jYXRpb24gbWF5IGhhcHBlbmVkIG9uIApwcm9jZXNzIGluaXRpYWxpemF0
aW9uLiBCdXQgd2hlbiBhdHRhY2tlciBjb21lIHRvIHRoZSBzZXJ2ZXIgYWxsIGhpcyAKYWxsb2Nh
dGlvbnMgd291bGQgYmUgbWFkZSBvbiB0aGUgcHJlZGljdGFibGUgb2Zmc2V0cyBmcm9tIGVhY2gg
b3RoZXIuIFNvIGluIApyZXN1bHQgd2UgZGlkIG5vdGhpbmcganVzdCBkZWNyZWFzZSBwZXJmb3Jt
YW5jZSBvZiBmaXJzdCAxMDAgYWxsb2NhdGlvbnMuIEkgCnRoaW5rIEkgY2FuIG1ha2UgaW9jdGwg
dG8gdHVybiBvZmYgdGhpcyByYW5kb21pemF0aW9uIHBlciBwcm9jZXNzIGFuZCBpdCBjb3VsZCAK
YmUgdXNlZCBpZiBuZWVkZWQuIEZvciBleGFtcGxlIGlmIGFwcGxpY2F0aW9uIGdvaW5nIHRvIGFs
bG9jYXRlIGJpZyBjaHVuayBvciAKbWFrZSBiaWcgbWVtb3J5IHByZXNzdXJlLCBldGMuCgpCZXN0
IHJlZ2FyZHMsCklseWEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCmxpbnV4LXNucHMtYXJjIG1haWxpbmcgbGlzdApsaW51eC1zbnBzLWFyY0BsaXN0cy5p
bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v
bGludXgtc25wcy1hcmM=
WARNING: multiple messages have this Message-ID (diff)
From: Ilya Smith <blackzert@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Rich Felker <dalias@libc.org>,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Michal Hocko <mhocko@kernel.org>,
Richard Henderson <rth@twiddle.net>,
"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
"mattst88@gmail.com" <mattst88@gmail.com>,
Vineet Gupta <vgupta@synopsys.com>,
Russell King <linux@armlinux.org.uk>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>,
"nyc@holomorphy.com" <nyc@holomorphy.com>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Hugh Dickins <hughd@google.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Steve Capper <steve.capper@arm.com>,
Punit Agrawal <punit.agrawal@arm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Nick Piggin <npiggin@gmail.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
Rik van Riel <riel@redhat.com>,
"nitin.m.gupta@oracle.com" <nitin.m.gupta@oracle.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Jerome Glisse <jglisse@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-metag@vger.kernel.org" <linux-metag@vger.kernel.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
linux-parisc <linux-parisc@vger.kernel.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
linux-s390 <linux-s390@vger.kernel.org>,
linux-sh <linux-sh@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.
Date: Tue, 3 Apr 2018 03:11:50 +0300 [thread overview]
Message-ID: <D9173B50-39D6-4EE5-AF8B-3EB50D0C9A3B@gmail.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7B3B8BC5@ORSMSX110.amr.corp.intel.com>
> On 29 Mar 2018, at 00:07, Luck, Tony <tony.luck@intel.com> wrote:
>
>> The default limit of only 65536 VMAs will also quickly come into play
>> if consecutive anon mmaps don't get merged. Of course this can be
>> raised, but it has significant resource and performance (fork) costs.
>
> Could the random mmap address chooser look for how many existing
> VMAs have space before/after and the right attributes to merge with the
> new one you want to create? If this is above some threshold (100?) then
> pick one of them randomly and allocate the new address so that it will
> merge from below/above with an existing one.
>
> That should still give you a very high degree of randomness, but prevent
> out of control numbers of VMAs from being created.
I think this wouldn’t work. For example these 100 allocation may happened on
process initialization. But when attacker come to the server all his
allocations would be made on the predictable offsets from each other. So in
result we did nothing just decrease performance of first 100 allocations. I
think I can make ioctl to turn off this randomization per process and it could
be used if needed. For example if application going to allocate big chunk or
make big memory pressure, etc.
Best regards,
Ilya
WARNING: multiple messages have this Message-ID (diff)
From: Ilya Smith <blackzert@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Rich Felker <dalias@libc.org>,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Michal Hocko <mhocko@kernel.org>,
Richard Henderson <rth@twiddle.net>,
"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
"mattst88@gmail.com" <mattst88@gmail.com>,
Vineet Gupta <vgupta@synopsys.com>,
Russell King <linux@armlinux.org.uk>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>,
"nyc@holomorphy.com" <nyc@holomorphy.com>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Hugh Dickins <hughd@google.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Steve Capper <steve.capper@arm.com>,
Punit Agrawal <punit.agrawal@arm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Nick Piggin <npiggin@gmail.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
Rik van Riel <riel@redhat.com>,
"nitin.m.gupta@oracle.com" <nitin.m.gupta@oracle.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Jerome Glisse <jglisse@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-metag@vger.kernel.org" <linux-metag@vger.kernel.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
linux-parisc <linux-parisc@vger.kernel.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
linux-s390 <linux-s390@vger.kernel.org>,
linux-sh <linux-sh@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.
Date: Tue, 3 Apr 2018 03:11:50 +0300 [thread overview]
Message-ID: <D9173B50-39D6-4EE5-AF8B-3EB50D0C9A3B@gmail.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7B3B8BC5@ORSMSX110.amr.corp.intel.com>
> On 29 Mar 2018, at 00:07, Luck, Tony <tony.luck@intel.com> wrote:
>
>> The default limit of only 65536 VMAs will also quickly come into play
>> if consecutive anon mmaps don't get merged. Of course this can be
>> raised, but it has significant resource and performance (fork) costs.
>
> Could the random mmap address chooser look for how many existing
> VMAs have space before/after and the right attributes to merge with the
> new one you want to create? If this is above some threshold (100?) then
> pick one of them randomly and allocate the new address so that it will
> merge from below/above with an existing one.
>
> That should still give you a very high degree of randomness, but prevent
> out of control numbers of VMAs from being created.
I think this wouldn’t work. For example these 100 allocation may happened on
process initialization. But when attacker come to the server all his
allocations would be made on the predictable offsets from each other. So in
result we did nothing just decrease performance of first 100 allocations. I
think I can make ioctl to turn off this randomization per process and it could
be used if needed. For example if application going to allocate big chunk or
make big memory pressure, etc.
Best regards,
Ilya
WARNING: multiple messages have this Message-ID (diff)
From: Ilya Smith <blackzert@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Rich Felker <dalias@libc.org>,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Michal Hocko <mhocko@kernel.org>,
Richard Henderson <rth@twiddle.net>,
"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
"mattst88@gmail.com" <mattst88@gmail.com>,
Vineet Gupta <vgupta@synopsys.com>,
Russell King <linux@armlinux.org.uk>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>,
"nyc@holomorphy.com" <nyc@holomorphy.com>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Hugh Dickins <hughd@google.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Steve Capper <steve.capper@arm.com>,
Punit Agrawal <punit.agrawal@arm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Nick Piggin <npiggin@gmail.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
Rik van Riel <riel@redhat.com>,
"nitin.m.gupta@oracle.com" <nitin.m.gupta@oracle.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Jerome Glisse <jglisse@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-metag@vger.kernel.org" <linux-metag@vger.kernel.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
linux-parisc <linux-parisc@vger.kernel.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
linux-s390 <linux-s390@vger.kernel.org>,
linux-sh <linux-sh@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.
Date: Tue, 3 Apr 2018 03:11:50 +0300 [thread overview]
Message-ID: <D9173B50-39D6-4EE5-AF8B-3EB50D0C9A3B@gmail.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7B3B8BC5@ORSMSX110.amr.corp.intel.com>
> On 29 Mar 2018, at 00:07, Luck, Tony <tony.luck@intel.com> wrote:
>=20
>> The default limit of only 65536 VMAs will also quickly come into play
>> if consecutive anon mmaps don't get merged. Of course this can be
>> raised, but it has significant resource and performance (fork) costs.
>=20
> Could the random mmap address chooser look for how many existing
> VMAs have space before/after and the right attributes to merge with =
the
> new one you want to create? If this is above some threshold (100?) =
then
> pick one of them randomly and allocate the new address so that it will
> merge from below/above with an existing one.
>=20
> That should still give you a very high degree of randomness, but =
prevent
> out of control numbers of VMAs from being created.
I think this wouldn=E2=80=99t work. For example these 100 allocation may =
happened on=20
process initialization. But when attacker come to the server all his=20
allocations would be made on the predictable offsets from each other. So =
in=20
result we did nothing just decrease performance of first 100 =
allocations. I=20
think I can make ioctl to turn off this randomization per process and it =
could=20
be used if needed. For example if application going to allocate big =
chunk or=20
make big memory pressure, etc.
Best regards,
Ilya
WARNING: multiple messages have this Message-ID (diff)
From: blackzert@gmail.com (Ilya Smith)
To: linux-snps-arc@lists.infradead.org
Subject: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.
Date: Tue, 3 Apr 2018 03:11:50 +0300 [thread overview]
Message-ID: <D9173B50-39D6-4EE5-AF8B-3EB50D0C9A3B@gmail.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7B3B8BC5@ORSMSX110.amr.corp.intel.com>
> On 29 Mar 2018,@00:07, Luck, Tony <tony.luck@intel.com> wrote:
>
>> The default limit of only 65536 VMAs will also quickly come into play
>> if consecutive anon mmaps don't get merged. Of course this can be
>> raised, but it has significant resource and performance (fork) costs.
>
> Could the random mmap address chooser look for how many existing
> VMAs have space before/after and the right attributes to merge with the
> new one you want to create? If this is above some threshold (100?) then
> pick one of them randomly and allocate the new address so that it will
> merge from below/above with an existing one.
>
> That should still give you a very high degree of randomness, but prevent
> out of control numbers of VMAs from being created.
I think this wouldn?t work. For example these 100 allocation may happened on
process initialization. But when attacker come to the server all his
allocations would be made on the predictable offsets from each other. So in
result we did nothing just decrease performance of first 100 allocations. I
think I can make ioctl to turn off this randomization per process and it could
be used if needed. For example if application going to allocate big chunk or
make big memory pressure, etc.
Best regards,
Ilya
WARNING: multiple messages have this Message-ID (diff)
From: Ilya Smith <blackzert@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
Rich Felker <dalias@libc.org>, Jan Kara <jack@suse.cz>,
linux-sh <linux-sh@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Bhupesh Sharma <bhsharma@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Michal Hocko <mhocko@kernel.org>, Linux-MM <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux <sparclinux@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
Helge Deller <deller@gmx.de>, X86 ML <x86@kernel.org>,
Hugh Dickins <hu>
Subject: Re: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.
Date: Tue, 3 Apr 2018 03:11:50 +0300 [thread overview]
Message-ID: <D9173B50-39D6-4EE5-AF8B-3EB50D0C9A3B@gmail.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7B3B8BC5@ORSMSX110.amr.corp.intel.com>
> On 29 Mar 2018, at 00:07, Luck, Tony <tony.luck@intel.com> wrote:
>
>> The default limit of only 65536 VMAs will also quickly come into play
>> if consecutive anon mmaps don't get merged. Of course this can be
>> raised, but it has significant resource and performance (fork) costs.
>
> Could the random mmap address chooser look for how many existing
> VMAs have space before/after and the right attributes to merge with the
> new one you want to create? If this is above some threshold (100?) then
> pick one of them randomly and allocate the new address so that it will
> merge from below/above with an existing one.
>
> That should still give you a very high degree of randomness, but prevent
> out of control numbers of VMAs from being created.
I think this wouldn’t work. For example these 100 allocation may happened on
process initialization. But when attacker come to the server all his
allocations would be made on the predictable offsets from each other. So in
result we did nothing just decrease performance of first 100 allocations. I
think I can make ioctl to turn off this randomization per process and it could
be used if needed. For example if application going to allocate big chunk or
make big memory pressure, etc.
Best regards,
Ilya
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2018-04-03 0:11 UTC|newest]
Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 16:36 [RFC PATCH v2 0/2] Randomization of address chosen by mmap Ilya Smith
2018-03-22 16:36 ` Ilya Smith
2018-03-22 16:36 ` Ilya Smith
2018-03-22 16:36 ` [RFC PATCH v2 1/2] " Ilya Smith
2018-03-22 16:36 ` Ilya Smith
2018-03-22 16:36 ` Ilya Smith
2018-03-22 20:53 ` Andrew Morton
2018-03-22 20:53 ` Andrew Morton
2018-03-22 20:53 ` Andrew Morton
2018-03-22 20:53 ` Andrew Morton
2018-03-23 17:43 ` Ilya Smith
2018-03-23 17:43 ` Ilya Smith
2018-03-23 17:43 ` Ilya Smith
2018-03-23 17:43 ` Ilya Smith
2018-03-23 17:43 ` Ilya Smith
2018-03-23 17:43 ` Ilya Smith
2018-03-22 16:36 ` [RFC PATCH v2 2/2] Architecture defined limit on memory region random shift Ilya Smith
2018-03-22 16:36 ` Ilya Smith
2018-03-22 16:36 ` Ilya Smith
2018-03-22 20:54 ` Andrew Morton
2018-03-22 20:54 ` Andrew Morton
2018-03-22 20:54 ` Andrew Morton
2018-03-22 20:54 ` Andrew Morton
2018-03-23 17:48 ` Ilya Smith
2018-03-23 17:48 ` Ilya Smith
2018-03-23 17:49 ` Ilya Smith
2018-03-23 17:49 ` Ilya Smith
2018-03-23 17:49 ` Ilya Smith
2018-03-23 17:49 ` Ilya Smith
2018-03-23 17:49 ` Ilya Smith
2018-03-23 17:49 ` Ilya Smith
2018-03-22 20:57 ` [RFC PATCH v2 0/2] Randomization of address chosen by mmap Andrew Morton
2018-03-22 20:57 ` Andrew Morton
2018-03-22 20:57 ` Andrew Morton
2018-03-22 20:57 ` Andrew Morton
2018-03-23 17:25 ` Ilya Smith
2018-03-23 17:25 ` Ilya Smith
2018-03-23 17:25 ` Ilya Smith
2018-03-23 17:25 ` Ilya Smith
2018-03-23 17:25 ` Ilya Smith
2018-03-23 17:25 ` Ilya Smith
2018-03-23 12:48 ` Matthew Wilcox
2018-03-23 12:48 ` Matthew Wilcox
2018-03-23 12:48 ` Matthew Wilcox
2018-03-23 12:48 ` Matthew Wilcox
2018-03-23 17:55 ` Ilya Smith
2018-03-23 17:55 ` Ilya Smith
2018-03-23 17:55 ` Ilya Smith
2018-03-23 17:55 ` Ilya Smith
2018-03-23 17:55 ` Ilya Smith
2018-03-23 17:55 ` Ilya Smith
2018-03-26 8:46 ` Michal Hocko
2018-03-26 8:46 ` Michal Hocko
2018-03-26 8:46 ` Michal Hocko
2018-03-26 8:46 ` Michal Hocko
2018-03-26 8:46 ` Michal Hocko
2018-03-26 19:45 ` Ilya Smith
2018-03-26 19:45 ` Ilya Smith
2018-03-26 19:45 ` Ilya Smith
2018-03-26 19:45 ` Ilya Smith
2018-03-26 19:45 ` Ilya Smith
2018-03-26 19:45 ` Ilya Smith
2018-03-27 7:24 ` Michal Hocko
2018-03-27 7:24 ` Michal Hocko
2018-03-27 7:24 ` Michal Hocko
2018-03-27 7:24 ` Michal Hocko
2018-03-27 7:24 ` Michal Hocko
2018-03-27 13:51 ` Ilya Smith
2018-03-27 13:51 ` Ilya Smith
2018-03-27 13:51 ` Ilya Smith
2018-03-27 13:51 ` Ilya Smith
2018-03-27 13:51 ` Ilya Smith
2018-03-27 13:51 ` Ilya Smith
2018-03-27 14:38 ` Michal Hocko
2018-03-27 14:38 ` Michal Hocko
2018-03-27 14:38 ` Michal Hocko
2018-03-27 14:38 ` Michal Hocko
2018-03-27 14:38 ` Michal Hocko
2018-03-28 18:47 ` Ilya Smith
2018-03-28 18:47 ` Ilya Smith
2018-03-28 18:47 ` Ilya Smith
2018-03-28 18:47 ` Ilya Smith
2018-03-28 18:47 ` Ilya Smith
2018-03-28 18:47 ` Ilya Smith
2018-03-27 22:16 ` Theodore Y. Ts'o
2018-03-27 22:16 ` Theodore Y. Ts'o
2018-03-27 22:16 ` Theodore Y. Ts'o
2018-03-27 22:16 ` Theodore Y. Ts'o
2018-03-27 22:16 ` Theodore Y. Ts'o
2018-03-27 23:58 ` Rich Felker
2018-03-27 23:58 ` Rich Felker
2018-03-27 23:58 ` Rich Felker
2018-03-27 23:58 ` Rich Felker
2018-03-28 18:48 ` Ilya Smith
2018-03-28 18:48 ` Ilya Smith
2018-03-28 18:48 ` Ilya Smith
2018-03-28 18:48 ` Ilya Smith
2018-03-28 18:48 ` Ilya Smith
2018-03-28 18:48 ` Ilya Smith
2018-03-27 22:53 ` Kees Cook
2018-03-27 22:53 ` Kees Cook
2018-03-27 22:53 ` Kees Cook
2018-03-27 22:53 ` Kees Cook
2018-03-27 22:53 ` Kees Cook
2018-03-27 23:49 ` Matthew Wilcox
2018-03-27 23:49 ` Matthew Wilcox
2018-03-27 23:49 ` Matthew Wilcox
2018-03-27 23:49 ` Matthew Wilcox
2018-03-27 23:57 ` Kees Cook
2018-03-27 23:57 ` Kees Cook
2018-03-27 23:57 ` Kees Cook
2018-03-27 23:57 ` Kees Cook
2018-03-28 0:00 ` Rich Felker
2018-03-28 0:00 ` Rich Felker
2018-03-28 0:00 ` Rich Felker
2018-03-28 0:00 ` Rich Felker
2018-03-28 21:07 ` Luck, Tony
2018-03-28 21:07 ` Luck, Tony
2018-03-28 21:07 ` Luck, Tony
2018-03-28 21:07 ` Luck, Tony
2018-03-28 21:07 ` Luck, Tony
2018-04-03 0:11 ` Ilya Smith [this message]
2018-04-03 0:11 ` Ilya Smith
2018-04-03 0:11 ` Ilya Smith
2018-04-03 0:11 ` Ilya Smith
2018-04-03 0:11 ` Ilya Smith
2018-04-03 0:11 ` Ilya Smith
2018-03-28 21:07 ` Ilya Smith
2018-03-28 21:07 ` Ilya Smith
2018-03-28 21:07 ` Ilya Smith
2018-03-28 21:07 ` Ilya Smith
2018-03-28 21:07 ` Ilya Smith
2018-03-23 18:00 ` Rich Felker
2018-03-23 18:00 ` Rich Felker
2018-03-23 18:00 ` Rich Felker
2018-03-23 18:00 ` Rich Felker
2018-03-23 18:00 ` Rich Felker
2018-03-23 19:06 ` Matthew Wilcox
2018-03-23 19:06 ` Matthew Wilcox
2018-03-23 19:06 ` Matthew Wilcox
2018-03-23 19:06 ` Matthew Wilcox
2018-03-23 19:16 ` Rich Felker
2018-03-23 19:16 ` Rich Felker
2018-03-23 19:16 ` Rich Felker
2018-03-23 19:16 ` Rich Felker
2018-03-23 19:16 ` Rich Felker
2018-03-23 19:29 ` Matthew Wilcox
2018-03-23 19:29 ` Matthew Wilcox
2018-03-23 19:29 ` Matthew Wilcox
2018-03-23 19:29 ` Matthew Wilcox
2018-03-23 19:35 ` Rich Felker
2018-03-23 19:35 ` Rich Felker
2018-03-23 19:35 ` Rich Felker
2018-03-23 19:35 ` Rich Felker
2018-03-23 19:35 ` Rich Felker
2018-03-28 4:50 ` Rob Landley
2018-03-28 4:50 ` Rob Landley
2018-03-28 4:50 ` Rob Landley
2018-03-28 4:50 ` Rob Landley
2018-03-28 4:50 ` Rob Landley
2018-03-30 7:55 ` Pavel Machek
2018-03-30 7:55 ` Pavel Machek
2018-03-30 7:55 ` Pavel Machek
2018-03-30 7:55 ` Pavel Machek
2018-03-30 9:07 ` Ilya Smith
2018-03-30 9:07 ` Ilya Smith
2018-03-30 9:07 ` Ilya Smith
2018-03-30 9:07 ` Ilya Smith
2018-03-30 9:07 ` Ilya Smith
2018-03-30 9:07 ` Ilya Smith
2018-03-30 9:57 ` Pavel Machek
2018-03-30 9:57 ` Pavel Machek
2018-03-30 9:57 ` Pavel Machek
2018-03-30 9:57 ` Pavel Machek
2018-03-30 11:10 ` Ilya Smith
2018-03-30 11:10 ` Ilya Smith
2018-03-30 11:10 ` Ilya Smith
2018-03-30 11:10 ` Ilya Smith
2018-03-30 11:10 ` Ilya Smith
2018-03-30 11:10 ` Ilya Smith
2018-03-30 13:33 ` Rich Felker
2018-03-30 13:33 ` Rich Felker
2018-03-30 13:33 ` Rich Felker
2018-03-30 13:33 ` Rich Felker
2018-03-30 13:33 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9173B50-39D6-4EE5-AF8B-3EB50D0C9A3B@gmail.com \
--to=blackzert@gmail.com \
--cc=aarcange@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bhsharma@redhat.com \
--cc=dalias@libc.org \
--cc=dan.j.williams@intel.com \
--cc=deepa.kernel@gmail.com \
--cc=deller@gmx.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=kstewart@linuxfoundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.