[v4,3/6] dt-bindings: fsl-qdma: Add NXP Layerscpae qDMA controller bindings

[Wen He <wen.he_1@nxp.com>]

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 2018年5月24日 3:59
> To: Wen He <wen.he_1@nxp.com>
> Cc: dmaengine@vger.kernel.org; devicetree@vger.kernel.org; Leo Li
> <leoyang.li@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; Jiaheng Fan
> <jiaheng.fan@nxp.com>; Vinod <vkoul@kernel.org>
> Subject: Re: [v4 3/6] dt-bindings: fsl-qdma: Add NXP Layerscpae qDMA
> controller bindings
> 
> Updated Vinod's email...
> 
> On Mon, May 21, 2018 at 12:52 AM, Wen He <wen.he_1@nxp.com> wrote:
> > Hi Rob,
> >
> > Please see my comments inline.
> >
> > Best Regards,
> > Wen
> >
> >> -----Original Message-----
> >> From: Rob Herring [mailto:robh@kernel.org]
> >> Sent: 2018年5月19日 5:26
> >> To: Wen He <wen.he_1@nxp.com>
> >> Cc: vinod.koul@intel.com; dmaengine@vger.kernel.org;
> >> devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; Jiafei Pan
> >> <jiafei.pan@nxp.com>; Jiaheng Fan <jiaheng.fan@nxp.com>
> >> Subject: Re: [v4 3/6] dt-bindings: fsl-qdma: Add NXP Layerscpae qDMA
> >> controller bindings
> >>
> >> On Mon, May 14, 2018 at 08:03:04PM +0800, Wen He wrote:
> >> > Document the devicetree bindings for NXP Layerscape qDMA controller
> >> > which could be found on NXP QorIQ Layerscape SoCs.
> >> >
> >> > Signed-off-by: Wen He <wen.he_1@nxp.com>
> >> > ---
> >> > change in v4:
> >> >     - Rewrite the bindings document that follows generic DMA
> >> > bindings file
> >> >
> >> > change in v3:
> >> >     - no change
> >> >
> >> > change in v2:
> >> >     - Remove indentation
> >> >     - Add "Should be" before 'fsl,ls1021a-qdma'
> >> >     - Replace 'channels' by 'dma-channels'
> >> >     - Replace 'qdma@8390000' by 'dma-controller@8390000'
> >> >
> >> >  Documentation/devicetree/bindings/dma/fsl-qdma.txt |   41
> >> ++++++++++++++++++++
> >> >  1 files changed, 41 insertions(+), 0 deletions(-)  create mode
> >> > 100644 Documentation/devicetree/bindings/dma/fsl-qdma.txt
> >> >
> >> > diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.txt
> >> > b/Documentation/devicetree/bindings/dma/fsl-qdma.txt
> >> > new file mode 100644
> >> > index 0000000..368c4e7
> >> > --- /dev/null
> >> > +++ b/Documentation/devicetree/bindings/dma/fsl-qdma.txt
> >> > @@ -0,0 +1,41 @@
> >> > +NXP Layerscape SoC qDMA Controller
> >> > +==================================
> >> > +
> >> > +This device follows the generic DMA bindings defined in dma/dma.txt.
> >> > +
> >> > +Required properties:
> >> > +
> >> > +- compatible:              Must be one of
> >> > +                    "fsl,ls1021a-qdma": for LS1021A Board
> >> > +                    "fsl,ls1043a-qdma": for ls1043A Board
> >> > +                    "fsl,ls1046a-qdma": for ls1046A Board
> >> > +- reg:                     Should contain the register's base
> address and length.
> >> > +- interrupts:              Should contain a reference to the
> interrupt used by
> >> this
> >> > +                   device.
> >> > +- interrupt-names: Should contain interrupt names:
> >> > +                    "qdma-error": the error interrupt
> >> > +                    "qdma-queue": the queue interrupt
> >> > +- queues:          Should contain number of queues supported.
> >>
> >> Needs a vendor prefix.
> >>
> >
> > Does means: The queues filed need a vendor prefix ?
> > like 'fsl-queues' ? right?
> 
> No, vendor prefixes end with a comma: fsl,queues
> 
> Rob

Done.
Thanks for your review, the issue will next version fix.

Best Regards,
Wen