* [PATCH] net/mlx4: Avoid stripping the glue library
@ 2018-07-31 13:15 Timothy Redaelli
2018-07-31 13:30 ` Luca Boccassi
2018-07-31 13:32 ` Christian Ehrhardt
0 siblings, 2 replies; 4+ messages in thread
From: Timothy Redaelli @ 2018-07-31 13:15 UTC (permalink / raw)
To: Matan Azrad, Shahaf Shuler; +Cc: dev, Adrien Mazarguil
Stripping binaries at build time is usually a bad thing since it makes
impossible to generate (split) debug symbols and this can lead to a more
difficult debugging.
CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
drivers/net/mlx4/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
index 63bc00337..92e932250 100644
--- a/drivers/net/mlx4/Makefile
+++ b/drivers/net/mlx4/Makefile
@@ -115,7 +115,7 @@ endif
$(LIB_GLUE): mlx4_glue.o
$Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
-Wl,-h,$(LIB_GLUE) \
- -s -shared -o $@ $< -libverbs -lmlx4
+ -shared -o $@ $< -libverbs -lmlx4
mlx4_glue.o: mlx4_autoconf.h
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net/mlx4: Avoid stripping the glue library
2018-07-31 13:15 [PATCH] net/mlx4: Avoid stripping the glue library Timothy Redaelli
@ 2018-07-31 13:30 ` Luca Boccassi
2018-08-01 8:30 ` Shahaf Shuler
2018-07-31 13:32 ` Christian Ehrhardt
1 sibling, 1 reply; 4+ messages in thread
From: Luca Boccassi @ 2018-07-31 13:30 UTC (permalink / raw)
To: Timothy Redaelli, Matan Azrad, Shahaf Shuler; +Cc: dev, Adrien Mazarguil
On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> Stripping binaries at build time is usually a bad thing since it
> makes
> impossible to generate (split) debug symbols and this can lead to a
> more
> difficult debugging.
>
> CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> drivers/net/mlx4/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> index 63bc00337..92e932250 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -115,7 +115,7 @@ endif
> $(LIB_GLUE): mlx4_glue.o
> $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> -Wl,-h,$(LIB_GLUE) \
> - -s -shared -o $@ $< -libverbs -lmlx4
> + -shared -o $@ $< -libverbs -lmlx4
>
> mlx4_glue.o: mlx4_autoconf.h
Acked-by: Luca Boccassi <bluca@debian.org>
Automated tools to generate separate packages with debug symbols (the
standard at least in Debian and derivatives distros) break if a library
is stripped, and it's very hard to notice as well as it's not an error
per se.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/mlx4: Avoid stripping the glue library
2018-07-31 13:30 ` Luca Boccassi
@ 2018-08-01 8:30 ` Shahaf Shuler
0 siblings, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2018-08-01 8:30 UTC (permalink / raw)
To: Luca Boccassi, Timothy Redaelli, Matan Azrad; +Cc: dev, Adrien Mazarguil
Tuesday, July 31, 2018 4:31 PM, Luca Boccassi:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library
>
> On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> > Stripping binaries at build time is usually a bad thing since it makes
> > impossible to generate (split) debug symbols and this can lead to a
> > more difficult debugging.
> >
> > CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
> >
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > ---
> > drivers/net/mlx4/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> > index 63bc00337..92e932250 100644
> > --- a/drivers/net/mlx4/Makefile
> > +++ b/drivers/net/mlx4/Makefile
> > @@ -115,7 +115,7 @@ endif
> > $(LIB_GLUE): mlx4_glue.o
> > $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> > -Wl,-h,$(LIB_GLUE) \
> > - -s -shared -o $@ $< -libverbs -lmlx4
> > + -shared -o $@ $< -libverbs -lmlx4
> >
> > mlx4_glue.o: mlx4_autoconf.h
>
> Acked-by: Luca Boccassi <bluca@debian.org>
>
> Automated tools to generate separate packages with debug symbols (the
> standard at least in Debian and derivatives distros) break if a library is
> stripped, and it's very hard to notice as well as it's not an error per se.
Applied to next-net-mlx, thanks.
>
> --
> Kind regards,
> Luca Boccassi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx4: Avoid stripping the glue library
2018-07-31 13:15 [PATCH] net/mlx4: Avoid stripping the glue library Timothy Redaelli
2018-07-31 13:30 ` Luca Boccassi
@ 2018-07-31 13:32 ` Christian Ehrhardt
1 sibling, 0 replies; 4+ messages in thread
From: Christian Ehrhardt @ 2018-07-31 13:32 UTC (permalink / raw)
To: Timothy M. Redaelli; +Cc: matan, Shahaf Shuler, dev, adrien.mazarguil
On Tue, Jul 31, 2018 at 3:26 PM Timothy Redaelli <tredaelli@redhat.com>
wrote:
> Stripping binaries at build time is usually a bad thing since it makes
> impossible to generate (split) debug symbols and this can lead to a more
> difficult debugging.
>
> CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> drivers/net/mlx4/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> index 63bc00337..92e932250 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -115,7 +115,7 @@ endif
> $(LIB_GLUE): mlx4_glue.o
> $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> -Wl,-h,$(LIB_GLUE) \
> - -s -shared -o $@ $< -libverbs -lmlx4
> + -shared -o $@ $< -libverbs -lmlx4
>
> mlx4_glue.o: mlx4_autoconf.h
>
>
After IRC discussion I completely agree that this shouldn't be stripped,
thanks for the fix.
Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
--
2.17.1
>
>
--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-01 8:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-31 13:15 [PATCH] net/mlx4: Avoid stripping the glue library Timothy Redaelli
2018-07-31 13:30 ` Luca Boccassi
2018-08-01 8:30 ` Shahaf Shuler
2018-07-31 13:32 ` Christian Ehrhardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.