All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liu, Jinsong" <jinsong.liu@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"chegger@amazon.de" <chegger@amazon.de>,
	Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH V4.1] mcheck, vmce: Allow vmce_amd_* functions to handle AMD  thresolding MSRs
Date: Tue, 18 Feb 2014 11:42:23 +0000	[thread overview]
Message-ID: <DE8DF0795D48FD4CA783C40EC8292335014F7A4D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <53034BC1020000780011D371@nat28.tlf.novell.com>

Jan Beulich wrote:
>>>> On 18.02.14 at 11:52, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:
>>>>> --- a/xen/arch/x86/cpu/mcheck/vmce.c
>>>>> +++ b/xen/arch/x86/cpu/mcheck/vmce.c
>>>>> @@ -107,7 +107,8 @@ static int bank_mce_rdmsr(const struct vcpu
>>>>> *v, uint32_t msr, uint64_t *val) 
>>>>> 
>>>>>      *val = 0;
>>>>> 
>>>>> -    switch ( msr & (MSR_IA32_MC0_CTL | 3) )
>>>>> +    /* Allow only first 3 MC banks into switch() */
>> 
>> I don't think this comments is good here. Remove it is better.
> 
> I had asked for this to be removed again too. I'm really thinking
> that V3 is what we should go with.
> 
> Jan

V3 is fine, except adding comments for '-MSR_IA32_MC0_CTL' is slightly better.

Thanks,
Jinsong

  reply	other threads:[~2014-02-18 11:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 23:26 [PATCH V4.1] mcheck, vmce: Allow vmce_amd_* functions to handle AMD thresolding MSRs Aravind Gopalakrishnan
2014-02-13  8:38 ` Jan Beulich
2014-02-13 17:27   ` Aravind Gopalakrishnan
2014-02-13 18:24     ` Aravind Gopalakrishnan
2014-02-14  8:28       ` Jan Beulich
2014-02-16 14:47         ` Liu, Jinsong
2014-02-18  4:25 ` Liu, Jinsong
2014-02-18  9:41   ` Jan Beulich
2014-02-18 10:52     ` Liu, Jinsong
2014-02-18 11:02       ` Jan Beulich
2014-02-18 11:42         ` Liu, Jinsong [this message]
2014-02-18 12:36           ` Jan Beulich
2014-02-18 12:42             ` Liu, Jinsong
2014-02-18 16:23               ` Aravind Gopalakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DE8DF0795D48FD4CA783C40EC8292335014F7A4D@SHSMSX101.ccr.corp.intel.com \
    --to=jinsong.liu@intel.com \
    --cc=JBeulich@suse.com \
    --cc=aravind.gopalakrishnan@amd.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=chegger@amazon.de \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.